Re: [RFC v3 0/5] virtio: support packed ring

On Fri, Apr 27, 2018 at 11:56:05AM +0800, Jason Wang wrote: > > > On 2018年04月25日 13:15, Tiwei Bie wrote: > > Hello everyone, > > > > This RFC implements packed ring support in virtio driver. > > > > Some simple functional tests have been done with Jason's > > packed ring implementation in

Re: [RFC v3 0/5] virtio: support packed ring

On 2018年04月25日 13:15, Tiwei Bie wrote: Hello everyone, This RFC implements packed ring support in virtio driver. Some simple functional tests have been done with Jason's packed ring implementation in vhost: https://lkml.org/lkml/2018/4/23/12 Both of ping and netperf worked as expected

Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On 4/26/2018 5:09 PM, Michael S. Tsirkin wrote: On Thu, Apr 26, 2018 at 03:33:26PM -0700, Stephen Hemminger wrote: On Thu, 26 Apr 2018 05:30:05 +0300 "Michael S. Tsirkin" wrote: On Wed, Apr 25, 2018 at 05:08:37PM -0700, Stephen Hemminger wrote: On Wed, 25 Apr 2018 16:59:28

Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Thu, Apr 26, 2018 at 03:33:26PM -0700, Stephen Hemminger wrote: > On Thu, 26 Apr 2018 05:30:05 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Apr 25, 2018 at 05:08:37PM -0700, Stephen Hemminger wrote: > > > On Wed, 25 Apr 2018 16:59:28 -0700 > > > Sridhar Samudrala

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Thu, Apr 26, 2018 at 03:14:46PM -0700, Siwei Liu wrote: > On Wed, Apr 25, 2018 at 7:28 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 25, 2018 at 03:57:57PM -0700, Siwei Liu wrote: > >> On Wed, Apr 25, 2018 at 3:22 PM, Michael S. Tsirkin > >> wrote: > >> > On

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Fri, 27 Apr 2018, Michael S. Tsirkin wrote: > On Thu, Apr 26, 2018 at 05:50:20PM -0400, Mikulas Patocka wrote: > > How is the user or developer supposed to learn about this option, if > > he gets no crash at all? > > Look in /sys/kernel/debug/fail* ? That actually lets you > filter by

Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Thu, 26 Apr 2018 05:30:05 +0300 "Michael S. Tsirkin" wrote: > On Wed, Apr 25, 2018 at 05:08:37PM -0700, Stephen Hemminger wrote: > > On Wed, 25 Apr 2018 16:59:28 -0700 > > Sridhar Samudrala wrote: > > > > > Use the registration/notification

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, Apr 26, 2018 at 05:50:20PM -0400, Mikulas Patocka wrote: > How is the user or developer supposed to learn about this option, if > he gets no crash at all? Look in /sys/kernel/debug/fail* ? That actually lets you filter by module, process etc. I think this patch conflates two things: 1.

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Wed, Apr 25, 2018 at 7:28 PM, Michael S. Tsirkin wrote: > On Wed, Apr 25, 2018 at 03:57:57PM -0700, Siwei Liu wrote: >> On Wed, Apr 25, 2018 at 3:22 PM, Michael S. Tsirkin wrote: >> > On Wed, Apr 25, 2018 at 02:38:57PM -0700, Siwei Liu wrote: >> >> On Mon,

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, 26 Apr 2018, John Stoffel wrote: > > "James" == James Bottomley > > writes: > > James> I may be an atypical developer but I'd rather have a root canal > James> than browse through menuconfig options. The way to get people > James> to

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, 26 Apr 2018, Michael S. Tsirkin wrote: > On Thu, Apr 26, 2018 at 03:36:14PM -0400, Mikulas Patocka wrote: > > People on this list argue "this should be a kernel parameter". > > How about making it a writeable attribute, so it's easy to turn on/off > after boot. Then you can keep it

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, Apr 26, 2018 at 03:36:14PM -0400, Mikulas Patocka wrote: > People on this list argue "this should be a kernel parameter". How about making it a writeable attribute, so it's easy to turn on/off after boot. Then you can keep it deterministic, userspace can play with the attribute at random

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, 26 Apr 2018, Michael S. Tsirkin wrote: > On Thu, Apr 26, 2018 at 02:54:26PM -0400, Mikulas Patocka wrote: > > > > > > On Thu, 26 Apr 2018, Michael S. Tsirkin wrote: > > > > > On Thu, Apr 26, 2018 at 12:07:25PM -0400, Mikulas Patocka wrote: > > > > > IIUC debug kernels mainly exist so

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, Apr 26, 2018 at 02:54:26PM -0400, Mikulas Patocka wrote: > > > On Thu, 26 Apr 2018, Michael S. Tsirkin wrote: > > > On Thu, Apr 26, 2018 at 12:07:25PM -0400, Mikulas Patocka wrote: > > > > IIUC debug kernels mainly exist so people who experience e.g. memory > > > > corruption can try

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, Apr 26, 2018 at 02:58:08PM -0400, Mikulas Patocka wrote: > > > On Thu, 26 Apr 2018, Michael S. Tsirkin wrote: > > > How do you make sure QA tests a specific corner case? Add it to > > the test plan :) > > BTW. how many "lines of code" of corporate bureaucracy would that take? :-) It's

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, 26 Apr 2018, Michael S. Tsirkin wrote: > How do you make sure QA tests a specific corner case? Add it to > the test plan :) BTW. how many "lines of code" of corporate bureaucracy would that take? :-) > I don't speak for Red Hat, etc. > > -- > MST Mikulas

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, 26 Apr 2018, Michael S. Tsirkin wrote: > On Thu, Apr 26, 2018 at 12:07:25PM -0400, Mikulas Patocka wrote: > > > IIUC debug kernels mainly exist so people who experience e.g. memory > > > corruption can try and debug the failure. In this case, CONFIG_DEBUG_SG > > > will *already* catch a

[PULL] virtio: fixups

The following changes since commit 6d08b06e67cd117f6992c46611dfb4ce267cd71e: Linux 4.17-rc2 (2018-04-22 19:20:09 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, Apr 26, 2018 at 12:07:25PM -0400, Mikulas Patocka wrote: > > IIUC debug kernels mainly exist so people who experience e.g. memory > > corruption can try and debug the failure. In this case, CONFIG_DEBUG_SG > > will *already* catch a failure early. Nothing special needs to be done. > > The

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, 26 Apr 2018, Michael S. Tsirkin wrote: > On Thu, Apr 26, 2018 at 11:44:21AM -0400, Mikulas Patocka wrote: > > > > > > On Thu, 26 Apr 2018, James Bottomley wrote: > > > > > On Thu, 2018-04-26 at 11:05 -0400, Mikulas Patocka wrote: > > > > > > > > On Thu, 26 Apr 2018, James Bottomley

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, Apr 26, 2018 at 11:44:21AM -0400, Mikulas Patocka wrote: > > > On Thu, 26 Apr 2018, James Bottomley wrote: > > > On Thu, 2018-04-26 at 11:05 -0400, Mikulas Patocka wrote: > > > > > > On Thu, 26 Apr 2018, James Bottomley wrote: > > [...] > > > > Perhaps find out beforehand instead of

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, 26 Apr 2018, James Bottomley wrote: > So you're shifting your argument from "I have to do it as a Kconfig > option because the distros require it" to "distributions will build > separate kernel packages for this, but won't do enabling in a non > kernel package"? To be honest, I think

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, 26 Apr 2018, James Bottomley wrote: > On Thu, 2018-04-26 at 11:05 -0400, Mikulas Patocka wrote: > > > > On Thu, 26 Apr 2018, James Bottomley wrote: > [...] > > > Perhaps find out beforehand instead of insisting on an approach > > without > > > knowing.  On openSUSE the grub config is

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, 26 Apr 2018, Mikulas Patocka wrote: > > > On Wed, 25 Apr 2018, James Bottomley wrote: > > > > BTW. even developers who compile their own kernel should have this > > > enabled by a CONFIG option - because if the developer sees the option > > > when browsing through menuconfig, he may

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, 26 Apr 2018, James Bottomley wrote: > On Thu, 2018-04-26 at 10:28 -0400, Mikulas Patocka wrote: > > > > On Thu, 26 Apr 2018, Michal Hocko wrote: > > > > > On Wed 25-04-18 18:42:57, Mikulas Patocka wrote: > > > >  > > > >  > > > > On Wed, 25 Apr 2018, James Bottomley wrote: > > > [...]

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Wed, 25 Apr 2018, James Bottomley wrote: > > BTW. even developers who compile their own kernel should have this > > enabled by a CONFIG option - because if the developer sees the option > > when browsing through menuconfig, he may enable it. If he doesn't see > > the option, he won't even

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, 26 Apr 2018, Michal Hocko wrote: > On Wed 25-04-18 18:42:57, Mikulas Patocka wrote: > > > > > > On Wed, 25 Apr 2018, James Bottomley wrote: > [...] > > > Kconfig proliferation, conversely, is a bit of a nightmare from both > > > the user and the tester's point of view, so we're trying

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

On Thu, Apr 26, 2018 at 3:14 PM, Alexandre Belloni wrote: > Hi, > > On 26/04/2018 15:45:44+0300, Laurent Pinchart wrote: >> Hi Daniel, >> >> On Thursday, 26 April 2018 15:36:15 EEST Daniel Vetter wrote: >> > On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Wed 25-04-18 18:42:57, Mikulas Patocka wrote: > > > On Wed, 25 Apr 2018, James Bottomley wrote: [...] > > Kconfig proliferation, conversely, is a bit of a nightmare from both > > the user and the tester's point of view, so we're trying to avoid it > > unless absolutely necessary. > > > >

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

Hi Daniel, On Thursday, 26 April 2018 15:36:15 EEST Daniel Vetter wrote: > On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar wrote: > > It's been a while since we introduced drm_dev{get/put} functions > > to replace reference/unreference in drm subsystem for the > > consistency purpose.

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar wrote: > It's been a while since we introduced drm_dev{get/put} functions > to replace reference/unreference in drm subsystem for the > consistency purpose. So, with this patch, let's just replace > all current use cases of drm_dev_unref()

Re: [PATCH] drm/core: Remove drm_dev_unref() and it's uses

On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar wrote: > It's been a while since we introduced drm_dev{get/put} functions > to replace reference/unreference in drm subsystem for the > consistency purpose. So, with this patch, let's just replace > all current use cases of drm_dev_unref()

Re: [PATCH] drm/core: Remove drm_dev_unref() and it's uses

Hi Vaishali, Thank you for the patch. On Thursday, 26 April 2018 13:28:19 EEST Vaishali Thakkar wrote: > It's been a while since we introduced drm_dev{get/put} functions > to replace reference/unreference in drm subsystem for the > consistency purpose. So, with this patch, let's just replace >