Re: [RFC v3 0/5] virtio: support packed ring

2018-04-27 Thread Jason Wang
On 2018年04月27日 17:12, Tiwei Bie wrote: On Fri, Apr 27, 2018 at 02:17:51PM +0800, Jason Wang wrote: On 2018年04月27日 12:18, Michael S. Tsirkin wrote: On Fri, Apr 27, 2018 at 11:56:05AM +0800, Jason Wang wrote: On 2018年04月25日 13:15, Tiwei Bie wrote: Hello everyone, This RFC implements packed

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Jason Wang
On 2018年04月28日 09:51, Kevin Easton wrote: On Fri, Apr 27, 2018 at 09:07:56PM -0400, Kevin Easton wrote: On Fri, Apr 27, 2018 at 07:05:45PM +0300, Michael S. Tsirkin wrote: On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: The struct vhost_msg within struct vhost_msg_node is

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-27 Thread Siwei Liu
On Thu, Apr 26, 2018 at 4:42 PM, Michael S. Tsirkin wrote: > On Thu, Apr 26, 2018 at 03:14:46PM -0700, Siwei Liu wrote: >> On Wed, Apr 25, 2018 at 7:28 PM, Michael S. Tsirkin wrote: >> > On Wed, Apr 25, 2018 at 03:57:57PM -0700, Siwei Liu wrote: >> >> On Wed,

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-27 Thread Mikulas Patocka
On Fri, 27 Apr 2018, Michael S. Tsirkin wrote: > 2. Ability to control this from a separate config >option. > >It's still not that clear to me why is this such a >hard requirement. If a distro wants to force specific >boot time options, why isn't CONFIG_CMDLINE sufficient?

Re: [PATCH net-next v9 0/4] Enable virtio_net to act as a standby for a passthru device

2018-04-27 Thread Jiri Pirko
Fri, Apr 27, 2018 at 07:53:01PM CEST, sridhar.samudr...@intel.com wrote: >On 4/27/2018 10:45 AM, Jiri Pirko wrote: >> Fri, Apr 27, 2018 at 07:06:56PM CEST, sridhar.samudr...@intel.com wrote: [...] >> >> No changes in v9? > >I listed v9 updates at the start of the message. Hmm, odd. I expected

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Michael S. Tsirkin
On Fri, Apr 27, 2018 at 06:11:31PM +0200, Dmitry Vyukov wrote: > On Fri, Apr 27, 2018 at 6:05 PM, Michael S. Tsirkin wrote: > > On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: > >> The struct vhost_msg within struct vhost_msg_node is copied to userspace, > >> so it

Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

2018-04-27 Thread Jiri Pirko
Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote: >This provides a generic interface for paravirtual drivers to listen >for netdev register/unregister/link change events from pci ethernet >devices with the same MAC and takeover their datapath. The notifier and >event

Re: [PATCH net-next v9 0/4] Enable virtio_net to act as a standby for a passthru device

2018-04-27 Thread Samudrala, Sridhar
On 4/27/2018 10:45 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:56PM CEST, sridhar.samudr...@intel.com wrote: v9: Select NET_FAILOVER automatically when VIRTIO_NET/HYPERV_NET are enabled. (stephen) Tested live migration with virtio-net/AVF(i40evf) configured in failover mode while running

Re: [PATCH net-next v9 0/4] Enable virtio_net to act as a standby for a passthru device

2018-04-27 Thread Jiri Pirko
Fri, Apr 27, 2018 at 07:06:56PM CEST, sridhar.samudr...@intel.com wrote: >v9: >Select NET_FAILOVER automatically when VIRTIO_NET/HYPERV_NET >are enabled. (stephen) > >Tested live migration with virtio-net/AVF(i40evf) configured in >failover mode while running iperf in background. >Build tested

[PATCH net-next v9 2/4] net: Introduce generic failover module

2018-04-27 Thread Sridhar Samudrala
This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their datapath. The notifier and event handling code is based on the existing netvsc implementation. It exposes 2 sets of

[PATCH net-next v9 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-27 Thread Sridhar Samudrala
Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar Samudrala --- drivers/net/hyperv/Kconfig | 1 + drivers/net/hyperv/hyperv_net.h | 2 + drivers/net/hyperv/netvsc_drv.c | 134

[PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-27 Thread Sridhar Samudrala
This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to enable

[PATCH net-next v9 0/4] Enable virtio_net to act as a standby for a passthru device

2018-04-27 Thread Sridhar Samudrala
v9: Select NET_FAILOVER automatically when VIRTIO_NET/HYPERV_NET are enabled. (stephen) Tested live migration with virtio-net/AVF(i40evf) configured in failover mode while running iperf in background. Build tested netvsc module. The main motivation for this patch is to enable cloud service

[PATCH net-next v9 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit

2018-04-27 Thread Sridhar Samudrala
This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. VIRTIO_NET_F_STANDBY is defined as bit 62 as it is a device feature bit. Signed-off-by: Sridhar Samudrala ---

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Dmitry Vyukov via Virtualization
On Fri, Apr 27, 2018 at 6:25 PM, Dmitry Vyukov wrote: >>> >> The struct vhost_msg within struct vhost_msg_node is copied to userspace, >>> >> so it should be allocated with kzalloc() to ensure all structure padding >>> >> is zeroed. >>> >> >>> >> Signed-off-by: Kevin Easton

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Dmitry Vyukov via Virtualization
On Fri, Apr 27, 2018 at 6:15 PM, Michael S. Tsirkin wrote: >> >> The struct vhost_msg within struct vhost_msg_node is copied to userspace, >> >> so it should be allocated with kzalloc() to ensure all structure padding >> >> is zeroed. >> >> >> >> Signed-off-by: Kevin Easton

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Michael S. Tsirkin
On Fri, Apr 27, 2018 at 06:11:31PM +0200, Dmitry Vyukov wrote: > On Fri, Apr 27, 2018 at 6:05 PM, Michael S. Tsirkin wrote: > > On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: > >> The struct vhost_msg within struct vhost_msg_node is copied to userspace, > >> so it

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Dmitry Vyukov via Virtualization
On Fri, Apr 27, 2018 at 6:05 PM, Michael S. Tsirkin wrote: > On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: >> The struct vhost_msg within struct vhost_msg_node is copied to userspace, >> so it should be allocated with kzalloc() to ensure all structure padding >>

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Michael S. Tsirkin
On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: > The struct vhost_msg within struct vhost_msg_node is copied to userspace, > so it should be allocated with kzalloc() to ensure all structure padding > is zeroed. > > Signed-off-by: Kevin Easton > Reported-by:

[PATCH] vhost: make msg padding explicit

2018-04-27 Thread Michael S. Tsirkin
There's a 32 bit hole just after type. It's best to give it a name, this way compiler is forced to initialize it with rest of the structure. Reported-by: Kevin Easton Signed-off-by: Michael S. Tsirkin --- include/uapi/linux/vhost.h | 1 + 1 file changed, 1

Re: [PATCH net-next v8 2/4] net: Introduce generic failover module

2018-04-27 Thread kbuild test robot
Hi Sridhar, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Sridhar-Samudrala/Enable-virtio_net-to-act-as-a-standby-for-a-passthru-device/20180427-183842 reproduce: # apt-get install

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-27 Thread Mikulas Patocka
On Fri, 27 Apr 2018, Michal Hocko wrote: > On Thu 26-04-18 18:52:05, Mikulas Patocka wrote: > > > > > > On Fri, 27 Apr 2018, Michael S. Tsirkin wrote: > [...] > > >But assuming it's important to control this kind of > > >fault injection to be controlled from > > >a dedicated

Re: [RFC v3 0/5] virtio: support packed ring

2018-04-27 Thread Tiwei Bie
On Fri, Apr 27, 2018 at 02:17:51PM +0800, Jason Wang wrote: > On 2018年04月27日 12:18, Michael S. Tsirkin wrote: > > On Fri, Apr 27, 2018 at 11:56:05AM +0800, Jason Wang wrote: > > > On 2018年04月25日 13:15, Tiwei Bie wrote: > > > > Hello everyone, > > > > > > > > This RFC implements packed ring

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-27 Thread Michal Hocko
On Thu 26-04-18 18:52:05, Mikulas Patocka wrote: > > > On Fri, 27 Apr 2018, Michael S. Tsirkin wrote: [...] > >But assuming it's important to control this kind of > >fault injection to be controlled from > >a dedicated menuconfig option, why not the rest of > >faults? > > The

Re: [RFC v3 0/5] virtio: support packed ring

2018-04-27 Thread Jason Wang
On 2018年04月27日 12:18, Michael S. Tsirkin wrote: On Fri, Apr 27, 2018 at 11:56:05AM +0800, Jason Wang wrote: On 2018年04月25日 13:15, Tiwei Bie wrote: Hello everyone, This RFC implements packed ring support in virtio driver. Some simple functional tests have been done with Jason's packed ring

[PATCH 16/17] drm/virtio: Remove unecessary dma_fence_ops

2018-04-27 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Signed-off-by: Daniel Vetter Cc: David Airlie Cc: Gerd Hoffmann Cc: virtualization@lists.linux-foundation.org ---

[PATCH 12/17] drm/qxl: Remove unecessary dma_fence_ops

2018-04-27 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualization@lists.linux-foundation.org ---