Re: [RFC V2] virtio: Add platform specific DMA API translation for virito devices

On Thu, Jun 07, 2018 at 07:28:35PM +0300, Michael S. Tsirkin wrote: > Let me restate it: DMA API has support for a wide range of hardware, and > hardware based virtio implementations likely won't benefit from all of > it. That is completely wrong. All aspects of the DMA API are about the system t

Re: [PATCH net] vhost_net: remove VHOST_NET_F_VIRTIO_NET_HDR support

On 2018年06月08日 12:46, Michael S. Tsirkin wrote: On Fri, Jun 08, 2018 at 11:50:42AM +0800, Jason Wang wrote: This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if a userpsace want to enable VRITIO_F_ANY_LAYOUT, VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and w

Re: [PATCH net] vhost_net: remove VHOST_NET_F_VIRTIO_NET_HDR support

On Fri, Jun 08, 2018 at 11:50:42AM +0800, Jason Wang wrote: > This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if > a userpsace want to enable VRITIO_F_ANY_LAYOUT, > VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and will > break networking. What breaks networking

[PATCH net] vhost_net: remove VHOST_NET_F_VIRTIO_NET_HDR support

This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if a userpsace want to enable VRITIO_F_ANY_LAYOUT, VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and will break networking. Fixing this by safely removing VHOST_NET_F_VIRTIO_NET_HDR support. There should be very few

RE: [PATCH v6] virtio_blk: add DISCARD and WRIET ZEROES commands support

> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Thursday, June 7, 2018 9:10 PM > To: Liu, Changpeng > Cc: virtualization@lists.linux-foundation.org; cav...@redhat.com; > jasow...@redhat.com; pbonz...@redhat.com; Wang, Wei W > > Subject: Re: [PATCH v6]

Re: [PATCH v3 2/3] x86/asm: add _ASM_ARG* constants for argument registers to

On 06/07/18 11:32, Nick Desaulniers wrote: > > Suggested-by: Sedat Dilek If this was suggested by Sedat, I didn't see that suggestion... -hpa ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundat

Re: KMSAN: uninit-value in _copy_to_iter (2)

On Thu, Jun 07, 2018 at 07:04:49PM +0100, Al Viro wrote: > On Thu, Jun 07, 2018 at 08:59:06PM +0300, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2018 at 06:43:55PM +0100, Al Viro wrote: > > > On Thu, Jun 07, 2018 at 06:38:48PM +0300, Michael S. Tsirkin wrote: > > > > #syz test: https://github.com

Re: [PATCH v3 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

On Thu, 2018-06-07 at 11:32 -0700, Nick Desaulniers wrote: > Functions marked extern inline do not emit an externally visible > function when the gnu89 C standard is used. Some KBUILD Makefiles > overwrite KBUILD_CFLAGS. This is an issue for GCC 5.1+ users as without > an explicit C standard specif

Call for Papers - DSIC’18 - Montenegro

DSIC’18 – The 2018 International Conference on Digital Science 19 – 21 October 2018, Montenegro https://digscience.org/ SCOPE DSIC’18 – The 2018 Internat

Re: [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations

On Thu, 2018-06-07 at 10:26 -0700, Nick Desaulniers wrote: > I get the feeling that the use of __inline__ or __inline (vs inline) > in the kernel may be wrong and their use should be eradicated in the > follow up patch set, but it would be cool if others have additional > insight. __inline is easy

Re: KMSAN: uninit-value in _copy_to_iter (2)

On Thu, Jun 07, 2018 at 08:59:06PM +0300, Michael S. Tsirkin wrote: > On Thu, Jun 07, 2018 at 06:43:55PM +0100, Al Viro wrote: > > On Thu, Jun 07, 2018 at 06:38:48PM +0300, Michael S. Tsirkin wrote: > > > #syz test: https://github.com/google/kmsan.git/master > > > d2d741e5d1898dfde1a75ea3d29a9a3e2

Re: KMSAN: uninit-value in _copy_to_iter (2)

On Thu, Jun 07, 2018 at 06:43:55PM +0100, Al Viro wrote: > On Thu, Jun 07, 2018 at 06:38:48PM +0300, Michael S. Tsirkin wrote: > > #syz test: https://github.com/google/kmsan.git/master > > d2d741e5d1898dfde1a75ea3d29a9a3e2edf0617 > > > > Subject: vhost: fix info leak > > > > Fixes: CVE-2018-1118

Re: KMSAN: uninit-value in _copy_to_iter (2)

On Thu, Jun 07, 2018 at 06:38:48PM +0300, Michael S. Tsirkin wrote: > #syz test: https://github.com/google/kmsan.git/master > d2d741e5d1898dfde1a75ea3d29a9a3e2edf0617 > > Subject: vhost: fix info leak > > Fixes: CVE-2018-1118 > Signed-off-by: Michael S. Tsirkin > --- > diff --git a/drivers/vhos

Re: KMSAN: uninit-value in _copy_to_iter (2)

#syz test: https://github.com/google/kmsan.git master Subject: vhost: fix info leak Fixes: CVE-2018-1118 Signed-off-by: Michael S. Tsirkin --- diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index f0be5f35ab28..9beefa6ed1ce 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.

Re: [RFC V2] virtio: Add platform specific DMA API translation for virito devices

On Wed, Jun 06, 2018 at 10:23:06PM -0700, Christoph Hellwig wrote: > On Thu, May 31, 2018 at 08:43:58PM +0300, Michael S. Tsirkin wrote: > > Pls work on a long term solution. Short term needs can be served by > > enabling the iommu platform in qemu. > > So, I spent some time looking at converting

Re: KMSAN: uninit-value in _copy_to_iter (2)

On Thu, Jun 7, 2018 at 5:38 PM, Michael S. Tsirkin wrote: > #syz test: https://github.com/google/kmsan.git/master > d2d741e5d1898dfde1a75ea3d29a9a3e2edf0617 Hi Michael, We need: #syz test: https://github.com/google/kmsan.git master here. Please see https://github.com/google/syzkaller/blob/mas

Re: KMSAN: uninit-value in _copy_to_iter (2)

#syz test: https://github.com/google/kmsan.git/master d2d741e5d1898dfde1a75ea3d29a9a3e2edf0617 Subject: vhost: fix info leak Fixes: CVE-2018-1118 Signed-off-by: Michael S. Tsirkin --- diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index f0be5f35ab28..9beefa6ed1ce 100644 --- a/driver

Re: [PATCH v6] virtio_blk: add DISCARD and WRIET ZEROES commands support

On Wed, Jun 06, 2018 at 12:19:00PM +0800, Changpeng Liu wrote: > Existing virtio-blk protocol doesn't have DISCARD/WRITE ZEROES commands > support, this will impact the performance when using SSD backend over > file systems. > > Commit 88c85538 "virtio-blk: add discard and write zeroes features to

Re: [PATCH v3] virtio: update the comments for transport features

On Fri, Jun 01, 2018 at 07:26:32PM +0800, Tiwei Bie wrote: > The existing comments for transport features are outdated. > So update them to address the latest changes in the spec. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > Reviewed-by: Cornelia Huck > --- > This patch is

Re: [RFC v6 4/5] virtio_ring: add event idx support in packed ring

On 2018年06月05日 15:40, Tiwei Bie wrote: static bool virtqueue_enable_cb_delayed_packed(struct virtqueue *_vq) { struct vring_virtqueue *vq = to_vvq(_vq); + u16 bufs, used_idx, wrap_counter; START_USE(vq); /* We optimistically turn back on interrupts, then check if t