Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Michael S. Tsirkin
On Fri, Nov 09, 2018 at 10:30:50AM +0800, Jason Wang wrote: > > On 2018/11/8 下午11:56, Michael S. Tsirkin wrote: > > On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: > > > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > > >

Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Michael S. Tsirkin
On Fri, Nov 09, 2018 at 10:25:28AM +0800, Jason Wang wrote: > > On 2018/11/8 下午10:14, Michael S. Tsirkin wrote: > > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > > > + > > > > > > + if (vq->vq.num_free < descs_used) { > > > > > >

Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Jason Wang
On 2018/11/8 下午11:56, Michael S. Tsirkin wrote: On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: On 2018/11/8 上午9:38, Tiwei Bie wrote: + + if (vq->vq.num_free < descs_used) { + pr_debug("Can't add buf le

Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Jason Wang
On 2018/11/8 下午10:14, Michael S. Tsirkin wrote: On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: On 2018/11/8 上午9:38, Tiwei Bie wrote: + + if (vq->vq.num_free < descs_used) { + pr_debug("Can't add buf len %i - avail = %i\n", +descs_used, v

Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Tiwei Bie
On Thu, Nov 08, 2018 at 10:56:02AM -0500, Michael S. Tsirkin wrote: > On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: > > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > > > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > > > + > > > > > > + if (vq->vq.num_free < des

[PATCH 4.9 121/171] x86/paravirt: Fix some warning messages

2018-11-08 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 571d0563c8881595f4ab027aef9ed1c55e3e7b7c ] The first argument to WARN_ONCE() is a condition. Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt guests") Sig

Re: [PATCH v3 5/7] iommu: Add virtio-iommu driver

2018-11-08 Thread Jean-Philippe Brucker
On 08/11/2018 14:51, Auger Eric wrote: >>> +/* >>> + * viommu_replay_mappings - re-send MAP requests >>> + * >>> + * When reattaching a domain that was previously detached from all >>> endpoints, >>> + * mappings were deleted from the device. Re-create the mappings available >>> in >>> + * the in

Re: [PATCH v3 6/7] iommu/virtio: Add probe request

2018-11-08 Thread Jean-Philippe Brucker
On 08/11/2018 14:48, Auger Eric wrote: >> +struct virtio_iommu_probe_property { >> +__le16 type; >> +__le16 length; > the value[] field has disappeared but still is documented in the v0.8 spec. Good catch. I removed value[]

Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Michael S. Tsirkin
On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > > + > > > > > + if (vq->vq.num_free < descs_used) { > > > > > + pr_debug("Can't add buf len %i - avail = %i

Re: [PATCH v3 5/7] iommu: Add virtio-iommu driver

2018-11-08 Thread Auger Eric
Hi Jean-Philippe, On 10/12/18 6:35 PM, Michael S. Tsirkin wrote: > On Fri, Oct 12, 2018 at 03:59:15PM +0100, Jean-Philippe Brucker wrote: >> The virtio IOMMU is a para-virtualized device, allowing to send IOMMU >> requests such as map/unmap over virtio transport without emulating page >> tables. T

Re: [PATCH v3 6/7] iommu/virtio: Add probe request

2018-11-08 Thread Auger Eric
Hi Jean-Philippe, On 10/12/18 4:59 PM, Jean-Philippe Brucker wrote: > When the device offers the probe feature, send a probe request for each > device managed by the IOMMU. Extract RESV_MEM information. When we > encounter a MSI doorbell region, set it up as a IOMMU_RESV_MSI region. > This will te

Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Michael S. Tsirkin
On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > + > > > > + if (vq->vq.num_free < descs_used) { > > > > + pr_debug("Can't add buf len %i - avail = %i\n", > > > > +descs_used, vq->vq.num_free);

Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Tiwei Bie
On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > + > > > > + if (vq->vq.num_free < descs_used) { > > > > + pr_debug("Can't add buf len %i - avail = %i\n", > > > > +descs_used, vq->vq.num_free);

Re: [PATCH 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-11-08 Thread Jason Wang
On 2018/11/8 上午9:56, jiangyiwen wrote: On 2018/11/7 21:32, Jason Wang wrote: On 2018/11/7 下午3:11, jiangyiwen wrote: On 2018/11/7 14:18, Jason Wang wrote: On 2018/11/6 下午2:30, jiangyiwen wrote: Seems duplicated with the one used by vhost-net. In packed virtqueue implementation, I plan to mov

Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Jason Wang
On 2018/11/8 上午9:38, Tiwei Bie wrote: + + if (vq->vq.num_free < descs_used) { + pr_debug("Can't add buf len %i - avail = %i\n", +descs_used, vq->vq.num_free); + /* FIXME: for historical reasons, we force a notify here if +