4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-19 Thread Christian Borntraeger
Folks, I got this warning today. I cant tell when and why this happened, so I do not know yet how to reproduce. Maybe someone has a quick idea. [85109.572032] WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect+0x1f0/0x1318 [85109.572036] Modules linked in:

[PATCH v2] drm/bochs: add edid present check

2018-12-19 Thread Gerd Hoffmann
Check first two header bytes before trying to read the edid blob, to avoid the log being spammed in case qemu has no edid support (old qemu or edid turned off). Fixes: 01f23459cf drm/bochs: add edid support. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_hw.c | 8 1 file

[PATCH] virtio: fix test build after uio.h change

2018-12-19 Thread Michael S. Tsirkin
Fixes: d38499530e5 ("fs: decouple READ and WRITE from the block layer ops") Signed-off-by: Michael S. Tsirkin --- tools/virtio/linux/kernel.h | 4 1 file changed, 4 insertions(+) diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h index fb22bccfbc8a..7ef45a4a3cba 100644

[PULL] virtio fix

2018-12-19 Thread Michael S. Tsirkin
Sorry about the last-minute pull req. But it does seem very very safe and also the tests aren't automatically built right now so the 0 day infrastructure won't help anyway. The following changes since commit 7566ec393f4161572ba6f11ad5171fd5d59b0fbd: Linux 4.20-rc7 (2018-12-16 15:46:55 -0800)

Re: [PATCH v6 0/7] Add virtio-iommu driver

2018-12-19 Thread Michael S. Tsirkin
On Thu, Dec 13, 2018 at 12:50:29PM +, Jean-Philippe Brucker wrote: > >> [3] git://linux-arm.org/linux-jpb.git virtio-iommu/v0.9.1 > >> git://linux-arm.org/kvmtool-jpb.git virtio-iommu/v0.9 > > > > Unfortunatly gitweb seems to be broken on linux-arm.org. What is missing > > in this

Re: [PATCH net 4/4] vhost: log dirty page correctly

2018-12-19 Thread kbuild test robot
Hi Jason, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Jason-Wang/Fix-various-issue-of-vhost/20181210-223236 config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0

Re: [PATCH] drm/bochs: add edid present check

2018-12-19 Thread Gerd Hoffmann
Hi, > You could probably have a comment here explaining the magic below > (just like in the commit message to ease the task of understanding > while reading the code why 2 of 8 bytes of the EDID header is checked > and why it is all needed). Of course one can use git blame... Up to you Makes

Re: [PATCH v3 00/12] x86, kbuild: revert macrofying inline assembly code

2018-12-19 Thread Masahiro Yamada
On Wed, Dec 19, 2018 at 9:44 PM Ingo Molnar wrote: > > > * Masahiro Yamada wrote: > > > This series reverts the in-kernel workarounds for inlining issues. > > > > The commit description of 77b0bf55bc67 mentioned > > "We also hope that GCC will eventually get fixed,..." > > > > Now, GCC provides

[PATCH 08/10] drm/virtio: drop fencing in virtio_gpu_resource_create_ioctl

2018-12-19 Thread Gerd Hoffmann
There is no need to wait for completion here. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 51 +- 1 file changed, 1 insertion(+), 50 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c

[PATCH 05/10] drm/virtio: use struct to pass params to virtio_gpu_object_create()

2018-12-19 Thread Gerd Hoffmann
Create virtio_gpu_object_params, use that to pass object parameters to virtio_gpu_object_create. Also drop unused "kernel" parameter (unused, always false). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h| 15 ++- drivers/gpu/drm/virtio/virtgpu_gem.c|

[PATCH 07/10] drm/virtio: params struct for virtio_gpu_cmd_create_resource_3d()

2018-12-19 Thread Gerd Hoffmann
Add 3d resource parameters to virtio_gpu_object_params struct and use it for virtio_gpu_cmd_resource_create_3d() calls. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 10 +- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 25 ++---

[PATCH 02/10] drm/virtio: fix pageflip flush

2018-12-19 Thread Gerd Hoffmann
Sending the flush command only makes sense if we actually have a framebuffer attached to the scanout (handle != 0). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_plane.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH 04/10] drm/virtio: move virtio_gpu_object_{attach, detach} calls.

2018-12-19 Thread Gerd Hoffmann
Drop the dummy ttm backend implementation, add a real one for TTM_PL_FLAG_TT objects. The bin/unbind callbacks will call virtio_gpu_object_{attach,detach}, to update the object state on the host side, instead of invoking those calls from the move_notify() callback. With that in place the move

[PATCH 09/10] drm/virtio: move virtio_gpu_cmd_create_resource call into virtio_gpu_object_create

2018-12-19 Thread Gerd Hoffmann
Specifically call virtio_gpu_object_create() before ttm_bo_init(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h| 2 ++ drivers/gpu/drm/virtio/virtgpu_gem.c| 3 +-- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 10 ++ drivers/gpu/drm/virtio/virtgpu_object.c

[PATCH 10/10] drm/virtio: ditch virtio_gpu_object_attach() calls

2018-12-19 Thread Gerd Hoffmann
With virtio_gpu_object_create() being called earlier ttm_bo_init() will handle the virtio_gpu_object_attach() (via backend binding), so we can drop the extra calls now. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_gem.c | 9 - drivers/gpu/drm/virtio/virtgpu_ioctl.c

[PATCH 01/10] drm/virtio: log error responses

2018-12-19 Thread Gerd Hoffmann
If we got an error response code from the host, print it to the log. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_vq.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c

[PATCH 03/10] drm/virtio: drop virtio_gpu_fence_cleanup()

2018-12-19 Thread Gerd Hoffmann
Just call drm_fence_put directly instead. Also set vgfb->fence to NULL after dropping the reference. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 1 - drivers/gpu/drm/virtio/virtgpu_fence.c | 8 drivers/gpu/drm/virtio/virtgpu_ioctl.c | 2 +-

[PATCH 06/10] drm/virtio: params struct for virtio_gpu_cmd_create_resource()

2018-12-19 Thread Gerd Hoffmann
Add format, width and height to the virtio_gpu_object_params struct and use the struct for virtio_gpu_cmd_create_resource(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 7 --- drivers/gpu/drm/virtio/virtgpu_gem.c | 8

[PATCH 13/14] drm/bochs: drop old fbdev emulation code

2018-12-19 Thread Gerd Hoffmann
Not needed any more, bochs uses the generic emulation now. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs.h | 9 --- drivers/gpu/drm/bochs/bochs_drv.c | 6 -- drivers/gpu/drm/bochs/bochs_fbdev.c | 137 3 files changed, 152

[PATCH 08/14] drm/bochs: atomic: set DRIVER_ATOMIC

2018-12-19 Thread Gerd Hoffmann
Conversion to atomic modesetting, final step. Set the DRIVER_ATOMIC flag. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index

[PATCH 07/14] drm/bochs: atomic: use atomic page_flip helper

2018-12-19 Thread Gerd Hoffmann
Conversion to atomic modesetting, step five. Use atomic page_flip helper for crtc. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_kms.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c

[PATCH 11/14] drm/bochs: add basic prime support

2018-12-19 Thread Gerd Hoffmann
Generic framebuffer emulation needs this. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs.h | 11 +++ drivers/gpu/drm/bochs/bochs_drv.c | 15 +- drivers/gpu/drm/bochs/bochs_mm.c | 63 +++ 3 files changed, 88 insertions(+), 1

[PATCH 14/14] drm/bochs: move remaining fb bits to kms

2018-12-19 Thread Gerd Hoffmann
bochs_fbdev.c is almost empty now. Move the remaining framebuffer bits over to bochs_kms.c. Pure code motion. No functional change. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_fbdev.c | 29 - drivers/gpu/drm/bochs/bochs_kms.c | 17

[PATCH 09/14] drm/bochs: remove old bochs_crtc_* functions

2018-12-19 Thread Gerd Hoffmann
Remove the old, now unused crtc callbacks. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_kms.c | 81 --- 1 file changed, 81 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c index

[PATCH 10/14] drm/bochs: drop unused gpu_addr arg from bochs_bo_pin()

2018-12-19 Thread Gerd Hoffmann
It's always NULL, so just remove it. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs.h | 2 +- drivers/gpu/drm/bochs/bochs_fbdev.c | 2 +- drivers/gpu/drm/bochs/bochs_kms.c | 2 +- drivers/gpu/drm/bochs/bochs_mm.c| 11 +-- 4 files changed, 4 insertions(+), 13

[PATCH 05/14] drm/bochs: atomic: switch planes to atomic, wire up helpers.

2018-12-19 Thread Gerd Hoffmann
Conversion to atomic modesetting, step three. Wire up atomic helpers. Switch planes to atomic. We are late to the party, the transitional helpers are gone, so this can't be splitted into smaller steps any more. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_fbdev.c | 3 ++

[PATCH 12/14] drm/bochs: switch to generic drm fbdev emulation

2018-12-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index a9c7140e3b..f1f65324bb 100644 --- a/drivers/gpu/drm/bochs/bochs_drv.c +++

[PATCH 04/14] drm/bochs: atomic: add mode_set_nofb callback.

2018-12-19 Thread Gerd Hoffmann
Conversion to atomic modesetting, step two. Add mode_set_nofb crtc helper callback. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_kms.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c index

[PULL 1/1] virtio-ccw: diag 500 may return a negative cookie

2018-12-19 Thread Cornelia Huck
If something goes wrong in the kvm io bus handling, the virtio-ccw diagnose may return a negative error value in the cookie gpr. Document this. Reviewed-by: Halil Pasic Signed-off-by: Cornelia Huck --- Documentation/virtual/kvm/s390-diag.txt | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH 06/14] drm/bochs: atomic: use atomic set_config helper

2018-12-19 Thread Gerd Hoffmann
Conversion to atomic modesetting, step four. Use atomic set_config helper for crtc. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c index

[PATCH 01/14] drm/bochs: encoder cleanup

2018-12-19 Thread Gerd Hoffmann
Most unused callbacks can be NULL pointers these days. Drop a bunch of empty encoder callbacks. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_kms.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c

[PATCH 02/14] drm/bochs: split bochs_hw_setmode

2018-12-19 Thread Gerd Hoffmann
Create a separate bochs_hw_setformat function to configure the framebuffer format (actually just the byteorder). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs.h | 5 +++-- drivers/gpu/drm/bochs/bochs_hw.c | 19 --- drivers/gpu/drm/bochs/bochs_kms.c | 3 ++-

Re: [PATCH v3 00/12] x86, kbuild: revert macrofying inline assembly code

2018-12-19 Thread Masahiro Yamada
On Wed, Dec 19, 2018 at 5:26 AM Nadav Amit wrote: > > > On Dec 17, 2018, at 8:03 AM, Masahiro Yamada > > wrote: > > > > This series reverts the in-kernel workarounds for inlining issues. > > > > The commit description of 77b0bf55bc67 mentioned > > "We also hope that GCC will eventually get

Re: [PATCH v2] VSOCK: Send reset control packet when socket is partially bound

2018-12-19 Thread David Miller
From: Jorgen Hansen Date: Tue, 18 Dec 2018 00:34:06 -0800 > If a server side socket is bound to an address, but not in the listening > state yet, incoming connection requests should receive a reset control > packet in response. However, the function used to send the reset > silently drops the

[PATCH v2] VSOCK: Send reset control packet when socket is partially bound

2018-12-19 Thread Jorgen Hansen
If a server side socket is bound to an address, but not in the listening state yet, incoming connection requests should receive a reset control packet in response. However, the function used to send the reset silently drops the reset packet if the sending socket isn't bound to a remote address (as

[PATCH] drm/bochs: add edid present check

2018-12-19 Thread Gerd Hoffmann
Check first two header bytes before trying to read the edid blob, to avoid the log being spammed in case qemu has no edid support (old qemu or edid turned off). Fixes: 01f23459cf drm/bochs: add edid support. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_hw.c | 4 1 file

[PATCH] virtio-ccw: diag 500 may return a negative cookie

2018-12-19 Thread Cornelia Huck
If something goes wrong in the kvm io bus handling, the virtio-ccw diagnose may return a negative error value in the cookie gpr. Document this. Signed-off-by: Cornelia Huck --- Even if the virtio spec is the correct place to specify what diag 500 subcode 3 does, we also should mention here

Re: [PATCH] Export mm_update_next_owner function for vhost-net

2018-12-19 Thread Michael S. Tsirkin
On Tue, Dec 18, 2018 at 09:39:16AM +0800, gchen chen wrote: > Yes, I think so.  > and i think the point is that unuse_mm() can't directly set tsk->mm=NULL. So why can't unuse_mm call mm_update_next_owner? -- MST ___ Virtualization mailing list

Re: kernel vhost demands an interrupt from guest when the ring is full in order to enable guest to submit new packets to the queue

2018-12-19 Thread Steven Luong (sluong) via Virtualization
On 12/17/18, 2:55 PM, "Michael S. Tsirkin" wrote: On Thu, Dec 13, 2018 at 11:24:28PM +, Steven Luong (sluong) via Virtualization wrote: > Folks, > > > > We came across a memory race condition between VPP vhost driver and the kernel > vhost. VPP is running

Re: kernel vhost demands an interrupt from guest when the ring is full in order to enable guest to submit new packets to the queue

2018-12-19 Thread Michael S. Tsirkin
On Mon, Dec 17, 2018 at 11:56:59PM +, Steven Luong (sluong) wrote: > > > On 12/17/18, 2:55 PM, "Michael S. Tsirkin" wrote: > > On Thu, Dec 13, 2018 at 11:24:28PM +, Steven Luong (sluong) via > Virtualization wrote: > > Folks, > > > > > > > > We came across

Re: kernel vhost demands an interrupt from guest when the ring is full in order to enable guest to submit new packets to the queue

2018-12-19 Thread Michael S. Tsirkin
On Thu, Dec 13, 2018 at 11:24:28PM +, Steven Luong (sluong) via Virtualization wrote: > Folks, > > > > We came across a memory race condition between VPP vhost driver and the kernel > vhost. VPP is running a tap interface over vhost backend. In this case, VPP is > acting as the vhost

Re: [PATCH] VSOCK: Send reset control packet when socket is partially bound

2018-12-19 Thread David Miller
From: Jorgen Hansen Date: Wed, 12 Dec 2018 01:38:59 -0800 > static int vmci_transport_send_reset_bh(struct sockaddr_vm *dst, > @@ -312,12 +328,29 @@ static int vmci_transport_send_reset_bh(struct > sockaddr_vm *dst, > static int vmci_transport_send_reset(struct sock *sk, >

[PATCH v3 00/12] x86, kbuild: revert macrofying inline assembly code

2018-12-19 Thread Masahiro Yamada
This series reverts the in-kernel workarounds for inlining issues. The commit description of 77b0bf55bc67 mentioned "We also hope that GCC will eventually get fixed,..." Now, GCC provides a solution. https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html explains the new "asm inline" syntax. The

[PATCH v3 04/12] Revert "x86/paravirt: Work around GCC inlining bugs when compiling paravirt ops"

2018-12-19 Thread Masahiro Yamada
This reverts commit 494b5168f2de009eb80f198f668da374295098dd. The in-kernel workarounds will be replaced with GCC's new "asm inline" syntax. Signed-off-by: Masahiro Yamada --- arch/x86/include/asm/paravirt_types.h | 56 ++- arch/x86/kernel/macros.S

Re: [PATCH] Export mm_update_next_owner function for vhost-net

2018-12-19 Thread Christoph Hellwig
This seems like an issue all the unuse_mm users (at least those outside of swapfile.c) have, so it should be solved in the core. Bonus points for moving the set_fs magic into use_mm().. ___ Virtualization mailing list

[PATCH 03/14] drm/bochs: atomic: add atomic_flush+atomic_enable callbacks.

2018-12-19 Thread Gerd Hoffmann
Conversion to atomic modesetting, step one. Add atomic crtc helper callbacks. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_kms.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c

Re: [PATCH v3 00/12] x86, kbuild: revert macrofying inline assembly code

2018-12-19 Thread Ingo Molnar
* Masahiro Yamada wrote: > This series reverts the in-kernel workarounds for inlining issues. > > The commit description of 77b0bf55bc67 mentioned > "We also hope that GCC will eventually get fixed,..." > > Now, GCC provides a solution. > >

[PULL 0/1] virtio-ccw: one more patch for 4.21

2018-12-19 Thread Cornelia Huck
The following changes since commit 37d1246af2d530710cf5822d2845774f01c03b22: virtio_net: bulk free tx skbs (2018-12-06 14:28:39 -0500) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/virtio-ccw-20181219 for you to fetch changes

Re: [PATCH v2] x86, kbuild: revert macrofying inline assembly code

2018-12-19 Thread Masahiro Yamada
On Sun, Dec 16, 2018 at 12:29 PM Nadav Amit wrote: > > > On Dec 15, 2018, at 6:50 PM, Masahiro Yamada > > wrote: > > > > Revert the following 9 commits: > > > > [1] 5bdcd510c2ac ("x86/jump-labels: Macrofy inline assembly code to > >work around GCC inlining bugs") > > > >This was

Re: [PATCH] virtio-ccw: diag 500 may return a negative cookie

2018-12-19 Thread Cornelia Huck
On Tue, 18 Dec 2018 14:20:34 +0100 Cornelia Huck wrote: > If something goes wrong in the kvm io bus handling, the virtio-ccw > diagnose may return a negative error value in the cookie gpr. > > Document this. > > Signed-off-by: Cornelia Huck > --- > > Even if the virtio spec is the correct