[PATCH net V2] vhost: log dirty page correctly

2019-01-08 Thread Jason Wang
Vhost dirty page logging API is designed to sync through GPA. But we try to log GIOVA when device IOTLB is enabled. This is wrong and may lead to missing data after migration. To solve this issue, when logging with device IOTLB enabled, we will: 1) reuse the device IOTLB translation result of

Re: __get_user slower than get_user (was Re: [RFC PATCH V3 0/5] Hi:)

2019-01-08 Thread Linus Torvalds
On Tue, Jan 8, 2019 at 8:31 PM Michael S. Tsirkin wrote: > > Linus, given that you just changed all users of access_ok anyway, do > you still think that the access_ok() conversion to return a speculation > sanitized pointer or NULL is too big a conversion? I didn't actually change a single

__get_user slower than get_user (was Re: [RFC PATCH V3 0/5] Hi:)

2019-01-08 Thread Michael S. Tsirkin
On Mon, Jan 07, 2019 at 02:44:24PM -0800, Dan Williams wrote: > On Mon, Jan 7, 2019 at 2:25 PM Michael S. Tsirkin wrote: > > > > On Mon, Jan 07, 2019 at 01:39:15PM -0800, Dan Williams wrote: > > > On Mon, Jan 7, 2019 at 6:11 AM Michael S. Tsirkin wrote: > > > > > > > > On Sun, Jan 06, 2019 at

Re: [RFC PATCH V3 0/5] Hi:

2019-01-08 Thread Jason Wang
On 2019/1/7 下午10:11, Michael S. Tsirkin wrote: On Sun, Jan 06, 2019 at 11:15:20PM -0800, Dan Williams wrote: On Sun, Jan 6, 2019 at 8:17 PM Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 11:53:41AM +0800, Jason Wang wrote: On 2019/1/7 上午11:28, Michael S. Tsirkin wrote: On Mon, Jan 07,

[PATCH v2 08/15] drm/bochs: atomic: set DRIVER_ATOMIC

2019-01-08 Thread Gerd Hoffmann
Conversion to atomic modesetting, final step. Set the DRIVER_ATOMIC flag. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c

[PATCH v2 05/15] drm/bochs: atomic: switch planes to atomic, wire up helpers.

2019-01-08 Thread Gerd Hoffmann
Conversion to atomic modesetting, step three. Wire up atomic helpers. Switch planes to atomic. We are late to the party, the transitional helpers are gone, so this can't be splitted into smaller steps any more. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko ---

[PATCH v2 13/15] drm/bochs: drop old fbdev emulation code

2019-01-08 Thread Gerd Hoffmann
Not needed any more, bochs uses the generic emulation now. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs.h | 9 --- drivers/gpu/drm/bochs/bochs_drv.c | 6 -- drivers/gpu/drm/bochs/bochs_fbdev.c | 137

[PATCH v2 10/15] drm/bochs: drop unused gpu_addr arg from bochs_bo_pin()

2019-01-08 Thread Gerd Hoffmann
It's always NULL, so just remove it. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs.h | 2 +- drivers/gpu/drm/bochs/bochs_fbdev.c | 2 +- drivers/gpu/drm/bochs/bochs_kms.c | 2 +- drivers/gpu/drm/bochs/bochs_mm.c| 11 +--

[PATCH v2 11/15] drm/bochs: add basic prime support

2019-01-08 Thread Gerd Hoffmann
Generic framebuffer emulation needs this. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs.h | 11 +++ drivers/gpu/drm/bochs/bochs_drv.c | 15 +- drivers/gpu/drm/bochs/bochs_mm.c | 63 +++ 3

[PATCH v2 12/15] drm/bochs: switch to generic drm fbdev emulation

2019-01-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index a9c7140e3b..350e34cf2c 100644 --- a/drivers/gpu/drm/bochs/bochs_drv.c +++

[PATCH v2 15/15] drm/bochs: reserve bo for pin/unpin

2019-01-08 Thread Gerd Hoffmann
The buffer object must be reserved before calling ttm_bo_validate for pinning/unpinning. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_mm.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c index

[PATCH v2 09/15] drm/bochs: remove old bochs_crtc_* functions

2019-01-08 Thread Gerd Hoffmann
Remove the old, now unused crtc callbacks. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_kms.c | 81 --- 1 file changed, 81 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c

[PATCH v2 07/15] drm/bochs: atomic: use atomic page_flip helper

2019-01-08 Thread Gerd Hoffmann
Conversion to atomic modesetting, step five. Use atomic page_flip helper for crtc. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_kms.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git

[PATCH v2 14/15] drm/bochs: move remaining fb bits to kms

2019-01-08 Thread Gerd Hoffmann
bochs_fbdev.c is almost empty now. Move the remaining framebuffer bits over to bochs_kms.c. Pure code motion. No functional change. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_fbdev.c | 29 -

[PATCH v2 04/15] drm/bochs: atomic: add mode_set_nofb callback.

2019-01-08 Thread Gerd Hoffmann
Conversion to atomic modesetting, step two. Add mode_set_nofb crtc helper callback. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_kms.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c

[PATCH v2 01/15] drm/bochs: encoder cleanup

2019-01-08 Thread Gerd Hoffmann
Most unused callbacks can be NULL pointers these days. Drop a bunch of empty encoder callbacks. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_kms.c | 26 -- 1 file changed, 26 deletions(-) diff --git

[PATCH v2 06/15] drm/bochs: atomic: use atomic set_config helper

2019-01-08 Thread Gerd Hoffmann
Conversion to atomic modesetting, step four. Use atomic set_config helper for crtc. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c

[PATCH v2 02/15] drm/bochs: split bochs_hw_setmode

2019-01-08 Thread Gerd Hoffmann
Create a separate bochs_hw_setformat function to configure the framebuffer format (actually just the byteorder). Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs.h | 5 +++-- drivers/gpu/drm/bochs/bochs_hw.c | 19 ---

CFP: The 28th Int. ACM Symp. on High-Performance Parallel and Distributed Computing (HPDC'19) 2019

2019-01-08 Thread Ioan Raicu
The 28th International ACM Symposium on High-Performance Parallel and Distributed Computing (HPDC'19) Phoenix, Arizona, United States on June 24-28, 2019 Sponsored by ACM SIGARCH http://www.hpdc.org/2019/ http://www.hpdc.org/2019/papers/call-for-papers/hpdc2019-flyer.pdf

Re: kernel vhost demands an interrupt from guest when the ring is full in order to enable guest to submit new packets to the queue

2019-01-08 Thread Steven Luong (sluong) via Virtualization
Michael, Thank you very much for your help. I greatly appreciate it. Steven On 12/17/18, 4:16 PM, "Michael S. Tsirkin" wrote: On Mon, Dec 17, 2018 at 11:56:59PM +, Steven Luong (sluong) wrote: > > > On 12/17/18, 2:55 PM, "Michael S. Tsirkin" wrote: > > On

Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-08 Thread Michael S. Tsirkin
On Tue, Jan 08, 2019 at 09:44:28AM -0800, Nick Desaulniers wrote: > Thanks for the patch and sorry for the delay; was totally unplugged > for the holidays. > On Wed, Jan 2, 2019 at 12:57 PM Michael S. Tsirkin wrote: > > > > Since commit 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h

[PATCH v2 03/15] drm/bochs: atomic: add atomic_flush+atomic_enable callbacks.

2019-01-08 Thread Gerd Hoffmann
Conversion to atomic modesetting, step one. Add atomic crtc helper callbacks. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_kms.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c

Re: [PATCH] vhost/vsock: fix vhost vsock cid hashing inconsistent

2019-01-08 Thread Stefan Hajnoczi
On Tue, Jan 08, 2019 at 04:07:03PM +0800, Zha Bin wrote: > The vsock core only supports 32bit CID, but the Virtio-vsock spec define > CID (dst_cid and src_cid) as u64 and the upper 32bits is reserved as > zero. This inconsistency causes one bug in vhost vsock driver. The > scenarios is: > > 0.

Re: [PATCH] drm/virtio: Drop deprecated load/unload initialization

2019-01-08 Thread Gerd Hoffmann
On Thu, Jan 03, 2019 at 01:16:00PM -0300, Ezequiel Garcia wrote: > Move the code around so the driver is probed the bus > .probe and removed from the bus .remove callbacks. > This commit is just a cleanup and shouldn't affect > functionality. Doesn't apply cleanly to drm-misc-next, and git can't

Re: [PATCH] drm/virtio: Remove incorrect kfree()

2019-01-08 Thread Gerd Hoffmann
On Wed, Jan 02, 2019 at 02:55:06PM -0300, Ezequiel Garcia wrote: > The virtio_gpu_output is a member of struct virtio_gpu_device > and is not a dynamically-allocated chunk, so it's wrong to kfree() it. > Removing it fixes a memory corruption BUG() that can be triggered > when the virtio-gpu driver

Re: [RFC PATCH V3 0/5] Hi:

2019-01-08 Thread Jason Wang
On 2019/1/7 下午10:47, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 02:58:08PM +0800, Jason Wang wrote: On 2019/1/5 上午5:41, Michael S. Tsirkin wrote: On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: This series tries to access virtqueue metadata through kernel virtual address

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-08 Thread Jason Wang
On 2019/1/7 下午10:19, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 02:31:47PM +0800, Jason Wang wrote: On 2019/1/7 下午12:01, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 11:51:55AM +0800, Jason Wang wrote: On 2019/1/7 上午11:17, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at

Re: [RFC PATCH V3 0/5] Hi:

2019-01-08 Thread Jason Wang
On 2019/1/7 下午10:37, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 02:50:17PM +0800, Jason Wang wrote: On 2019/1/7 下午12:17, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 11:53:41AM +0800, Jason Wang wrote: On 2019/1/7 上午11:28, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at

Re: [PATCH v3 1/3] virtio-balloon: tweak config_changed implementation

2019-01-08 Thread Christian Borntraeger
On 08.01.2019 06:35, Wei Wang wrote: > On 01/07/2019 09:49 PM, Christian Borntraeger wrote: >> >> On 07.01.2019 08:01, Wei Wang wrote: >>> virtio-ccw has deadlock issues with reading the config space inside the >>> interrupt context, so we tweak the virtballoon_changed implementation >>> by