Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag

2019-05-13 Thread Pankaj Gupta
> > > > > > Hi Dan, > > > > While testing device mapper with DAX, I faced a bug with the commit: > > > > commit ad428cdb525a97d15c0349fdc80f3d58befb50df > > Author: Dan Williams > > Date: Wed Feb 20 21:12:50 2019 -0800 > > > > When I reverted the condition to old code[1] it worked for me. I >

Re: [PATCH net] vhost: don't use kmap() to log dirty pages

2019-05-13 Thread Jason Wang
On 2019/5/14 上午12:42, David Miller wrote: From: Jason Wang Date: Mon, 13 May 2019 01:27:45 -0400 Vhost log dirty pages directly to a userspace bitmap through GUP and kmap_atomic() since kernel doesn't have a set_bit_to_user() helper. This will cause issues for the arch that has virtually tagg

Re: [PATCH v2 1/8] vsock/virtio: limit the memory used per-socket

2019-05-13 Thread Jason Wang
On 2019/5/14 上午11:25, Jason Wang wrote: On 2019/5/14 上午1:23, Stefano Garzarella wrote: On Mon, May 13, 2019 at 05:58:53PM +0800, Jason Wang wrote: On 2019/5/10 下午8:58, Stefano Garzarella wrote: Since virtio-vsock was introduced, the buffers filled by the host and pushed to the guest using th

Re: [PATCH v2 7/8] vsock/virtio: increase RX buffer size to 64 KiB

2019-05-13 Thread Jason Wang
On 2019/5/14 上午1:51, Stefano Garzarella wrote: On Mon, May 13, 2019 at 06:01:52PM +0800, Jason Wang wrote: On 2019/5/10 下午8:58, Stefano Garzarella wrote: In order to increase host -> guest throughput with large packets, we can use 64 KiB RX buffers. Signed-off-by: Stefano Garzarella --- i

Re: [PATCH v2 1/8] vsock/virtio: limit the memory used per-socket

2019-05-13 Thread Jason Wang
On 2019/5/14 上午1:23, Stefano Garzarella wrote: On Mon, May 13, 2019 at 05:58:53PM +0800, Jason Wang wrote: On 2019/5/10 下午8:58, Stefano Garzarella wrote: Since virtio-vsock was introduced, the buffers filled by the host and pushed to the guest using the vring, are directly queued in a per-sock

Re: [PATCH net] vhost: don't use kmap() to log dirty pages

2019-05-13 Thread kbuild test robot
Hi Jason, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vhost-don-t-use-kmap-to-log-dirty-pages/20190514-052319 config: i386-randconfig-x005-201919 (attached as .config) compiler: gcc-7 (Debia

Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag

2019-05-13 Thread Dan Williams
On Mon, May 13, 2019 at 10:32 AM Pankaj Gupta wrote: > > > Hi Dan, > > While testing device mapper with DAX, I faced a bug with the commit: > > commit ad428cdb525a97d15c0349fdc80f3d58befb50df > Author: Dan Williams > Date: Wed Feb 20 21:12:50 2019 -0800 > > When I reverted the condition to old

Re: [PATCH v2 7/8] vsock/virtio: increase RX buffer size to 64 KiB

2019-05-13 Thread Stefano Garzarella
On Mon, May 13, 2019 at 06:01:52PM +0800, Jason Wang wrote: > > On 2019/5/10 下午8:58, Stefano Garzarella wrote: > > In order to increase host -> guest throughput with large packets, > > we can use 64 KiB RX buffers. > > > > Signed-off-by: Stefano Garzarella > > --- > > include/linux/virtio_vsoc

Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag

2019-05-13 Thread Pankaj Gupta
Hi Dan, While testing device mapper with DAX, I faced a bug with the commit: commit ad428cdb525a97d15c0349fdc80f3d58befb50df Author: Dan Williams Date: Wed Feb 20 21:12:50 2019 -0800 When I reverted the condition to old code[1] it worked for me. I am thinking when we map two different devi

Re: [PATCH v2 1/8] vsock/virtio: limit the memory used per-socket

2019-05-13 Thread Stefano Garzarella
On Mon, May 13, 2019 at 05:58:53PM +0800, Jason Wang wrote: > > On 2019/5/10 下午8:58, Stefano Garzarella wrote: > > Since virtio-vsock was introduced, the buffers filled by the host > > and pushed to the guest using the vring, are directly queued in > > a per-socket list avoiding to copy it. > > Th

Re: [PATCH v2 0/8] vsock/virtio: optimizations to increase the throughput

2019-05-13 Thread Stefano Garzarella
On Mon, May 13, 2019 at 05:33:40PM +0800, Jason Wang wrote: > > On 2019/5/10 下午8:58, Stefano Garzarella wrote: > > While I was testing this new series (v2) I discovered an huge use of memory > > and a memory leak in the virtio-vsock driver in the guest when I sent > > 1-byte packets to the guest.

Re: [PATCH net] vhost: don't use kmap() to log dirty pages

2019-05-13 Thread David Miller
From: Jason Wang Date: Mon, 13 May 2019 01:27:45 -0400 > Vhost log dirty pages directly to a userspace bitmap through GUP and > kmap_atomic() since kernel doesn't have a set_bit_to_user() > helper. This will cause issues for the arch that has virtually tagged > caches. The way to fix is to keep u

Re: [PATCH v2 1/8] vsock/virtio: limit the memory used per-socket

2019-05-13 Thread Stefano Garzarella
On Sun, May 12, 2019 at 12:57:48PM -0400, Michael S. Tsirkin wrote: > On Fri, May 10, 2019 at 02:58:36PM +0200, Stefano Garzarella wrote: > > Since virtio-vsock was introduced, the buffers filled by the host > > and pushed to the guest using the vring, are directly queued in > > a per-socket list a

Re: [PATCH 09/10] virtio/s390: use DMA memory for ccw I/O and classic notifiers

2019-05-13 Thread Cornelia Huck
On Fri, 26 Apr 2019 20:32:44 +0200 Halil Pasic wrote: > Before virtio-ccw could get away with not using DMA API for the pieces of > memory it does ccw I/O with. With protected virtualization this has to > change, since the hypervisor needs to read and sometimes also write these > pieces of memory

Re: [PATCH 05/10] s390/cio: introduce DMA pools to cio

2019-05-13 Thread Cornelia Huck
On Sun, 12 May 2019 20:22:56 +0200 Halil Pasic wrote: > On Fri, 10 May 2019 16:10:13 +0200 > Cornelia Huck wrote: > > > On Fri, 10 May 2019 00:11:12 +0200 > > Halil Pasic wrote: > > > > > On Thu, 9 May 2019 12:11:06 +0200 > > > Cornelia Huck wrote: > > > > > > > On Wed, 8 May 2019 23:22

Re: [PATCH 07/10] s390/airq: use DMA memory for adapter interrupts

2019-05-13 Thread Cornelia Huck
On Fri, 26 Apr 2019 20:32:42 +0200 Halil Pasic wrote: > Protected virtualization guests have to use shared pages for airq > notifier bit vectors, because hypervisor needs to write these bits. > > Let us make sure we allocate DMA memory for the notifier bit vectors. [Looking at this first, befor

Re: [PATCH v2 8/8] vsock/virtio: make the RX buffer size tunable

2019-05-13 Thread Jason Wang
On 2019/5/13 下午6:05, Jason Wang wrote: On 2019/5/10 下午8:58, Stefano Garzarella wrote: The RX buffer size determines the memory consumption of the vsock/virtio guest driver, so we make it tunable through a module parameter. The size allowed are between 4 KB and 64 KB in order to be compatible

Re: [PATCH 01/10] virtio/s390: use vring_create_virtqueue

2019-05-13 Thread Cornelia Huck
On Mon, 13 May 2019 14:27:35 +0200 Michael Mueller wrote: > On 13.05.19 11:52, Cornelia Huck wrote: > > On Sun, 12 May 2019 12:47:39 -0400 > > "Michael S. Tsirkin" wrote: > > > >> On Fri, May 10, 2019 at 04:07:44PM +0200, Cornelia Huck wrote: > >>> On Tue, 7 May 2019 15:58:12 +0200 > >>> Ch

Re: [PATCH 10/10] virtio/s390: make airq summary indicators DMA

2019-05-13 Thread Cornelia Huck
On Fri, 26 Apr 2019 20:32:45 +0200 Halil Pasic wrote: > Hypervisor needs to interact with the summary indicators, so these > need to be DMA memory as well (at least for protected virtualization > guests). > > Signed-off-by: Halil Pasic > --- > drivers/s390/virtio/virtio_ccw.c | 24

Re: [PATCH 08/10] virtio/s390: add indirection to indicators access

2019-05-13 Thread Cornelia Huck
On Fri, 10 May 2019 17:36:05 +0200 Pierre Morel wrote: > On 10/05/2019 13:54, Halil Pasic wrote: > > On Fri, 10 May 2019 09:43:08 +0200 > > Pierre Morel wrote: > > > >> On 09/05/2019 20:26, Halil Pasic wrote: > >>> On Thu, 9 May 2019 14:01:01 +0200 > >>> Pierre Morel wrote: > >>> >

Re: [PATCH v2 8/8] vsock/virtio: make the RX buffer size tunable

2019-05-13 Thread Jason Wang
On 2019/5/10 下午8:58, Stefano Garzarella wrote: The RX buffer size determines the memory consumption of the vsock/virtio guest driver, so we make it tunable through a module parameter. The size allowed are between 4 KB and 64 KB in order to be compatible with old host drivers. Suggested-by: Ste

Re: [PATCH v2 7/8] vsock/virtio: increase RX buffer size to 64 KiB

2019-05-13 Thread Jason Wang
On 2019/5/10 下午8:58, Stefano Garzarella wrote: In order to increase host -> guest throughput with large packets, we can use 64 KiB RX buffers. Signed-off-by: Stefano Garzarella --- include/linux/virtio_vsock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux

Re: [PATCH v2 1/8] vsock/virtio: limit the memory used per-socket

2019-05-13 Thread Jason Wang
On 2019/5/10 下午8:58, Stefano Garzarella wrote: Since virtio-vsock was introduced, the buffers filled by the host and pushed to the guest using the vring, are directly queued in a per-socket list avoiding to copy it. These buffers are preallocated by the guest with a fixed size (4 KB). The maxim

Re: [PATCH 01/10] virtio/s390: use vring_create_virtqueue

2019-05-13 Thread Cornelia Huck
On Sun, 12 May 2019 12:47:39 -0400 "Michael S. Tsirkin" wrote: > On Fri, May 10, 2019 at 04:07:44PM +0200, Cornelia Huck wrote: > > On Tue, 7 May 2019 15:58:12 +0200 > > Christian Borntraeger wrote: > > > > > On 05.05.19 13:15, Cornelia Huck wrote: > > > > On Sat, 4 May 2019 16:03:40 +0200

Re: [PATCH 06/10] s390/cio: add basic protected virtualization support

2019-05-13 Thread Cornelia Huck
On Fri, 26 Apr 2019 20:32:41 +0200 Halil Pasic wrote: > As virtio-ccw devices are channel devices, we need to use the dma area > for any communication with the hypervisor. > > This patch addresses the most basic stuff (mostly what is required for > virtio-ccw), and does take care of QDIO or any

Re: [PATCH v2 0/8] vsock/virtio: optimizations to increase the throughput

2019-05-13 Thread Jason Wang
On 2019/5/10 下午8:58, Stefano Garzarella wrote: While I was testing this new series (v2) I discovered an huge use of memory and a memory leak in the virtio-vsock driver in the guest when I sent 1-byte packets to the guest. These issues are present since the introduction of the virtio-vsock drive