Re: [RFC PATCH 5/6] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-05-27 Thread Nadav Amit via Virtualization
> On May 27, 2019, at 2:47 AM, Peter Zijlstra wrote: > > On Sat, May 25, 2019 at 10:54:50AM +0200, Juergen Gross wrote: >> On 25/05/2019 10:22, Nadav Amit wrote: > >>> diff --git a/arch/x86/include/asm/paravirt_types.h >>> b/arch/x86/include/asm/paravirt_types.h >>> index

Re: [PATCH v7 0/7] Add virtio-iommu driver

2019-05-27 Thread Michael S. Tsirkin
On Mon, May 27, 2019 at 11:26:04AM +0200, Joerg Roedel wrote: > On Sun, May 12, 2019 at 12:31:59PM -0400, Michael S. Tsirkin wrote: > > OK this has been in next for a while. > > > > Last time IOMMU maintainers objected. Are objections > > still in force? > > > > If not could we get acks please?

Re: [PATCH v2 3/8] s390/cio: add basic protected virtualization support

2019-05-27 Thread Michael Mueller
On 25.05.19 11:44, Sebastian Ott wrote: On Thu, 23 May 2019, Michael Mueller wrote: static struct ccw_device * io_subchannel_allocate_dev(struct subchannel *sch) { struct ccw_device *cdev; + struct gen_pool *dma_pool; cdev = kzalloc(sizeof(*cdev), GFP_KERNEL); -

Re: [PATCH v2 3/8] s390/cio: add basic protected virtualization support

2019-05-27 Thread Cornelia Huck
On Mon, 27 May 2019 14:30:14 +0200 Halil Pasic wrote: > On Mon, 27 May 2019 12:38:02 +0200 > Cornelia Huck wrote: > > > On Thu, 23 May 2019 18:22:04 +0200 > > Michael Mueller wrote: > > > > > From: Halil Pasic > > > > > > As virtio-ccw devices are channel devices, we need to use the dma

Re: [RFC PATCH 5/6] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-05-27 Thread Paolo Bonzini
On 27/05/19 14:32, Peter Zijlstra wrote: > On Mon, May 27, 2019 at 12:21:59PM +0200, Paolo Bonzini wrote: >> On 27/05/19 11:47, Peter Zijlstra wrote: > >>> --- a/arch/x86/kernel/kvm.c >>> +++ b/arch/x86/kernel/kvm.c >>> @@ -580,7 +580,7 @@ static void __init kvm_apf_trap_init(voi >>> >>>

Re: [RFC PATCH 5/6] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-05-27 Thread Peter Zijlstra
On Mon, May 27, 2019 at 12:21:59PM +0200, Paolo Bonzini wrote: > On 27/05/19 11:47, Peter Zijlstra wrote: > > --- a/arch/x86/kernel/kvm.c > > +++ b/arch/x86/kernel/kvm.c > > @@ -580,7 +580,7 @@ static void __init kvm_apf_trap_init(voi > > > > static DEFINE_PER_CPU(cpumask_var_t,

Re: [PATCH v2 3/8] s390/cio: add basic protected virtualization support

2019-05-27 Thread Halil Pasic
On Mon, 27 May 2019 12:38:02 +0200 Cornelia Huck wrote: > On Thu, 23 May 2019 18:22:04 +0200 > Michael Mueller wrote: > > > From: Halil Pasic > > > > As virtio-ccw devices are channel devices, we need to use the dma area > > for any communication with the hypervisor. > > > > It handles

Re: [PATCH v2 3/8] s390/cio: add basic protected virtualization support

2019-05-27 Thread Michael Mueller
On 27.05.19 12:38, Cornelia Huck wrote: On Thu, 23 May 2019 18:22:04 +0200 Michael Mueller wrote: From: Halil Pasic As virtio-ccw devices are channel devices, we need to use the dma area for any communication with the hypervisor. It handles neither QDIO in the common code, nor any

Re: [PATCH v2 6/8] virtio/s390: add indirection to indicators access

2019-05-27 Thread Cornelia Huck
On Mon, 27 May 2019 13:57:06 +0200 Halil Pasic wrote: > On Mon, 27 May 2019 13:00:28 +0200 > Cornelia Huck wrote: > > > On Thu, 23 May 2019 18:22:07 +0200 > > Michael Mueller wrote: > > > > > From: Halil Pasic > > > > > > This will come in handy soon when we pull out the indicators from

Re: [PATCH v2 2/8] s390/cio: introduce DMA pools to cio

2019-05-27 Thread Cornelia Huck
On Mon, 27 May 2019 13:47:55 +0200 Halil Pasic wrote: > On Mon, 27 May 2019 08:57:18 +0200 > Cornelia Huck wrote: > > > On Thu, 23 May 2019 18:22:03 +0200 > > Michael Mueller wrote: > > > > > From: Halil Pasic > > > > > > To support protected virtualization cio will need to make sure the

Re: [PATCH v2 5/8] virtio/s390: use cacheline aligned airq bit vectors

2019-05-27 Thread Halil Pasic
On Mon, 27 May 2019 12:55:31 +0200 Cornelia Huck wrote: > On Thu, 23 May 2019 18:22:06 +0200 > Michael Mueller wrote: > > > From: Halil Pasic > > > > The flag AIRQ_IV_CACHELINE was recently added to airq_iv_create(). Let > > us use it! We actually wanted the vector to span a cacheline all

Re: [PATCH v2 2/8] s390/cio: introduce DMA pools to cio

2019-05-27 Thread Michael Mueller
On 27.05.19 08:57, Cornelia Huck wrote: On Thu, 23 May 2019 18:22:03 +0200 Michael Mueller wrote: From: Halil Pasic To support protected virtualization cio will need to make sure the memory used for communication with the hypervisor is DMA memory. Let us introduce one global cio, and

Re: [PATCH v2 8/8] virtio/s390: make airq summary indicators DMA

2019-05-27 Thread Cornelia Huck
On Thu, 23 May 2019 18:22:09 +0200 Michael Mueller wrote: > From: Halil Pasic > > Hypervisor needs to interact with the summary indicators, so these > need to be DMA memory as well (at least for protected virtualization > guests). > > Signed-off-by: Halil Pasic > --- >

Re: [PATCH v2 6/8] virtio/s390: add indirection to indicators access

2019-05-27 Thread Halil Pasic
On Mon, 27 May 2019 13:00:28 +0200 Cornelia Huck wrote: > On Thu, 23 May 2019 18:22:07 +0200 > Michael Mueller wrote: > > > From: Halil Pasic > > > > This will come in handy soon when we pull out the indicators from > > virtio_ccw_device to a memory area that is shared with the hypervisor >

Re: [PATCH v2 7/8] virtio/s390: use DMA memory for ccw I/O and classic notifiers

2019-05-27 Thread Cornelia Huck
On Thu, 23 May 2019 18:22:08 +0200 Michael Mueller wrote: > From: Halil Pasic > > Before virtio-ccw could get away with not using DMA API for the pieces of > memory it does ccw I/O with. With protected virtualization this has to > change, since the hypervisor needs to read and sometimes also

Re: [PATCH v2 2/8] s390/cio: introduce DMA pools to cio

2019-05-27 Thread Halil Pasic
On Mon, 27 May 2019 08:57:18 +0200 Cornelia Huck wrote: > On Thu, 23 May 2019 18:22:03 +0200 > Michael Mueller wrote: > > > From: Halil Pasic > > > > To support protected virtualization cio will need to make sure the > > memory used for communication with the hypervisor is DMA memory. > > >

Re: [PATCH v2 2/8] s390/cio: introduce DMA pools to cio

2019-05-27 Thread Michael Mueller
On 25.05.19 11:22, Sebastian Ott wrote: On Thu, 23 May 2019, Michael Mueller wrote: +static void __init cio_dma_pool_init(void) +{ + /* No need to free up the resources: compiled in */ + cio_dma_pool = cio_gp_dma_create(cio_get_dma_css_dev(), 1); This can return NULL.

[PATCH] drm/virtio: add plane check

2019-05-27 Thread Gerd Hoffmann
Use drm_atomic_helper_check_plane_state() to sanity check the plane state. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_plane.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c

Re: [PATCH v2 6/8] virtio/s390: add indirection to indicators access

2019-05-27 Thread Cornelia Huck
On Thu, 23 May 2019 18:22:07 +0200 Michael Mueller wrote: > From: Halil Pasic > > This will come in handy soon when we pull out the indicators from > virtio_ccw_device to a memory area that is shared with the hypervisor > (in particular for protected virtualization guests). > > Signed-off-by:

Re: [PATCH v2 5/8] virtio/s390: use cacheline aligned airq bit vectors

2019-05-27 Thread Cornelia Huck
On Thu, 23 May 2019 18:22:06 +0200 Michael Mueller wrote: > From: Halil Pasic > > The flag AIRQ_IV_CACHELINE was recently added to airq_iv_create(). Let > us use it! We actually wanted the vector to span a cacheline all along. > > Signed-off-by: Halil Pasic > --- >

Re: [PATCH v2 4/8] s390/airq: use DMA memory for adapter interrupts

2019-05-27 Thread Cornelia Huck
On Thu, 23 May 2019 18:22:05 +0200 Michael Mueller wrote: > From: Halil Pasic > > Protected virtualization guests have to use shared pages for airq > notifier bit vectors, because hypervisor needs to write these bits. > > Let us make sure we allocate DMA memory for the notifier bit vectors by

Re: [PATCH v2 3/8] s390/cio: add basic protected virtualization support

2019-05-27 Thread Cornelia Huck
On Thu, 23 May 2019 18:22:04 +0200 Michael Mueller wrote: > From: Halil Pasic > > As virtio-ccw devices are channel devices, we need to use the dma area > for any communication with the hypervisor. > > It handles neither QDIO in the common code, nor any device type specific > stuff (like

Re: [RFC PATCH 5/6] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-05-27 Thread Paolo Bonzini
On 27/05/19 11:47, Peter Zijlstra wrote: > On Sat, May 25, 2019 at 10:54:50AM +0200, Juergen Gross wrote: >> On 25/05/2019 10:22, Nadav Amit wrote: > >>> diff --git a/arch/x86/include/asm/paravirt_types.h >>> b/arch/x86/include/asm/paravirt_types.h >>> index 946f8f1f1efc..3a156e63c57d 100644 >>>

Re: [RFC PATCH 5/6] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-05-27 Thread Peter Zijlstra
On Sat, May 25, 2019 at 10:54:50AM +0200, Juergen Gross wrote: > On 25/05/2019 10:22, Nadav Amit wrote: > > diff --git a/arch/x86/include/asm/paravirt_types.h > > b/arch/x86/include/asm/paravirt_types.h > > index 946f8f1f1efc..3a156e63c57d 100644 > > --- a/arch/x86/include/asm/paravirt_types.h >

Re: [PATCH v7 0/7] Add virtio-iommu driver

2019-05-27 Thread Joerg Roedel
On Sun, May 12, 2019 at 12:31:59PM -0400, Michael S. Tsirkin wrote: > OK this has been in next for a while. > > Last time IOMMU maintainers objected. Are objections > still in force? > > If not could we get acks please? No objections against the code, I only hesitated because the Spec was not

Re: [PATCH 10/10] docs: fix broken documentation links

2019-05-27 Thread Rafael J. Wysocki
On Mon, May 20, 2019 at 4:48 PM Mauro Carvalho Chehab wrote: > > Mostly due to x86 and acpi conversion, several documentation > links are still pointing to the old file. Fix them. > > Signed-off-by: Mauro Carvalho Chehab For the ACPI part: Acked-by: Rafael J. Wysocki

[PATCH 12/13] drm/virtio: drop DRM_AUTH usage from the driver

2019-05-27 Thread Emil Velikov
From: Emil Velikov The authentication can be circumvented, by design, by using the render node. >From the driver POV there is no distinction between primary and render nodes, thus we can drop the token. Cc: Gerd Hoffmann Cc: virtualization@lists.linux-foundation.org Cc: David Airlie Cc:

Re: [PATCH v2 2/8] s390/cio: introduce DMA pools to cio

2019-05-27 Thread Cornelia Huck
On Thu, 23 May 2019 18:22:03 +0200 Michael Mueller wrote: > From: Halil Pasic > > To support protected virtualization cio will need to make sure the > memory used for communication with the hypervisor is DMA memory. > > Let us introduce one global cio, and some tools for pools seated "one

Re: PROBLEM: VirtIO DRM driver crashes when setting specific 16.16 fixed-point property values

2019-05-27 Thread Gerd Hoffmann
On Fri, May 24, 2019 at 02:46:50PM -0400, Tyler Slabinski wrote: > VirtIO DRM driver crashes when setting specific 16.16 fixed-point > property values > > When running a virtual machine with a VirtIO GPU, it's possible to > crash the entire VM by setting the value of a 16.16 fixed-point >