Re: [PATCH V2 3/5] vDPA: introduce vDPA bus

2020-02-18 Thread Jason Wang
On 2020/2/18 下午9:56, Jason Gunthorpe wrote: On Mon, Feb 17, 2020 at 02:08:03PM +0800, Jason Wang wrote: I thought you were copied in the patch [1], maybe we can move vhost related discussion there to avoid confusion. [1] https://lwn.net/Articles/811210/ Wow, that is .. confusing. So this is

Re: [PATCH] x86/ioperm: add new paravirt function update_io_bitmap

2020-02-18 Thread Jürgen Groß
On 18.02.20 22:03, Thomas Gleixner wrote: Juergen Gross writes: Commit 111e7b15cf10f6 ("x86/ioperm: Extend IOPL config to control ioperm() as well") reworked the iopl syscall to use I/O bitmaps. Unfortunately this broke Xen PV domains using that syscall as there is currently no I/O bitmap supp

Re: [PATCH V2 3/5] vDPA: introduce vDPA bus

2020-02-18 Thread Tiwei Bie
On Tue, Feb 18, 2020 at 01:56:12PM +, Jason Gunthorpe wrote: > On Mon, Feb 17, 2020 at 02:08:03PM +0800, Jason Wang wrote: > > > I thought you were copied in the patch [1], maybe we can move vhost related > > discussion there to avoid confusion. > > > > [1] https://lwn.net/Articles/811210/ >

Re: [PATCH] vhost: introduce vDPA based backend

2020-02-18 Thread Tiwei Bie
On Tue, Feb 18, 2020 at 09:53:59AM -0400, Jason Gunthorpe wrote: > On Fri, Jan 31, 2020 at 11:36:51AM +0800, Tiwei Bie wrote: > > > +static int vhost_vdpa_alloc_minor(struct vhost_vdpa *v) > > +{ > > + return idr_alloc(&vhost_vdpa.idr, v, 0, MINORMASK + 1, > > +GFP_KERNEL); >

Re: [PATCH 1/2] virtio-blk: fix hw_queue stopped on arbitrary error

2020-02-18 Thread Ming Lei
On Tue, Feb 18, 2020 at 8:35 PM Halil Pasic wrote: > > On Tue, 18 Feb 2020 10:21:18 +0800 > Ming Lei wrote: > > > On Thu, Feb 13, 2020 at 8:38 PM Halil Pasic wrote: > > > > > > Since nobody else is going to restart our hw_queue for us, the > > > blk_mq_start_stopped_hw_queues() is in virtblk_don

Re: [PATCH] x86/ioperm: add new paravirt function update_io_bitmap

2020-02-18 Thread Thomas Gleixner
Juergen Gross writes: > Commit 111e7b15cf10f6 ("x86/ioperm: Extend IOPL config to control > ioperm() as well") reworked the iopl syscall to use I/O bitmaps. > > Unfortunately this broke Xen PV domains using that syscall as there > is currently no I/O bitmap support in PV domains. > > Add I/O bitma

[PATCH] x86/ioperm: add new paravirt function update_io_bitmap

2020-02-18 Thread Juergen Gross
Commit 111e7b15cf10f6 ("x86/ioperm: Extend IOPL config to control ioperm() as well") reworked the iopl syscall to use I/O bitmaps. Unfortunately this broke Xen PV domains using that syscall as there is currently no I/O bitmap support in PV domains. Add I/O bitmap support via a new paravirt functi

Re: [PATCH V2 3/5] vDPA: introduce vDPA bus

2020-02-18 Thread Jason Gunthorpe
On Mon, Feb 17, 2020 at 02:08:03PM +0800, Jason Wang wrote: > I thought you were copied in the patch [1], maybe we can move vhost related > discussion there to avoid confusion. > > [1] https://lwn.net/Articles/811210/ Wow, that is .. confusing. So this is supposed to duplicate the uAPI of vhost-

Re: [PATCH] vhost: introduce vDPA based backend

2020-02-18 Thread Jason Gunthorpe
On Fri, Jan 31, 2020 at 11:36:51AM +0800, Tiwei Bie wrote: > +static int vhost_vdpa_alloc_minor(struct vhost_vdpa *v) > +{ > + return idr_alloc(&vhost_vdpa.idr, v, 0, MINORMASK + 1, > + GFP_KERNEL); > +} Please don't use idr in new code, use xarray directly > +static int

Re: [PATCH 1/2] virtio-blk: fix hw_queue stopped on arbitrary error

2020-02-18 Thread Halil Pasic
On Tue, 18 Feb 2020 10:21:18 +0800 Ming Lei wrote: > On Thu, Feb 13, 2020 at 8:38 PM Halil Pasic wrote: > > > > Since nobody else is going to restart our hw_queue for us, the > > blk_mq_start_stopped_hw_queues() is in virtblk_done() is not sufficient > > necessarily sufficient to ensure that the

[PATCH v2 2/4] drm/ast: Use simple encoder

2020-02-18 Thread Thomas Zimmermann
The ast driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. v2: * rebase onto new simple-encoder interface Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 6 +- drivers/gpu/drm/ast/ast_mode.c | 25

[PATCH v2 4/4] drm/qxl: Use simple encoder

2020-02-18 Thread Thomas Zimmermann
The qxl driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. v2: * rebase onto new simple-encoder interface Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_display.c | 18 +++--- 1 file changed, 3 insertions(+),

[PATCH v2 1/4] drm/simple-kms: Add drm_simple_encoder_{init, create}()

2020-02-18 Thread Thomas Zimmermann
This patch makes the internal encoder implementation of the simple KMS helpers available to drivers. These simple-encoder helpers initialize an encoder with an empty implementation. This covers the requirements of most of the existing DRM drivers. A call to drm_simple_encoder_create() allocates an

[PATCH v2 3/4] drm/mgag200: Use simple encoder

2020-02-18 Thread Thomas Zimmermann
The mgag200 driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. v2: * rebase onto new simple-encoder interface Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 7 --- drivers/gpu/drm/mgag200/mgag200_mode.c

[PATCH v2 0/4] drm: Provide a simple encoder

2020-02-18 Thread Thomas Zimmermann
Many DRM drivers implement an encoder with an empty implementation. This patchset adds drm_simple_encoder_init() and drm_simple_encoder_create(), which can be used by drivers instead. Except for the destroy callback, the simple encoder's implementation is empty. The patchset also converts 4 encode