Re: [PATCH] vdpa: move to drivers/vdpa

2020-03-31 Thread Randy Dunlap
On 3/31/20 12:19 PM, Michael S. Tsirkin wrote: > We have both vhost and virtio drivers that depend on vdpa. > It's easier to locate it at a top level directory otherwise > we run into issues e.g. if vhost is built-in but virtio > is modular. Let's just move it up a level. > > Reported-by: Randy

Re: [PATCH v3 0/8] vhost: Reset batched descriptors on SET_VRING_BASE call

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 09:27:56PM +0200, Eugenio Pérez wrote: > Vhost did not reset properly the batched descriptors on SET_VRING_BASE > event. Because of that, is possible to return an invalid descriptor to > the guest. > > This series ammend this, resetting them every time backend changes,

Re: mmotm 2020-03-30-18-46 uploaded (VDPA + vhost)

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 11:42:47AM -0700, Randy Dunlap wrote: > On 3/31/20 11:37 AM, Michael S. Tsirkin wrote: > > On Tue, Mar 31, 2020 at 11:27:54AM -0700, Randy Dunlap wrote: > >> On 3/30/20 6:47 PM, a...@linux-foundation.org wrote: > >>> The mm-of-the-moment snapshot 2020-03-30-18-46 has been

[PATCH] vdpa: move to drivers/vdpa

2020-03-31 Thread Michael S. Tsirkin
We have both vhost and virtio drivers that depend on vdpa. It's easier to locate it at a top level directory otherwise we run into issues e.g. if vhost is built-in but virtio is modular. Let's just move it up a level. Reported-by: Randy Dunlap Signed-off-by: Michael S. Tsirkin --- Randy I'd

Re: mmotm 2020-03-30-18-46 uploaded (VDPA + vhost)

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 11:42:47AM -0700, Randy Dunlap wrote: > On 3/31/20 11:37 AM, Michael S. Tsirkin wrote: > > On Tue, Mar 31, 2020 at 11:27:54AM -0700, Randy Dunlap wrote: > >> On 3/30/20 6:47 PM, a...@linux-foundation.org wrote: > >>> The mm-of-the-moment snapshot 2020-03-30-18-46 has been

Re: mmotm 2020-03-30-18-46 uploaded (VDPA + vhost)

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 11:42:47AM -0700, Randy Dunlap wrote: > On 3/31/20 11:37 AM, Michael S. Tsirkin wrote: > > On Tue, Mar 31, 2020 at 11:27:54AM -0700, Randy Dunlap wrote: > >> On 3/30/20 6:47 PM, a...@linux-foundation.org wrote: > >>> The mm-of-the-moment snapshot 2020-03-30-18-46 has been

Re: mmotm 2020-03-30-18-46 uploaded (VDPA + vhost)

2020-03-31 Thread Randy Dunlap
On 3/31/20 11:37 AM, Michael S. Tsirkin wrote: > On Tue, Mar 31, 2020 at 11:27:54AM -0700, Randy Dunlap wrote: >> On 3/30/20 6:47 PM, a...@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2020-03-30-18-46 has been uploaded to >>> >>>http://www.ozlabs.org/~akpm/mmotm/ >>> >>>

Re: mmotm 2020-03-30-18-46 uploaded (VDPA + vhost)

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 11:27:54AM -0700, Randy Dunlap wrote: > On 3/30/20 6:47 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2020-03-30-18-46 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for

Re: [PATCH v2 1/8] vhost: Create accessors for virtqueues private_data

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 07:59:59PM +0200, Eugenio Pérez wrote: > Signed-off-by: Eugenio Pérez > --- > drivers/vhost/net.c | 28 +++- > drivers/vhost/vhost.h | 28 > drivers/vhost/vsock.c | 14 +++--- Seems to be missing scsi and

Re: [PATCH v2 1/8] vhost: Create accessors for virtqueues private_data

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 07:59:59PM +0200, Eugenio Pérez wrote: > Signed-off-by: Eugenio Pérez > --- > drivers/vhost/net.c | 28 +++- > drivers/vhost/vhost.h | 28 > drivers/vhost/vsock.c | 14 +++--- > 3 files changed, 50

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Nadav Amit via Virtualization
> On Mar 31, 2020, at 7:09 AM, David Hildenbrand wrote: > > On 31.03.20 16:07, Michael S. Tsirkin wrote: >> On Tue, Mar 31, 2020 at 04:03:18PM +0200, David Hildenbrand wrote: >>> On 31.03.20 15:37, Michael S. Tsirkin wrote: On Tue, Mar 31, 2020 at 03:32:05PM +0200, David Hildenbrand wrote:

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Nadav Amit via Virtualization
> On Mar 31, 2020, at 6:32 AM, David Hildenbrand wrote: > > On 31.03.20 15:24, Michael S. Tsirkin wrote: >> On Tue, Mar 31, 2020 at 12:35:24PM +0200, David Hildenbrand wrote: >>> On 26.03.20 10:49, Michael S. Tsirkin wrote: On Thu, Mar 26, 2020 at 08:54:04AM +0100, David Hildenbrand wrote:

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 04:34:48PM +0200, David Hildenbrand wrote: > On 31.03.20 16:29, David Hildenbrand wrote: > > On 31.03.20 16:18, Michael S. Tsirkin wrote: > >> On Tue, Mar 31, 2020 at 04:09:59PM +0200, David Hildenbrand wrote: > >> > >> ... > >> > >> So if we want to address

Re: [PATCH Resend] drm/qxl: Use correct notify port address when creating cursor ring

2020-03-31 Thread Gerd Hoffmann
On Tue, Mar 31, 2020 at 02:18:08PM +0800, Huacai Chen wrote: > The command ring and cursor ring use different notify port addresses > definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in > qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring > and cursor ring. This

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread David Hildenbrand
On 31.03.20 16:29, David Hildenbrand wrote: > On 31.03.20 16:18, Michael S. Tsirkin wrote: >> On Tue, Mar 31, 2020 at 04:09:59PM +0200, David Hildenbrand wrote: >> >> ... >> >> So if we want to address this, IMHO this calls for a new API. >> Along the lines of

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread David Hildenbrand
On 31.03.20 16:18, Michael S. Tsirkin wrote: > On Tue, Mar 31, 2020 at 04:09:59PM +0200, David Hildenbrand wrote: > > ... > > So if we want to address this, IMHO this calls for a new API. > Along the lines of > >struct page

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 04:09:59PM +0200, David Hildenbrand wrote: ... > >>> So if we want to address this, IMHO this calls for a new API. > >>> Along the lines of > >>> > >>>struct page *alloc_page_range(gfp_t gfp, unsigned int > >>> min_order, >

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread David Hildenbrand
On 31.03.20 16:07, Michael S. Tsirkin wrote: > On Tue, Mar 31, 2020 at 04:03:18PM +0200, David Hildenbrand wrote: >> On 31.03.20 15:37, Michael S. Tsirkin wrote: >>> On Tue, Mar 31, 2020 at 03:32:05PM +0200, David Hildenbrand wrote: On 31.03.20 15:24, Michael S. Tsirkin wrote: > On Tue,

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 04:03:18PM +0200, David Hildenbrand wrote: > On 31.03.20 15:37, Michael S. Tsirkin wrote: > > On Tue, Mar 31, 2020 at 03:32:05PM +0200, David Hildenbrand wrote: > >> On 31.03.20 15:24, Michael S. Tsirkin wrote: > >>> On Tue, Mar 31, 2020 at 12:35:24PM +0200, David

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread David Hildenbrand
On 31.03.20 15:37, Michael S. Tsirkin wrote: > On Tue, Mar 31, 2020 at 03:32:05PM +0200, David Hildenbrand wrote: >> On 31.03.20 15:24, Michael S. Tsirkin wrote: >>> On Tue, Mar 31, 2020 at 12:35:24PM +0200, David Hildenbrand wrote: On 26.03.20 10:49, Michael S. Tsirkin wrote: > On Thu,

Re: [PATCH] vhost: vdpa: remove unnecessary null check

2020-03-31 Thread Michael S. Tsirkin
On Mon, Mar 30, 2020 at 06:50:40PM -0500, Gustavo A. R. Silva wrote: > container_of is never null, so this null check is > unnecessary. > > Addresses-Coverity-ID: 1492006 ("Logically dead code") > Fixes: 20453a45fb06 ("vhost: introduce vDPA-based backend") > Signed-off-by: Gustavo A. R. Silva

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 03:32:05PM +0200, David Hildenbrand wrote: > On 31.03.20 15:24, Michael S. Tsirkin wrote: > > On Tue, Mar 31, 2020 at 12:35:24PM +0200, David Hildenbrand wrote: > >> On 26.03.20 10:49, Michael S. Tsirkin wrote: > >>> On Thu, Mar 26, 2020 at 08:54:04AM +0100, David

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread David Hildenbrand
On 31.03.20 15:24, Michael S. Tsirkin wrote: > On Tue, Mar 31, 2020 at 12:35:24PM +0200, David Hildenbrand wrote: >> On 26.03.20 10:49, Michael S. Tsirkin wrote: >>> On Thu, Mar 26, 2020 at 08:54:04AM +0100, David Hildenbrand wrote: > Am 26.03.2020 um 08:21 schrieb Michael S. Tsirkin

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 12:35:24PM +0200, David Hildenbrand wrote: > On 26.03.20 10:49, Michael S. Tsirkin wrote: > > On Thu, Mar 26, 2020 at 08:54:04AM +0100, David Hildenbrand wrote: > >> > >> > >>> Am 26.03.2020 um 08:21 schrieb Michael S. Tsirkin : > >>> > >>> On Thu, Mar 12, 2020 at

Re: [PATCH 11/70] x86/boot/compressed/64: Disable red-zone usage

2020-03-31 Thread Borislav Petkov
On Thu, Mar 19, 2020 at 10:13:08AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > The x86-64 ABI defines a red-zone on the stack: > > The 128-byte area beyond the location pointed to by %rsp is > considered to be reserved and shall not be modified by signal or > interrupt handlers.

Re: linux-next: Tree for Mar 30 (vhost)

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 10:27:48AM +0800, Jason Wang wrote: > > On 2020/3/31 上午1:22, Randy Dunlap wrote: > > On 3/30/20 2:43 AM, Stephen Rothwell wrote: > > > Hi all, > > > > > > The merge window has opened, so please do not add any material for the > > > next release into your linux-next

Re: linux-next: Tree for Mar 30 (vhost)

2020-03-31 Thread Michael S. Tsirkin
On Mon, Mar 30, 2020 at 10:22:22AM -0700, Randy Dunlap wrote: > On 3/30/20 2:43 AM, Stephen Rothwell wrote: > > Hi all, > > > > The merge window has opened, so please do not add any material for the > > next release into your linux-next included trees/branches until after > > the merge window

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread David Hildenbrand
On 26.03.20 10:49, Michael S. Tsirkin wrote: > On Thu, Mar 26, 2020 at 08:54:04AM +0100, David Hildenbrand wrote: >> >> >>> Am 26.03.2020 um 08:21 schrieb Michael S. Tsirkin : >>> >>> On Thu, Mar 12, 2020 at 09:51:25AM +0100, David Hildenbrand wrote: > On 12.03.20 09:47, Michael S. Tsirkin

Re: [PATCH 20/22] drm/vkms: Use simple encoder

2020-03-31 Thread Thomas Zimmermann
Hi Am 24.03.20 um 12:59 schrieb Rodrigo Siqueira: > Hi Thomas, > > First of all, thanks for your patch! > > I applied all your series, compiled it, and when I tried > `make INSTALL_MOD_PATH=/PATH/ modules_instal` I got the following > message: > > depmod: ERROR: Cycle detected: drm_kms_helper

Re: [PATCH -next] virtio: vdpa: remove unused variables 'ifcvf' and 'ifcvf_lm'

2020-03-31 Thread Jason Wang
On 2020/3/31 下午4:02, YueHaibing wrote: drivers/virtio/vdpa/ifcvf/ifcvf_main.c:34:24: warning: variable ‘ifcvf’ set but not used [-Wunused-but-set-variable] drivers/virtio/vdpa/ifcvf/ifcvf_base.c:304:31: warning: variable ‘ifcvf_lm’ set but not used [-Wunused-but-set-variable] Reported-by:

Re: [vhost:linux-next 8/13] include/linux/vringh.h:18:10: fatal error: linux/vhost_iotlb.h: No such file or directory

2020-03-31 Thread Jason Wang
On 2020/3/31 下午3:31, Xia, Hui wrote: -Original Message- From: Jason Wang Sent: 2020年3月30日 10:47 To: lkp Cc:kbuild-...@lists.01.org;k...@vger.kernel.org;virtualization@lists.linux- foundation.org;net...@vger.kernel.org; Michael S. Tsirkin Subject: Re: [vhost:linux-next 8/13]

[PATCH -next] virtio: vdpa: remove unused variables 'ifcvf' and 'ifcvf_lm'

2020-03-31 Thread YueHaibing
drivers/virtio/vdpa/ifcvf/ifcvf_main.c:34:24: warning: variable ‘ifcvf’ set but not used [-Wunused-but-set-variable] drivers/virtio/vdpa/ifcvf/ifcvf_base.c:304:31: warning: variable ‘ifcvf_lm’ set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot Signed-off-by: YueHaibing ---

[PATCH Resend] drm/qxl: Use correct notify port address when creating cursor ring

2020-03-31 Thread Huacai Chen
The command ring and cursor ring use different notify port addresses definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring and cursor ring. This doesn't cause any problems now, because QEMU's behaviors on

[PATCH v2 -next] vdpasim: Return status in vdpasim_get_status

2020-03-31 Thread YueHaibing
vdpasim->status should acquired under spin lock. Fixes: 870448c31775 ("vdpasim: vDPA device simulator") Signed-off-by: YueHaibing Acked-by: Jason Wang --- v2: Fix patch title typo --- drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git