Re: [PATCH] scsi: virtio_scsi: remove unnecessary condition check

2020-07-13 Thread Martin K. Petersen
On Thu, 9 Jul 2020 11:06:07 -0400, Xianting Tian wrote: > kmem_cache_destroy and mempool_destroy can correctly handle > null pointer parameter, so there is no need to check if the > parameter is null before calling kmem_cache_destroy and > mempool_destroy. Applied to 5.9/scsi-queue, thanks! [1/1

Re: [PATCH] virtio_balloon: clear modern features under legacy

2020-07-13 Thread Alexander Duyck
On Sun, Jul 12, 2020 at 8:10 AM Michael S. Tsirkin wrote: > > On Fri, Jul 10, 2020 at 09:13:41AM -0700, Alexander Duyck wrote: > > On Fri, Jul 10, 2020 at 4:31 AM Michael S. Tsirkin wrote: > > > > > > Page reporting features were never supported by legacy hypervisors. > > > Supporting them poses

Re: [PATCH v3 02/19] compiler.h: Split {READ, WRITE}_ONCE definitions out into rwonce.h

2020-07-13 Thread boqun . feng
On Fri, Jul 10, 2020 at 05:51:46PM +0100, Will Deacon wrote: > In preparation for allowing architectures to define their own > implementation of the READ_ONCE() macro, move the generic > {READ,WRITE}_ONCE() definitions out of the unwieldy 'linux/compiler.h' > file and into a new 'rwonce.h' header u

Re: [PATCH v2 12/24] scsi: virtio_scsi: Demote seemingly unintentional kerneldoc header

2020-07-13 Thread Lee Jones
On Mon, 13 Jul 2020, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2020 at 08:59:49AM +0100, Lee Jones wrote: > > This is the only use of kerneldoc in the sourcefile and no > > descriptions are provided. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/scsi/virtio_scsi.c:1

Re: [PATCH v3 07/19] vhost: Remove redundant use of read_barrier_depends() barrier

2020-07-13 Thread Michael S. Tsirkin
On Fri, Jul 10, 2020 at 05:51:51PM +0100, Will Deacon wrote: > Since commit 76ebbe78f739 ("locking/barriers: Add implicit > smp_read_barrier_depends() to READ_ONCE()"), there is no need to use > smp_read_barrier_depends() outside of the Alpha architecture code. > > Unfortunately, there is precisel

Re: [PATCH v2 12/24] scsi: virtio_scsi: Demote seemingly unintentional kerneldoc header

2020-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2020 at 08:59:49AM +0100, Lee Jones wrote: > This is the only use of kerneldoc in the sourcefile and no > descriptions are provided. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member > 'vscsi' not descr

Re: [PATCH] vsock/virtio: annotate 'the_virtio_vsock' RCU pointer

2020-07-13 Thread Michael S. Tsirkin
On Fri, Jul 10, 2020 at 02:12:43PM +0200, Stefano Garzarella wrote: > Commit 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free > on the_virtio_vsock") starts to use RCU to protect 'the_virtio_vsock' > pointer, but we forgot to annotate it. > > This patch adds the annotation to fix the f

Re: [PATCH 2/7] kvm/vfio: detect assigned device via irqbypass manager

2020-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2020 at 04:13:35PM +0800, Jason Wang wrote: > > On 2020/7/13 上午5:06, Michael S. Tsirkin wrote: > > On Sun, Jul 12, 2020 at 10:49:21PM +0800, Zhu Lingshan wrote: > > > We used to detect assigned device via VFIO manipulated device > > > conters. This is less flexible consider VFIO is

Re: [PATCH 00/18] Allow architectures to override __READ_ONCE()

2020-07-13 Thread Peter Zijlstra
On Fri, Jul 10, 2020 at 05:51:44PM +0100, Will Deacon wrote: > SeongJae Park (1): > Documentation/barriers/kokr: Remove references to > [smp_]read_barrier_depends() > > Will Deacon (18): > tools: bpf: Use local copy of headers including uapi/linux/filter.h > compiler.h: Split {READ,WRIT

Re: [PATCH] vhost/scsi: fix up req type endian-ness

2020-07-13 Thread Stefan Hajnoczi
On Fri, Jul 10, 2020 at 06:48:51AM -0400, Michael S. Tsirkin wrote: > vhost/scsi doesn't handle type conversion correctly > for request type when using virtio 1.0 and up for BE, > or cross-endian platforms. > > Fix it up using vhost_32_to_cpu. > > Cc: sta...@vger.kernel.org > Signed-off-by: Micha

Re: [PATCH] vsock/virtio: annotate 'the_virtio_vsock' RCU pointer

2020-07-13 Thread Stefan Hajnoczi
On Fri, Jul 10, 2020 at 02:12:43PM +0200, Stefano Garzarella wrote: > Commit 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free > on the_virtio_vsock") starts to use RCU to protect 'the_virtio_vsock' > pointer, but we forgot to annotate it. > > This patch adds the annotation to fix the f

Re: [PATCH 6/7] ifcvf: replace irq_request/free with helpers in vDPA core.

2020-07-13 Thread Jason Wang
On 2020/7/12 下午10:49, Zhu Lingshan wrote: This commit replaced irq_request/free() with helpers in vDPA core, so that it can request/free irq and setup irq offloading on order. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++- 1 file changed, 6 insertions(+),

Re: [PATCH 5/7] virtio_vdpa: init IRQ offloading function pointers to NULL.

2020-07-13 Thread Jason Wang
On 2020/7/12 下午10:49, Zhu Lingshan wrote: This commit initialize IRQ offloading function pointers in virtio_vdpa_driver to NULL. Becasue irq offloading only focus on VMs for vhost_vdpa. Signed-off-by: Zhu Lingshan --- drivers/virtio/virtio_vdpa.c | 2 ++ 1 file changed, 2 insertions(+) dif

Re: [PATCH 4/7] vDPA: implement IRQ offloading helpers in vDPA core

2020-07-13 Thread Jason Wang
On 2020/7/12 下午10:49, Zhu Lingshan wrote: This commit implements IRQ offloading helpers in vDPA core by introducing two couple of functions: vdpa_alloc_vq_irq() and vdpa_free_vq_irq(): request irq and free irq, will setup irq offloading if irq_bypass is enabled. vdpa_setup_irq() and vdpa_unset

Re: [PATCH 3/7] vhost_vdpa: implement IRQ offloading functions in vhost_vdpa

2020-07-13 Thread Jason Wang
On 2020/7/12 下午10:49, Zhu Lingshan wrote: This patch introduce a set of functions for setup/unsetup and update irq offloading respectively by register/unregister and re-register the irq_bypass_producer. Signed-off-by: Zhu Lingshan --- drivers/vhost/vdpa.c | 69 +++

Re: [PATCH 2/7] kvm/vfio: detect assigned device via irqbypass manager

2020-07-13 Thread Jason Wang
On 2020/7/13 上午5:06, Michael S. Tsirkin wrote: On Sun, Jul 12, 2020 at 10:49:21PM +0800, Zhu Lingshan wrote: We used to detect assigned device via VFIO manipulated device conters. This is less flexible consider VFIO is not the only interface for assigned device. vDPA devices has dedicated backe

Re: [RFC]: mm,power: introduce MADV_WIPEONSUSPEND

2020-07-13 Thread Michal Hocko
On Sun 12-07-20 09:22:28, Pavel Machek wrote: > On Tue 2020-07-07 12:00:41, Colm MacCarthaigh wrote: > > > > > > On 7 Jul 2020, at 9:37, Pavel Machek wrote: > > > Please go through the thread and try to understand it. > > > > > > You'd need syscalls per get_randomness(), not per migration. > >

[PATCH v2 12/24] scsi: virtio_scsi: Demote seemingly unintentional kerneldoc header

2020-07-13 Thread Lee Jones
This is the only use of kerneldoc in the sourcefile and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member 'vscsi' not described in 'virtscsi_complete_cmd' drivers/scsi/virtio_scsi.c:109: warning:

Re: [PATCH 2/7] kvm/vfio: detect assigned device via irqbypass manager

2020-07-13 Thread Jason Wang
On 2020/7/12 下午11:29, Alex Williamson wrote: On Sun, 12 Jul 2020 22:49:21 +0800 Zhu Lingshan wrote: We used to detect assigned device via VFIO manipulated device conters. This is less flexible consider VFIO is not the only interface for assigned device. vDPA devices has dedicated backed hardw

[vhost:config-endian 38/39] drivers/platform/mellanox/mlxbf-tmfifo.c:1241:22: error: expected ')' before ';' token

2020-07-13 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git config-endian head: df43c8f58f42ec36e91740f91ea7360f63213004 commit: e1e22056bc3641f340ed27012cfd1b8b05f83a0a [38/39] fixup! virtio_net: correct tags for config space fields config: arm64-allyesconfig (attached as .config) co