Re: [PATCH] vdpa/mlx5: Fix error return in map_direct_mr()

2020-10-26 Thread Jason Wang
On 2020/10/26 下午3:06, Jing Xiangfeng wrote: Fix to return the variable "err" from the error handling case instead of "ret". Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code") Signed-off-by: Jing Xiangfeng --- drivers/vdpa/mlx5/core/mr.c | 5 ++--- 1 file changed, 2 inser

[PATCH mlx5-next 08/11] RDMA/mlx5: Convert mlx5_ib to use auxiliary bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky The conversion to auxiliary bus solves long standing issue with existing mlx5_ib<->mlx5_core coupling. It required to have both modules in initramfs if one of them needed for the boot. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/ib_rep.c | 77

[PATCH mlx5-next 05/11] net/mlx5: Register mlx5 devices to auxiliary virtual bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Create auxiliary devices under new virtual bus. This will replace the custom-made mlx5 ->add()/->remove() interfaces and next patches will fill the missing callback and remove the old interface logic. The attachment of auxiliary drivers to the devices is possible in 1-to-1

[PATCH mlx5-next 03/11] net/mlx5_core: Clean driver version and name

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Remove exposed driver version as it was done in other drivers, so module version will work correctly by displaying the kernel version for which it is compiled. And move mlx5_core module name to general include, so auxiliary drivers will be able to use it as a basis for a na

[PATCH mlx5-next 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Change module registration logic to use auxiliary bus instead of custom made mlx5 register interface. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 28 ++- drivers/vdpa/mlx5/Makefile| 2 +- drivers/vdpa/mlx5/ne

[PATCH mlx5-next 01/11] net/mlx5: Don't skip vport check

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Users of mlx5_eswitch_get_vport() are required to check return value prior to passing mlx5_vport further. Fix all the places to do not skip that check. Fixes: c7eddc6092b4 ("net/mlx5: E-switch, Move devlink eswitch ports closer to eswitch") Fixes: 5d9986a3947a ("net/mlx5:

[PATCH mlx5-next 10/11] net/mlx5: Simplify eswitch mode check

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Provide mlx5_core device instead of "priv" pointer while checking eswith mode. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/counters.c | 7 --- drivers/infiniband/hw/mlx5/ib_rep.c | 5 - drivers/infiniband/hw/mlx5/ib_rep.

[PATCH mlx5-next 00/11] Convert mlx5 to use auxiliary bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This patch set converts mlx5 driver to use auxiliary bus [1]. In this series, we are connecting three subsystems (VDPA, netdev and RDMA) through mlx5_core PCI driver. That driver is responsible to create proper devices based on supported firmware. First four patches a

[PATCH mlx5-next 11/11] RDMA/mlx5: Remove IB representors dead code

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Delete dead code. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/ib_rep.c | 31 +-- drivers/infiniband/hw/mlx5/ib_rep.h | 31 --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 4 +-- 3 files changed, 9

[PATCH mlx5-next 07/11] net/mlx5e: Connect ethernet part to auxiliary bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Reuse auxiliary bus to perform device management of the ethernet part of the mlx5 driver. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 74 ++ .../net/ethernet/mellanox/mlx5/core/en_main.c | 133 -- .../net/eth

[PATCH mlx5-next 09/11] net/mlx5: Delete custom device management logic

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky After conversion to use auxiliary bus, all custom device management is not needed anymore, delete it. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 299 +- drivers/net/ethernet/mellanox/mlx5/core/lag.c | 18 -- .../net

[PATCH mlx5-next 04/11] vdpa/mlx5: Make hardware definitions visible to all mlx5 devices

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Move mlx5_vdpa IFC header file to the general include folder, so mlx5_core will be able to reuse it to check if VDPA is supported prior to creating an auxiliary device. As part of this move, update the header file name to mlx5 general naming scheme. Reviewed-by: Parav Pand

[PATCH mlx5-next 02/11] net/mlx5: Properly convey driver version to firmware

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky mlx5 firmware expects driver version in specific format X.X.X, so make it always correct and based on real kernel version aligned with the driver. Fixes: 012e50e109fd ("net/mlx5: Set driver version into firmware") Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/me

Re: [PATCH 5/5] drm/: Constify struct drm_driver

2020-10-26 Thread Daniel Vetter
On Mon, Oct 26, 2020 at 9:43 AM Thomas Zimmermann wrote: > > Hi > > Am 23.10.20 um 14:28 schrieb Daniel Vetter: > > Only the following drivers aren't converted: > > - amdgpu, because of the driver_feature mangling due to virt support > > - nouveau, because DRIVER_ATOMIC uapi is still not the defau

Re: [PATCH 5/5] drm/: Constify struct drm_driver

2020-10-26 Thread Thomas Zimmermann
Hi Am 23.10.20 um 14:28 schrieb Daniel Vetter: > Only the following drivers aren't converted: > - amdgpu, because of the driver_feature mangling due to virt support > - nouveau, because DRIVER_ATOMIC uapi is still not the default on the > platforms where it's supported (i.e. again driver_feature

Re: [PATCH v5 10/10] drm/fb_helper: Support framebuffers in I/O memory

2020-10-26 Thread Thomas Zimmermann
Hi Am 24.10.20 um 22:38 schrieb Sam Ravnborg: > Hi Thomas. > > On Tue, Oct 20, 2020 at 02:20:46PM +0200, Thomas Zimmermann wrote: >> At least sparc64 requires I/O-specific access to framebuffers. This >> patch updates the fbdev console accordingly. >> >> For drivers with direct access to the fram