Re: [PATCH mlx5-next v1 04/11] vdpa/mlx5: Make hardware definitions visible to all mlx5 devices

2020-11-05 Thread Leon Romanovsky
On Thu, Nov 05, 2020 at 04:36:57PM -0400, Jason Gunthorpe wrote: > On Thu, Nov 05, 2020 at 12:31:52PM -0800, Saeed Mahameed wrote: > > On Sun, 2020-11-01 at 22:15 +0200, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Move mlx5_vdpa IFC header file to the general include folder, so

Re: [PATCH mlx5-next v1 05/11] net/mlx5: Register mlx5 devices to auxiliary virtual bus

2020-11-05 Thread Leon Romanovsky
On Thu, Nov 05, 2020 at 05:09:48PM -0400, Jason Gunthorpe wrote: > On Thu, Nov 05, 2020 at 12:59:20PM -0800, Saeed Mahameed wrote: > > > 2. you can always load a driver without its underlying device existed. > > for example, you can load a pci device driver/module and it will load > > and wait for

Re: [PATCH v7 01/72] KVM: SVM: nested: Don't allocate VMCB structures on stack

2020-11-05 Thread Borislav Petkov
On Thu, Nov 05, 2020 at 06:31:53PM -0600, Michael Roth wrote: > I can confirm that patch fixes the issue. It is indeed a 5.9.1 tree, but > looks like the SEV-ES patches didn't go in until v5.10-rc1 Yes, they went into 5.10-rc1 during the merge window. > (this tree had a backport of them), so stab

[PATCH v3] vhost-vdpa: fix page pinning leakage in error path (rework)

2020-11-05 Thread Si-Wei Liu
Pinned pages are not properly accounted particularly when mapping error occurs on IOTLB update. Clean up dangling pinned pages for the error path. The memory usage for bookkeeping pinned pages is reverted to what it was before: only one single free page is needed. This helps reduce the host memory

Re: [PATCH v2] vhost-vdpa: fix page pinning leakage in error path (rework)

2020-11-05 Thread si-wei liu
On 11/4/2020 7:26 PM, Jason Wang wrote: On 2020/11/5 上午7:33, Si-Wei Liu wrote: Pinned pages are not properly accounted particularly when mapping error occurs on IOTLB update. Clean up dangling pinned pages for the error path. The memory usage for bookkeeping pinned pages is reverted to what i

Re: [PATCH 2/2] vhost-vdpa: fix page pinning leakage in error path (rework)

2020-11-05 Thread si-wei liu
On 11/4/2020 7:12 PM, Jason Wang wrote: On 2020/11/5 上午7:40, si-wei liu wrote: On 11/3/2020 6:42 PM, Jason Wang wrote: On 2020/10/30 下午3:45, Si-Wei Liu wrote: Pinned pages are not properly accounted particularly when mapping error occurs on IOTLB update. Clean up dangling pinned pages for

Re: [PATCH v2 02/17] x86/hyperv: detect if Linux is the root partition

2020-11-05 Thread kernel test robot
Hi Wei, I love your patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on asm-generic/master iommu/next tip/timers/core pci/next linus/master v5.10-rc2 next-20201105] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v2 07/17] x86/hyperv: extract partition ID from Microsoft Hypervisor if necessary

2020-11-05 Thread kernel test robot
Hi Wei, I love your patch! Perhaps something to improve: [auto build test WARNING on tip/x86/core] [also build test WARNING on asm-generic/master iommu/next tip/timers/core pci/next linus/master v5.10-rc2 next-20201105] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH v2 07/17] x86/hyperv: extract partition ID from Microsoft Hypervisor if necessary

2020-11-05 Thread kernel test robot
Hi Wei, I love your patch! Perhaps something to improve: [auto build test WARNING on tip/x86/core] [also build test WARNING on asm-generic/master iommu/next tip/timers/core pci/next linus/master v5.10-rc2 next-20201105] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH v2 02/17] x86/hyperv: detect if Linux is the root partition

2020-11-05 Thread kernel test robot
Hi Wei, I love your patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on asm-generic/master iommu/next tip/timers/core pci/next linus/master v5.10-rc2 next-20201105] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH mlx5-next v1 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus

2020-11-05 Thread gregkh
On Thu, Nov 05, 2020 at 12:47:38PM -0400, Jason Gunthorpe wrote: > On Thu, Nov 05, 2020 at 08:33:02AM +0100, gregkh wrote: > > > Were there any additional changes you wanted to see happen? I'll go > > > give the final set another once over, but David has been diligently > > > fixing up all the decl

Re: [PATCH mlx5-next v1 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus

2020-11-05 Thread Jason Gunthorpe
On Thu, Nov 05, 2020 at 08:33:02AM +0100, gregkh wrote: > > Were there any additional changes you wanted to see happen? I'll go > > give the final set another once over, but David has been diligently > > fixing up all the declared major issues so I expect to find at most > > minor incremental fixup

Re: [PATCH v7 01/72] KVM: SVM: nested: Don't allocate VMCB structures on stack

2020-11-05 Thread Borislav Petkov
On Thu, Nov 05, 2020 at 10:24:37AM -0600, Michael Roth wrote: > > out_set_gif: > > svm_set_gif(svm, !!(kvm_state->flags & KVM_STATE_NESTED_GIF_SET)); > > - return 0; > > + > > + ret = 0; > > +out_free: > > + kfree(save); > > + kfree(ctl); > > This change seems to t

Re: [PATCH v5 09/10] dma-buf-map: Add memcpy and pointer-increment interfaces

2020-11-05 Thread Daniel Vetter
On Thu, Nov 05, 2020 at 11:37:08AM +0100, Thomas Zimmermann wrote: > Hi > > Am 05.11.20 um 11:07 schrieb Linus Walleij: > > Overall I like this, just an inline question: > > > > On Tue, Oct 20, 2020 at 2:20 PM Thomas Zimmermann > > wrote: > > > >> To do framebuffer updates, one needs memcpy fr

Re: [PATCH] drm/virtio: use kvmalloc for large allocations

2020-11-05 Thread Gerd Hoffmann
On Thu, Nov 05, 2020 at 04:00:54PM +0900, Sergey Senozhatsky wrote: > Hi, > > On (20/11/05 07:52), Gerd Hoffmann wrote: > > > - *ents = kmalloc_array(*nents, sizeof(struct virtio_gpu_mem_entry), > > > - GFP_KERNEL); > > > + *ents = kvmalloc_array(*nents, > > > +

Re: [PATCH 0/8] slab: provide and use krealloc_array()

2020-11-05 Thread Linus Walleij
On Tue, Oct 27, 2020 at 1:17 PM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Andy brought to my attention the fact that users allocating an array of > equally sized elements should check if the size multiplication doesn't > overflow. This is why we have helpers like kmalloc_array()

Re: [PATCH v5 09/10] dma-buf-map: Add memcpy and pointer-increment interfaces

2020-11-05 Thread Thomas Zimmermann
Hi Am 05.11.20 um 11:07 schrieb Linus Walleij: > Overall I like this, just an inline question: > > On Tue, Oct 20, 2020 at 2:20 PM Thomas Zimmermann wrote: > >> To do framebuffer updates, one needs memcpy from system memory and a >> pointer-increment function. Add both interfaces with documenta

Re: [PATCH v5 09/10] dma-buf-map: Add memcpy and pointer-increment interfaces

2020-11-05 Thread Linus Walleij
Overall I like this, just an inline question: On Tue, Oct 20, 2020 at 2:20 PM Thomas Zimmermann wrote: > To do framebuffer updates, one needs memcpy from system memory and a > pointer-increment function. Add both interfaces with documentation. (...) > +/** > + * dma_buf_map_memcpy_to - Memcpy i