RE: [PATCH linux-next 1/9] vdpa_sim: Consider read only supported features instead of current

2021-02-25 Thread Parav Pandit
Hi Michael, Jason, > From: Michael S. Tsirkin > Sent: Wednesday, February 24, 2021 12:40 PM > > On Wed, Feb 24, 2021 at 08:18:36AM +0200, Parav Pandit wrote: > > To honor VIRTIO_F_VERSION_1 feature bit, during endianness detection, > > consider the read only supported features bit instead of cur

Re: [PATCH v4] i2c: virtio: add a virtio i2c frontend driver

2021-02-25 Thread Jie Deng
On 2021/2/26 12:21, Viresh Kumar wrote: On 26-02-21, 10:46, Jie Deng wrote: This v4 was the old version before the specification was acked by the virtio tc. Following is the latest specification. https://raw.githubusercontent.com/oasis-tcs/virtio-spec/master/virtio-i2c.tex I will send the v

RE: [PATCH linux-next 2/9] vdpa: Introduce query of device config layout

2021-02-25 Thread Parav Pandit
> From: Jason Wang > Sent: Wednesday, February 24, 2021 2:18 PM > > On 2021/2/24 2:18 下午, Parav Pandit wrote: > > + > > + if (nla_put_u16(msg, VDPA_ATTR_DEV_NET_CFG_MAX_VQP, > > + config->max_virtqueue_pairs)) > > + return -EMSGSIZE; > > > We probably need to che

RE: [PATCH linux-next 4/9] vdpa_sim_net: Enable user to set mac address and mtu

2021-02-25 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 24, 2021 12:27 PM > > On Wed, Feb 24, 2021 at 08:18:39AM +0200, Parav Pandit wrote: > > Enable user to set the mac address and mtu so that each vdpa device > > can have its own user specified mac address and mtu. > > This is done by implem

Re: [PATCH v4] i2c: virtio: add a virtio i2c frontend driver

2021-02-25 Thread Jie Deng
On 2021/2/25 15:21, Viresh Kumar wrote: On 12-10-20, 09:55, Jie Deng wrote: Add an I2C bus driver for virtio para-virtualization. The controller can be emulated by the backend driver in any device model software by following the virtio protocol. This driver communicates with the backend driv

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-25 Thread Si-Wei Liu
Hi Michael, Are you okay to live without this ioctl for now? I think QEMU is the one that needs to be fixed and will have to be made legacy guest aware. I think the kernel can just honor the feature negotiation result done by QEMU and do as what's told to.Will you agree? If it's fine, I wo

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-25 Thread Si-Wei Liu
Hi Michael, Are you okay to live without this ioctl for now? I think QEMU is the one that needs to be fixed and will have to be made legacy guest aware. I think the kernel can just honor the feature negotiation result done by QEMU and do as what's told to.Will you agree? If it's fine, I woul

Re: [PATCH v5 6/9] ALSA: virtio: PCM substream operators

2021-02-25 Thread Anton Yakovlev
On 25.02.2021 21:30, Takashi Iwai wrote:> On Thu, 25 Feb 2021 20:02:50 +0100, Michael S. Tsirkin wrote: On Thu, Feb 25, 2021 at 01:51:16PM +0100, Takashi Iwai wrote: On Thu, 25 Feb 2021 13:14:37 +0100, Anton Yakovlev wrote: [snip] Takashi given I was in my tree for a while and I planned

Re: [GIT PULL] virtio: features, fixes

2021-02-25 Thread pr-tracker-bot
The pull request you sent on Thu, 25 Feb 2021 14:33:33 -0500: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ffc1759676bed0bff046427dd7d00cb68660190d Thank you! -- Deet-doot-dot, I am a b

[GIT PULL] virtio: features, fixes

2021-02-25 Thread Michael S. Tsirkin
There are a couple new drivers and support for the new management interface for mlx under review now. I figured I'll send them separately if review is done in time, lots of people are waiting for the vdpa tool patches to I want to make sure they make this release. The following changes since commi

Re: [PATCH v5 6/9] ALSA: virtio: PCM substream operators

2021-02-25 Thread Michael S. Tsirkin
On Thu, Feb 25, 2021 at 01:51:16PM +0100, Takashi Iwai wrote: > On Thu, 25 Feb 2021 13:14:37 +0100, > Anton Yakovlev wrote: > > > > On 25.02.2021 11:55, Takashi Iwai wrote: > > > On Mon, 22 Feb 2021 16:34:41 +0100, > > > Anton Yakovlev wrote: > > >> +static int virtsnd_pcm_open(struct snd_pcm_subs

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-25 Thread Michael S. Tsirkin
On Thu, Feb 25, 2021 at 12:36:07PM +0800, Jason Wang wrote: > > On 2021/2/24 7:12 下午, Cornelia Huck wrote: > > On Wed, 24 Feb 2021 17:29:07 +0800 > > Jason Wang wrote: > > > > > On 2021/2/23 6:58 下午, Cornelia Huck wrote: > > > > On Tue, 23 Feb 2021 18:31:07 +0800 > > > > Jason Wang wrote: > > >

Re: [PATCH v2 net-next] virtio-net: support XDP_TX when not more queues

2021-02-25 Thread Jesper Dangaard Brouer
On Thu, 25 Feb 2021 16:22:29 +0800 Xuan Zhuo wrote: > The number of queues implemented by many virtio backends is limited, > especially some machines have a large number of CPUs. In this case, it > is often impossible to allocate a separate queue for XDP_TX. > > This patch allows XDP_TX to run b

Re: [RFC PATCH v5 02/19] af_vsock: separate wait data loop

2021-02-25 Thread Jorgen Hansen
> On 18 Feb 2021, at 06:36, Arseny Krasnov wrote: > > This moves wait loop for data to dedicated function, because later > it will be used by SEQPACKET data receive loop. > > Signed-off-by: Arseny Krasnov > --- > net/vmw_vsock/af_vsock.c | 155 +-- > 1 file

Re: [RFC PATCH v5 04/19] af_vsock: implement SEQPACKET receive loop

2021-02-25 Thread Jorgen Hansen
On 18 Feb 2021, at 06:37, Arseny Krasnov wrote: > > This adds receive loop for SEQPACKET. It looks like receive loop for > STREAM, but there is a little bit difference: > 1) It doesn't call notify callbacks. > 2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because > there is n

[bug report] vdpa: set the virtqueue num during register

2021-02-25 Thread Dan Carpenter
Hello Jason Wang, The patch ddd50f4495d3: "vdpa: set the virtqueue num during register" from Feb 23, 2021, leads to the following static checker warning: drivers/vdpa/ifcvf/ifcvf_main.c:433 ifcvf_probe() warn: risky error pointer math: '__vdpa_alloc_device(dev, &ifc_vdpa_ops, 259

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-25 Thread Cornelia Huck
On Thu, 25 Feb 2021 12:36:07 +0800 Jason Wang wrote: > On 2021/2/24 7:12 下午, Cornelia Huck wrote: > > On Wed, 24 Feb 2021 17:29:07 +0800 > > Jason Wang wrote: > > > >> On 2021/2/23 6:58 下午, Cornelia Huck wrote: > >>> On Tue, 23 Feb 2021 18:31:07 +0800 > >>> Jason Wang wrote: > The pro

Re: [PATCH v5 6/9] ALSA: virtio: PCM substream operators

2021-02-25 Thread Anton Yakovlev
On 25.02.2021 11:55, Takashi Iwai wrote: On Mon, 22 Feb 2021 16:34:41 +0100, Anton Yakovlev wrote: +static int virtsnd_pcm_open(struct snd_pcm_substream *substream) +{ + struct virtio_pcm *vpcm = snd_pcm_substream_chip(substream); + struct virtio_pcm_substream *vss = NULL; + + if (vp

Re: [PATCH 4/7] x86/boot/compressed/64: Add 32-bit boot #VC handler

2021-02-25 Thread Borislav Petkov
On Wed, Feb 10, 2021 at 11:21:32AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Add a #VC exception handler which is used when the kernel still executes > in protected mode. This boot-path already uses CPUID, which will cause #VC > exceptions in an SEV-ES guest. > > Signed-off-by: Joerg R

Re: [PATCH v5 2/9] ALSA: virtio: add virtio sound driver

2021-02-25 Thread Anton Yakovlev
On 25.02.2021 11:38, Takashi Iwai wrote: On Mon, 22 Feb 2021 16:34:37 +0100, Anton Yakovlev wrote: +static int virtsnd_find_vqs(struct virtio_snd *snd) +{ + struct virtio_device *vdev = snd->vdev; + vq_callback_t *callbacks[VIRTIO_SND_VQ_MAX] = { + [VIRTIO_SND_VQ_EVENT] = vir