Re: [External] Re: [RFC PATCH] virtio-vsock: add description for datagram type

2021-03-26 Thread Jiang Wang .
Hi Michael and Stefan, I thought about this and discussed it with my colleague Cong Wang. One idea is to make current asynchronous send_pkt flow to be synchronous, then if the virtqueue is full, the function can return ENOMEM all the way back to the caller and the caller can check the return

Re: [PATCH] virtio-balloon: move release_pages_balloon() outside of mutex_unlock(>balloon_lock)

2021-03-26 Thread David Hildenbrand
On 26.03.21 10:53, Liu Xiang wrote: Since pages have been deflated to a local list, there is no race between fill and leak. Signed-off-by: Liu Xiang --- drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c

Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-26 Thread Jason Wang
在 2021/3/26 下午2:56, Yongji Xie 写道: On Fri, Mar 26, 2021 at 2:16 PM Jason Wang wrote: 在 2021/3/26 下午1:14, Yongji Xie 写道: + } + map->bounce_page = page; + + /* paired with vduse_domain_map_page() */ + smp_mb(); So this is suspicious. It's better to explain like, we need make

Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-26 Thread Jason Wang
在 2021/3/26 下午1:14, Yongji Xie 写道: + } + map->bounce_page = page; + + /* paired with vduse_domain_map_page() */ + smp_mb(); So this is suspicious. It's better to explain like, we need make sure A must be done after B. OK. I see. It's used to protect this pattern: