Re: [PATCH v2 4/6] virtio: Initialize authorized attribute for confidential guest

2021-10-01 Thread Dan Williams
On Fri, Oct 1, 2021 at 12:02 PM Alan Stern wrote: > > On Fri, Oct 01, 2021 at 11:09:52AM -0700, Dan Williams wrote: > > On Fri, Oct 1, 2021 at 9:47 AM Alan Stern wrote: > > > > > > On Fri, Oct 01, 2021 at 09:13:54AM -0700, Dan Williams wrote: > > > > Bear with me, and perhaps it's a lack of

Re: [PATCH v2 4/6] virtio: Initialize authorized attribute for confidential guest

2021-10-01 Thread Alan Stern
On Fri, Oct 01, 2021 at 11:09:52AM -0700, Dan Williams wrote: > On Fri, Oct 1, 2021 at 9:47 AM Alan Stern wrote: > > > > On Fri, Oct 01, 2021 at 09:13:54AM -0700, Dan Williams wrote: > > > Bear with me, and perhaps it's a lack of imagination on my part, but I > > > don't see how to get to a

Re: [PATCH v2 4/6] virtio: Initialize authorized attribute for confidential guest

2021-10-01 Thread Dan Williams
On Fri, Oct 1, 2021 at 9:47 AM Alan Stern wrote: > > On Fri, Oct 01, 2021 at 09:13:54AM -0700, Dan Williams wrote: > > Bear with me, and perhaps it's a lack of imagination on my part, but I > > don't see how to get to a globally generic "authorized" sysfs ABI > > given that USB and Thunderbolt

Re: [PATCH v2 4/6] virtio: Initialize authorized attribute for confidential guest

2021-10-01 Thread Alan Stern
On Fri, Oct 01, 2021 at 09:13:54AM -0700, Dan Williams wrote: > Bear with me, and perhaps it's a lack of imagination on my part, but I > don't see how to get to a globally generic "authorized" sysfs ABI > given that USB and Thunderbolt want to do bus specific actions on > authorization toggle

Re: [PATCH v2 4/6] virtio: Initialize authorized attribute for confidential guest

2021-10-01 Thread Dan Williams
On Fri, Oct 1, 2021 at 12:03 AM Greg Kroah-Hartman wrote: > > On Thu, Sep 30, 2021 at 12:04:05PM -0700, Kuppuswamy, Sathyanarayanan wrote: > > > > > > On 9/30/21 8:23 AM, Greg Kroah-Hartman wrote: > > > On Thu, Sep 30, 2021 at 08:18:18AM -0700, Kuppuswamy, Sathyanarayanan > > > wrote: > > > > >

Re: [PATCH v2 2/6] driver core: Add common support to skip probe for un-authorized devices

2021-10-01 Thread Andi Kleen
Forget about trust for the moment. Let's say the goal is to prevent the kernel from creating any bindings other that those in some small "allowed" set. To fully specify one of the allowed bindings, you would have to provide both a device ID and a driver name. But in practice this isn't

Re: [PATCH v2 2/6] driver core: Add common support to skip probe for un-authorized devices

2021-10-01 Thread Alan Stern
On Fri, Oct 01, 2021 at 08:29:36AM +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 30, 2021 at 12:15:16PM -0700, Andi Kleen wrote: > > > > On 9/30/2021 10:23 AM, Greg Kroah-Hartman wrote: > > > On Thu, Sep 30, 2021 at 10:17:09AM -0700, Andi Kleen wrote: > > > > The legacy drivers could be fixed,

Re: [PATCH v2 4/6] virtio: Initialize authorized attribute for confidential guest

2021-10-01 Thread Andi Kleen
On 10/1/2021 12:03 AM, Greg Kroah-Hartman wrote: On Thu, Sep 30, 2021 at 12:04:05PM -0700, Kuppuswamy, Sathyanarayanan wrote: On 9/30/21 8:23 AM, Greg Kroah-Hartman wrote: On Thu, Sep 30, 2021 at 08:18:18AM -0700, Kuppuswamy, Sathyanarayanan wrote: On 9/30/21 6:36 AM, Dan Williams wrote:

Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-01 Thread Cornelia Huck
On Fri, Oct 01 2021, Halil Pasic wrote: > On Thu, 30 Sep 2021 13:31:04 +0200 > Cornelia Huck wrote: > >> On Thu, Sep 30 2021, Halil Pasic wrote: >> >> > On Thu, 30 Sep 2021 11:28:23 +0200 >> > Cornelia Huck wrote: >> > >> >> On Thu, Sep 30 2021, Halil Pasic wrote: >> >> > @@ -249,6

Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-01 Thread Christian Borntraeger
Am 30.09.21 um 03:20 schrieb Halil Pasic: This patch fixes a regression introduced by commit 82e89ea077b9 ("virtio-blk: Add validation for block size in config space") and enables similar checks in verify() on big endian platforms. The problem with checking multi-byte config fields in the

Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-01 Thread Halil Pasic
On Thu, 30 Sep 2021 13:31:04 +0200 Cornelia Huck wrote: > On Thu, Sep 30 2021, Halil Pasic wrote: > > > On Thu, 30 Sep 2021 11:28:23 +0200 > > Cornelia Huck wrote: > > > >> On Thu, Sep 30 2021, Halil Pasic wrote: > >> > >> > This patch fixes a regression introduced by commit

Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-01 Thread Halil Pasic
On Thu, 30 Sep 2021 07:12:21 -0400 "Michael S. Tsirkin" wrote: > On Thu, Sep 30, 2021 at 03:20:49AM +0200, Halil Pasic wrote: > > This patch fixes a regression introduced by commit 82e89ea077b9 > > ("virtio-blk: Add validation for block size in config space") and > > enables similar checks in

Re: [PATCH v2 4/6] virtio: Initialize authorized attribute for confidential guest

2021-10-01 Thread Greg Kroah-Hartman
On Thu, Sep 30, 2021 at 12:04:05PM -0700, Kuppuswamy, Sathyanarayanan wrote: > > > On 9/30/21 8:23 AM, Greg Kroah-Hartman wrote: > > On Thu, Sep 30, 2021 at 08:18:18AM -0700, Kuppuswamy, Sathyanarayanan wrote: > > > > > > > > > On 9/30/21 6:36 AM, Dan Williams wrote: > > > > > And in

Re: [PATCH v2 2/6] driver core: Add common support to skip probe for un-authorized devices

2021-10-01 Thread Greg Kroah-Hartman
On Thu, Sep 30, 2021 at 12:15:16PM -0700, Andi Kleen wrote: > > On 9/30/2021 10:23 AM, Greg Kroah-Hartman wrote: > > On Thu, Sep 30, 2021 at 10:17:09AM -0700, Andi Kleen wrote: > > > The legacy drivers could be fixed, but nobody really wants to touch them > > > anymore and they're impossible to