在 2022/4/6 下午8:04, Michael S. Tsirkin 写道:
On Wed, Apr 06, 2022 at 04:35:38PM +0800, Jason Wang wrote:
This is a rework on the previous IRQ hardening that is done for
virtio-pci where several drawbacks were found and were reverted:
1) try to use IRQF_NO_AUTOEN which is not friendly to affinity
在 2022/4/6 下午11:31, Michael S. Tsirkin 写道:
On Wed, Apr 06, 2022 at 03:04:32PM +0200, Cornelia Huck wrote:
On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote:
On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote:
This patch implements PCI version of synchronize_vqs().
Cc: Thomas Gleixner
在 2022/4/6 下午7:59, Michael S. Tsirkin 写道:
On Wed, Apr 06, 2022 at 04:35:36PM +0800, Jason Wang wrote:
This patch introduce
introduces
a new
new
virtio config ops to vring
callbacks. Transport specific method is required to call
synchornize_irq() on the IRQs. For the transport that doesn't
在 2022/4/6 下午7:44, Michael S. Tsirkin 写道:
patch had wrong mime type. I managed to extra it but pls fix.
From: Stefano Garzarella
It will allows us
will allow us
to do extension on virtio_device_ready() without
duplicating codes.
code
Cc: Thomas Gleixner
Cc: Peter Zijlstra
Cc: "Paul
在 2022/4/6 下午7:36, Michael S. Tsirkin 写道:
On Wed, Apr 06, 2022 at 04:35:33PM +0800, Jason Wang wrote:
Hi All:
This is a rework on the IRQ hardening for virtio which is done
previously by the following commits are reverted:
9e35276a5344 ("virtio_pci: harden MSI-X interrupts")
080cd7c3ac87 ("vi
Christoph,
> Secure erase is a very different operation from discard in that it is
> a data integrity operation vs hint. Fully split the limits and helper
> infrastructure to make the separation more clear.
Great!
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engi
Christoph,
> Add a helper to query the number of sectors support per each discard
> bio based on the block device and use this helper to stop various
> places from poking into the request_queue to see if discard is
> supported and if so how much. This mirrors what is done e.g. for
> write zeroe
Christoph,
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
Very happy to finally see this flag removed!
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Abstract away implementation details from file systems by providing a
> block_device based helper to retreive the discard granularity.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Virtualizati
Christoph,
> Move all the logic to limit the discard bio size into a common helper
> so that it is better documented.
Looks OK.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Virtualization mailing list
Vir
Christoph,
> No need to inline these fairly larger helpers. Also fix the return
> value to be unsigned, just like the field in struct queue_limits.
I believe the original reason for the signed int here was to be able to
express -1 for sysfs. I am not sure why I didn't just use the misaligned
f
Christoph,
> Use the bdev based alignment helper instead of open coding it.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.
Christoph,
> Just use bdev_alignment_offset in disk_discard_alignment_show instead.
> That helpers is the same except for an always false branch that
> doesn't matter in this slow path.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
__
Christoph,
> No need to inline these fairly larger helpers.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.
Christoph,
> This does the same as the open coded variant except for an extra
> branch, and allows to remove queue_alignment_offset entirely.
Also fine.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Virtua
Christoph,
> Replace the open coded offset calculation with the proper helper.
> This is an ABI change in that the -1 for a misaligned partition is
> properly propagated, which can be considered a bug fix and maches what
> is done on the whole device.
Looks good.
Reviewed-by: Martin K. Peterse
Christoph,
> Add a helper to check the nonrot flag based on the block_device
> instead of having to poke into the block layer internal request_queue.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Virtualiza
Christoph,
> Use the proper bdev_discard_alignment helper that accounts for partition
> offsets.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Virtualization mailing list
Virtualization@lists.linux-foundati
Christoph,
> Add a helper to check the stable writes flag based on the block_device
> instead of having to poke into the block layer internal request_queue.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Vir
Christoph,
> Add a helper to check the FUA flag based on the block_device instead
> of having to poke into the block layer internal request_queue.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Virtualizatio
Christoph,
> Add a helper to check the write cache flag based on the block_device
> instead of having to poke into the block layer internal request_queue.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Virtu
Christoph,
> Add a helper to check the max supported sectors for zone append based
> on the block_device instead of having to poke into the block layer
> internal request_queue.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
__
Christoph,
> The target code is a consumer of the block layer and should generally
> work on struct block_device.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Virtualization mailing list
Virtualization@lis
Christoph,
> For block devices the target code implements UNMAP as calls to
> blkdev_issue_discard, which does not guarantee zeroing just because
> Write Zeroes is supported.
>
> Note that this does not affect the file backed path which uses
> fallocate to punch holes.
Reviewed-by: Martin K. Pe
Christoph,
> For block devices the target code implements UNMAP as calls to
> blkdev_issue_discard, which does not guarantee zeroing just because
> Write Zeroes is supported.
>
> Note that this does not affect the file backed path which uses
> fallocate to punch holes.
>
> Fixes: 2237498f0b5c ("
From: Zhu Lingshan
[ Upstream commit cce0ab2b2a39072d81f98017f7b076f3410ef740 ]
When irq number is negative(e.g., -EINVAL), the virtqueue
may be disabled or the virtqueues are sharing a device irq.
In such case, we should not setup irq offloading for a virtqueue.
Signed-off-by: Zhu Lingshan
Li
From: "Michael S. Tsirkin"
[ Upstream commit f03560a57c1f60db6ac23ffd9714e1c69e2f95c7 ]
When using pthreads, one has to compile and link with -lpthread,
otherwise e.g. glibc is not guaranteed to be reentrant.
This replaces -lpthread.
Reported-by: Matthew Wilcox
Signed-off-by: Michael S. Tsirk
From: Zhu Lingshan
[ Upstream commit cce0ab2b2a39072d81f98017f7b076f3410ef740 ]
When irq number is negative(e.g., -EINVAL), the virtqueue
may be disabled or the virtqueues are sharing a device irq.
In such case, we should not setup irq offloading for a virtqueue.
Signed-off-by: Zhu Lingshan
Li
From: "Michael S. Tsirkin"
[ Upstream commit f03560a57c1f60db6ac23ffd9714e1c69e2f95c7 ]
When using pthreads, one has to compile and link with -lpthread,
otherwise e.g. glibc is not guaranteed to be reentrant.
This replaces -lpthread.
Reported-by: Matthew Wilcox
Signed-off-by: Michael S. Tsirk
From: "Michael S. Tsirkin"
[ Upstream commit f03560a57c1f60db6ac23ffd9714e1c69e2f95c7 ]
When using pthreads, one has to compile and link with -lpthread,
otherwise e.g. glibc is not guaranteed to be reentrant.
This replaces -lpthread.
Reported-by: Matthew Wilcox
Signed-off-by: Michael S. Tsirk
From: Zhu Lingshan
[ Upstream commit cce0ab2b2a39072d81f98017f7b076f3410ef740 ]
When irq number is negative(e.g., -EINVAL), the virtqueue
may be disabled or the virtqueues are sharing a device irq.
In such case, we should not setup irq offloading for a virtqueue.
Signed-off-by: Zhu Lingshan
Li
From: Zhu Lingshan
[ Upstream commit cce0ab2b2a39072d81f98017f7b076f3410ef740 ]
When irq number is negative(e.g., -EINVAL), the virtqueue
may be disabled or the virtqueues are sharing a device irq.
In such case, we should not setup irq offloading for a virtqueue.
Signed-off-by: Zhu Lingshan
Li
From: "Michael S. Tsirkin"
[ Upstream commit f03560a57c1f60db6ac23ffd9714e1c69e2f95c7 ]
When using pthreads, one has to compile and link with -lpthread,
otherwise e.g. glibc is not guaranteed to be reentrant.
This replaces -lpthread.
Reported-by: Matthew Wilcox
Signed-off-by: Michael S. Tsirk
On Wed, Apr 06, 2022 at 01:06:23PM -0300, Jason Gunthorpe wrote:
> On Wed, Apr 06, 2022 at 05:50:56PM +0200, Christoph Hellwig wrote:
> > On Wed, Apr 06, 2022 at 12:18:23PM -0300, Jason Gunthorpe wrote:
> > > > Oh, I didn't know about device_get_dma_attr()..
> >
> > Which is completely broken for
On Wed, Apr 06, 2022 at 12:18:23PM -0300, Jason Gunthorpe wrote:
> > Oh, I didn't know about device_get_dma_attr()..
Which is completely broken for any non-OF, non-ACPI plaform.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
ht
On 2022-04-06 15:14, Jason Gunthorpe wrote:
On Wed, Apr 06, 2022 at 03:51:50PM +0200, Christoph Hellwig wrote:
On Wed, Apr 06, 2022 at 09:07:30AM -0300, Jason Gunthorpe wrote:
Didn't see it
I'll move dev_is_dma_coherent to device.h along with
device_iommu_mapped() and others then
No. It it
On Wed, Apr 06, 2022 at 11:14:46AM -0300, Jason Gunthorpe wrote:
> Really? It is the only condition that dma_info_to_prot() tests to
> decide of IOMMU_CACHE is used or not, so you are saying that there is
> a condition where a device can be attached to an iommu_domain and
> dev_is_dma_coherent() re
On Wed, Apr 06, 2022 at 03:04:32PM +0200, Cornelia Huck wrote:
> On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote:
>
> > On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote:
> >> This patch implements PCI version of synchronize_vqs().
> >>
> >> Cc: Thomas Gleixner
> >> Cc: Peter Zijlstra
On 2022-04-05 17:16, Jason Gunthorpe wrote:
vdpa and usnic are trying to test if IOMMU_CACHE is supported. The correct
way to do this is via dev_is_dma_coherent()
Not necessarily...
Disregarding the complete disaster of PCIe No Snoop on Arm-Based
systems, there's the more interesting effectiv
On Wed, Apr 06, 2022 at 09:07:30AM -0300, Jason Gunthorpe wrote:
> Didn't see it
>
> I'll move dev_is_dma_coherent to device.h along with
> device_iommu_mapped() and others then
No. It it is internal for a reason. It also doesn't actually work
outside of the dma core. E.g. for non-swiotlb ARM
On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote:
> On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote:
>> This patch implements PCI version of synchronize_vqs().
>>
>> Cc: Thomas Gleixner
>> Cc: Peter Zijlstra
>> Cc: "Paul E. McKenney"
>> Cc: Marc Zyngier
>> Signed-off-by: Jason Wang
On Wed, Apr 06, 2022 at 04:35:38PM +0800, Jason Wang wrote:
> This is a rework on the previous IRQ hardening that is done for
> virtio-pci where several drawbacks were found and were reverted:
>
> 1) try to use IRQF_NO_AUTOEN which is not friendly to affinity managed IRQ
>that is used by some
On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote:
> This patch implements PCI version of synchronize_vqs().
>
> Cc: Thomas Gleixner
> Cc: Peter Zijlstra
> Cc: "Paul E. McKenney"
> Cc: Marc Zyngier
> Signed-off-by: Jason Wang
Please add implementations at least for ccw and mmio.
>
On Wed, Apr 06, 2022 at 04:35:36PM +0800, Jason Wang wrote:
> This patch introduce
introduces
> a new
new
> virtio config ops to vring
> callbacks. Transport specific method is required to call
> synchornize_irq() on the IRQs. For the transport that doesn't provide
> synchronize_vqs(), use sync
On Wed, Apr 06, 2022 at 04:35:35PM +0800, Jason Wang wrote:
> This allows us to do common extension without duplicating codes.
codes -> code
> Cc: Thomas Gleixner
> Cc: Peter Zijlstra
> Cc: "Paul E. McKenney"
> Cc: Marc Zyngier
> Signed-off-by: Jason Wang
> ---
> drivers/virtio/virtio.c | 4
patch had wrong mime type. I managed to extra it but pls fix.
>
>
> From: Stefano Garzarella
>
> It will allows us
will allow us
> to do extension on virtio_device_ready() without
> duplicating codes.
code
>
> Cc: Thomas Gleixner
> Cc: Peter Zijlstra
> Cc: "Paul E. McKenney"
> Cc: Marc
On Wed, Apr 06, 2022 at 04:35:33PM +0800, Jason Wang wrote:
> Hi All:
>
> This is a rework on the IRQ hardening for virtio which is done
> previously by the following commits are reverted:
>
> 9e35276a5344 ("virtio_pci: harden MSI-X interrupts")
> 080cd7c3ac87 ("virtio-pci: harden INTX interrupts
This is a rework on the previous IRQ hardening that is done for
virtio-pci where several drawbacks were found and were reverted:
1) try to use IRQF_NO_AUTOEN which is not friendly to affinity managed IRQ
that is used by some device such as virtio-blk
2) done only for PCI transport
In this patc
This patch implements PCI version of synchronize_vqs().
Cc: Thomas Gleixner
Cc: Peter Zijlstra
Cc: "Paul E. McKenney"
Cc: Marc Zyngier
Signed-off-by: Jason Wang
---
drivers/virtio/virtio_pci_common.c | 14 ++
drivers/virtio/virtio_pci_common.h | 2 ++
drivers/virtio/virtio_pci_l
This patch introduce a new virtio config ops to vring
callbacks. Transport specific method is required to call
synchornize_irq() on the IRQs. For the transport that doesn't provide
synchronize_vqs(), use synchornize_rcu() as a fallback.
Cc: Thomas Gleixner
Cc: Peter Zijlstra
Cc: "Paul E. McKenne
This allows us to do common extension without duplicating codes.
Cc: Thomas Gleixner
Cc: Peter Zijlstra
Cc: "Paul E. McKenney"
Cc: Marc Zyngier
Signed-off-by: Jason Wang
---
drivers/virtio/virtio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/virtio.
From: Stefano Garzarella
It will allows us to do extension on virtio_device_ready() without
duplicating codes.
Cc: Thomas Gleixner
Cc: Peter Zijlstra
Cc: "Paul E. McKenney"
Cc: Marc Zyngier
Signed-off-by: Stefano Garzarella
Signed-off-by: Jason Wang
---
drivers/virtio/virtio.c | 5 +++--
Hi All:
This is a rework on the IRQ hardening for virtio which is done
previously by the following commits are reverted:
9e35276a5344 ("virtio_pci: harden MSI-X interrupts")
080cd7c3ac87 ("virtio-pci: harden INTX interrupts")
The reason is that it depends on the IRQF_NO_AUTOEN which may conflict
在 2022/4/6 上午10:35, Jason Wang 写道:
在 2022/4/4 下午7:24, Michael S. Tsirkin 写道:
On Mon, Apr 04, 2022 at 11:07:36AM +, Eli Cohen wrote:
From: Michael S. Tsirkin
Sent: Monday, April 4, 2022 1:35 PM
To: Jason Wang
Cc: Eli Cohen ; hdan...@sina.com;
virtualization@lists.linux-foundation.org;
On Tue, Apr 05, 2022 at 10:33:42AM +0200, Cornelia Huck wrote:
> On Tue, Apr 05 2022, "Michael S. Tsirkin" wrote:
>
> > On Mon, Apr 04, 2022 at 05:39:24PM +0200, Cornelia Huck wrote:
> >> On Mon, Mar 07 2022, "Michael S. Tsirkin" wrote:
> >>
> >> > On Mon, Mar 07, 2022 at 10:42:30AM +0800, zhen
Hi Christoph,
On Wed, Apr 06, 2022 at 06:05:04AM +, Christoph Hellwig wrote:
> From: Christoph Hellwig
> Subject: [PATCH 15/27] block: use bdev_alignment_offset in
> part_alignment_offset_show
>
> Replace the open coded offset calculation with the proper helper.
> This is an ABI change in t
> From: Jason Gunthorpe
> Sent: Wednesday, April 6, 2022 12:16 AM
>
> This new mechanism will replace using IOMMU_CAP_CACHE_COHERENCY
> and
> IOMMU_CACHE to control the no-snoop blocking behavior of the IOMMU.
>
> Currently only Intel and AMD IOMMUs are known to support this
> feature. They both
> From: Jason Gunthorpe
> Sent: Wednesday, April 6, 2022 3:29 AM
>
> On Tue, Apr 05, 2022 at 01:10:44PM -0600, Alex Williamson wrote:
> > On Tue, 5 Apr 2022 13:16:01 -0300
> > Jason Gunthorpe wrote:
> >
> > > dev_is_dma_coherent() is the control to determine if IOMMU_CACHE can
> be
> > > suppor
58 matches
Mail list logo
