RE: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group

2022-09-08 Thread Tian, Kevin
> From: Nicolin Chen > Sent: Friday, September 9, 2022 11:17 AM > > On Thu, Sep 08, 2022 at 01:14:42PM -0300, Jason Gunthorpe wrote: > > > > I am wondering if this can be solved by better defining what the return > > > codes mean and adjust the call-back functions to match the definition. > > >

Re: [PATCH v3 1/6] udp: allow header check for dodgy GSO_UDP_L4 packets.

2022-09-08 Thread Andrew Melnichenko
Hi all, On Thu, Sep 8, 2022 at 3:40 AM David Ahern wrote: > > On 9/7/22 6:50 AM, Andrew Melnychenko wrote: > > diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c > > index 6d1a4bec2614..8e002419b4d5 100644 > > --- a/net/ipv4/udp_offload.c > > +++ b/net/ipv4/udp_offload.c > > @@ -387,7

Re: [PATCH v3 0/6] TUN/VirtioNet USO features support.

2022-09-08 Thread Andrew Melnichenko
Hi all, On Thu, Sep 8, 2022 at 3:44 AM David Ahern wrote: > > On 9/7/22 6:50 AM, Andrew Melnychenko wrote: > > Added new offloads for TUN devices TUN_F_USO4 and TUN_F_USO6. > > Technically they enable NETIF_F_GSO_UDP_L4 > > (and only if USO4 & USO6 are set simultaneously). > > It allows the

Re: [PATCH] virtio_bt: Fix alignment in configuration struct

2022-09-08 Thread Michael S. Tsirkin
On Tue, Aug 30, 2022 at 09:45:02AM -0400, Michael S. Tsirkin wrote: > On Thu, Aug 11, 2022 at 10:02:31AM -0700, Luiz Augusto von Dentz wrote: > > Hi Michael, > > > > On Thu, Aug 11, 2022 at 1:00 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Aug 08, 2022 at 08:16:11AM -0400, Michael S. Tsirkin

Call to discuss vsock netdev/sk_buff [was Re: [PATCH 0/6] virtio/vsock: introduce dgrams, sk_buff, and qdisc]

2022-09-08 Thread Stefano Garzarella
On Thu, Aug 18, 2022 at 02:39:32PM +, Bobby Eshleman wrote: On Tue, Sep 06, 2022 at 09:26:33AM -0400, Stefan Hajnoczi wrote: Hi Bobby, If you are attending Linux Foundation conferences in Dublin, Ireland next week (Linux Plumbers Conference, Open Source Summit Europe, KVM Forum,

Re: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group

2022-09-08 Thread Joerg Roedel
On Wed, Sep 07, 2022 at 02:10:33PM -0300, Jason Gunthorpe wrote: > Sure, rust has all sorts of nice things. But the kernel doesn't follow > rust idioms, and I don't think this is a great place to start > experimenting with them. It is actually a great place to start experimenting. The IOMMU

Re: [PATCH v1] drm/ttm: Refcount allocated tail pages

2022-09-08 Thread Rob Clark
On Tue, Sep 6, 2022 at 1:01 PM Daniel Vetter wrote: > > On Mon, Aug 15, 2022 at 12:05:19PM +0200, Christian König wrote: > > Am 15.08.22 um 11:54 schrieb Dmitry Osipenko: > > > Higher order pages allocated using alloc_pages() aren't refcounted and > > > they > > > need to be refcounted,

Re: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group

2022-09-08 Thread Robin Murphy
On 2022-09-08 01:43, Jason Gunthorpe wrote: On Wed, Sep 07, 2022 at 08:41:13PM +0100, Robin Murphy wrote: FWIW, we're now very close to being able to validate dev->iommu against where the domain came from in core code, and so short-circuit ->attach_dev entirely if they don't match. I don't

RE: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group

2022-09-08 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Thursday, September 8, 2022 5:31 PM > > This mixture of error codes is the basic reason why a new code was > > used, because none of the existing codes are used with any > > consistency. > > btw I saw the policy for -EBUSY is also not consistent in this series. > >

RE: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group

2022-09-08 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, September 8, 2022 8:43 AM > > On Wed, Sep 07, 2022 at 08:41:13PM +0100, Robin Murphy wrote: > > > Again, not what I was suggesting. In fact the nature of > iommu_attach_group() > > already rules out bogus devices getting this far, so all a driver

Re: [PATCH 0/6] virtio/vsock: introduce dgrams, sk_buff, and qdisc

2022-09-08 Thread Stefano Garzarella
On Thu, Aug 18, 2022 at 02:39:32PM +, Bobby Eshleman wrote: On Tue, Sep 06, 2022 at 09:26:33AM -0400, Stefan Hajnoczi wrote: Hi Bobby, If you are attending Linux Foundation conferences in Dublin, Ireland next week (Linux Plumbers Conference, Open Source Summit Europe, KVM Forum,