Re: [PATCH v2] virtio_blk: add SECURE ERASE command support

2022-09-20 Thread Alvaro Karsz
> Okay, I have replied in the max_secure_erase_seg sub-thread. I think > probing the device should fail if the value is 0. There are no existing > non-compliant devices that we need to be compatible with - let's > encourage device implementors to report usable max_secure_erase_seg > values. Ok, I

Re: [PATCH 1/4] vDPA: allow userspace to query features of a vDPA device

2022-09-20 Thread Jason Wang
On Tue, Sep 20, 2022 at 5:58 PM Zhu, Lingshan wrote: > > > > On 9/20/2022 10:02 AM, Jason Wang wrote: > > On Fri, Sep 9, 2022 at 5:05 PM Zhu Lingshan wrote: > >> This commit adds a new vDPA netlink attribution > >> VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES. Userspace can query > >> features of vDPA d

Re: [PATCH 2/4] vDPA: only report driver features if FEATURES_OK is set

2022-09-20 Thread Jason Wang
On Tue, Sep 20, 2022 at 1:46 PM Zhu, Lingshan wrote: > > > > On 9/20/2022 10:16 AM, Jason Wang wrote: > > On Fri, Sep 9, 2022 at 5:05 PM Zhu Lingshan wrote: > >> vdpa_dev_net_config_fill() should only report driver features > >> to userspace after features negotiation is done. > >> > >> Signed-of

RE: [PATCH 0/3] vdpa: device feature provisioning

2022-09-20 Thread Parav Pandit via Virtualization
Hi Jason, > From: Jason Wang > Sent: Thursday, September 15, 2022 4:51 AM > To: m...@redhat.com; jasow...@redhat.com > Cc: Eli Cohen ; si-wei@oracle.com; Parav Pandit > ; wuzongy...@linux.alibaba.com; > virtualization@lists.linux-foundation.org; linux-ker...@vger.kernel.org; > epere...@redhat

Re: [PATCH v2] virtio_blk: add SECURE ERASE command support

2022-09-20 Thread Stefan Hajnoczi
On Mon, Sep 19, 2022 at 09:09:05PM +0300, Alvaro Karsz wrote: > Thanks for the reply. > > > This can be simplified with min_not_zero(). > > Ok, I will do it in the next version. > > > It's worth including a comment here that the discard and secure erase > > limits are combined because the Linux

Re: [PATCH v2] virtio_blk: add SECURE ERASE command support

2022-09-20 Thread Stefan Hajnoczi
On Sun, Sep 18, 2022 at 07:07:34PM +0300, Alvaro Karsz wrote: > > sounds good. Add a code comment? > > I will. > > > yes but I now see two places that seem to include this logic. > > > Yes, this is because the same logic is applied on 2 different pairs. > > * secure_erase_sector_alignment and

Re: [PATCH v2 00/44] cpuidle,rcu: Clean up the mess

2022-09-20 Thread Peter Zijlstra
Because Nadav asked about tracing/kprobing idle, I had another go around and noticed not all functions calling ct_cpuidle_enter are __cpuidle. Basically all cpuidle_driver::enter functions should be __cpuidle; i'll do that audit shortly. For now this is ct_cpuidle_enter / CPU_IDLE_ENTER users.

Re: [PATCH RFC 0/8] Introduce provisioning primitives for thinly provisioned storage

2022-09-20 Thread Christoph Hellwig
On Tue, Sep 20, 2022 at 08:17:10PM +1000, Daniil Lunev wrote: > to WRITE ZERO command in NVMe, but to WRITE UNAVAILABLE in There is no such thing as WRITE UNAVAILABLE in NVMe. > NVME 2.0 spec, and to UNMAP ANCHORED in SCSI spec. The SCSI anchored LBA state is quite complicated, and in addition t

Re: [PATCH v2 08/44] cpuidle,imx6: Push RCU-idle into driver

2022-09-20 Thread Peter Zijlstra
On Mon, Sep 19, 2022 at 04:21:23PM +0200, Frederic Weisbecker wrote: > On Mon, Sep 19, 2022 at 11:59:47AM +0200, Peter Zijlstra wrote: > > Doing RCU-idle outside the driver, only to then temporarily enable it > > again, at least twice, before going idle is daft. > > Hmm, what ends up calling RCU_I

Re: [PATCH v2 03/44] cpuidle/poll: Ensure IRQ state is invariant

2022-09-20 Thread Peter Zijlstra
On Mon, Sep 19, 2022 at 03:19:27PM +0200, Frederic Weisbecker wrote: > On Mon, Sep 19, 2022 at 11:59:42AM +0200, Peter Zijlstra wrote: > > cpuidle_state::enter() methods should be IRQ invariant > > Got a bit confused with the invariant thing since the first chunck I > see in this patch is a conver

Re: [PATCH 0/3] MAINTAINERS: Update entries for some VMware drivers

2022-09-20 Thread Stefano Garzarella
On Mon, Sep 19, 2022 at 10:41:47AM -0700, Jakub Kicinski wrote: On Tue, 6 Sep 2022 10:27:19 -0700 vd...@vmware.com wrote: From: Vishnu Dasa This series updates a few existing maintainer entries for VMware supported drivers and adds a new entry for vsock vmci transport driver. Just to be sur

Re: [PATCH RFC 4/8] fs: Introduce FALLOC_FL_PROVISION

2022-09-20 Thread Christoph Hellwig
On Thu, Sep 15, 2022 at 09:48:22AM -0700, Sarthak Kukreti wrote: > From: Sarthak Kukreti > > FALLOC_FL_PROVISION is a new fallocate() allocation mode that > sends a hint to (supported) thinly provisioned block devices to > allocate space for the given range of sectors via REQ_OP_PROVISION. So, h

Re: [PATCH RFC 0/8] Introduce provisioning primitives for thinly provisioned storage

2022-09-20 Thread Christoph Hellwig
On Fri, Sep 16, 2022 at 11:48:34AM -0700, Sarthak Kukreti wrote: > Yes. On ChromiumOS, we regularly deal with storage devices that don't > support WRITE_ZEROES or that need to have it disabled, via a quirk, > due to a bug in the vendor's implementation. So bloody punich the vendors for it. Unlike