Re: [PATCH v1] virtio_blk: should not use IRQD_AFFINITY_MANAGED in init_rq

2022-09-27 Thread Ming Lei
On Sat, Sep 24, 2022 at 11:48:54AM +0800, Angus Chen wrote: > The background is that we use dpu in cloud computing,the arch is x86,80 > cores.We will have a lots of virtio devices,like 512 or more. > When we probe about 200 virtio_blk devices,it will fail and > the stack is print as follows: > > [

Re: [PATCH v2] virtio_pci: avoid to request intx irq if pin is zero

2022-09-27 Thread Michael S. Tsirkin
Thanks! More minor issues to address On Wed, Sep 28, 2022 at 01:35:22PM +0800, Angus Chen wrote: > The background is that we use dpu in cloud computing,the arch is x86,80 > cores.We will have a lots of virtio devices,like 512 or more. > When we probe about 200 virtio_blk devices,it will fail and >

Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

2022-09-27 Thread Christian Borntraeger
Am 27.09.22 um 07:35 schrieb Christian Borntraeger: Am 26.09.22 um 20:22 schrieb Peter Zijlstra: On Mon, Sep 26, 2022 at 08:06:46PM +0200, Peter Zijlstra wrote: Let me go git-grep some to see if there's more similar fail. I've ended up with the below... Tested-by: Christian Borntraege

Re: [PATCH] virtio_ring: remove unnecessary to_vvq() call

2022-09-27 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 02:26:16AM +, Bo Liu (刘波)-浪潮信息 wrote: > >On Mon, Sep 26, 2022 at 05:11:30AM -0400, Bo Liu wrote: > >> It passes '_vq' to vring_free(), which still calls to_vvq() to get > >> 'vq', let's directly pass 'vq'. It can avoid unnecessary call of > >> to_vvq() in hot path. > >>

Re: [PATCH] virtio_pci: avoid to request intx irq if irq is zero

2022-09-27 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 11:57:06AM +0800, Angus Chen wrote: > The background is that we use dpu in cloud computing,the arch is x86,80 > cores.We will have a lots of virtio devices,like 512 or more. > When we probe about 200 virtio_blk devices,it will fail and > the stack is print as follows: > > [

Re: [PATCH] virtio_ring: Drop unnecessary initialization of detach_buf_packed

2022-09-27 Thread Michael S. Tsirkin
On Mon, Sep 26, 2022 at 06:29:46AM -0400, Deming Wang wrote: > The variable is initialized but it is only used after its assignment. > > Signed-off-by: Deming Wang The thing to do here is to move the first assigment to the initialization. > --- > drivers/virtio/virtio_ring.c | 2 +- > 1 file c

Re: [syzbot] usb-testing boot error: BUG: unable to handle kernel paging request in virtnet_set_affinity

2022-09-27 Thread Michael S. Tsirkin
On Mon, Aug 22, 2022 at 12:48:32PM -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:ad57410d231d usb: gadget: rndis: use %u instead of %d to p.. > git tree: > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing > console outp

Re: [syzbot] linux-next boot error: WARNING in cpumask_next_wrap

2022-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2022 at 02:44:35PM -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:1bd8b75fe6ad Add linux-next specific files for 20220927 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=10

Re: [PATCH RFC 3/8] virtio_blk: Add support for provision requests

2022-09-27 Thread Michael S. Tsirkin
On Thu, Sep 15, 2022 at 09:48:21AM -0700, Sarthak Kukreti wrote: > From: Sarthak Kukreti > > Adds support for provision requests. Provision requests act like > the inverse of discards. > > Signed-off-by: Sarthak Kukreti > --- > drivers/block/virtio_blk.c | 48 +

Re: [PATCH v1] virtio_blk: should not use IRQD_AFFINITY_MANAGED in init_rq

2022-09-27 Thread Michael S. Tsirkin
On Sat, Sep 24, 2022 at 11:48:54AM +0800, Angus Chen wrote: > The background is that we use dpu in cloud computing,the arch is x86,80 > cores.We will have a lots of virtio devices,like 512 or more. > When we probe about 200 virtio_blk devices,it will fail and > the stack is print as follows: > > [

Re: [PATCH] virtio_ring: remove unnecessary to_vvq() call

2022-09-27 Thread Michael S. Tsirkin
On Mon, Sep 26, 2022 at 05:11:30AM -0400, Bo Liu wrote: > It passes '_vq' to vring_free(), which still calls to_vvq() > to get 'vq', let's directly pass 'vq'. It can avoid > unnecessary call of to_vvq() in hot path. > > Signed-off-by: Bo Liu What is the point of this change? __vring_new_virtque

Re: [PATCH net-next 0/4] shrink struct ubuf_info

2022-09-27 Thread Paolo Abeni
On Tue, 2022-09-27 at 21:17 +0100, Pavel Begunkov wrote: > On 9/27/22 20:59, Paolo Abeni wrote: > > On Tue, 2022-09-27 at 19:48 +0100, Pavel Begunkov wrote: > > > On 9/27/22 18:56, Paolo Abeni wrote: > > > > On Tue, 2022-09-27 at 18:16 +0100, Pavel Begunkov wrote: > > > > > On 9/27/22 15:28, Pavel

Re: [PATCH net-next 0/4] shrink struct ubuf_info

2022-09-27 Thread Paolo Abeni
On Tue, 2022-09-27 at 19:48 +0100, Pavel Begunkov wrote: > On 9/27/22 18:56, Paolo Abeni wrote: > > On Tue, 2022-09-27 at 18:16 +0100, Pavel Begunkov wrote: > > > On 9/27/22 15:28, Pavel Begunkov wrote: > > > > Hello Paolo, > > > > > > > > On 9/27/22 14:49, Paolo Abeni wrote: > > > > > Hello, > >

Re: [PATCH net-next 0/4] shrink struct ubuf_info

2022-09-27 Thread Paolo Abeni
On Tue, 2022-09-27 at 18:16 +0100, Pavel Begunkov wrote: > On 9/27/22 15:28, Pavel Begunkov wrote: > > Hello Paolo, > > > > On 9/27/22 14:49, Paolo Abeni wrote: > > > Hello, > > > > > > On Fri, 2022-09-23 at 17:39 +0100, Pavel Begunkov wrote: > > > > struct ubuf_info is large but not all fields a

Re: [PATCH 0/6] virtio/vsock: introduce dgrams, sk_buff, and qdisc

2022-09-27 Thread Stefano Garzarella
On Mon, Sep 26, 2022 at 03:42:19PM +0200, Stefano Garzarella wrote: Hi, On Mon, Aug 15, 2022 at 10:56:03AM -0700, Bobby Eshleman wrote: Hey everybody, This series introduces datagrams, packet scheduling, and sk_buff usage to virtio vsock. Just a reminder for those who are interested, tomorro

Re: [PATCH net-next 0/4] shrink struct ubuf_info

2022-09-27 Thread Paolo Abeni
Hello, On Fri, 2022-09-23 at 17:39 +0100, Pavel Begunkov wrote: > struct ubuf_info is large but not all fields are needed for all > cases. We have limited space in io_uring for it and large ubuf_info > prevents some struct embedding, even though we use only a subset > of the fields. It's also not

Re: [PATCH V2 2/3] vdpa_sim_net: support feature provisioning

2022-09-27 Thread Si-Wei Liu
On 9/26/2022 9:07 PM, Jason Wang wrote: On Tue, Sep 27, 2022 at 11:59 AM Jason Wang wrote: On Tue, Sep 27, 2022 at 9:02 AM Si-Wei Liu wrote: On 9/26/2022 12:11 AM, Jason Wang wrote: On Sat, Sep 24, 2022 at 4:01 AM Si-Wei Liu wrote: On 9/21/2022 7:43 PM, Jason Wang wrote: This patch i

Re: [PATCH V2 2/3] vdpa_sim_net: support feature provisioning

2022-09-27 Thread Si-Wei Liu
On 9/26/2022 8:59 PM, Jason Wang wrote: On Tue, Sep 27, 2022 at 9:02 AM Si-Wei Liu wrote: On 9/26/2022 12:11 AM, Jason Wang wrote: On Sat, Sep 24, 2022 at 4:01 AM Si-Wei Liu wrote: On 9/21/2022 7:43 PM, Jason Wang wrote: This patch implements features provisioning for vdpa_sim_net. 1)

[PATCH V3 3/3] vp_vdpa: support feature provisioning

2022-09-27 Thread Jason Wang
This patch allows the device features to be provisioned via netlink. This is done by: 1) validating the provisioned features to be a subset of the parent features. 2) clearing the features that is not wanted by the userspace For example: # vdpa mgmtdev show pci/:02:00.0: supported_class

[PATCH V3 2/3] vdpa_sim_net: support feature provisioning

2022-09-27 Thread Jason Wang
This patch implements features provisioning for vdpa_sim_net. 1) validating the provisioned features to be a subset of the parent features. 2) clearing the features that is not wanted by the userspace For example: # vdpa mgmtdev show vdpasim_net: supported_classes net max_supported_vqs 3

[PATCH V3 0/3] vdpa: device feature provisioning

2022-09-27 Thread Jason Wang
Hi All: Virtio features are neogiated between the device and the drivers. This allows the mediation layer like vDPA to hide some features from the driver to faciliate the cross vendor live migration: vDPA on the source supports feature set X vDPA on the destination supports feature set Y Managem

[PATCH V3 1/3] vdpa: device feature provisioning

2022-09-27 Thread Jason Wang
This patch allows the device features to be provisioned through netlink. A new attribute is introduced to allow the userspace to pass a 64bit device features during device adding. This provides several advantages: - Allow to provision a subset of the features to ease the cross vendor live migra