Re: [PATCH v4] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Gerd Hoffmann
On Wed, Mar 01, 2023 at 03:37:24AM +0300, Dmitry Osipenko wrote: > On 2/28/23 18:54, Rob Clark wrote: > > From: Rob Clark > > > > Add a build option to disable modesetting support. This is useful in > > cases where the guest only needs to use the GPU in a headless mode, or > > (such as in the

Re: [PATCH v4 2/2] vdpasim: support doorbell mapping

2023-02-28 Thread Jason Wang
在 2023/2/27 17:18, Longpeng(Mike) 写道: From: Longpeng Support doorbell mapping for vdpasim devices, then we can test the notify passthrough feature even if there's no real hardware on hand. Allocates a dummy page which is used to emulate the notify page of the device, all VQs share the same

Re: [PATCH v4 07/15] vdpa: add vhost_vdpa_suspend

2023-02-28 Thread Si-Wei Liu
On 2/24/2023 7:54 AM, Eugenio Pérez wrote: The function vhost.c:vhost_dev_stop fetches the vring base so the vq state can be migrated to other devices. However, this is unreliable in vdpa, since we didn't signal the device to suspend the queues, making the value fetched useless. Suspend the

Re: [PATCH v3 05/11] vduse: Support automatic irq callback affinity

2023-02-28 Thread kernel test robot
Hi Xie, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/irq/core] [also build test WARNING on linus/master next-20230228] [cannot apply to mst-vhost/linux-next hch-configfs/for-next v6.2] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH net-next v3 1/3] vsock: support sockmap

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 07:04:34PM +, Bobby Eshleman wrote: > @@ -1241,19 +1252,34 @@ static int vsock_dgram_connect(struct socket *sock, > > memcpy(>remote_addr, remote_addr, sizeof(vsk->remote_addr)); > sock->state = SS_CONNECTED; > + sk->sk_state = TCP_ESTABLISHED; > >

[PATCH v4] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Rob Clark
From: Rob Clark Add a build option to disable modesetting support. This is useful in cases where the guest only needs to use the GPU in a headless mode, or (such as in the CrOS usage) window surfaces are proxied to a host compositor. As the modesetting ioctls are a big surface area for

Re: [PATCH v3] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Rob Clark
On Tue, Feb 28, 2023 at 4:34 AM Thomas Zimmermann wrote: > > Hi > > Am 27.02.23 um 19:15 schrieb Rob Clark: > > On Mon, Feb 27, 2023 at 9:57 AM Dmitry Osipenko > > wrote: > >> > >> On 2/27/23 20:38, Rob Clark wrote: > >> ... > >>> + if (IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS)) { > >>> +

Re: [PATCH v3] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Thomas Zimmermann
Am 28.02.23 um 13:34 schrieb Thomas Zimmermann: Hi Am 27.02.23 um 19:15 schrieb Rob Clark: On Mon, Feb 27, 2023 at 9:57 AM Dmitry Osipenko wrote: On 2/27/23 20:38, Rob Clark wrote: ... + if (IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS)) { + /* get display info */ +

Re: [PATCH v3] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Gerd Hoffmann
Hi, > + if (!vgdev->num_scanouts) { > + /* > + * Having an EDID but no scanouts is non-sensical, > + * but it is permitted to have no scanouts and no > + * EDID (in which case DRIVER_MODESET and > +

Re: [PATCH v3] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Thomas Zimmermann
Hi Am 27.02.23 um 19:15 schrieb Rob Clark: On Mon, Feb 27, 2023 at 9:57 AM Dmitry Osipenko wrote: On 2/27/23 20:38, Rob Clark wrote: ... + if (IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS)) { + /* get display info */ + virtio_cread_le(vgdev->vdev, struct

Re: [PATCH] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Thomas Zimmermann
Hi Am 24.02.23 um 19:02 schrieb Rob Clark: From: Rob Clark Add a build option to disable modesetting support. This is useful in cases where the guest only needs to use the GPU in a headless mode, or (such as in the CrOS usage) window surfaces are proxied to a host compositor. We've just

Re: [PATCH v2] vdpa_sim: set last_used_idx as last_avail_idx in vdpasim_queue_ready

2023-02-28 Thread Michael S. Tsirkin
On Fri, Feb 03, 2023 at 03:25:01PM +0100, Eugenio Pérez wrote: > Starting from an used_idx different than 0 is needed in use cases like > virtual machine migration. Not doing so and letting the caller set an > avail idx different than 0 causes destination device to try to use old > buffers that

Re: [PATCH] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Thomas Zimmermann
Hi Am 28.02.23 um 10:19 schrieb Javier Martinez Canillas: Gerd Hoffmann writes: [...] I think it is a bad idea to make that a compile time option, I'd suggest a runtime switch instead, for example a module parameter to ask the driver to ignore any scanouts. I don't think there's a need

Re: [PATCH vhost 07/10] virtio_ring: add api virtio_dma_map() for advance dma

2023-02-28 Thread Xuan Zhuo
On Tue, 21 Feb 2023 09:51:07 +0800, Jason Wang wrote: > On Mon, Feb 20, 2023 at 3:02 PM Xuan Zhuo wrote: > > > > On Mon, 20 Feb 2023 13:38:24 +0800, Jason Wang wrote: > > > On Tue, Feb 14, 2023 at 3:27 PM Xuan Zhuo > > > wrote: > > > > > > > > Added virtio_dma_map() to map DMA addresses for

Re: [PATCH v3 05/11] vduse: Support automatic irq callback affinity

2023-02-28 Thread kernel test robot
Hi Xie, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/irq/core] [also build test WARNING on linus/master next-20230228] [cannot apply to mst-vhost/linux-next v6.2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v2] vdpa_sim: set last_used_idx as last_avail_idx in vdpasim_queue_ready

2023-02-28 Thread Stefano Garzarella
On Fri, Feb 03, 2023 at 03:25:01PM +0100, Eugenio Pérez wrote: Starting from an used_idx different than 0 is needed in use cases like virtual machine migration. Not doing so and letting the caller set an avail idx different than 0 causes destination device to try to use old buffers that source

Re: [RFC PATCH v1 12/12] test/vsock: MSG_ZEROCOPY support for vsock_perf

2023-02-28 Thread Stefano Garzarella
On Mon, Feb 20, 2023 at 09:05:12AM +, Krasnov Arseniy wrote: On 16.02.2023 18:29, Stefano Garzarella wrote: On Mon, Feb 06, 2023 at 07:06:32AM +, Arseniy Krasnov wrote: To use this option pass '--zc' parameter: --zerocopy or --zero-copy maybe better follow what we did with the other

Re: [RFC PATCH v1 07/12] vsock/virtio: MGS_ZEROCOPY flag support

2023-02-28 Thread Stefano Garzarella
On Mon, Feb 20, 2023 at 09:04:04AM +, Krasnov Arseniy wrote: On 16.02.2023 18:16, Stefano Garzarella wrote: On Mon, Feb 06, 2023 at 07:00:35AM +, Arseniy Krasnov wrote: This adds main logic of MSG_ZEROCOPY flag processing for packet creation. When this flag is set and user's iov

Re: [RFC PATCH v1 00/12] vsock: MSG_ZEROCOPY flag support

2023-02-28 Thread Stefano Garzarella
On Mon, Feb 20, 2023 at 08:59:32AM +, Krasnov Arseniy wrote: On 16.02.2023 16:33, Stefano Garzarella wrote: Hi Arseniy, sorry for the delay, but I was offline. Hello! Sure no problem!, i was also offline a little bit so i'm replying just now On Mon, Feb 06, 2023 at 06:51:55AM +,

Re: [PATCH v2] virtio-net: Fix probe of virtio-net on kvmtool

2023-02-28 Thread Xuan Zhuo
On Tue, 28 Feb 2023 18:06:38 +0800, Xuan Zhuo wrote: > On Fri, 24 Feb 2023 11:11:37 +0800, Jason Wang wrote: > > On Fri, Feb 24, 2023 at 3:38 AM Rob Bradford via B4 Relay > > wrote: > > > > > > From: Rob Bradford > > > > > > kvmtool does not support the VIRTIO_NET_F_CTRL_GUEST_OFFLOADS

Re: [PATCH v2] virtio-net: Fix probe of virtio-net on kvmtool

2023-02-28 Thread Xuan Zhuo
On Fri, 24 Feb 2023 11:11:37 +0800, Jason Wang wrote: > On Fri, Feb 24, 2023 at 3:38 AM Rob Bradford via B4 Relay > wrote: > > > > From: Rob Bradford > > > > kvmtool does not support the VIRTIO_NET_F_CTRL_GUEST_OFFLOADS feature > > but does advertise the VIRTIO_NET_F_GUEST_TSO{4,6} features.