Re: [PATCH v3] vringh: IOMEM support

2023-04-27 Thread Shunsuke Mie
Hi Simon-san, 2023年4月27日(木) 4:21 Simon Horman : > > On Tue, Apr 25, 2023 at 07:22:50PM +0900, Shunsuke Mie wrote: > > Introduce a new memory accessor for vringh. It is able to use vringh to > > virtio rings located on io-memory region. > > > > Signed-off-by: Shunsuke Mie > > ... > > Hi Mie-san,

Re: [PATCH v3] vringh: IOMEM support

2023-04-27 Thread Shunsuke Mie
2023年4月26日(水) 15:10 Jason Wang : > > On Tue, Apr 25, 2023 at 6:23 PM Shunsuke Mie wrote: > > > > Introduce a new memory accessor for vringh. It is able to use vringh to > > virtio rings located on io-memory region. > > Is there a user for this? It would be better if you can describe the > use

Re: [PATCH net-next v4 12/15] virtio_net: small: avoid double counting in xdp scenarios

2023-04-27 Thread Xuan Zhuo
On Thu, 27 Apr 2023 21:08:25 -0400, "Michael S. Tsirkin" wrote: > On Thu, Apr 27, 2023 at 11:05:31AM +0800, Xuan Zhuo wrote: > > Avoid the problem that some variables(headroom and so on) will repeat > > the calculation when process xdp. > > > > Signed-off-by: Xuan Zhuo > > Acked-by: Jason Wang

Re: [PATCH v2] virtio_net: suppress cpu stall when free_unused_bufs

2023-04-27 Thread Michael S. Tsirkin
On Thu, Apr 27, 2023 at 06:46:18PM +0800, Wenliang Wang wrote: > For multi-queue and large ring-size use case, the following error > occurred when free_unused_bufs: > rcu: INFO: rcu_sched self-detected stall on CPU. > > Signed-off-by: Wenliang Wang pls send vN+1 as a new thread not as a reply

Re: [PATCH net-next v4 12/15] virtio_net: small: avoid double counting in xdp scenarios

2023-04-27 Thread Michael S. Tsirkin
On Thu, Apr 27, 2023 at 11:05:31AM +0800, Xuan Zhuo wrote: > Avoid the problem that some variables(headroom and so on) will repeat > the calculation when process xdp. > > Signed-off-by: Xuan Zhuo > Acked-by: Jason Wang this is "code duplication" not "double counting". > --- >

Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups

2023-04-27 Thread pr-tracker-bot
The pull request you sent on Mon, 24 Apr 2023 17:48:42 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8ccd54fe45713cd458015b5b08d6098545e70543 Thank you! -- Deet-doot-dot, I am a

Re: [RFC PATCH v2 1/3] PCI: endpoint: introduce a helper to implement pci ep virtio function

2023-04-27 Thread Bjorn Helgaas
Simple typos, don't repost until there's more substantive feedback. On Thu, Apr 27, 2023 at 07:44:26PM +0900, Shunsuke Mie wrote: > The Linux PCIe Endpoint framework supports to implement PCIe endpoint > functions using a PCIe controller operating in endpoint mode. > It is possble to realize the

Re: [RFC PATCH v2 3/3] PCI: endpoint: Add EP function driver to provide virtio-console functionality

2023-04-27 Thread Bjorn Helgaas
Random typos and trivial things. No need to repost until somebody does a more substantive review. On Thu, Apr 27, 2023 at 07:44:28PM +0900, Shunsuke Mie wrote: > Add a new PCIe endpoint function driver that works as a pci virtio-console > device. The console connect to endpoint side console. It

Re: [RFC PATCH v2 0/3] Introduce a PCIe endpoint virtio console

2023-04-27 Thread Bjorn Helgaas
On Thu, Apr 27, 2023 at 07:44:25PM +0900, Shunsuke Mie wrote: > ... > PCI: endpoint: introduce a helper to implement pci ep virtio function > virtio_pci: add a definition of queue flag in ISR > PCI: endpoint: Add EP function driver to provide virtio-console > functionality Capitalize

[RFC PATCH v2 3/3] PCI: endpoint: Add EP function driver to provide virtio-console functionality

2023-04-27 Thread Shunsuke Mie
Add a new PCIe endpoint function driver that works as a pci virtio-console device. The console connect to endpoint side console. It enables to communicate PCIe host and endpoint. Architecture is following: ┌┐ ┌──┬┐ │virtioe │ │

[RFC PATCH v2 0/3] Introduce a PCIe endpoint virtio console

2023-04-27 Thread Shunsuke Mie
PCIe endpoint framework provides APIs to implement PCIe endpoint function. This framework allows defining various PCIe endpoint function behaviors in software. This patch extend the framework for virtio pci device. The virtio is defined to communicate guest on virtual machine and host side.

[RFC PATCH v2 2/3] virtio_pci: add a definition of queue flag in ISR

2023-04-27 Thread Shunsuke Mie
Already it has beed defined a config changed flag of ISR, but not the queue flag. Add a macro for it. Signed-off-by: Shunsuke Mie --- include/uapi/linux/virtio_pci.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h index

[RFC PATCH v2 1/3] PCI: endpoint: introduce a helper to implement pci ep virtio function

2023-04-27 Thread Shunsuke Mie
The Linux PCIe Endpoint framework supports to implement PCIe endpoint functions using a PCIe controller operating in endpoint mode. It is possble to realize the behavior of PCIe device, such as virtio PCI device. This patch introduces a setof helper functions and data structures to implement a

Re: [PATCH 4/5] synchronize irqs in the reset routine

2023-04-27 Thread Zhu, Lingshan
On 4/26/2023 1:06 PM, Jason Wang wrote: 在 2023/4/1 04:48, Zhu Lingshan 写道: This commit synchronize irqs of the virtqueues and config space in the reset routine. Thus ifcvf_stop_hw() and reset() are refactored as well. Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.c | 61

Re: [PATCH] virtio_net: suppress cpu stall when free_unused_bufs

2023-04-27 Thread Xuan Zhuo
On Thu, 27 Apr 2023 16:49:58 +0800, Wenliang Wang wrote: > On 4/27/23 4:23 PM, Michael S. Tsirkin wrote: > > On Thu, Apr 27, 2023 at 04:13:45PM +0800, Xuan Zhuo wrote: > >> On Thu, 27 Apr 2023 04:12:44 -0400, "Michael S. Tsirkin" > >> wrote: > >>> On Thu, Apr 27, 2023 at 03:13:44PM +0800, Xuan

Re: [PATCH 2/5] get_driver_features from virito registers

2023-04-27 Thread Zhu, Lingshan
On 4/26/2023 12:02 PM, Jason Wang wrote: 在 2023/4/1 04:48, Zhu Lingshan 写道: This commit implements a new function ifcvf_get_driver_feature() which read driver_features from virtio registers. To be less ambiguous, ifcvf_set_features() is renamed to ifcvf_set_driver_features(), and

Re: [PATCH] virtio_net: suppress cpu stall when free_unused_bufs

2023-04-27 Thread Michael S. Tsirkin
On Thu, Apr 27, 2023 at 04:13:45PM +0800, Xuan Zhuo wrote: > On Thu, 27 Apr 2023 04:12:44 -0400, "Michael S. Tsirkin" > wrote: > > On Thu, Apr 27, 2023 at 03:13:44PM +0800, Xuan Zhuo wrote: > > > On Thu, 27 Apr 2023 15:02:26 +0800, Wenliang Wang > > > wrote: > > > > > > > > > > > > On 4/27/23

Re: [PATCH] virtio_net: suppress cpu stall when free_unused_bufs

2023-04-27 Thread Xuan Zhuo
On Thu, 27 Apr 2023 04:12:44 -0400, "Michael S. Tsirkin" wrote: > On Thu, Apr 27, 2023 at 03:13:44PM +0800, Xuan Zhuo wrote: > > On Thu, 27 Apr 2023 15:02:26 +0800, Wenliang Wang > > wrote: > > > > > > > > > On 4/27/23 2:20 PM, Xuan Zhuo wrote: > > > > On Thu, 27 Apr 2023 12:34:33 +0800,

Re: [PATCH] virtio_net: suppress cpu stall when free_unused_bufs

2023-04-27 Thread Michael S. Tsirkin
On Thu, Apr 27, 2023 at 03:13:44PM +0800, Xuan Zhuo wrote: > On Thu, 27 Apr 2023 15:02:26 +0800, Wenliang Wang > wrote: > > > > > > On 4/27/23 2:20 PM, Xuan Zhuo wrote: > > > On Thu, 27 Apr 2023 12:34:33 +0800, Wenliang Wang > > > wrote: > > >> For multi-queue and large rx-ring-size use case,

Re: [PATCH 1/5] virt queue ops take immediate actions

2023-04-27 Thread Zhu, Lingshan
On 4/26/2023 11:39 AM, Jason Wang wrote: 在 2023/4/1 04:48, Zhu Lingshan 写道: In this commit, virtqueue operations including: set_vq_num(), set_vq_address(), set_vq_ready() and get_vq_ready() access PCI registers directly to take immediate actions. Signed-off-by: Zhu Lingshan ---  

Re: [PATCH] virtio_net: suppress cpu stall when free_unused_bufs

2023-04-27 Thread Xuan Zhuo
On Thu, 27 Apr 2023 15:02:26 +0800, Wenliang Wang wrote: > > > On 4/27/23 2:20 PM, Xuan Zhuo wrote: > > On Thu, 27 Apr 2023 12:34:33 +0800, Wenliang Wang > > wrote: > >> For multi-queue and large rx-ring-size use case, the following error > > > > Cound you give we one number for example? > >

Re: [PATCH net-next v4 00/15] virtio_net: refactor xdp codes

2023-04-27 Thread Paolo Abeni
On Thu, 2023-04-27 at 11:05 +0800, Xuan Zhuo wrote: > Due to historical reasons, the implementation of XDP in virtio-net is > relatively > chaotic. For example, the processing of XDP actions has two copies of similar > code. Such as page, xdp_page processing, etc. > > The purpose of this patch

Re: [PATCH] virtio_net: suppress cpu stall when free_unused_bufs

2023-04-27 Thread Xuan Zhuo
On Thu, 27 Apr 2023 12:34:33 +0800, Wenliang Wang wrote: > For multi-queue and large rx-ring-size use case, the following error Cound you give we one number for example? > occurred when free_unused_bufs: > rcu: INFO: rcu_sched self-detected stall on CPU. > > Signed-off-by: Wenliang Wang > ---