Re: [PATCH net-next v2 00/12] vsock/virtio: continue MSG_ZEROCOPY support

2023-10-03 Thread Stefano Garzarella
Hi Arseniy, On Sun, Oct 01, 2023 at 12:02:56AM +0300, Arseniy Krasnov wrote: Hello, this patchset contains second and third parts of another big patchset for MSG_ZEROCOPY flag support: https://lore.kernel.org/netdev/20230701063947.3422088-1-avkras...@sberdevices.ru/ During review of this

Re: [PATCH net-next v2 10/12] test/vsock: MSG_ZEROCOPY flag tests

2023-10-03 Thread Stefano Garzarella
On Sun, Oct 01, 2023 at 12:03:06AM +0300, Arseniy Krasnov wrote: This adds three tests for MSG_ZEROCOPY feature: 1) SOCK_STREAM tx with different buffers. 2) SOCK_SEQPACKET tx with different buffers. 3) SOCK_STREAM test to read empty error queue of the socket. Signed-off-by: Arseniy Krasnov

Re: [PATCH net-next v2 09/12] docs: net: description of MSG_ZEROCOPY for AF_VSOCK

2023-10-03 Thread Stefano Garzarella
On Sun, Oct 01, 2023 at 12:03:05AM +0300, Arseniy Krasnov wrote: This adds description of MSG_ZEROCOPY flag support for AF_VSOCK type of socket. Signed-off-by: Arseniy Krasnov --- Documentation/networking/msg_zerocopy.rst | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

Re: [PATCH net-next v2 08/12] vsock: enable setting SO_ZEROCOPY

2023-10-03 Thread Stefano Garzarella
On Sun, Oct 01, 2023 at 12:03:04AM +0300, Arseniy Krasnov wrote: For AF_VSOCK, zerocopy tx mode depends on transport, so this option must be set in AF_VSOCK implementation where transport is accessible (if transport is not set during setting SO_ZEROCOPY: for example socket is not connected, then

Re: [PATCH net-next v2 02/12] vsock: read from socket's error queue

2023-10-03 Thread Stefano Garzarella
On Sun, Oct 01, 2023 at 12:02:58AM +0300, Arseniy Krasnov wrote: This adds handling of MSG_ERRQUEUE input flag in receive call. This flag is used to read socket's error queue instead of data queue. Possible scenario of error queue usage is receiving completions for transmission with MSG_ZEROCOPY

Re: [PATCH net-next v2 01/12] vsock: set EPOLLERR on non-empty error queue

2023-10-03 Thread Stefano Garzarella
On Sun, Oct 01, 2023 at 12:02:57AM +0300, Arseniy Krasnov wrote: If socket's error queue is not empty, EPOLLERR must be set. Otherwise, reader of error queue won't detect data in it using EPOLLERR bit. Currently for AF_VSOCK this is actual only with MSG_ZEROCOPY, as this feature is the only user

Re: [LINUX KERNEL PATCH v5 1/2] virtio_pci: Add freeze_mode for virtio_pci_common_cfg

2023-10-03 Thread Michael S. Tsirkin
On Tue, Sep 19, 2023 at 06:46:06PM +0800, Jiqian Chen wrote: > When guest vm does S3, Qemu will reset and clear some things of virtio > devices, but guest can't aware that, so that may cause some problems. > For excample, Qemu calls virtio_reset->virtio_gpu_gl_reset, that will > destroy render

Re: [PATCH net v2 5/6] virtio-net: fix the vq coalescing setting for vq resize

2023-10-03 Thread Paolo Abeni
On Mon, 2023-09-25 at 15:53 +0800, Heng Qi wrote: > According to the definition of virtqueue coalescing spec[1]: > > Upon disabling and re-enabling a transmit virtqueue, the device MUST set > the coalescing parameters of the virtqueue to those configured through the >

Re: [PATCH vhost 10/16] vdpa/mlx5: Allow creation/deletion of any given mr struct

2023-10-03 Thread Dragos Tatulea via Virtualization
On Thu, 2023-09-28 at 19:45 +0300, Dragos Tatulea wrote: > This patch adapts the mr creation/deletion code to be able to work with > any given mr struct pointer. All the APIs are adapted to take an extra > parameter for the mr. > > mlx5_vdpa_create/delete_mr doesn't need a ASID parameter anymore.