Re: [PATCH 2/2] lguest: virtio-rng support

2008-05-19 Thread Johannes Berg
+ +/* Our random number generator device reads from /dev/urandom into the Guest's + * input buffers. The usual case is that the Guest doesn't want random numbers + * and so has no buffers although /dev/urandom is still readable, whereas + * console is the reverse. Is it really a good

Re: [PATCH 1/4] virtio_net: use DECLARE_EWMA

2015-08-19 Thread Johannes Berg
Sorry, forgot to Cc Michael and the virt list - patch reproduced below in full. johannes From 22500fbcf722748fe3471b2e4c6156db47aade15 Mon Sep 17 00:00:00 2001 From: Johannes Berg johannes.b...@intel.com Date: Wed, 19 Aug 2015 09:25:18 +0200 Subject: [PATCH] virtio_net: use DECLARE_EWMA Instead

[PATCH] average: change to declare precision, not factor

2017-02-15 Thread Johannes Berg
From: Johannes Berg <johannes.b...@intel.com> Declaring the factor is counter-intuitive, and people are prone to using small(-ish) values even when that makes no sense. Change the DECLARE_EWMA() macro to take the fractional precision, in bits, rather than a factor, and update all users.

Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

2016-12-06 Thread Johannes Berg
On Tue, 2016-12-06 at 17:41 +0200, Michael S. Tsirkin wrote: > It seems that there should be a better way to do it, > but this works too. In some cases there might be: > --- a/drivers/s390/virtio/Makefile > +++ b/drivers/s390/virtio/Makefile > @@ -6,6 +6,8 @@ >  # it under the terms of the GNU

custom virt-io support (in user-mode-linux)

2019-05-22 Thread Johannes Berg
Hi, While my main interest is mostly in UML right now [1] I've CC'ed the qemu and virtualization lists because something similar might actually apply to other types of virtualization. I'm thinking about adding virt-io support to UML, but the tricky part is that while I want to use the virt-io

Re: custom virt-io support (in user-mode-linux)

2019-05-22 Thread Johannes Berg
Hi Anton, > > I'm thinking about adding virt-io support to UML, but the tricky part is > > that while I want to use the virt-io basics (because it's a nice > > interface from the 'inside'), I don't actually want the stock drivers > > that are part of the kernel now (like virtio-net etc.) but

Re: [Qemu-devel] custom virt-io support (in user-mode-linux)

2019-05-23 Thread Johannes Berg
Hi Stefan, > Check out vhost-user. It's a protocol for running a subset of a VIRTIO > device's emulation in a separate process (usually just the data plane > with the PCI emulation and other configuration/setup still handled by > QEMU). Yes, I think that's basically what I'm looking for. >

Re: [Qemu-devel] custom virt-io support (in user-mode-linux)

2019-05-24 Thread Johannes Berg
On Thu, 2019-05-23 at 15:41 +0100, Stefan Hajnoczi wrote: > > Also, not sure I understand how the client is started? > > The vhost-user device backend can be launched before QEMU. QEMU is > started with the UNIX domain socket path so it can connect. Hmm. I guess I'm confusing the terminology

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2019-12-09 Thread Johannes Berg
> else if (sinfo->gso_type & SKB_GSO_TCPV6) > hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6; > - else > - return -EINVAL; > + else { > + if (skb->data_len == 0) > +

Re: [RFC PATCH 01/17] virtio_ring: Avoid reading unneeded used length

2021-05-17 Thread Johannes Berg
On Mon, 2021-05-17 at 17:08 +0800, Xie Yongji wrote: > If device driver doesn't need used length, it can pass a NULL > len in virtqueue_get_buf()/virtqueue_get_buf_ctx(). > Well, actually, it can't right now? You should probably rephrase this, saying something like Allow passing NULL to len