Re: [PATCH net-next 4/4] mlx4: sizeof style usage

2017-10-26 Thread Leon Romanovsky
++- > drivers/net/ethernet/mellanox/mlx4/qp.c| 12 +-- > .../net/ethernet/mellanox/mlx4/resource_tracker.c | 24 > +++--- > 15 files changed, 56 insertions(+), 56 deletions(-) > Thanks, Reviewed-by:

Re: [Qemu-devel] [RFC 0/3] VirtIO RDMA

2019-04-22 Thread Leon Romanovsky
On Fri, Apr 19, 2019 at 01:16:06PM +0200, Hannes Reinecke wrote: > On 4/15/19 12:35 PM, Yuval Shaia wrote: > > On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > > > On Thu, 11 Apr 2019 14:01:54 +0300 > > > Yuval Shaia wrote: > > > > > > > Data center backends use more and more RDMA

[PATCH mlx5-next 00/11] Convert mlx5 to use auxiliary bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This patch set converts mlx5 driver to use auxiliary bus [1]. In this series, we are connecting three subsystems (VDPA, netdev and RDMA) through mlx5_core PCI driver. That driver is responsible to create proper devices based on supported firmware. First four patches

[PATCH mlx5-next 11/11] RDMA/mlx5: Remove IB representors dead code

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Delete dead code. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/ib_rep.c | 31 +-- drivers/infiniband/hw/mlx5/ib_rep.h | 31 --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 4 +-- 3 files changed, 9

[PATCH mlx5-next 07/11] net/mlx5e: Connect ethernet part to auxiliary bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Reuse auxiliary bus to perform device management of the ethernet part of the mlx5 driver. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 74 ++ .../net/ethernet/mellanox/mlx5/core/en_main.c | 133 -- .../net

[PATCH mlx5-next 09/11] net/mlx5: Delete custom device management logic

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky After conversion to use auxiliary bus, all custom device management is not needed anymore, delete it. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 299 +- drivers/net/ethernet/mellanox/mlx5/core/lag.c | 18

[PATCH mlx5-next 04/11] vdpa/mlx5: Make hardware definitions visible to all mlx5 devices

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Move mlx5_vdpa IFC header file to the general include folder, so mlx5_core will be able to reuse it to check if VDPA is supported prior to creating an auxiliary device. As part of this move, update the header file name to mlx5 general naming scheme. Reviewed-by: Parav

[PATCH mlx5-next 02/11] net/mlx5: Properly convey driver version to firmware

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky mlx5 firmware expects driver version in specific format X.X.X, so make it always correct and based on real kernel version aligned with the driver. Fixes: 012e50e109fd ("net/mlx5: Set driver version into firmware") Signed-off-by: Leon Romanovsky --- drivers/ne

[PATCH mlx5-next 05/11] net/mlx5: Register mlx5 devices to auxiliary virtual bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Create auxiliary devices under new virtual bus. This will replace the custom-made mlx5 ->add()/->remove() interfaces and next patches will fill the missing callback and remove the old interface logic. The attachment of auxiliary drivers to the devices is possible in

[PATCH mlx5-next 03/11] net/mlx5_core: Clean driver version and name

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Remove exposed driver version as it was done in other drivers, so module version will work correctly by displaying the kernel version for which it is compiled. And move mlx5_core module name to general include, so auxiliary drivers will be able to use it as a basis

[PATCH mlx5-next 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Change module registration logic to use auxiliary bus instead of custom made mlx5 register interface. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 28 ++- drivers/vdpa/mlx5/Makefile| 2 +- drivers/vdpa/mlx5

[PATCH mlx5-next 01/11] net/mlx5: Don't skip vport check

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Users of mlx5_eswitch_get_vport() are required to check return value prior to passing mlx5_vport further. Fix all the places to do not skip that check. Fixes: c7eddc6092b4 ("net/mlx5: E-switch, Move devlink eswitch ports closer to eswitch") Fixes: 5d9986a3947a

[PATCH mlx5-next 10/11] net/mlx5: Simplify eswitch mode check

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Provide mlx5_core device instead of "priv" pointer while checking eswith mode. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/counters.c | 7 --- drivers/infiniband/hw/mlx5/ib_rep.c | 5 - drivers/infiniba

[PATCH mlx5-next 08/11] RDMA/mlx5: Convert mlx5_ib to use auxiliary bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky The conversion to auxiliary bus solves long standing issue with existing mlx5_ib<->mlx5_core coupling. It required to have both modules in initramfs if one of them needed for the boot. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/ib_rep.c

Re: netconsole deadlock with virtnet

2020-11-24 Thread Leon Romanovsky
> > On Mon, 23 Nov 2020 09:31:28 -0500 Steven Rostedt wrote: > > > > > On Mon, 23 Nov 2020 13:08:55 +0200 > > > > > Leon Romanovsky wrote: > > > > > > > > > > > [ 10.028024] Chain exists of: > > > > > > [ 1

Re: netconsole deadlock with virtnet

2020-11-24 Thread Leon Romanovsky
On Tue, Nov 24, 2020 at 04:57:23PM +0800, Jason Wang wrote: > > On 2020/11/24 下午4:01, Leon Romanovsky wrote: > > On Tue, Nov 24, 2020 at 11:22:03AM +0800, Jason Wang wrote: > > > On 2020/11/24 上午3:21, Jakub Kicinski wrote: > > > > On Mon, 23 Nov 2020 14

Re: netconsole deadlock with virtnet

2020-11-22 Thread Leon Romanovsky
On Thu, Nov 19, 2020 at 01:55:53PM +0100, Petr Mladek wrote: > On Tue 2020-11-17 09:33:25, Steven Rostedt wrote: > > On Tue, 17 Nov 2020 12:23:41 +0200 > > Leon Romanovsky wrote: > > > > > Hi, > > > > > > Approximately two weeks ago, our re

netconsole deadlock with virtnet

2020-11-17 Thread Leon Romanovsky
Hi, Approximately two weeks ago, our regression team started to experience those netconsole splats. The tested code is Linus's master (-rc4) + netdev net-next + netdev net-rc. Such splats are random and we can't bisect because there is no stable reproducer. Any idea, what is the root cause? [

Re: netconsole deadlock with virtnet

2020-11-17 Thread Leon Romanovsky
On Tue, Nov 17, 2020 at 09:33:25AM -0500, Steven Rostedt wrote: > On Tue, 17 Nov 2020 12:23:41 +0200 > Leon Romanovsky wrote: > > > Hi, > > > > Approximately two weeks ago, our regression team started to experience those > > netconsole splats. The tested code

Re: netconsole deadlock with virtnet

2020-11-23 Thread Leon Romanovsky
On Wed, Nov 18, 2020 at 09:12:57AM -0500, Steven Rostedt wrote: > > [ Adding netdev as perhaps someone there knows ] > > On Wed, 18 Nov 2020 12:09:59 +0800 > Jason Wang wrote: > > > > This CPU0 lock(_xmit_ETHER#2) -> hard IRQ -> lock(console_owner) is > > > basically > > > soft IRQ ->

[PATCH mlx5-next v1 01/11] net/mlx5: Don't skip vport check

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky Users of mlx5_eswitch_get_vport() are required to check return value prior to passing mlx5_vport further. Fix all the places to do not skip that check. Fixes: c7eddc6092b4 ("net/mlx5: E-switch, Move devlink eswitch ports closer to eswitch") Fixes: 5d9986a3947a

[PATCH mlx5-next v1 00/11] Convert mlx5 to use auxiliary bus

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Renamed _mlx5_rescan_driver to be mlx5_rescan_driver_locked like in other parts of the mlx5 driver. * Renamed MLX5_INTERFACE_PROTOCOL_VDPA to tbe MLX5_INTERFACE_PROTOCOL_VNET as a preparation to coming series from Eli C. * Some small naming renames

[PATCH mlx5-next v1 05/11] net/mlx5: Register mlx5 devices to auxiliary virtual bus

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky Create auxiliary devices under new virtual bus. This will replace the custom-made mlx5 ->add()/->remove() interfaces and next patches will fill the missing callback and remove the old interface logic. The attachment of auxiliary drivers to the devices is possible in

[PATCH mlx5-next v1 04/11] vdpa/mlx5: Make hardware definitions visible to all mlx5 devices

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky Move mlx5_vdpa IFC header file to the general include folder, so mlx5_core will be able to reuse it to check if VDPA is supported prior to creating an auxiliary device. As part of this move, update the header file name to mlx5 general naming scheme. Reviewed-by: Parav

[PATCH mlx5-next v1 03/11] net/mlx5_core: Clean driver version and name

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky Remove exposed driver version as it was done in other drivers, so module version will work correctly by displaying the kernel version for which it is compiled. And move mlx5_core module name to general include, so auxiliary drivers will be able to use it as a basis

[PATCH mlx5-next v1 08/11] RDMA/mlx5: Convert mlx5_ib to use auxiliary bus

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky The conversion to auxiliary bus solves long standing issue with existing mlx5_ib<->mlx5_core coupling. It required to have both modules in initramfs if one of them needed for the boot. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/ib_rep.c

[PATCH mlx5-next v1 07/11] net/mlx5e: Connect ethernet part to auxiliary bus

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky Reuse auxiliary bus to perform device management of the ethernet part of the mlx5 driver. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 74 ++ .../net/ethernet/mellanox/mlx5/core/en_main.c | 133 -- .../net

[PATCH mlx5-next v1 10/11] net/mlx5: Simplify eswitch mode check

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky Provide mlx5_core device instead of "priv" pointer while checking eswith mode. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/counters.c | 7 --- drivers/infiniband/hw/mlx5/ib_rep.c | 5 - drivers/infiniba

[PATCH mlx5-next v1 09/11] net/mlx5: Delete custom device management logic

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky After conversion to use auxiliary bus, all custom device management is not needed anymore, delete it. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 288 ++ drivers/net/ethernet/mellanox/mlx5/core/lag.c | 18

[PATCH mlx5-next v1 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky Change module registration logic to use auxiliary bus instead of custom made mlx5 register interface. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 28 ++- drivers/vdpa/mlx5/Makefile| 2 +- drivers/vdpa/mlx5

[PATCH mlx5-next v1 11/11] RDMA/mlx5: Remove IB representors dead code

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky Delete dead code. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/ib_rep.c | 31 +++-- drivers/infiniband/hw/mlx5/ib_rep.h | 31 - 2 files changed, 7 insertions(+), 55 deletions(-) diff --git a/drivers

[PATCH mlx5-next v1 02/11] net/mlx5: Properly convey driver version to firmware

2020-11-01 Thread Leon Romanovsky
From: Leon Romanovsky mlx5 firmware expects driver version in specific format X.X.X, so make it always correct and based on real kernel version aligned with the driver. Fixes: 012e50e109fd ("net/mlx5: Set driver version into firmware") Signed-off-by: Leon Romanovsky --- drivers/ne

Re: [PATCH mlx5-next v1 03/11] net/mlx5_core: Clean driver version and name

2020-11-01 Thread Leon Romanovsky
On Mon, Nov 02, 2020 at 05:07:59AM +, Parav Pandit wrote: > > > > From: Leon Romanovsky > > Sent: Monday, November 2, 2020 1:46 AM > > > > From: Leon Romanovsky > > > > Remove exposed driver version as it was done in other drivers, so module >

Re: [PATCH mlx5-next v1 05/11] net/mlx5: Register mlx5 devices to auxiliary virtual bus

2020-11-05 Thread Leon Romanovsky
On Thu, Nov 05, 2020 at 05:09:48PM -0400, Jason Gunthorpe wrote: > On Thu, Nov 05, 2020 at 12:59:20PM -0800, Saeed Mahameed wrote: > > > 2. you can always load a driver without its underlying device existed. > > for example, you can load a pci device driver/module and it will load > > and wait for

Re: [PATCH mlx5-next v1 04/11] vdpa/mlx5: Make hardware definitions visible to all mlx5 devices

2020-11-05 Thread Leon Romanovsky
On Thu, Nov 05, 2020 at 04:36:57PM -0400, Jason Gunthorpe wrote: > On Thu, Nov 05, 2020 at 12:31:52PM -0800, Saeed Mahameed wrote: > > On Sun, 2020-11-01 at 22:15 +0200, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Move mlx5_vdpa IFC header fi

Re: [PATCH] vhost: add vhost_test to Kconfig & Makefile

2021-06-16 Thread Leon Romanovsky
On Wed, Jun 16, 2021 at 08:07:34PM +0800, Cai Huoqing wrote: > When running vhost test, make it easier to config > > Signed-off-by: Cai Huoqing > --- > drivers/vhost/Kconfig | 12 > drivers/vhost/Makefile | 3 +++ > 2 files changed, 15 insertions(+) > > diff --git

[PATCH rdma-next 0/5] mlx5 MR cache enhancements

2021-06-22 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This series from Aharon changes how memory region (MR) cache logic works in mlx5 driver. First 3 patches are global conversions of internal structures to hold mkeys, while the rest of the patches changes cache logic in the RDMA subsystem. Thanks Aharon Landau (5

[PATCH mlx5-next 2/5] RDMA/mlx5: Move struct mlx5_core_mkey to mlx5_ib

2021-06-22 Thread Leon Romanovsky
From: Aharon Landau Moving mlx5_core_mkey struct to mlx5_ib as the mlx5_core doesn't use it at this point. Signed-off-by: Aharon Landau Reviewed-by: Shay Drory Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/devx.c| 2 +- drivers/infiniband/hw/mlx5/mlx5_ib.h | 22

[PATCH mlx5-next 4/5] RDMA/mlx5: Change the cache structure to an rbtree

2021-06-22 Thread Leon Romanovsky
as LSB. mlx5_ib_dev will hold the root of the tree. When initializing a device, the default entries will be generated, that is, entries for mkeys' size = 2^x and access_flag = IB_ACCESS_DISABLE_RELAXED_ORDERING. Signed-off-by: Aharon Landau Reviewed-by: Shay Drory Signed-off-by: Leon Romanovsky

[PATCH rdma-next 5/5] RDMA/mlx5: Delay the deregistration of a non-cache mkey

2021-06-22 Thread Leon Romanovsky
Landau Reviewed-by: Shay Drory Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/mlx5_ib.h | 1 + drivers/infiniband/hw/mlx5/mr.c | 210 +-- 2 files changed, 163 insertions(+), 48 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers

[PATCH mlx5-next 3/5] RDMA/mlx5: Change the cache to hold mkeys instead of MRs

2021-06-22 Thread Leon Romanovsky
-by: Shay Drory Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c| 4 +- drivers/infiniband/hw/mlx5/mlx5_ib.h | 56 ++-- drivers/infiniband/hw/mlx5/mr.c | 378 ++- drivers/infiniband/hw/mlx5/odp.c | 9 +- include/linux/mlx5/driver.h

[PATCH mlx5-next 1/5] RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key

2021-06-22 Thread Leon Romanovsky
Reviewed-by: Shay Drory Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/mr.c | 42 +-- drivers/infiniband/hw/mlx5/odp.c | 2 +- .../mellanox/mlx5/core/diag/fw_tracer.c | 2 +- .../mellanox/mlx5/core/diag/fw_tracer.h | 2

Re: [PATCH] virtio-net: fix the kzalloc/kfree mismatch problem

2021-06-01 Thread Leon Romanovsky
On Mon, May 24, 2021 at 10:37:14AM +0800, Jason Wang wrote: > > 在 2021/5/24 上午10:06, Xuan Zhuo 写道: > > On Mon, 24 May 2021 01:48:53 +, Guodeqing (A) > > wrote: > > > > > > > -Original Message- > > > > From: Max Gurtovoy [mailto:mgurto...@nvidia.com] > > > > Sent: Sunday, May 23,

Re: [PATCH] virtio_net: Remove BUG() to aviod machine dead

2021-06-01 Thread Leon Romanovsky
On Tue, May 25, 2021 at 02:19:03PM +0800, Jason Wang wrote: > > 在 2021/5/19 下午10:18, Xianting Tian 写道: > > thanks, I submit the patch as commented by Andrew > > https://lkml.org/lkml/2021/5/18/256 > > > > Actually, if xmit_skb() returns error, below code will give a warning > > with error code.

Re: [PATCH] virtio-net: fix the kzalloc/kfree mismatch problem

2021-06-02 Thread Leon Romanovsky
On Wed, Jun 02, 2021 at 03:19:46PM +0800, Jason Wang wrote: > > 在 2021/6/2 下午1:50, Leon Romanovsky 写道: > > On Mon, May 24, 2021 at 10:37:14AM +0800, Jason Wang wrote: > > > 在 2021/5/24 上午10:06, Xuan Zhuo 写道: > > > > On Mon, 24 May 2021 01:48:53 +00

Re: [PATCH] virtio_net: Remove BUG() to aviod machine dead

2021-06-02 Thread Leon Romanovsky
On Wed, Jun 02, 2021 at 03:14:50PM +0800, Jason Wang wrote: > > 在 2021/6/2 下午1:59, Leon Romanovsky 写道: > > On Tue, May 25, 2021 at 02:19:03PM +0800, Jason Wang wrote: > > > 在 2021/5/19 下午10:18, Xianting Tian 写道: > > > > thanks, I submit the patch as commented b

Re: [PATCH] [v2] virtio_net: Remove BUG() to avoid machine dead

2021-06-05 Thread Leon Romanovsky
> + return -EPROTO; Yeah, as we discussed, BUG*() macros in non-core code that checks in-kernel API better to be deleted. Thanks, Reviewed-by: Leon Romanovsky ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] vdp/mlx5: Fix setting the correct dma_device

2021-06-06 Thread Leon Romanovsky
On Mon, Jun 07, 2021 at 10:30:42AM +0800, Jason Wang wrote: > > 在 2021/6/4 下午11:57, Leon Romanovsky 写道: > > On Fri, Jun 04, 2021 at 10:35:59AM +0800, Jason Wang wrote: > > > 在 2021/6/3 下午7:22, Eli Cohen 写道: > > > > Before SF support was introduced, the DMA device

Re: [PATCH] vdp/mlx5: Fix setting the correct dma_device

2021-06-04 Thread Leon Romanovsky
On Fri, Jun 04, 2021 at 10:35:59AM +0800, Jason Wang wrote: > > 在 2021/6/3 下午7:22, Eli Cohen 写道: > > Before SF support was introduced, the DMA device was equal to > > mdev->device which was in essence equal to pdev->dev; > > With SF introduction this is no longer true. It has already been > >

Re: [PATCH V3 4/6] vDPA/ifcvf: remove the version number string

2021-03-10 Thread Leon Romanovsky
I already added my ROB, but will add again. Thanks, Reviewed-by: Leon Romanovsky ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] virtio_net: replace if (cond) BUG() with BUG_ON()

2021-03-18 Thread Leon Romanovsky
On Wed, Mar 17, 2021 at 01:57:15PM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/net/virtio_net.c:1551:2-5: WARNING: Use BUG_ON instead of if > condition followed by BUG. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- >

Re: [PATCH 3/3] vDPA/ifcvf: bump version string to 1.0

2021-03-07 Thread Leon Romanovsky
On Fri, Mar 05, 2021 at 10:20:00PM +0800, Zhu Lingshan wrote: > This commit bumps ifcvf driver version string to 1.0 > > Signed-off-by: Zhu Lingshan > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c

Re: [PATCH V2 4/4] vDPA/ifcvf: remove the version number string

2021-03-08 Thread Leon Romanovsky
On Mon, Mar 08, 2021 at 04:35:25PM +0800, Zhu Lingshan wrote: > This commit removes the version number string, using kernel > version is enough. > > Signed-off-by: Zhu Lingshan > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 2 -- > 1 file changed, 2 deletions(-) > T

Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-15 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 08:42:26AM +0200, Eli Cohen wrote: > On Tue, Feb 16, 2021 at 08:35:51AM +0200, Leon Romanovsky wrote: > > On Tue, Feb 16, 2021 at 07:50:22AM +0200, Eli Cohen wrote: > > > struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well >

Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-15 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 07:50:22AM +0200, Eli Cohen wrote: > struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well > in mlx5v_remove(). > > Fixes: 74c9729dd892 ("vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus") > Signed-off-by: Eli Cohen > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c

Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-16 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 02:45:40PM +0200, Eli Cohen wrote: > On Tue, Feb 16, 2021 at 09:37:34AM +0200, Leon Romanovsky wrote: > > On Tue, Feb 16, 2021 at 08:42:26AM +0200, Eli Cohen wrote: > > > On Tue, Feb 16, 2021 at 08:35:51AM +0200, Leon Romanovsky wrote: > > > >

Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter

2021-09-07 Thread Leon Romanovsky
On Sun, Sep 05, 2021 at 11:15:16AM -0400, Michael S. Tsirkin wrote: > On Sun, Sep 05, 2021 at 01:20:24PM +0300, Leon Romanovsky wrote: > > On Sun, Sep 05, 2021 at 01:49:46AM -0700, Chaitanya Kulkarni wrote: > > > > > > On 9/5/2021 12:46 AM, Leon Romanovsky wrote: >

Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter

2021-09-05 Thread Leon Romanovsky
On Sun, Sep 05, 2021 at 02:16:58PM +0300, Max Gurtovoy wrote: > > On 9/5/2021 1:19 PM, Leon Romanovsky wrote: > > On Sun, Sep 05, 2021 at 12:19:09PM +0300, Max Gurtovoy wrote: > > > On 9/5/2021 11:49 AM, Chaitanya Kulkarni wrote: > > > > On 9/5/202

Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter

2021-09-05 Thread Leon Romanovsky
On Thu, Sep 02, 2021 at 11:46:22PM +0300, Max Gurtovoy wrote: > Sometimes a user would like to control the amount of request queues to > be created for a block device. For example, for limiting the memory > footprint of virtio-blk devices. > > Reviewed-by: Christoph Hellwig > Reviewed-by: Stefan

Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter

2021-09-05 Thread Leon Romanovsky
On Sun, Sep 05, 2021 at 12:19:09PM +0300, Max Gurtovoy wrote: > > On 9/5/2021 11:49 AM, Chaitanya Kulkarni wrote: > > > > On 9/5/2021 12:46 AM, Leon Romanovsky wrote: > > > > +static unsigned int num_request_queues; > > > > +module_param_cb(num_request_q

Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter

2021-09-05 Thread Leon Romanovsky
On Sun, Sep 05, 2021 at 01:49:46AM -0700, Chaitanya Kulkarni wrote: > > On 9/5/2021 12:46 AM, Leon Romanovsky wrote: > > > +static unsigned int num_request_queues; > > > +module_param_cb(num_request_queues, _count_ops, > > > _request_queues, > > >

Re: [PATCH mlx5-next 1/5] RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key

2021-07-29 Thread Leon Romanovsky
On Thu, Jul 29, 2021 at 12:28:03PM -0300, Jason Gunthorpe wrote: > On Tue, Jun 22, 2021 at 03:08:19PM +0300, Leon Romanovsky wrote: > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/mr.c > > b/drivers/net/ethernet/mellanox/mlx5/core/mr.c > > index 50af84e76

Re: [PATCH mlx5-next 1/7] RDMA/mlx5: Don't set esc_size in user mr

2021-10-12 Thread Leon Romanovsky
On Tue, Oct 12, 2021 at 11:04:33AM -0300, Jason Gunthorpe wrote: > On Tue, Oct 12, 2021 at 04:57:16PM +0300, Aharon Landau wrote: > > > > On 10/12/2021 3:52 PM, Jason Gunthorpe wrote: > > > On Tue, Oct 12, 2021 at 01:26:29PM +0300, Leon Romanovsky wrote: >

[PATCH mlx5-next 0/7] Clean MR key use across mlx5_* modules

2021-10-12 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This is cleanup series of mlx5_* MR mkey management. Thanks Aharon Landau (7): RDMA/mlx5: Don't set esc_size in user mr RDMA/mlx5: Remove iova from struct mlx5_core_mkey RDMA/mlx5: Remove size from struct mlx5_core_mkey RDMA/mlx5: Remove pd from struct

[PATCH mlx5-next 5/7] RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key

2021-10-12 Thread Leon Romanovsky
Reviewed-by: Shay Drory Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/mr.c | 21 -- drivers/infiniband/hw/mlx5/odp.c | 2 +- .../mellanox/mlx5/core/diag/fw_tracer.c | 6 ++--- .../mellanox/mlx5/core/diag/fw_tracer.h | 2

[PATCH mlx5-next 3/7] RDMA/mlx5: Remove size from struct mlx5_core_mkey

2021-10-12 Thread Leon Romanovsky
From: Aharon Landau mkey->size is already stored in ibmr->length, no need to store it here. Signed-off-by: Aharon Landau Reviewed-by: Shay Drory Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/devx.c| 1 - drivers/infiniband/hw/mlx5/mr.c

[PATCH mlx5-next 1/7] RDMA/mlx5: Don't set esc_size in user mr

2021-10-12 Thread Leon Romanovsky
lated items in the mlx5_ib_mr") Signed-off-by: Aharon Landau Reviewed-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/mr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index 9091de381e83..0ff

[PATCH mlx5-next 2/7] RDMA/mlx5: Remove iova from struct mlx5_core_mkey

2021-10-12 Thread Leon Romanovsky
From: Aharon Landau iova is already stored in ibmr->iova, no need to store it here. Signed-off-by: Aharon Landau Reviewed-by: Shay Drory Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/devx.c| 1 - drivers/infiniband/hw/mlx5/mr.c |

[PATCH mlx5-next 7/7] RDMA/mlx5: Attach ndescs to mlx5_ib_mkey

2021-10-12 Thread Leon Romanovsky
From: Aharon Landau Generalize the use of ndescs by adding it to mlx5_ib_mkey. Signed-off-by: Aharon Landau Reviewed-by: Shay Drory Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/devx.c| 10 -- drivers/infiniband/hw/mlx5/devx.h| 2 +- drivers/infiniband/hw

[PATCH mlx5-next 6/7] RDMA/mlx5: Move struct mlx5_core_mkey to mlx5_ib

2021-10-12 Thread Leon Romanovsky
From: Aharon Landau Move mlx5_core_mkey struct to mlx5_ib, as the mlx5_core doesn't use it at this point. Signed-off-by: Aharon Landau Reviewed-by: Shay Drory Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/devx.c| 2 +- drivers/infiniband/hw/mlx5/mlx5_ib.h | 25

[PATCH mlx5-next 4/7] RDMA/mlx5: Remove pd from struct mlx5_core_mkey

2021-10-12 Thread Leon Romanovsky
From: Aharon Landau There is no read of mkey->pd, only write. Remove it. Signed-off-by: Aharon Landau Reviewed-by: Shay Drory Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/devx.c| 1 - drivers/infiniband/hw/mlx5/mr.c | 3 --- drivers/net/ether

Re: [PATCH mlx5-next 0/7] Clean MR key use across mlx5_* modules

2021-10-19 Thread Leon Romanovsky
On Wed, Oct 13, 2021 at 11:43:03AM -0300, Jason Gunthorpe wrote: > On Tue, Oct 12, 2021 at 01:26:28PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Hi, > > > > This is cleanup series of mlx5_* MR mkey management. > > > > Thank

Re: [PATCH 2/2] virtio-blk: set NUMA affinity for a tagset

2021-09-27 Thread Leon Romanovsky
On Sun, Sep 26, 2021 at 05:55:18PM +0300, Max Gurtovoy wrote: > To optimize performance, set the affinity of the block device tagset > according to the virtio device affinity. > > Signed-off-by: Max Gurtovoy > --- > drivers/block/virtio_blk.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 2/2] virtio-blk: set NUMA affinity for a tagset

2021-09-28 Thread Leon Romanovsky
On Tue, Sep 28, 2021 at 06:59:15PM +0300, Max Gurtovoy wrote: > > On 9/27/2021 9:23 PM, Leon Romanovsky wrote: > > On Mon, Sep 27, 2021 at 08:25:09PM +0300, Max Gurtovoy wrote: > > > On 9/27/2021 2:34 PM, Leon Romanovsky wrote: > > > > On Sun, Sep 26, 2021 at 05:

Re: [PATCH 2/2] virtio-blk: set NUMA affinity for a tagset

2021-09-29 Thread Leon Romanovsky
On Wed, Sep 29, 2021 at 02:28:08AM +0300, Max Gurtovoy wrote: > > On 9/28/2021 7:27 PM, Leon Romanovsky wrote: > > On Tue, Sep 28, 2021 at 06:59:15PM +0300, Max Gurtovoy wrote: > > > On 9/27/2021 9:23 PM, Leon Romanovsky wrote: > > > > On Mon, Sep 27, 2021 at 08:

Re: [RFC 0/5] VirtIO RDMA

2021-09-22 Thread Leon Romanovsky
On Wed, Sep 22, 2021 at 08:08:44PM +0800, Junji Wei wrote: > > On Sep 15, 2021, at 9:43 PM, Jason Gunthorpe wrote: <...> > >> 4. The FRMR api need to set key of MR through IB_WR_REG_MR. > >> But it is impossible to change a key of mr using uverbs. > > > > FRMR is more like memory windows in

Re: Re: [RFC 0/5] VirtIO RDMA

2021-09-22 Thread Leon Romanovsky
On Wed, Sep 22, 2021 at 09:37:37PM +0800, 魏俊吉 wrote: > On Wed, Sep 22, 2021 at 9:06 PM Leon Romanovsky wrote: > > > > On Wed, Sep 22, 2021 at 08:08:44PM +0800, Junji Wei wrote: > > > > On Sep 15, 2021, at 9:43 PM, Jason Gunthorpe wrote: > > > > <...>

Re: [PATCH 2/2] virtio-blk: set NUMA affinity for a tagset

2021-09-27 Thread Leon Romanovsky
On Mon, Sep 27, 2021 at 08:25:09PM +0300, Max Gurtovoy wrote: > > On 9/27/2021 2:34 PM, Leon Romanovsky wrote: > > On Sun, Sep 26, 2021 at 05:55:18PM +0300, Max Gurtovoy wrote: > > > To optimize performance, set the affinity of the block device tagset > > > according

[PATCH mlx5-next] IB/mlx5: Rename is_apu_thread_cq function to is_apu_cq

2021-07-18 Thread Leon Romanovsky
was first introduced. Signed-off-by: Tal Gilboa Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/cq.c| 2 +- drivers/infiniband/hw/mlx5/devx.c | 7 +++ drivers/net/ethernet/mellanox/mlx5/core/cq.c | 3 ++- drivers/net

Re: [PATCH mlx5-next] IB/mlx5: Rename is_apu_thread_cq function to is_apu_cq

2021-07-25 Thread Leon Romanovsky
On Sun, Jul 18, 2021 at 02:54:13PM +0300, Leon Romanovsky wrote: > From: Tal Gilboa > > is_apu_thread_cq() used to detect CQs which are attached to APU > threads. This was extended to support other elements as well, > so the function was renamed to is_apu_cq(). > >

Re: [PATCH v2] MAINTAINERS: Update for VMCI driver

2021-07-25 Thread Leon Romanovsky
On Wed, Jul 21, 2021 at 03:02:46AM -0700, Jorgen Hansen wrote: > Add maintainer info for the VMware VMCI driver. > > v2: moved pv-drivers to L: as private list Please put changelog under "---". There is no value to see vXXX in the final commit in the repo. Thanks > > Acked-by: Vishnu Dasa >

Re: [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use

2022-03-09 Thread Leon Romanovsky
On Tue, Mar 08, 2022 at 09:57:57AM +0100, Greg KH wrote: > On Tue, Mar 08, 2022 at 08:10:06AM +, Lee Jones wrote: > > On Mon, 07 Mar 2022, Greg KH wrote: > > > > > On Mon, Mar 07, 2022 at 07:17:57PM +, Lee Jones wrote: > > > > vhost_vsock_handle_tx_kick() already holds the mutex during

Re: [PATCH 1/1] vhost: Provide a kernel warning if mutex is held whilst clean-up in progress

2022-03-03 Thread Leon Romanovsky
On Thu, Mar 03, 2022 at 03:19:29PM +, Lee Jones wrote: > All workers/users should be halted before any clean-up should take place. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Lee Jones > --- > drivers/vhost/vhost.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH 1/1] vhost: Provide a kernel warning if mutex is held whilst clean-up in progress

2022-03-03 Thread Leon Romanovsky
On Thu, Mar 03, 2022 at 04:01:06PM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 03, 2022 at 09:14:36PM +0200, Leon Romanovsky wrote: > > On Thu, Mar 03, 2022 at 03:19:29PM +, Lee Jones wrote: > > > All workers/users should be halted before any clean-up

Re: [PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit

2022-03-24 Thread Leon Romanovsky
igned-off-by: Randy Dunlap > Cc: Eli Cohen > Cc: Saeed Mahameed > Cc: net...@vger.kernel.org > Cc: Leon Romanovsky > Cc: linux-r...@vger.kernel.org > --- > drivers/net/ethernet/mellanox/mlx5/core/main.c |8 ++++ > 1 file changed, 4 insertions(+), 4 deletions(-) >

Re: [PATCH vhost v2 00/16] vdpa: Add support for vq descriptor mappings

2023-10-02 Thread Leon Romanovsky
On Thu, Sep 28, 2023 at 07:45:11PM +0300, Dragos Tatulea wrote: > This patch series adds support for vq descriptor table mappings which > are used to improve vdpa live migration downtime. The improvement comes > from using smaller mappings which take less time to create and destroy > in hw. > >

Re: (subset) [PATCH vhost v2 00/16] vdpa: Add support for vq descriptor mappings

2023-10-02 Thread Leon Romanovsky
y > in hw. > > The first part adds the vdpa core changes from Si-Wei [0]. > > [...] Applied, thanks! [01/16] vdpa/mlx5: Expose descriptor group mkey hw capability https://git.kernel.org/rdma/rdma/c/d424348b060d87 Best rega

Re: [PATCH] net: move from strlcpy with unused retval to strscpy

2022-08-21 Thread Leon Romanovsky
ool.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- > .../ethernet/mellanox/mlx5/core/ipoib/ethtool.c | 2 +- Thanks, Reviewed-by: Leon Romanovsky ___ Virtualization mailing list Virtualization@lists.linux-foundation.

Re: [RFC PATCH net-next 10/19] pds_core: devlink params for enabling VIF support

2022-11-29 Thread Leon Romanovsky
On Mon, Nov 28, 2022 at 03:39:22PM -0800, Jakub Kicinski wrote: > On Tue, 29 Nov 2022 00:29:42 +0100 Andrew Lunn wrote: > > > How about: > > > DEVLINK_PARAM_GENERIC_ID_ENABLE_LIVE_MIGRATION > > > > Much better. > > +1, although I care much less about the define name which is stupidly > long

Re: [PATCH] vhost: Add uAPI for Vhost SCMI backend

2023-02-13 Thread Leon Romanovsky
On Mon, Feb 13, 2023 at 10:04:17AM +0530, Neeraj Upadhyay wrote: > Add a uAPI for starting and stopping a SCMI vhost based > backend. > > Signed-off-by: Neeraj Upadhyay > --- > > SCMI Vhost backend implementation is work in progress: >