Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces

2019-04-19 Thread Liran Alon
> On 6 Mar 2019, at 23:42, si-wei liu wrote: > > > > On 3/6/2019 1:36 PM, Samudrala, Sridhar wrote: >> >> On 3/6/2019 1:26 PM, si-wei liu wrote: >>> >>> >>> On 3/6/2019 4:04 AM, Jiri Pirko wrote: > --- a/net/core/failover.c > +++ b/net/core/failover.c > @@ -16,6 +16,11 @@

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
Hi Michael, Great blog-post which summarise everything very well! Some comments I have: 1) I think that when we are using the term “1-netdev model” on community discussion, we tend to refer to what you have defined in blog-post as "3-device model with hidden slaves”. Therefore, I would

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 0:10, Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2019 at 11:43:41PM +0200, Liran Alon wrote: >> >> >>> On 20 Mar 2019, at 16:09, Michael S. Tsirkin wrote: >>> >>> On Wed, Mar 20, 2019 at 02:23:36PM +0200, Liran Alon w

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 20 Mar 2019, at 12:25, Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2019 at 01:25:58AM +0200, Liran Alon wrote: >> >> >>> On 19 Mar 2019, at 23:19, Michael S. Tsirkin wrote: >>> >>> On Tue, Mar 19, 2019 at 08:46:47AM -0700, Stephen He

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 19 Mar 2019, at 23:19, Michael S. Tsirkin wrote: > > On Tue, Mar 19, 2019 at 08:46:47AM -0700, Stephen Hemminger wrote: >> On Tue, 19 Mar 2019 14:38:06 +0200 >> Liran Alon wrote: >> >>> b.3) cloud-init: If configured to perform network-configuratio

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 20 Mar 2019, at 16:09, Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2019 at 02:23:36PM +0200, Liran Alon wrote: >> >> >>> On 20 Mar 2019, at 12:25, Michael S. Tsirkin wrote: >>> >>> On Wed, Mar 20, 2019 at 01:25:58AM +0200, Liran Alon w

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 10:58, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 12:19:22AM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 0:10, Michael S. Tsirkin wrote: >>> >>> On Wed, Mar 20, 2019 at 11:43:41PM +0200, Liran Alon w

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-04-19 Thread Liran Alon
> On 28 Feb 2019, at 1:50, Michael S. Tsirkin wrote: > > On Wed, Feb 27, 2019 at 03:34:56PM -0800, si-wei liu wrote: >> >> >> On 2/27/2019 2:38 PM, Michael S. Tsirkin wrote: >>> On Tue, Feb 26, 2019 at 04:17:21PM -0800, si-wei liu wrote: On 2/25/2019 6:08 PM, Michael S. Tsirkin

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 15:51, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 03:24:39PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 15:12, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 03:04:37PM +0200, Liran Alon w

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 17:50, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen Hemminger wrote: >> On Thu, 21 Mar 2019 15:04:37 +0200 >> Liran Alon wrote: >> >>>> >>>> OK. Now what happens if master is

Re: [PATCH net v2] failover: allow name change on IFF_UP slave interfaces

2019-04-19 Thread Liran Alon
ch can be fixed specifically to work with the new naming >> behavior of failover slaves. Userspace component interacting with >> slaves should be changed to operate on failover master instead, as the >> failover slave is dynamic in nature which may come and go at any point. >>

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 15:12, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 03:04:37PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 14:57, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 02:47:50PM +0200, Liran Alon w

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 14:57, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 02:47:50PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 14:37, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 12:07:57PM +0200, Liran

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 14:37, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 12:07:57PM +0200, Liran Alon wrote: >>>>>> 2) It brings non-intuitive customer experience. For example, a customer >>>>>> may attempt to analyse connectivity issue

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 19:12, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 06:31:35PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 17:50, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen He