Re: [PATCH v2 3/6] powerpc/smp: Move shared_processor static key to smp.h

2023-10-20 Thread Michael Ellerman
Srikar Dronamraju writes: > * Michael Ellerman [2023-10-19 15:41:40]: > >> Srikar Dronamraju writes: >> > The ability to detect if the system is running in a shared processor >> > mode is helpful in few more generic cases not just in >> > paravirtual

Re: [PATCH v2 3/6] powerpc/smp: Move shared_processor static key to smp.h

2023-10-18 Thread Michael Ellerman
Srikar Dronamraju writes: > The ability to detect if the system is running in a shared processor > mode is helpful in few more generic cases not just in > paravirtualization. > For example: At boot time, different scheduler/ topology flags may be > set based on the processor mode. Hence move it

Re: [PATCH v2] powerpc/paravirt: Improve vcpu_is_preempted

2023-10-18 Thread Michael Ellerman
Hi Srikar, Srikar Dronamraju writes: > PowerVM Hypervisor dispatches on a whole core basis. In a shared LPAR, a > CPU from a core that is CEDED or preempted may have a larger latency. In > such a scenario, its preferable to choose a different CPU to run. > > If one of the CPUs in the core is

Re: [PATCH] virtio_pci: use irq to detect interrupt support

2022-10-12 Thread Michael Ellerman
her platforms that use of_irq_parse_and_map_pci(). > > However Linus said: > The correct way to check for "no irq" doesn't use NO_IRQ at all, it > just does > if (dev->irq) ... > so let's just check irq and be done with it. > > Suggested-by: Lin

Re: [GIT PULL] virtio: fixes, features

2022-10-12 Thread Michael Ellerman
Michael Ellerman writes: > [ Cc += Bjorn & linux-pci ] > > "Michael S. Tsirkin" writes: >> On Wed, Oct 12, 2022 at 05:21:24PM +1100, Michael Ellerman wrote: >>> "Michael S. Tsirkin" writes: > ... >>> > -

Re: [PATCH] virtio_pci: read interrupt pin directly

2022-10-12 Thread Michael Ellerman
other platforms that use of_irq_parse_and_map_pci(). > > Work around the issue in virtio for now, and let's try to fix > all affected pci systems and then we can revert this. > > Reported-by: Michael Ellerman > Fixes: 71491c54eafa ("virtio_pci: don't try to use intxif pin

Re: [GIT PULL] virtio: fixes, features

2022-10-12 Thread Michael Ellerman
[ Cc += Bjorn & linux-pci ] "Michael S. Tsirkin" writes: > On Wed, Oct 12, 2022 at 05:21:24PM +1100, Michael Ellerman wrote: >> "Michael S. Tsirkin" writes: ... >> > >> > virtio:

Re: [GIT PULL] virtio: fixes, features

2022-10-12 Thread Michael Ellerman
"Michael S. Tsirkin" writes: > The following changes since commit 4fe89d07dcc2804c8b562f6c7896a45643d34b2f: > > Linux 6.0 (2022-10-02 14:09:07 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus > > for you to

Re: [GIT PULL] virtio: last minute fixup

2022-05-12 Thread Michael Ellerman
Linus Torvalds writes: > On Wed, May 11, 2022 at 3:12 AM Michael Ellerman wrote: >> >> Which I read as you endorsing Link: tags :) > > I absolutely adore "Link:" tags. They've been great. > > But they've been great for links that are *usedful*.

Re: [GIT PULL] virtio: last minute fixup

2022-05-11 Thread Michael Ellerman
Konstantin Ryabitsev writes: ... > > I think we should simply disambiguate the trailer added by tooling like b4. > Instead of using Link:, it can go back to using Message-Id, which is already > standard with git -- it's trivial for git.kernel.org to link them to > lore.kernel.org. But my mailer,

Re: [GIT PULL] virtio: last minute fixup

2022-05-11 Thread Michael Ellerman
Linus Torvalds writes: > On Tue, May 10, 2022 at 5:24 AM Michael S. Tsirkin wrote: >> >> A last minute fixup of the transitional ID numbers. >> Important to get these right - if users start to depend on the >> wrong ones they are very hard to fix. > > Hmm. I've pulled this, but those numbers

Re: update_balloon_size_func blocked for more than 120 seconds

2021-11-23 Thread Michael Ellerman
David Hildenbrand writes: > On Thu, Nov 11, 2021 at 11:49 PM Luis Chamberlain wrote: >> >> I get the following splats with a kvm guest in idle, after a few seconds >> it starts: >> >> [ 242.412806] INFO: task kworker/6:2:271 blockedfor more than 120 seconds. >> [ 242.415790] Tainted: G

Re: [PATCH V5 1/4] virtio_ring: validate used buffer length

2021-11-23 Thread Michael Ellerman
"Michael S. Tsirkin" writes: > On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote: >> On Tue, Nov 23, 2021 at 4:24 AM Halil Pasic wrote: >> > >> > On Mon, 22 Nov 2021 14:25:26 +0800 >> > Jason Wang wrote: >> > >> > > I think the fixes are: >> > > >> > > 1) fixing the vhost vsock >> > >

Re: [PATCH v8 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-08-20 Thread Michael Ellerman
Daniel Axtens writes: > Xianting Tian writes: > >> As well known, hvc backend driver(eg, virtio-console) can register its >> operations to hvc framework. The operations can contain put_chars(), >> get_chars() and so on. >> >> Some hvc backend may do dma in its operations. eg, put_chars() of >>

Re: [PATCH v1 05/12] mm/memory_hotplug: remove nid parameter from remove_memory() and friends

2021-06-08 Thread Michael Ellerman
get that big. > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: Dan Williams > Cc: Vishal Verma > Cc: Dave Jiang > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Andre

Re: [PATCH v1 04/12] mm/memory_hotplug: remove nid parameter from arch_remove_memory()

2021-06-08 Thread Michael Ellerman
David Hildenbrand writes: > The parameter is unused, let's remove it. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger &g

Re: [PATCH v2 3/7] mm/memory_hotplug: prepare passing flags to add_memory() and friends

2020-09-09 Thread Michael Ellerman
David Hildenbrand writes: > On 09.09.20 09:17, Greg Kroah-Hartman wrote: >> On Tue, Sep 08, 2020 at 10:10:08PM +0200, David Hildenbrand wrote: >>> We soon want to pass flags, e.g., to mark added System RAM resources. >>> mergeable. Prepare for that. >> >> What are these random "flags", and how

Re: [PATCH v3 5/6] powerpc/pseries: implement paravirt qspinlocks for SPLPAR

2020-07-09 Thread Michael Ellerman
Nicholas Piggin writes: > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/include/asm/paravirt.h | 28 > arch/powerpc/include/asm/qspinlock.h | 66 +++ > arch/powerpc/include/asm/qspinlock_paravirt.h | 7 ++ >

Re: [PATCH v3 4/6] powerpc/64s: implement queued spinlocks and rwlocks

2020-07-09 Thread Michael Ellerman
Nicholas Piggin writes: > These have shown significantly improved performance and fairness when > spinlock contention is moderate to high on very large systems. > > [ Numbers hopefully forthcoming after more testing, but initial >results look good ] Would be good to have something here,

Re: [PATCH v3 3/6] powerpc: move spinlock implementation to simple_spinlock

2020-07-09 Thread Michael Ellerman
Nicholas Piggin writes: > To prepare for queued spinlocks. This is a simple rename except to update > preprocessor guard name and a file reference. > > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/include/asm/simple_spinlock.h| 292 ++ >

Re: [PATCH v3 2/6] powerpc/pseries: move some PAPR paravirt functions to their own file

2020-07-09 Thread Michael Ellerman
Nicholas Piggin writes: > Little bit of changelog would be nice :D > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/include/asm/paravirt.h | 61 + > arch/powerpc/include/asm/spinlock.h | 24 +--- > arch/powerpc/lib/locks.c| 12 +++--- > 3

Re: [PATCH v3 1/6] powerpc/powernv: must include hvcall.h to get PAPR defines

2020-07-09 Thread Michael Ellerman
Nicholas Piggin writes: > An include goes away in future patches which breaks compilation > without this. > > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/platforms/powernv/pci-ioda-tce.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 5/8] powerpc/64s: implement queued spinlocks and rwlocks

2020-07-03 Thread Michael Ellerman
Nicholas Piggin writes: > Excerpts from Will Deacon's message of July 2, 2020 8:35 pm: >> On Thu, Jul 02, 2020 at 08:25:43PM +1000, Nicholas Piggin wrote: >>> Excerpts from Will Deacon's message of July 2, 2020 6:02 pm: >>> > On Thu, Jul 02, 2020 at 05:48:36PM +1000, Nicholas Piggin wrote: >>> >>

Re: [PATCH] iommu: spapr_tce: Disable compile testing to fix build on book3s_32 config

2020-04-19 Thread Michael Ellerman
Christophe Leroy writes: > On 04/14/2020 02:26 PM, Krzysztof Kozlowski wrote: >> Although SPAPR_TCE_IOMMU itself can be compile tested on certain PowerPC >> configurations, its presence makes arch/powerpc/kvm/Makefile to select >> modules which do not build in such configuration. >> >> The

Re: Build regressions/improvements in v5.7-rc1

2020-04-14 Thread Michael Ellerman
Geert Uytterhoeven writes: > On Mon, 13 Apr 2020, Geert Uytterhoeven wrote: >> Below is the list of build error/warning regressions/improvements in >> v5.7-rc1[1] compared to v5.6[2]. >> >> Summarized: >> - build errors: +132/-3 >> - build warnings: +257/-79 >> >> Happy fixing! ;-) >> >> Thanks

Re: [PATCH] vhost: do not enable VHOST_MENU by default

2020-04-13 Thread Michael Ellerman
quot;. So this patch tries to enable CONFIG_VHOST explicitly in > defconfigs that enables CONFIG_VHOST_NET and CONFIG_VHOST_VSOCK. > > Cc: Thomas Bogendoerfer > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Heiko Carstens > Cc: Vasily

Re: [RESEND PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation)

2020-03-12 Thread Michael Ellerman
oid *dst, unsigned long count) > { > readsb(addr, dst, count); > } > -void ioread16_rep(void __iomem *addr, void *dst, unsigned long count) > +void ioread16_rep(const void __iomem *addr, void *dst, unsigned long count) > { > readsw(addr, dst, count); > } &g

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-13 Thread Michael Ellerman
Randy Dunlap <rdun...@infradead.org> writes: > On 02/12/2018 04:28 AM, Michael Ellerman wrote: >> Randy Dunlap <rdun...@infradead.org> writes: >> >>> From: Randy Dunlap <rdun...@infradead.org> >>> >>> Currently #includes for no o

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-12 Thread Michael Ellerman
Randy Dunlap writes: > From: Randy Dunlap > > Currently #includes for no obvious > reason. It looks like it's only a convenience, so remove kmemleak.h > from slab.h and add to any users of kmemleak_* > that don't already #include it. > Also

Re: Ping Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all

2018-01-28 Thread Michael Ellerman
Vincent Legoll <vincent.leg...@gmail.com> writes: > On 1/23/18, Michael Ellerman <m...@ellerman.id.au> wrote: >> This has been broken in linux-next for ~6 weeks now, can we please merge >> this and get it fixed. > > Added Stephen Rothwell to cc It should b

Ping Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all

2018-01-22 Thread Michael Ellerman
Vincent Legoll writes: > No need to get into the submenu to disable all VIRTIO-related > config entries. > > This makes it easier to disable all VIRTIO config options > without entering the submenu. It will also enable one > to see that en/dis-abled state from the

Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all

2018-01-02 Thread Michael Ellerman
Michael Ellerman <m...@ellerman.id.au> writes: > Vincent Legoll <vincent.leg...@gmail.com> writes: > >> Hello, >> >> thanks for the help, and sorry for the poor patch, >> >> On Thu, Dec 21, 2017 at 11:53 AM, Michael Ellerman <m...@ellerman.id.a

Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all

2017-12-21 Thread Michael Ellerman
Vincent Legoll <vincent.leg...@gmail.com> writes: > Hello, > > thanks for the help, and sorry for the poor patch, > > On Thu, Dec 21, 2017 at 11:53 AM, Michael Ellerman <m...@ellerman.id.au> > wrote: >> This breaks all existing .configs *and* defconfigs th

Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all

2017-12-21 Thread Michael Ellerman
Vincent Legoll writes: > No need to get into the submenu to disable all VIRTIO-related > config entries. > > This makes it easier to disable all VIRTIO config options > without entering the submenu. It will also enable one > to see that en/dis-abled state from the

Re: Memory corruption in powerpc guests with virtio_balloon (was Re: [PATCH v3] virtio_balloon: fix deadlock on OOM)

2017-12-03 Thread Michael Ellerman
"Michael S. Tsirkin" <m...@redhat.com> writes: > On Fri, Dec 01, 2017 at 11:31:08PM +1100, Michael Ellerman wrote: >> "Michael S. Tsirkin" <m...@redhat.com> writes: >> >> > fill_balloon doing memory allocations under balloon_lock &g

Memory corruption in powerpc guests with virtio_balloon (was Re: [PATCH v3] virtio_balloon: fix deadlock on OOM)

2017-12-01 Thread Michael Ellerman
"Michael S. Tsirkin" writes: > fill_balloon doing memory allocations under balloon_lock > can cause a deadlock when leak_balloon is called from > virtballoon_oom_notify and tries to take same lock. > > To fix, split page allocation and enqueue and do allocations outside the

Re: [PATCH v7 6/6] powerpc: pSeries: Add pv-qspinlock build config/make

2016-09-25 Thread Michael Ellerman
xinhui writes: > hi, all > ok, this patch set depends on > https://patchwork.kernel.org/patch/8953981/ [V4] powerpc: Implement {cmp}xchg > for u8 and u16 AKA: https://patchwork.ozlabs.org/patch/615480/ Sorry I saw the discussion on that and thought there'd

Re: [PATCH v3 3/3] Use separate struct console structure for each hvc_console.

2011-11-09 Thread Michael Ellerman
On Tue, 2011-11-08 at 13:45 -0800, Miche Baker-Harvey wrote: It is possible to make any virtio_console port be a console by sending VIRITO_CONSOLE_CONSOLE_PORT. But hvc_alloc was using a single struct console hvc_console, which contains both an index and flags which are per-port. This adds

Re: Extending virtio_console to support multiple ports

2009-08-26 Thread Michael Ellerman
On Wed, 2009-08-26 at 21:15 +0530, Amit Shah wrote: [cc'ing some people who have made some commits in hvc_console.c] On (Wed) Aug 26 2009 [16:57:18], Amit Shah wrote: On (Tue) Aug 25 2009 [11:47:20], Amit Shah wrote: Hello all, Here is a new iteration of the patch series that

Re: [PATCH] msi-x: let drivers retry when not enough vectors

2009-05-07 Thread Michael Ellerman
On Fri, 2009-05-08 at 09:25 +0930, Rusty Russell wrote: On Thu, 7 May 2009 07:49:53 pm Sheng Yang wrote: On Thursday 07 May 2009 17:53:02 Matthew Wilcox wrote: Here's a good example. Let's suppose you have a driver which supports two different models of cards, one has 16 MSI-X