from restricted __virtio16
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index c06c02704461..2466d5087478 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -808,7
The simulator behaves like a ramdisk, so we don't have to do
anything when a VIRTIO_BLK_T_FLUSH request is received, but it
could be useful to test driver behavior.
Let's expose the VIRTIO_BLK_F_FLUSH feature to inform the driver
that we support the flush command.
Signed-off-by: Stefano
sets to 0 the
specified region.
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 74 +++-
1 file changed, 73 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
index
in vdpasim_blk_check_range()
to avoid duplicate prints.
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 38 +---
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
VIRTIO spec states: "The sector number indicates the offset
(multiplied by 512) where the read or write is to occur. This field is
unused and set to 0 for commands other than read or write."
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 10
://lore.kernel.org/virtualization/20220810094347.20449-1-sgarz...@redhat.com/
v1:
https://lore.kernel.org/virtualization/20220428151242.213824-1-sgarz...@redhat.com/
Tree available here:
https://gitlab.com/sgarzarella/linux.git vdpa-sim-blk-flush-discard-wz
Thanks,
Stefano
Stefano Garzarella (4
sets to 0 the
specified region.
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 74 +++-
1 file changed, 73 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
index
The simulator behaves like a ramdisk, so we don't have to do
anything when a VIRTIO_BLK_T_FLUSH request is received, but it
could be useful to test driver behavior.
Let's expose the VIRTIO_BLK_F_FLUSH feature to inform the driver
that we support the flush command.
Signed-off-by: Stefano
in vdpasim_blk_check_range()
to avoid duplicate prints.
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 38 +---
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
VIRTIO spec states: "The sector number indicates the offset
(multiplied by 512) where the read or write is to occur. This field is
unused and set to 0 for commands other than read or write."
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 10
available here:
https://gitlab.com/sgarzarella/linux.git vdpa-sim-blk-flush-discard-wz
Thanks,
Stefano
Stefano Garzarella (4):
vdpa_sim_blk: check if sector is 0 for commands other than read or
write
vdpa_sim_blk: make vdpasim_blk_check_range usable by other requests
vdpa_sim_blk: add
On Tue, Aug 09, 2022 at 09:45:47AM +, Arseniy Krasnov wrote:
On 09.08.2022 12:37, Arseniy Krasnov wrote:
On 08.08.2022 13:30, Stefano Garzarella wrote:
On Mon, Aug 8, 2022 at 12:23 PM Stefano Garzarella wrote:
On Wed, Aug 03, 2022 at 01:51:05PM +, Arseniy Krasnov wrote:
This adds
Hi Arseniy,
On Wed, Aug 03, 2022 at 01:48:06PM +, Arseniy Krasnov wrote:
Hello,
This patchset includes some updates for SO_RCVLOWAT:
I have reviewed all the patches, run tests and everything seems okay :-)
I left some minor comments and asked Bryan and Vishnu to take a better
look at
On Wed, Aug 03, 2022 at 02:07:58PM +, Arseniy Krasnov wrote:
This adds test to check,that when poll() returns POLLIN,POLLRDNORM bits,
next read call won't block.
Signed-off-by: Arseniy Krasnov
---
tools/testing/vsock/vsock_test.c | 107 +++
1 file changed, 107
macro on both server and client functions, I suggest
to move this define outside the function.
Other than that the test LGTM. I also ran it and everything is fine :-)
thanks for adding it!
Reviewed-by: Stefano Garzarella
___
Virtualization mailing
On Wed, Aug 03, 2022 at 02:05:52PM +, Arseniy Krasnov wrote:
This adds extra condition to wake up data reader: do it only when number
of readable bytes >= SO_RCVLOWAT. Otherwise, there is no sense to kick
user,because it will wait until SO_RCVLOWAT bytes will be dequeued.
Ditto as previous
can mention that these are done in vsock_data_ready().
Anyway, the patch LGTM:
Reviewed-by: Stefano Garzarella
Signed-off-by: Arseniy Krasnov
---
net/vmw_vsock/virtio_transport_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/vmw_vsock/virtio_transport_common.c
b/
an RFC, I suggest you add a space after the punctuation. :-)
The patch LGTM:
Reviewed-by: Stefano Garzarella
Signed-off-by: Arseniy Krasnov
---
include/net/af_vsock.h | 1 +
net/vmw_vsock/af_vsock.c | 10 ++
2 files changed, 11 insertions(+)
diff --git a/include/net/af_vsock.h b
expected by the user.
Let's use sock_rcvlowat() to get the right target to pass to
notify_poll_in().
Anyway, the patch LGTM:
Reviewed-by: Stefano Garzarella
Signed-off-by: Arseniy Krasnov
---
net/vmw_vsock/af_vsock.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net
to sk_rcvlowat in this case.
Ditto as the previous patch.
With that fixed:
Reviewed-by: Stefano Garzarella
@Bryan, @Vishnu, if you're happy with this change, can you ack/review?
Thanks,
Stefano
Signed-off-by: Arseniy Krasnov
---
net/vmw_vsock/vmci_transport_notify.c| 8
net
to sk_rcvlowat in this case.
Little suggestion:
We should update the commit description, since so far 'target' is not
equal to sk_rcvlowat.
With that fixed (and adding some spaces after the commas):
Reviewed-by: Stefano Garzarella
Signed-off-by: Arseniy Krasnov
---
net/vmw_vsock
insertions(+)
Reviewed-by: Stefano Garzarella
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
On Mon, Aug 8, 2022 at 12:23 PM Stefano Garzarella wrote:
>
> On Wed, Aug 03, 2022 at 01:51:05PM +, Arseniy Krasnov wrote:
> >This adds transport specific callback for SO_RCVLOWAT, because in some
> >transports it may be difficult to know current available number of byte
On Wed, Aug 03, 2022 at 01:51:05PM +, Arseniy Krasnov wrote:
This adds transport specific callback for SO_RCVLOWAT, because in some
transports it may be difficult to know current available number of bytes
ready to read. Thus, when SO_RCVLOWAT is set, transport may reject it.
Signed-off-by:
nd request will return -ETIMEDOUT.
Suggested-by: Stefano Garzarella
Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
Signed-off-by: Peilin Ye
---
(new patch in v2)
Thanks for sending this :-)
Reviewed-by: Stefano Garzarella
___
Virtual
k_hold() to keep the reference count
balanced.
Reported-and-tested-by: syzbot+b03f55bf128f9a38f...@syzkaller.appspotmail.com
Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
Co-developed-by: Stefano Garzarella
Signed-off-by: Stefano Garzarella
Signed-off-by: Peilin Ye
---
On Sat, Aug 06, 2022 at 10:42:40AM +0100, Will Deacon wrote:
Hi Stefano,
On Sat, Aug 06, 2022 at 09:48:28AM +0200, Stefano Garzarella wrote:
On Fri, Aug 05, 2022 at 07:11:06PM +0100, Will Deacon wrote:
> The fundamental issue is, I think, that VIRTIO_F_ACCESS_PLATFORM is
> being used f
Hi Linus,
On Fri, Aug 05, 2022 at 03:57:08PM -0700, Linus Torvalds wrote:
On Fri, Aug 5, 2022 at 11:11 AM Will Deacon wrote:
[tl;dr a change from ~18 months ago breaks Android userspace and I don't
know what to do about it]
Augh.
I had hoped that android being "closer" to upstream would
Hi Will,
On Fri, Aug 05, 2022 at 07:11:06PM +0100, Will Deacon wrote:
Hi folks,
[tl;dr a change from ~18 months ago breaks Android userspace and I don't
know what to do about it]
As part of the development work for next year's Android, we've recently
been bringing up a 5.15 KVM host and have
Hi Arseniy,
sorry but I didn't have time to review this series. I will definitely do
it next Monday!
Have a nice weekend,
Stefano
On Wed, Aug 03, 2022 at 01:48:06PM +, Arseniy Krasnov wrote:
Hello,
This patchset includes some updates for SO_RCVLOWAT:
1) af_vsock:
During my
On Thu, Aug 04, 2022 at 04:44:47PM -0700, Peilin Ye wrote:
Hi Stefano,
On Thu, Aug 04, 2022 at 08:59:23AM +0200, Stefano Garzarella wrote:
The last thing I was trying to figure out before sending the patch was
whether to set sock->state = SS_UNCONNECTED in vsock_connect_timeout().
I think
On Wed, Aug 03, 2022 at 07:09:25PM -0700, Peilin Ye wrote:
From: Peilin Ye
An O_NONBLOCK vsock_connect() request may try to reschedule
@connect_work. Consider the following vsock_connect() requests:
1. The 1st, non-blocking request schedules @connect_work, which will
expire after, say,
On Thu, Aug 04, 2022 at 09:52:47AM +0800, Jason Wang wrote:
On Thu, Aug 4, 2022 at 1:46 AM Andrey Zhadchenko
wrote:
Hi!
Recently I sent vhost-blk patchset and Stefano suggested to instead join
efforts on developing vdpa-blk.
I played with it a bit and looks like vdpa itself pins the whole
Hi Vishnu,
On Tue, Aug 02, 2022 at 05:35:22AM +, Vishnu Dasa wrote:
On Jul 27, 2022, at 5:37 AM, Stefano Garzarella
wrote:
Hi Arseniy,
On Mon, Jul 25, 2022 at 07:54:05AM +, Arseniy Krasnov wrote:
[...]
3) vmci/vsock:
Same as 2), but i'm not sure about this changes. Will be very
On Tue, Aug 2, 2022 at 4:45 AM Zhi Guo wrote:
>
>
>
> 2022年7月22日 下午3:12,Eugenio Perez Martin 写道:
>
> On Thu, Jul 21, 2022 at 10:44 AM Guo Zhi wrote:
>
>
> Only add to used ring when a batch a buffer have all been used. And if
> in order feature negotiated, add randomness to the used buffer's
Hi Arseniy,
On Mon, Jul 25, 2022 at 07:54:05AM +, Arseniy Krasnov wrote:
Hello,
This patchset includes some updates for SO_RCVLOWAT:
1) af_vsock:
During my experiments with zerocopy receive, i found, that in some
cases, poll() implementation violates POSIX: when socket has non-
On Wed, Jul 27, 2022 at 2:22 PM Stefano Garzarella wrote:
>
> @Jorgen can you take a look at this series, especially this patch?
Jorgen's email bounced back, so I'm CCing VMCI maintainers.
Bryan, Rajesh, Vishnu, can you take a look?
Thanks,
Stefano
>
> Maybe we need to update
On Mon, Jul 25, 2022 at 08:05:28AM +, Arseniy Krasnov wrote:
This adds transport specific callback for SO_RCVLOWAT, because in some
transports it may be difficult to know current available number of bytes
ready to read. Thus, when SO_RCVLOWAT is set, transport may reject it.
Signed-off-by:
@Jorgen can you take a look at this series, especially this patch?
Maybe we need to update the comments in the else branch, something like
s/there is nothing/there is not enough data
Thanks,
Stefano
On Mon, Jul 25, 2022 at 08:01:01AM +, Arseniy Krasnov wrote:
This callback controls
On Mon, Jul 25, 2022 at 07:56:59AM +, Arseniy Krasnov wrote:
Both bits indicate, that next data read call won't be blocked, but when
sk_rcvlowat is not 1, these bits will be set by poll anyway, thus when
user tries to dequeue data,it will wait until sk_rcvlowat bytes of data
will be
On Wed, Jul 20, 2022 at 06:07:47AM +, Arseniy Krasnov wrote:
On 19.07.2022 15:58, Stefano Garzarella wrote:
On Mon, Jul 18, 2022 at 08:12:52AM +, Arseniy Krasnov wrote:
Hello,
during my experiments with zerocopy receive, i found, that in some
cases, poll() implementation violates
On Wed, Jul 20, 2022 at 05:46:01AM +, Arseniy Krasnov wrote:
On 19.07.2022 15:52, Stefano Garzarella wrote:
On Mon, Jul 18, 2022 at 08:19:06AM +, Arseniy Krasnov wrote:
This adds test to check, that when poll() returns POLLIN and
POLLRDNORM bits, next read call won't block.
Signed-off
On Wed, Jul 20, 2022 at 05:38:03AM +, Arseniy Krasnov wrote:
On 19.07.2022 15:48, Stefano Garzarella wrote:
On Mon, Jul 18, 2022 at 08:17:31AM +, Arseniy Krasnov wrote:
This callback controls setting of POLLIN,POLLRDNORM output bits
of poll() syscall,but in some cases,it is incorrectly
On Mon, Jul 18, 2022 at 08:12:52AM +, Arseniy Krasnov wrote:
Hello,
during my experiments with zerocopy receive, i found, that in some
cases, poll() implementation violates POSIX: when socket has non-
default SO_RCVLOWAT(e.g. not 1), poll() will always set POLLIN and
POLLRDNORM bits in
On Mon, Jul 18, 2022 at 08:19:06AM +, Arseniy Krasnov wrote:
This adds test to check, that when poll() returns POLLIN and
POLLRDNORM bits, next read call won't block.
Signed-off-by: Arseniy Krasnov
---
tools/testing/vsock/vsock_test.c | 90
1 file changed,
On Mon, Jul 18, 2022 at 08:17:31AM +, Arseniy Krasnov wrote:
This callback controls setting of POLLIN,POLLRDNORM output bits
of poll() syscall,but in some cases,it is incorrectly to set it,
when socket has at least 1 bytes of available data. Use 'target'
which is already exists and equal to
On Mon, Jul 18, 2022 at 08:15:42AM +, Arseniy Krasnov wrote:
Both bits indicate, that next data read call won't be blocked,
but when sk_rcvlowat is not 1,these bits will be set by poll
anyway,thus when user tries to dequeue data, it will wait until
sk_rcvlowat bytes of data will be
On Tue, Jul 12, 2022 at 04:47:10PM +0800, Jason Wang wrote:
On Tue, Jul 12, 2022 at 4:46 PM Stefano Garzarella wrote:
On Tue, Jul 12, 2022 at 04:34:11PM +0800, Jason Wang wrote:
>
>在 2022/7/5 01:16, Stefano Garzarella 写道:
>>The first 3 patches fix various problems I have
On Tue, Jul 12, 2022 at 04:34:11PM +0800, Jason Wang wrote:
在 2022/7/5 01:16, Stefano Garzarella 写道:
The first 3 patches fix various problems I have encountered with
virtio_test (they may go without this series, but I included to allow you
to test the series).
Patch 4 is in preparation
On Fri, Jul 08, 2022 at 01:38:45PM +0200, Eugenio Perez Martin wrote:
On Tue, Jun 28, 2022 at 3:43 PM Stefano Garzarella wrote:
On Thu, Jun 23, 2022 at 06:07:36PM +0200, Eugenio Pérez wrote:
>Userland knows if it can suspend the device or not by checking this feature
>bit.
>
&
Fix the build caused by the following changes:
- phys_addr_t is now defined in tools/include/linux/types.h
- dev_warn_once() is used in drivers/virtio/virtio_ring.c
- linux/uio.h included by vringh.h use INT_MAX defined in limits.h
Signed-off-by: Stefano Garzarella
---
tools/virtio/linux
On Mon, Jul 04, 2022 at 03:07:15PM -0400, Michael S. Tsirkin wrote:
On Mon, Jul 04, 2022 at 07:16:56PM +0200, Stefano Garzarella wrote:
Fix the build caused by the following changes:
- phys_addr_t is now defined in tools/include/linux/types.h
- dev_warn_once() is used in drivers/virtio
On Mon, Jul 04, 2022 at 03:06:39PM -0400, Michael S. Tsirkin wrote:
On Mon, Jul 04, 2022 at 07:16:58PM +0200, Stefano Garzarella wrote:
Commit 8b4ec69d7e09 ("virtio: harden vring IRQ") initialize vq->broken
to true, so we need to call __virtio_unbreak_device() before starting
to us
This adds a test module for vhost-vdpa infrastructure to be used
with virtio_test.
Intentionally not tied to kbuild to prevent people from installing
and loading it accidentally.
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_test.c | 203 ++
tools
-vdpa
The --reset option is not supported for now when using vhost-vdpa.
Signed-off-by: Stefano Garzarella
---
tools/virtio/virtio_test.c | 127 +++--
1 file changed, 109 insertions(+), 18 deletions(-)
diff --git a/tools/virtio/virtio_test.c b/tools/virtio
The feature negotiation are per device, so it' s better to move them
earlier in vdev_info_init() since vhost_vq_setup() contains the code
to initialize virtqueue.
Signed-off-by: Stefano Garzarella
---
tools/virtio/virtio_test.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff
Commit 8b4ec69d7e09 ("virtio: harden vring IRQ") initialize vq->broken
to true, so we need to call __virtio_unbreak_device() before starting
to use it.
Signed-off-by: Stefano Garzarella
---
tools/virtio/linux/virtio.h | 2 ++
tools/virtio/virtio_test.c | 1 +
2 files changed,
Adding $(srctree) on the included path we can build vhost_test
also when the kernel is not built in the source tree (make O=...).
Use of EXTRA_CFLAGS is deprecated, so let's use ccflags-y.
Signed-off-by: Stefano Garzarella
---
tools/virtio/vhost_test/Makefile | 2 +-
1 file changed, 1
Fix the build caused by the following changes:
- phys_addr_t is now defined in tools/include/linux/types.h
- dev_warn_once() is used in drivers/virtio/virtio_ring.c
- linux/uio.h included by vringh.h use INT_MAX defined in limits.h
Signed-off-by: Stefano Garzarella
---
tools/virtio/linux
device
$ vdpa dev add mgmtdev vdpasim_test name dev0
# run the test using the /dev/vhost-vdpa-0 device
$ ./virtio_test --vdpa /dev/vhost-vdpa-0
spurious wakeups: 0x0 started=0x10 completed=0x10
Comments and suggestions are welcome :-)
Thanks,
Stefano
Stefano Garzarella (6):
tools
Jason Wang
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
index b2d75efec63a..43422b3854d2 100644
--- a/dr
Limit the number of requests (4 per queue as for vdpa_sim_net) handled
in a batch to prevent the worker from using the CPU for too long.
Suggested-by: Eugenio Pérez
Signed-off-by: Stefano Garzarella
---
v2:
- restored previous behaviour, exiting the loop immediately if the
request
-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
index 42d401d43911..a83a5c76f620 100644
--- a/drivers/vdpa/vdpa_sim
of the guest
doing a DoS to the host.
The third makes the simulator more correct (following what we do in
vdpa_sim_net) by calling vringh_complete_iotlb() in the error path as well.
Stefano Garzarella (3):
vdpa_sim_blk: use dev_dbg() to print errors
vdpa_sim_blk: limit the number of request
On Thu, Jun 23, 2022 at 06:07:37PM +0200, Eugenio Pérez wrote:
>The ioctl adds support for suspending the device from userspace.
>
>This is a must before getting virtqueue indexes (base) for live migration,
>since the device could modify them after userland gets them. There are
>individual ways to
On Thu, Jun 23, 2022 at 06:07:36PM +0200, Eugenio Pérez wrote:
Userland knows if it can suspend the device or not by checking this feature
bit.
It's only offered if the vdpa driver backend implements the suspend()
operation callback, and to offer it or userland to ack it if the backend
does not
On Thu, Jun 23, 2022 at 06:07:35PM +0200, Eugenio Pérez wrote:
This operation is optional: It it's not implemented, backend feature bit
will not be exposed.
Signed-off-by: Eugenio Pérez
---
include/linux/vdpa.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/linux/vdpa.h
On Tue, Jun 28, 2022 at 6:01 AM Jason Wang wrote:
>
> On Thu, Jun 23, 2022 at 4:58 PM Stefano Garzarella
> wrote:
> >
> > On Thu, Jun 23, 2022 at 11:50:22AM +0800, Jason Wang wrote:
> > >On Wed, Jun 22, 2022 at 12:09 AM Stefano Garzarella
> > >wrote:
>
On Thu, Jun 23, 2022 at 11:59:56AM +0800, Jason Wang wrote:
On Thu, Jun 23, 2022 at 3:21 AM Eugenio Perez Martin
wrote:
On Wed, Jun 22, 2022 at 5:39 PM Stefano Garzarella wrote:
>
> Hi,
> while developing/testing the vdpa-blk support in libblkio [1], I
> realized that we a
extend iotlb_translate() to also return the
number of bytes successfully translated.
In copy_from_iotlb()/copy_to_iotlb() loops by calling iotlb_translate()
several times until we complete the translation.
Signed-off-by: Stefano Garzarella
---
drivers/vhost/vringh.c | 78
On Thu, Jun 23, 2022 at 11:50:22AM +0800, Jason Wang wrote:
On Wed, Jun 22, 2022 at 12:09 AM Stefano Garzarella wrote:
Limit the number of requests (4 per queue as for vdpa_sim_net) handled
in a batch to prevent the worker from using the CPU for too long.
Suggested-by: Eugenio Pérez
Signed
leak since we are not
freeing `v->vdev.vqs` during the release from the same commit.
Since vhost_vdpa_cleanup() calls vhost_dev_cleanup() we can remove its
call from vhost_vdpa_release().
Fixes: 3d5698793897 ("vhost-vdpa: introduce asid based IOTLB")
Cc: gautam.da...@xilinx.com
Call vringh_complete_iotlb() even when we encounter a serious error
that prevents us from writing the status in the "in" header
(e.g. the header length is incorrect, etc.).
The guest is misbehaving, so maybe the ring is in a bad state, but
let's avoid making things worse.
Signed-off-b
Limit the number of requests (4 per queue as for vdpa_sim_net) handled
in a batch to prevent the worker from using the CPU for too long.
Suggested-by: Eugenio Pérez
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 15 ++-
1 file changed, 14 insertions
Use dev_dbg() instead of dev_err()/dev_warn() to avoid flooding the
host with prints, when the guest driver is misbehaving.
In this way, prints can be dynamically enabled when the vDPA block
simulator is used to validate a driver.
Suggested-by: Jason Wang
Signed-off-by: Stefano Garzarella
The first two patches essentially limit the possibility of the guest
doing a DoS to the host.
The third makes the simulator more correct (following what we do in
vdpa_sim_net) by calling vringh_complete_iotlb() in the error path as well.
Stefano Garzarella (3):
vdpa_sim_blk: use dev_dbg
Hi Gautam,
On Wed, Mar 30, 2022 at 8:21 PM Gautam Dawar wrote:
>
> This patch introduces the control virtqueue support for vDPA
> simulator. This is a requirement for supporting advanced features like
> multiqueue.
>
> A requirement for control virtqueue is to isolate its memory access
> from
.@xilinx.com
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
index 42d401d43911..03a28def8eee 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim_b
er.
Fixes: bda324fd037a ("vdpasim: control virtqueue support")
Cc: gautam.da...@xilinx.com
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_
the
value of "mdev->pci_dev", so assigning "pci_dev" to
"mdev->pci_dev"
is unnecessary since they store the same value.
Anyway, the patch LGTM:
Reviewed-by: Stefano Garzarella
The new patch is:
In function vp_modern_probe(), "pci_dev" is init
"mdev->pci_dev"
is unnecessary since they store the same value.
Anyway, the patch LGTM:
Reviewed-by: Stefano Garzarella
Signed-off-by: Bo Liu
---
drivers/virtio/virtio_pci_modern_dev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/virtio/virtio_pci_modern_dev.c
b/drivers/
On Thu, Jun 09, 2022 at 12:33:32PM +, Arseniy Krasnov wrote:
On 09.06.2022 11:54, Stefano Garzarella wrote:
Hi Arseniy,
I left some comments in the patches, and I'm adding something also here:
Thanks for comments
On Fri, Jun 03, 2022 at 05:27:56AM +, Arseniy Krasnov wrote
On Thu, Jun 09, 2022 at 12:20:22PM +, Arseniy Krasnov wrote:
On 09.06.2022 11:39, Stefano Garzarella wrote:
On Fri, Jun 03, 2022 at 05:35:48AM +, Arseniy Krasnov wrote:
This:
1) Adds callback for 'mmap()' call on socket. It checks vm
area flags and sets vm area ops.
2) Adds special
Hi Arseniy,
I left some comments in the patches, and I'm adding something also here:
On Fri, Jun 03, 2022 at 05:27:56AM +, Arseniy Krasnov wrote:
INTRODUCTION
Hello, this is experimental implementation of virtio vsock zerocopy
receive. It was inspired
On Fri, Jun 03, 2022 at 05:37:48AM +, Arseniy Krasnov wrote:
This adds transport callback which processes rx
queue of socket and instead of copying data to
user provided buffer, it inserts data pages of
each packet to user's vm area.
Signed-off-by: Arseniy Krasnov
---
On Fri, Jun 03, 2022 at 05:35:48AM +, Arseniy Krasnov wrote:
This:
1) Adds callback for 'mmap()' call on socket. It checks vm
area flags and sets vm area ops.
2) Adds special 'getsockopt()' case which calls transport
zerocopy callback. Input argument is vm area address.
3) Adds
On Fri, Jun 03, 2022 at 05:33:04AM +, Arseniy Krasnov wrote:
For packets received from virtio RX queue, use buddy
allocator instead of 'kmalloc()' to be able to insert
such pages to user provided vma. Single call to
'copy_from_iter()' replaced with per-page loop.
Signed-off-by: Arseniy
On Fri, Jun 03, 2022 at 05:31:00AM +, Arseniy Krasnov wrote:
To support zerocopy receive, packet's buffer allocation
is changed: for buffers which could be mapped to user's
vma we can't use 'kmalloc()'(as kernel restricts to map
slab pages to user's vma) and raw buddy allocator now
called.
leiter
Cc: linux-s...@vger.kernel.org
Reviewed-by: Cornelia Huck
Signed-off-by: Jason Wang
---
include/linux/virtio_config.h | 25 +
1 file changed, 25 insertions(+)
Reviewed-by: Stefano Garzarella
___
Virtualization ma
: "Paul E. McKenney"
Cc: Marc Zyngier
Cc: Halil Pasic
Cc: Cornelia Huck
Cc: Vineeth Vijayan
Cc: Peter Oberparleiter
Cc: linux-s...@vger.kernel.org
Signed-off-by: Jason Wang
---
include/linux/virtio_config.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano
leiter
Cc: linux-s...@vger.kernel.org
Reviewed-by: Cornelia Huck
Signed-off-by: Jason Wang
---
drivers/virtio/virtio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Maybe I had already reviewed it :-), anyway:
Reviewed-by: Stefano
/vdpa_sim/vdpa_sim.c | 21 +
drivers/vdpa/vdpa_sim/vdpa_sim.h | 1 +
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 3 +++
drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 3 +++
4 files changed, 28 insertions(+)
Reviewed-by: Stefano Garzarella
diff --git a/drivers/vdpa/vdpa_sim
On Thu, May 26, 2022 at 02:43:35PM +0200, Eugenio Pérez wrote:
This operation is optional: It it's not implemented, backend feature bit
will not be exposed.
Signed-off-by: Eugenio Pérez
---
include/linux/vdpa.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/vdpa.h
;
linux-ker...@vger.kernel.org; k...@vger.kernel.org;
virtualization@lists.linux-foundation.org; Jason Wang
Cc: Zhu Lingshan ; mart...@xilinx.com; Stefano Garzarella ; ecree.xil...@gmail.com; Eli Cohen
; Dan Carpenter ; Parav Pandit ; Wu Zongyong
; din...@xilinx.com; Christophe JAILLET ; Xie
On Tue, May 24, 2022 at 07:06:10PM +0200, Eugenio Pérez wrote:
Implement stop operation for vdpa_sim devices, so vhost-vdpa will offer
that backend feature and userspace can effectively stop the device.
This is a must before get virtqueue indexes (base) for live migration,
since the device
On Tue, May 24, 2022 at 09:42:06AM +0200, Eugenio Perez Martin wrote:
On Tue, May 24, 2022 at 9:09 AM Stefano Garzarella wrote:
On Mon, May 23, 2022 at 09:20:14PM +0200, Eugenio Perez Martin wrote:
>On Sat, May 21, 2022 at 12:13 PM Si-Wei Liu wrote:
>>
>>
>>
>> On
On Fri, May 20, 2022 at 11:09:11AM +, Arseniy Krasnov wrote:
Hello Stefano,
On 19.05.2022 10:42, Stefano Garzarella wrote:
On Wed, May 18, 2022 at 11:04:30AM +, Arseniy Krasnov wrote:
Hello Stefano,
On 17.05.2022 18:14, Stefano Garzarella wrote:
Hi Arseniy,
On Thu, May 12, 2022
On Mon, May 23, 2022 at 09:20:14PM +0200, Eugenio Perez Martin wrote:
On Sat, May 21, 2022 at 12:13 PM Si-Wei Liu wrote:
On 5/20/2022 10:23 AM, Eugenio Pérez wrote:
> This operation is optional: It it's not implemented, backend feature bit
> will not be exposed.
>
> Signed-off-by: Eugenio
queue
groups")
Fixes: e96ef636f154 ("vhost-vdpa: introduce uAPI to get the number of address
spaces")
Signed-off-by: Dan Carpenter
---
drivers/vhost/vdpa.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Stefano Garzarella
diff --git a/drivers/vh
condition here.
Yeah, I think so!
Anyway, this patch LGTM:
Reviewed-by: Stefano Garzarella
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
501 - 600 of 1601 matches
Mail list logo