Hi Arseny,
On Thu, Feb 18, 2021 at 08:33:44AM +0300, Arseny Krasnov wrote:
This patchset impelements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of recor
| 2 --
2 files changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Stefano Garzarella
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 42e09cc..4b15c00 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -141,15 +141,14 @@ void virtio_config_changed(s
insertions(+)
create mode 100644 drivers/vdpa/virtio_pci/Makefile
create mode 100644 drivers/vdpa/virtio_pci/vp_vdpa.c
Acked-by: Stefano Garzarella
diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
index ffd1e098bfd2..a245809c99d0 100644
--- a/drivers/vdpa/Kconfig
+++ b/drivers/vdpa/Kconfig
The title is a little cryptic, maybe a something like:
virtio/vsock: set packet's type in virtio_transport_send_pkt_info()
On Thu, Feb 18, 2021 at 08:39:02AM +0300, Arseny Krasnov wrote:
This moves passing type of packet from 'info' srtucture to send
Also here replace send with the function n
On Thu, Feb 18, 2021 at 08:39:23AM +0300, Arseny Krasnov wrote:
'virtio_transport_send_credit_update()' has some extra args:
1) 'type' may be set in 'virtio_transport_send_pkt_info()' using type
of socket.
2) This function is static and 'hdr' arg was always NULL.
Signed-off-by: Arseny Krasnov
On Thu, Feb 18, 2021 at 08:39:37AM +0300, Arseny Krasnov wrote:
This adds transport callback and it's logic for SEQPACKET dequeue.
Callback fetches RW packets from rx queue of socket until whole record
is copied(if user's buffer is full, user is not woken up). This is done
to not stall sender, be
On Mon, Feb 22, 2021 at 03:23:11PM +0100, Stefano Garzarella wrote:
Hi Arseny,
On Thu, Feb 18, 2021 at 08:33:44AM +0300, Arseny Krasnov wrote:
This patchset impelements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
On Wed, Feb 24, 2021 at 07:29:25AM +0300, Arseny Krasnov wrote:
On 23.02.2021 17:50, Stefano Garzarella wrote:
On Mon, Feb 22, 2021 at 03:23:11PM +0100, Stefano Garzarella wrote:
Hi Arseny,
On Thu, Feb 18, 2021 at 08:33:44AM +0300, Arseny Krasnov wrote:
This patchset impelements
On Wed, Feb 24, 2021 at 01:41:56AM -0500, Michael S. Tsirkin wrote:
On Wed, Feb 24, 2021 at 08:07:48AM +0300, Arseny Krasnov wrote:
On 23.02.2021 17:17, Michael S. Tsirkin wrote:
> On Thu, Feb 18, 2021 at 08:39:37AM +0300, Arseny Krasnov wrote:
>> This adds transport callback and it's logic for
On Wed, Feb 24, 2021 at 11:28:50AM +0300, Arseny Krasnov wrote:
On 24.02.2021 11:23, Stefano Garzarella wrote:
On Wed, Feb 24, 2021 at 07:29:25AM +0300, Arseny Krasnov wrote:
On 23.02.2021 17:50, Stefano Garzarella wrote:
On Mon, Feb 22, 2021 at 03:23:11PM +0100, Stefano Garzarella wrote
On Thu, Feb 18, 2021 at 09:08:23AM +0300, Arseny Krasnov wrote:
Signed-off-by: Arseny Krasnov
---
virtio-vsock.tex | 40 +---
1 file changed, 37 insertions(+), 3 deletions(-)
diff --git a/virtio-vsock.tex b/virtio-vsock.tex
index da7e641..1ee8f99 100644
--- a/
nice ping :-)
On Tue, Feb 16, 2021 at 10:44:44AM +0100, Stefano Garzarella wrote:
Following the discussion with Michael and Jason [1], I reworked a bit
get/set_config() in vdpa.
I changed vdpa_get_config() to check the boundaries and added vdpa_set_config().
When 'offset' or '
On Tue, Mar 02, 2021 at 12:05:35PM +0800, Jason Wang wrote:
On 2021/2/16 5:44 下午, Stefano Garzarella wrote:
vdpa_get_config() and vdpa_set_config() now return the amount
of bytes read and written, so let's return them to the user space.
We also modify vhost_vdpa_config_validate() to ret
On Tue, Mar 02, 2021 at 12:14:13PM +0800, Jason Wang wrote:
On 2021/2/16 5:44 下午, Stefano Garzarella wrote:
This new callback is used to get the size of the configuration space
of vDPA devices.
Signed-off-by: Stefano Garzarella
---
include/linux/vdpa.h | 4
drivers/vdpa
On Wed, Mar 03, 2021 at 01:08:43PM +0100, Cornelia Huck wrote:
On Wed, 24 Feb 2021 10:32:00 +0100
Stefano Garzarella wrote:
On Thu, Feb 18, 2021 at 09:08:23AM +0300, Arseny Krasnov wrote:
>Signed-off-by: Arseny Krasnov
>---
> virtio-vsock.tex | 40 +++
On Thu, Mar 04, 2021 at 04:31:22PM +0800, Jason Wang wrote:
On 2021/3/2 10:06 下午, Stefano Garzarella wrote:
On Tue, Mar 02, 2021 at 12:05:35PM +0800, Jason Wang wrote:
On 2021/2/16 5:44 下午, Stefano Garzarella wrote:
vdpa_get_config() and vdpa_set_config() now return the amount
of bytes read
On Thu, Mar 04, 2021 at 04:34:52PM +0800, Jason Wang wrote:
On 2021/3/2 10:15 下午, Stefano Garzarella wrote:
On Tue, Mar 02, 2021 at 12:14:13PM +0800, Jason Wang wrote:
On 2021/2/16 5:44 下午, Stefano Garzarella wrote:
This new callback is used to get the size of the configuration space
of
Hi Arseny,
thanks for this new version.
It's a busy week for me, but I hope to review this series by the end of
this week :-)
Thanks,
Stefano
On Sun, Mar 07, 2021 at 08:57:19PM +0300, Arseny Krasnov wrote:
This patchset implements support of SOCK_SEQPACKET for virtio
transport.
haps using
this Rust library [2] ?
Could we put it in the kernel tree in tool/testing?
Thanks,
Stefano
[1] https://github.com/stefano-garzarella/vhost/tree/vdpa
[2] https://github.com/rust-vmm/vhost
Stefano Garzarella (2):
vhost-vdpa: fix use-after-free of v->config_ctx
vhost-vdpa: set v-&
in
other functions such as vhost_vdpa_config_put().
Fixes: 776f395004d8 ("vhost_vdpa: Support config interrupt in vdpa")
Cc: lingshan@intel.com
Cc: sta...@vger.kernel.org
Signed-off-by: Stefano Garzarella
---
drivers/vhost/vdpa.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
st_vdpa: Support config interrupt in vdpa")
Cc: lingshan@intel.com
Cc: sta...@vger.kernel.org
Signed-off-by: Stefano Garzarella
---
drivers/vhost/vdpa.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index ef688c8c0e0e
Krasnov
---
net/vmw_vsock/af_vsock.c | 64 +---
1 file changed, 34 insertions(+), 30 deletions(-)
Reviewed-by: Stefano Garzarella
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https
vsock/af_vsock.c | 156 +--
1 file changed, 84 insertions(+), 72 deletions(-)
Reviewed-by: Stefano Garzarella
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/ma
t functions were created.
Signed-off-by: Arseny Krasnov
---
include/net/af_vsock.h | 5 +++
net/vmw_vsock/af_vsock.c | 95 +++-
2 files changed, 99 insertions(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella
___
Vi
On Sun, Mar 07, 2021 at 09:00:26PM +0300, Arseny Krasnov wrote:
This adds some logic to current stream enqueue function for SEQPACKET
support:
1) Use transport's seqpacket enqueue callback.
2) Return value from enqueue function is whole record length or error
for SOCK_SEQPACKET.
Signed-off-by:
On Sun, Mar 07, 2021 at 08:59:45PM +0300, Arseny Krasnov wrote:
This adds receive loop for SEQPACKET. It looks like receive loop for
STREAM, but there is a little bit difference:
1) It doesn't call notify callbacks.
2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because
there
On Sun, Mar 07, 2021 at 09:02:31PM +0300, Arseny Krasnov wrote:
This adds transport callback which tries to fetch record begin marker
from socket's rx queue. It is called from af_vsock.c before reading data
packets of record.
Signed-off-by: Arseny Krasnov
---
include/linux/virtio_vsock.h
+++-
2 files changed, 36 insertions(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
anged, 17 insertions(+), 14 deletions(-)
Reviewed-by: Stefano Garzarella
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
am type is supported, set it directly in 'virtio_transport_send_
pkt_info()', so callers don't need to set it.
Signed-off-by: Arseny Krasnov
---
net/vmw_vsock/virtio_transport_common.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-
On Sun, Mar 07, 2021 at 09:01:44PM +0300, Arseny Krasnov wrote:
This function is static and 'hdr' arg was always NULL.
Signed-off-by: Arseny Krasnov
---
net/vmw_vsock/virtio_transport_common.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Stefano
On Sun, Mar 07, 2021 at 09:02:01PM +0300, Arseny Krasnov wrote:
This adds transport callback and it's logic for SEQPACKET dequeue.
Callback fetches RW packets from rx queue of socket until whole record
is copied(if user's buffer is full, user is not woken up). This is done
to not stall sender, be
On Sun, Mar 07, 2021 at 09:02:50PM +0300, Arseny Krasnov wrote:
This modifies current receive logic for SEQPACKET support:
1) Inserts 'SEQ_BEGIN' packet to socket's rx queue.
2) Inserts 'RW' packet to socket's rx queue, but without merging with
buffer of last packet in queue.
3) Performs check
On Sun, Mar 07, 2021 at 09:03:09PM +0300, Arseny Krasnov wrote:
This adds rest of logic for SEQPACKET:
1) SEQPACKET specific functions which send SEQ_BEGIN/SEQ_END.
Note that both functions may sleep to wait enough space for
SEQPACKET header.
2) SEQ_BEGIN/SEQ_END in TAP packet capture.
3) Sen
On Sun, Mar 07, 2021 at 09:03:41PM +0300, Arseny Krasnov wrote:
This adds handling of SEQPACKET bit: if guest sets features with
this bit cleared, then SOCK_SEQPACKET support will be disabled.
Signed-off-by: Arseny Krasnov
---
drivers/vhost/vsock.c | 6 +-
1 file changed, 5 insertions(+), 1
On Sun, Mar 07, 2021 at 09:04:01PM +0300, Arseny Krasnov wrote:
This adds handling of SEQPACKET bit: guest tries to negotiate it
with vhost.
Signed-off-by: Arseny Krasnov
---
net/vmw_vsock/virtio_transport.c | 5 +
1 file changed, 5 insertions(+)
Also for this patch I think is better to mo
Hi Arseny,
On Sun, Mar 07, 2021 at 08:57:19PM +0300, Arseny Krasnov wrote:
This patchset implements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of record
allow vhost-vdpa to use
block devices, and I added get_config_size() callback to allow any device
in vhost-vdpa.
The series also includes small fixes for vringh, vdpa, and vdpa_sim that I
discovered while implementing and testing the block simulator.
Thanks for your feedback,
Stefano
Max G
, vdpasim_map_range() and vdpasim_unmap_range(),
to handle the IOVA allocation and the registration into the IOMMU/IOTLB.
These functions are used by dma_map_ops callbacks.
Acked-by: Jason Wang
Signed-off-by: Stefano Garzarella
---
v2:
- used ULONG_MAX instead of ~0UL [Jason]
- fixed typos in comment and
ff-by: Stefano Garzarella
---
include/linux/vringh.h | 6 +-
drivers/vdpa/vdpa_sim/vdpa_sim.c | 3 ++-
drivers/vhost/vringh.c | 9 -
3 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/include/linux/vringh.h b/include/linux/vringh.h
index 59bd50f
__vringh_iov() overwrites the contents of riov and wiov, in fact it
resets the 'i' and 'used' fields, but also the 'consumed' field should
be reset to avoid an inconsistent state.
Acked-by: Jason Wang
Signed-off-by: Stefano Garzarella
---
drivers/vhost/vringh
riov and wiov can be reused with subsequent calls of vringh_getdesc_*().
Let's add a paragraph in the documentation of these functions to better
explain when riov and wiov need to be cleaned up.
Acked-by: Jason Wang
Signed-off-by: Stefano Garzarella
---
drivers/vhost/vringh.c
In some cases, it may be useful to provide a way to skip a number
of bytes in a vringh_kiov.
Let's implement vringh_kiov_advance() for this purpose, reusing the
code from vringh_iov_xfer().
We replace that code calling the new vringh_kiov_advance().
Acked-by: Jason Wang
Signed-off-by: St
This new helper returns the total number of bytes covered by
a vringh_kiov.
Suggested-by: Jason Wang
Acked-by: Jason Wang
Signed-off-by: Stefano Garzarella
---
include/linux/vringh.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/linux/vringh.h b/include/linux
a
request, but we should call it when we free the entire device.
Acked-by: Jason Wang
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
index
This new callback is used to get the size of the configuration space
of vDPA devices.
Signed-off-by: Stefano Garzarella
---
include/linux/vdpa.h | 4
drivers/vdpa/ifcvf/ifcvf_main.c | 6 ++
drivers/vdpa/mlx5/net/mlx5_vnet.c | 6 ++
drivers/vdpa/vdpa_sim/vdpa_sim.c
: Stefano Garzarella
---
drivers/vhost/vdpa.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index 7ae4080e57d8..850ed4b62942 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -16,12 +16,12 @@
#include
#include
Let's use the new 'get_config_size()' callback available instead of
using the 'virtio_id' to get the size of the device config space.
Signed-off-by: Stefano Garzarella
---
drivers/vhost/vdpa.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git
n the next commits.
Signed-off-by: Max Gurtovoy
[sgarzare: various cleanups/fixes]
Acked-by: Jason Wang
Signed-off-by: Stefano Garzarella
---
v4:
- include linux/blkdev.h to fix a build issue
- fix vdpa_register_device() passing the new 'nvqs' params
v3:
- updated Mellanox copy
The previous implementation wrote only the status of each request.
This patch implements a more accurate block device simulator,
providing a ramdisk-like behavior and adding input validation.
Acked-by: Jason Wang
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
---
v2:
- used %zd
Handle VIRTIO_BLK_T_GET_ID request, always answering the
"vdpa_blk_sim" string.
Acked-by: Jason Wang
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
---
v2:
- made 'vdpasim_blk_id' static [Jason]
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 15 +++
;vdpasim_blk",
"vendor_id": 0,
"max_vqs": 1,
"max_vq_size": 256
}
}
}
# Delete the vDPA device after its use
$ vdpa dev del blk0
Signed-off-by: Stefano Garzarella
---
drivers/
On Mon, Mar 15, 2021 at 05:51:30PM +0100, Laurent Vivier wrote:
On 15/03/2021 17:34, Stefano Garzarella wrote:
This new helper returns the total number of bytes covered by
a vringh_kiov.
Suggested-by: Jason Wang
Acked-by: Jason Wang
Signed-off-by: Stefano Garzarella
---
include/linux
On Tue, Mar 16, 2021 at 06:37:31AM +0300, Arseny Krasnov wrote:
On 15.03.2021 18:22, Arseny Krasnov wrote:
On 15.03.2021 14:40, Stefano Garzarella wrote:
Hi Arseny,
On Sun, Mar 07, 2021 at 08:57:19PM +0300, Arseny Krasnov wrote:
This patchset implements support of SOCK_SEQPACKET for
On Tue, Mar 16, 2021 at 06:35:11AM +0300, Arseny Krasnov wrote:
On 15.03.2021 18:53, Cornelia Huck wrote:
On Mon, 15 Mar 2021 11:35:41 +0300
Arseny Krasnov wrote:
This replaces constants defined in "bit X set to Y" manner
with enums from Linux kernel uapi headers.
---
virtio-vsock.tex | 29
On Tue, Mar 16, 2021 at 09:50:48AM -0400, Michael S. Tsirkin wrote:
On Mon, Feb 22, 2021 at 11:16:54AM +0100, Stefano Garzarella wrote:
On Thu, Feb 18, 2021 at 09:07:12AM +0300, Arseny Krasnov wrote:
> This patchset adds description of SOCK_SEQPACKET socket's type
> of virtio vsock.
wed-by: Stefano Garzarella
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
the
reviewer is no longer happy. But this doesn't seem to be the case.
So please keep the tags between versions :-)
Reviewed-by: Stefano Garzarella
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 421c0303b26f..0bc661e54262 100644
--- a/net/vmw_vsock/af_vs
On Tue, Mar 23, 2021 at 04:10:03PM +0300, Arseny Krasnov wrote:
This adds receive loop for SEQPACKET. It looks like receive loop for
STREAM, but there is a little bit difference:
1) It doesn't call notify callbacks.
2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because
there
), 38 deletions(-)
I had already reviewed this one as well and it doesn't seem to have
changed :-)
Reviewed-by: Stefano Garzarella
diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h
index 74ac8a4c4168..7232f6c42a36 100644
--- a/include/net/af_vsock.h
+++ b/include/net/
c | 21 +++--
2 files changed, 17 insertions(+), 6 deletions(-)
Reviewed-by: Stefano Garzarella
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
On Tue, Mar 23, 2021 at 04:12:41PM +0300, Arseny Krasnov wrote:
This adds transport callback and it's logic for SEQPACKET dequeue.
Callback fetches RW packets from rx queue of socket until whole record
is copied(if user's buffer is full, user is not woken up). This is done
to not stall sender, be
On Tue, Mar 23, 2021 at 04:12:55PM +0300, Arseny Krasnov wrote:
This adds transport callback which tries to fetch record begin marker
from socket's rx queue. It is called from af_vsock.c before reading data
packets of record.
Signed-off-by: Arseny Krasnov
---
v6 -> v7:
1) Now 'virtio_transport_
socket.
net/vmw_vsock/virtio_transport_common.c | 64 +
1 file changed, 45 insertions(+), 19 deletions(-)
Reviewed-by: Stefano Garzarella
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
On Tue, Mar 23, 2021 at 04:13:29PM +0300, Arseny Krasnov wrote:
This adds rest of logic for SEQPACKET:
1) SEQPACKET specific functions which send SEQ_BEGIN/SEQ_END.
Note that both functions may sleep to wait enough space for
SEQPACKET header.
2) SEQ_BEGIN/SEQ_END in TAP packet capture.
3) Sen
On Tue, Mar 23, 2021 at 04:13:49PM +0300, Arseny Krasnov wrote:
This adds new virtio vsock specific feature bit which means
SOCK_SEQPACKET support. Guest negotiates this bit with vhost,
thus checking that vhost side supports SEQPACKET.
Signed-off-by: Arseny Krasnov
---
include/uapi/linux/virtio
On Tue, Mar 23, 2021 at 04:14:03PM +0300, Arseny Krasnov wrote:
This adds SEQPACKET ops for virtio transport and 'seqpacket_allow()'
callback.
Signed-off-by: Arseny Krasnov
---
net/vmw_vsock/virtio_transport.c | 12
1 file changed, 12 insertions(+)
Sorry for not mentioning this in
On Tue, Mar 23, 2021 at 04:14:18PM +0300, Arseny Krasnov wrote:
This also removes ignore of non-stream type of packets and adds
'seqpacket_allow()' callback.
Signed-off-by: Arseny Krasnov
---
drivers/vhost/vsock.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
Same thin
On Tue, Mar 23, 2021 at 04:14:33PM +0300, Arseny Krasnov wrote:
This adds SEQPACKET ops for loopback transport and 'seqpacket_allow()'
callback.
Signed-off-by: Arseny Krasnov
---
net/vmw_vsock/vsock_loopback.c | 12
1 file changed, 12 insertions(+)
Reviewed-b
Hi Arseny,
On Tue, Mar 23, 2021 at 04:07:13PM +0300, Arseny Krasnov wrote:
This patchset implements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of record
ertions(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
and performance should be comparable
to SOCK_STREAM.
Well, my first versions of SOCK_SEQPACKET implementation, worked
something like this: i used flags field of header as length of whole
message. I discussed it with Stefano Garzarella, and he told that it
will
be better to use special "header"
On Tue, Mar 30, 2021 at 09:15:39AM +0300, Arseny Krasnov wrote:
On 30.03.2021 00:28, Stefano Garzarella wrote:
On Mon, Mar 29, 2021 at 08:33:27PM +0300, Arseny Krasnov wrote:
On 29.03.2021 19:11, Stefan Hajnoczi wrote:
On Fri, Mar 26, 2021 at 12:02:50PM +0300, Arseny Krasnov wrote:
This
Hi Jiang,
On Fri, Mar 26, 2021 at 04:40:09PM -0700, Jiang Wang . wrote:
Hi Michael and Stefan,
I thought about this and discussed it with my colleague Cong Wang.
One idea is to make current asynchronous send_pkt flow to be synchronous,
then if the virtqueue is full, the function can return ENO
On Tue, Mar 30, 2021 at 06:02:33PM -0700, Jiang Wang . wrote:
Hi Stefano,
I checked dgram code again. I think assigning transport for each packet
is doable. The dgram will be similar to stream to have two transports.
Yeah, make sense.
If there is no other problem, I can submit a Linux kerne
On Wed, Mar 31, 2021 at 10:04:18AM +0100, Stefan Hajnoczi wrote:
On Mon, Feb 08, 2021 at 08:39:30AM -0800, syzbot wrote:
Hello,
syzbot found the following issue on:
HEAD commit:9f29bd8b Merge tag 'fs_for_v5.11-rc5' of git://git.kernel...
git tree: upstream
console output: https://syz
30.03.2021 11:55, Stefan Hajnoczi wrote:
On Tue, Mar 30, 2021 at 09:15:39AM +0300, Arseny Krasnov wrote:
On 30.03.2021 00:28, Stefano Garzarella wrote:
On Mon, Mar 29, 2021 at 08:33:27PM +0300, Arseny Krasnov wrote:
On 29.03.2021 19:11, Stefan Hajnoczi wrote:
On Fri, Mar 26, 2021 at 12:02:50PM +0300
Hi Michael,
do you think this series is in an acceptable state to be queued for the
next merge window?
All patches should be already acked by Jason, let me know if I need to
change anything.
Thanks,
Stefano
On Mon, Mar 15, 2021 at 05:34:36PM +0100, Stefano Garzarella wrote:
v4:
- added
{
+ err = -ENOMEM;
goto err_map;
+ }
err = create_direct_mr(mvdev, mr);
if (err)
--
2.30.1
Reviewed-by: Stefano Garzarella
___
Virtualization mailing list
Virtualization@l
Hi Jiang,
thanks for re-starting the multi-transport support for dgram!
On Wed, Apr 07, 2021 at 11:25:36AM -0700, Jiang Wang . wrote:
On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote:
> On 6 Apr 2021, at 20:31, Jiang Wang wrote:
>
> From: "jiang.wang"
>
> Currently, only VMCI supports dg
On Mon, Apr 12, 2021 at 02:50:17PM +0100, Stefan Hajnoczi wrote:
On Thu, Apr 01, 2021 at 04:36:02AM +, jiang.wang wrote:
Add supports for datagram type for virtio-vsock. Datagram
sockets are connectionless and unreliable. To avoid contention
with stream and other sockets, add two more virtqu
5fef3c020..25533db01f5f 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -2089,7 +2089,7 @@ static int mlx5v_probe(struct auxiliary_device *adev,
return 0;
reg_err:
- kfree(mdev);
+ kfree(mgtdev);
return err;
}
--
2.30.2
R
On Tue, Apr 13, 2021 at 12:12:50PM +, Jorgen Hansen wrote:
On 12 Apr 2021, at 20:53, Jiang Wang .
mailto:jiang.w...@bytedance.com>> wrote:
On Mon, Apr 12, 2021 at 7:04 AM Stefano Garzarella
mailto:sgarz...@redhat.com>> wrote:
Hi Jiang,
thanks for re-starting the multi-trans
On Mon, Apr 12, 2021 at 03:42:23PM -0700, Jiang Wang . wrote:
On Mon, Apr 12, 2021 at 7:21 AM Stefano Garzarella wrote:
On Mon, Apr 12, 2021 at 02:50:17PM +0100, Stefan Hajnoczi wrote:
>On Thu, Apr 01, 2021 at 04:36:02AM +, jiang.wang wrote:
>> Add supports for datagram type f
On Tue, Apr 13, 2021 at 09:16:50AM -0400, Michael S. Tsirkin wrote:
On Tue, Apr 13, 2021 at 02:58:53PM +0200, Stefano Garzarella wrote:
On Mon, Apr 12, 2021 at 03:42:23PM -0700, Jiang Wang . wrote:
> On Mon, Apr 12, 2021 at 7:21 AM Stefano Garzarella
wrote:
> >
> > On Mon, Apr
On Tue, Apr 13, 2021 at 09:50:45AM -0400, Michael S. Tsirkin wrote:
On Tue, Apr 13, 2021 at 03:38:52PM +0200, Stefano Garzarella wrote:
On Tue, Apr 13, 2021 at 09:16:50AM -0400, Michael S. Tsirkin wrote:
> On Tue, Apr 13, 2021 at 02:58:53PM +0200, Stefano Garzarella wrote:
> > On Mo
On Tue, Apr 13, 2021 at 03:58:34PM -0400, Michael S. Tsirkin wrote:
On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote:
On Tue, Apr 13, 2021 at 09:50:45AM -0400, Michael S. Tsirkin wrote:
> On Tue, Apr 13, 2021 at 03:38:52PM +0200, Stefano Garzarella wrote:
> > On Tu
On Tue, Apr 13, 2021 at 03:00:50PM -0700, Jiang Wang . wrote:
On Tue, Apr 13, 2021 at 12:58 PM Michael S. Tsirkin wrote:
On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote:
> On Tue, Apr 13, 2021 at 09:50:45AM -0400, Michael S. Tsirkin wrote:
> > On Tue, Apr 13, 2021
On Wed, Apr 14, 2021 at 03:20:07AM -0400, Michael S. Tsirkin wrote:
On Wed, Apr 14, 2021 at 08:57:06AM +0200, Stefano Garzarella wrote:
On Tue, Apr 13, 2021 at 03:58:34PM -0400, Michael S. Tsirkin wrote:
> On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote:
> > On Tu
On Wed, Apr 14, 2021 at 05:18:32PM +0800, Zhu Lingshan wrote:
get_config_size() should return the size based on the decected
device type.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/i
On Thu, Apr 15, 2021 at 04:23:15PM +0800, Zhu Lingshan wrote:
On 4/15/2021 4:12 PM, Stefano Garzarella wrote:
On Wed, Apr 14, 2021 at 05:18:32PM +0800, Zhu Lingshan wrote:
get_config_size() should return the size based on the decected
device type.
Signed-off-by: Zhu Lingshan
---
drivers
On Thu, Apr 15, 2021 at 05:53:35PM +0800, Zhu Lingshan wrote:
This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block
for vDPA.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_base.h | 8 +++-
drivers/vdpa/ifcvf/ifcvf_main.c | 10 +-
2 files changed, 16 insertions(+),
On Thu, Apr 15, 2021 at 05:53:36PM +0800, Zhu Lingshan wrote:
get_config_size() should return the size based on the decected
device type.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_main.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers
insertions(+), 2 deletions(-)
Reviewed-by: Stefano Garzarella
diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h b/drivers/vdpa/ifcvf/ifcvf_base.h
index 1c04cd256fa7..0111bfdeb342 100644
--- a/drivers/vdpa/ifcvf/ifcvf_base.h
+++ b/drivers/vdpa/ifcvf/ifcvf_base.h
@@ -15,6 +15,7 @@
#include
#include
: Stefano Garzarella
diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
index 376b2014916a..3b6f7862dbb8 100644
--- a/drivers/vdpa/ifcvf/ifcvf_main.c
+++ b/drivers/vdpa/ifcvf/ifcvf_main.c
@@ -356,7 +356,24 @@ static u32 ifcvf_vdpa_get_vq_align(struct vdpa_device
*vdpa_dev
ts during the socket release")
Reported-and-tested-by: syzbot+24452624fc4c571ee...@syzkaller.appspotmail.com
Signed-off-by: Stefano Garzarella
---
net/vmw_vsock/virtio_transport_common.c | 28 +
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/net/vmw_vsock/
On Wed, Apr 14, 2021 at 09:04:47AM +0300, Arseny Krasnov wrote:
On 13.04.2021 22:55, Michael S. Tsirkin wrote:
On Tue, Apr 13, 2021 at 05:22:44PM +0300, Arseny Krasnov wrote:
On 13.04.2021 16:10, Michael S. Tsirkin wrote:
On Tue, Apr 13, 2021 at 03:53:29PM +0300, Arseny Krasnov wrote:
This a
On Tue, Apr 13, 2021 at 03:42:47PM +0300, Arseny Krasnov wrote:
This adds receive loop for SEQPACKET. It looks like receive loop for
STREAM, but there is a little bit difference:
1) It doesn't call notify callbacks.
2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because
there
On Tue, Apr 13, 2021 at 03:44:40PM +0300, Arseny Krasnov wrote:
>This adds transport callback and it's logic for SEQPACKET dequeue.
>Callback fetches RW packets from rx queue of socket until whole record
>is copied(if user's buffer is full, user is not woken up). This is done
>to not stall sender,
On Tue, Apr 13, 2021 at 03:45:25PM +0300, Arseny Krasnov wrote:
>This adds rest of logic for SEQPACKET:
>1) Send SHUTDOWN on socket close for SEQPACKET type.
>2) Set SEQPACKET packet type during send.
>3) 'seqpacket_allow' flag to virtio transport.
>4) Set 'VIRTIO_VSOCK_SEQ_EOR' bit in flags for la
601 - 700 of 1608 matches
Mail list logo
