Re: [PATCH] AF_VMCHANNEL address family for guest-host communication.

On Mon, 15 Dec 2008 17:01:14 -0600 Anthony Liguori anth...@codemonkey.ws wrote: David Miller wrote: From: Anthony Liguori anth...@codemonkey.ws Date: Mon, 15 Dec 2008 14:44:26 -0600 We want this communication mechanism to be simple and reliable as we want to implement the backends

Re: [patch 34/54] Staging: hv: remove STRUCT_PACKED and STRUCT_ALIGNED defines

On Fri, 24 Jul 2009 23:32:19 +0200 Jörn Engel jo...@logfs.org wrote: On Tue, 21 July 2009 01:46:41 +0200, Arnd Bergmann wrote: On Friday 17 July 2009, Greg Kroah-Hartman wrote: @@ -43,7 +43,7 @@ typedef struct _RING_BUFFER { // volatile u32 InterruptMask; // Ring data

Re: [PATCH][RFC] net/bridge: add basic VEPA support

On Mon, 15 Jun 2009 17:33:10 + Fischer, Anna anna.fisc...@hp.com wrote: This patch adds basic Virtual Ethernet Port Aggregator (VEPA) capabilities to the Linux kernel Ethernet bridging code. A Virtual Ethernet Port Aggregator (VEPA) is a capability within a physical end station that

Re: [evb] RE: [PATCH][RFC] net/bridge: add basic VEPA support

On Fri, 7 Aug 2009 14:06:58 -0700 Paul Congdon \(UC Davis\) ptcong...@ucdavis.edu wrote: Yaron, The interface multiplexing can be achieved using macvlan driver or using an SR-IOV capable NIC (the preferred option), macvlan may need to be extended to support VEPA multicast handling, this

Re: [evb] RE: [PATCH][RFC] net/bridge: add basic VEPA support

On Sun, 09 Aug 2009 14:19:08 +0300 Or Gerlitz ogerl...@voltaire.com wrote: Stephen Hemminger wrote: I have a patch that forwards all multicast packets, and another that does proper forwarding. It should have worked that way in original macvlan, the current behavior is really a bug

Re: [evb] RE: [PATCH][RFC] net/bridge: add basic VEPA support

On Mon, 10 Aug 2009 16:32:01 + Fischer, Anna anna.fisc...@hp.com wrote: Subject: Re: [evb] RE: [PATCH][RFC] net/bridge: add basic VEPA support On Monday 10 August 2009, Stephen Hemminger wrote: On Sun, 09 Aug 2009 14:19:08 +0300, Or Gerlitz ogerl...@voltaire.com wrote: Looking

Re: [PATCH] net/bridge: Add 'hairpin' port forwarding mode

diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index eb404dc..e486f1f 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -256,6 +256,7 @@ static struct net_bridge_port *new_nbp(struct net_bridge *br, p-path_cost = port_cost(dev); p-priority = 0x8000

Re: [RFC] Virtual Machine Device Queues(VMDq) support on KVM

On Tue, 1 Sep 2009 14:58:19 +0800 Xin, Xiaohui xiaohui@intel.com wrote: [RFC] Virtual Machine Device Queues (VMDq) support on KVM Network adapter with VMDq technology presents multiple pairs of tx/rx queues, and renders network L2 sorting mechanism based on MAC addresses

Re: [RFC] Virtual Machine Device Queues(VMDq) support on KVM

On Mon, 21 Sep 2009 16:37:22 +0930 Rusty Russell ru...@rustcorp.com.au wrote: Actually this framework can apply to traditional network adapters which have just one tx/rx queue pair. And applications using the same user/kernel interface can utilize this framework to send/receive

Re: [RFC] Virtual Machine Device Queues(VMDq) support on KVM

On Tue, 22 Sep 2009 13:50:54 +0200 Arnd Bergmann a...@arndb.de wrote: On Tuesday 22 September 2009, Michael S. Tsirkin wrote: More importantly, when virtualizations is used with multi-queue NIC's the virtio-net NIC is a single CPU bottleneck. The virtio-net NIC should preserve the

Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

On Wed, 30 Sep 2009 14:34:57 -0700 (PDT) Shreyas Bhatewara sbhatew...@vmware.com wrote: Note: your patch was linewrapped again + + +static void +vmxnet3_declare_features(struct vmxnet3_adapter *adapter, bool dma64) +{ + struct net_device *netdev = adapter-netdev; + +

Re: [PATCH 2.6.32-rc3] net: VMware virtual Ethernet NIC driver: vmxnet3

On Thu, 8 Oct 2009 10:59:26 -0700 (PDT) Shreyas Bhatewara sbhatew...@vmware.com wrote: Hello all, I do not mean to be bothersome but this thread has been unusually silent. Could you please review the patch for me and reply with your comments / acks ? Thanks. -Shreyas Looks fine,

Re: [PATCH for-2.6.35] virtio_net: fix oom handling on tx

On Thu, 10 Jun 2010 10:17:07 -0700 Sridhar Samudrala s...@us.ibm.com wrote: On Thu, 2010-06-10 at 18:20 +0300, Michael S. Tsirkin wrote: virtio net will never try to overflow the TX ring, so the only reason add_buf may fail is out of memory. Thus, we can not stop the device until some

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

On Mon, 12 Jul 2010 20:06:28 -0700 Shreyas Bhatewara sbhatew...@vmware.com wrote: On Thu, 2010-05-06 at 13:21 -0700, Christoph Hellwig wrote: On Wed, May 05, 2010 at 10:52:53AM -0700, Stephen Hemminger wrote: Let me put it bluntly. Any design that allows external code to run

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

On Mon, 12 Jul 2010 20:06:28 -0700 Shreyas Bhatewara sbhatew...@vmware.com wrote: On Thu, 2010-05-06 at 13:21 -0700, Christoph Hellwig wrote: On Wed, May 05, 2010 at 10:52:53AM -0700, Stephen Hemminger wrote: Let me put it bluntly. Any design that allows external code to run

[PATCH] virtio: fix format of sysfs driver/vendor files

with! Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- a/drivers/virtio/virtio.c 2010-11-09 21:39:31.713916249 -0800 +++ b/drivers/virtio/virtio.c 2010-11-09 21:40:16.072089461 -0800 @@ -9,19 +9,19 @@ static ssize_t device_show(struct device struct

Re: [PATCH]: An implementation of HyperV KVP functionality

On Thu, 11 Nov 2010 13:03:10 -0700 Ky Srinivasan ksriniva...@novell.com wrote: +static char *kvp_keys[KVP_MAX_KEY] = {FullyQualifiedDomainName, + IntegrationServicesVersion, + NetworkAddressIPv4, +

Re: [PATCH] xen: fix p2m section mismatches

On Thu, 24 Mar 2011 13:34:32 -0700 Randy Dunlap randy.dun...@oracle.com wrote: From: Randy Dunlap randy.dun...@oracle.com Fix section mismatch warnings: set_phys_range_identity() is called by __init xen_set_identity(), so also mark set_phys_range_identity() as __init. then:

[PATCH] virtio-net: per cpu 64 bit stats

Use per-cpu variables to maintain 64 bit statistics. Compile tested only. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- a/drivers/net/virtio_net.c 2011-06-14 15:18:46.448596355 -0400 +++ b/drivers/net/virtio_net.c 2011-06-15 09:54:22.914426067 -0400 @@ -40,6 +40,15 @@ module_param

Re: [PATCH] virtio-net: per cpu 64 bit stats (v2)

Use per-cpu variables to maintain 64 bit statistics. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- a/drivers/net/virtio_net.c 2011-06-14 15:18:46.448596355 -0400 +++ b/drivers/net/virtio_net.c 2011-06-15 12:02:54.860667443 -0400 @@ -40,6 +40,15 @@ module_param(gso, bool, 0444

Re: [PATCH] virtio-net: per cpu 64 bit stats

On Wed, 15 Jun 2011 21:33:16 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 15, 2011 at 11:43:37AM -0400, Stephen Hemminger wrote: Use per-cpu variables to maintain 64 bit statistics. Compile tested only. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com Interesting

Re: [PATCH 00/40] Staging: hv: Driver cleanup

On Fri, 1 Jul 2011 00:19:38 + KY Srinivasan k...@microsoft.com wrote: -Original Message- From: Stephen Hemminger [mailto:shemmin...@vyatta.com] Sent: Thursday, June 30, 2011 7:48 PM To: KY Srinivasan Cc: Christoph Hellwig; de...@linuxdriverproject.org; gre...@suse.de

Re: [RFC] kvm tools: Implement multiple VQ for virtio-net

I have been playing with userspace-rcu which has a number of neat lockless routines for queuing and hashing. But there aren't kernel versions and several of them may require cmpxchg to work. ___ Virtualization mailing list

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

On Mon, 28 Nov 2011 12:25:15 +0800 Jason Wang jasow...@redhat.com wrote: I'm using ixgbe for testing also, for host, its driver seems provide irq affinity hint, so no binding or irqbalance is needed. The hint is for irqbalance to use. You need to still do manual affinity or use irqbalance.

[PATCH] vhost-net: add module alias

style initialization. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- drivers/vhost/net.c|8 +--- include/linux/miscdevice.h |1 + 2 files changed, 6 insertions(+), 3 deletions(-) --- a/drivers/vhost/net.c 2012-01-10 10:56:58.883179194 -0800 +++ b/drivers/vhost

Re: [PATCH] vhost-net: add module alias

On Wed, 11 Jan 2012 15:43:42 +0800 Amos Kong kongjian...@gmail.com wrote: On Wed, Jan 11, 2012 at 12:54 PM, Stephen Hemminger shemmin...@vyatta.comwrote: By adding the a module alias, programs (or users) won't have to explicitly call modprobe. Vhost-net will always be available if built

Re: [PATCH] vhost-net: add module alias

On Wed, 11 Jan 2012 11:07:47 +0400 Michael Tokarev m...@tls.msk.ru wrote: On 11.01.2012 08:54, Stephen Hemminger wrote: By adding the a module alias, programs (or users) won't have to explicitly call modprobe. Vhost-net will always be available if built into the kernel. It does require

[PATCH] vhost-net: add module alias (v2)

initialization. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- v2 - document minor number and make sure to not overlap Documentation/devices.txt |2 ++ drivers/vhost/net.c|8 +--- include/linux/miscdevice.h |1 + 3 files changed, 8 insertions(+), 3 deletions

Re: [PATCH] vhost-net: add module alias (v2.1)

. Vhost-net will always be available if built into the kernel. It does require assigning a permanent minor number for depmod to work. Also: - use C99 style initialization. - add missing entry in documentation for loop-control Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- 2.1 - add

Re: [vmw_vmci RFC 01/11] Apply VMCI context code

On Tue, 15 May 2012 08:06:58 -0700 Andrew Stiegmann (stieg) astiegm...@vmware.com wrote: Context code maintains state for vmci and allows the driver to communicate with multiple VMs. Signed-off-by: Andrew Stiegmann (stieg) astiegm...@vmware.com Running checkpatch reveals the usual noise,

Re: [PATCH] virtio-net: fix a race on 32bit arches

On Wed, 6 Jun 2012 17:49:42 +0300 Michael S. Tsirkin m...@redhat.com wrote: Sounds good, but I have a question: this realies on counters being atomic on 64 bit. Would not it be better to always use a seqlock even on 64 bit? This way counters would actually be correct and in sync. As it is if

Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

On Fri, 06 Jul 2012 11:20:06 +0800 Jason Wang jasow...@redhat.com wrote: On 07/05/2012 08:51 PM, Sasha Levin wrote: On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) if (virtio_has_feature(vdev,

Re: [Question]About KVM network zero-copy feature!

On Fri, 10 Aug 2012 11:34:32 +0800 Peter Huang(Peng) peter.huangp...@huawei.com wrote: Hi,All I searched from git-log, and found that until now we have vhost TX zero-copy experiment feature, how about RX zero-copy? For XEN, net-back also only has TX zero-copy, Is there any reason that

Re: [PATCH 0/6] VSOCK for Linux upstreaming

On Mon, 05 Nov 2012 10:00:38 -0800 George Zhang georgezh...@vmware.com wrote: * * * This series of VSOCK linux upstreaming patches include latest udpate from VMware. Summary of changes: - Add include/linux/socket.h for AF_VSOCK. - Cleanup some comments. - Cleanup

Re: [PATCH 0/6] VSOCK for Linux upstreaming

Never mind, mail server seemed to be overloaded today. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 1/6] VSOCK: vsock protocol implementation.

On Mon, 05 Nov 2012 10:00:51 -0800 George Zhang georgezh...@vmware.com wrote: + /* Added in 2.6.10. */ + .owner = THIS_MODULE, Thanks for submitting this, it will make life easier for distro's that now have to go through extra effort to include out of mainline support for Vmware. You

Re: [net-next RFC] pktgen: don't wait for the device who doesn't free skb immediately after sent

On Mon, 26 Nov 2012 15:56:52 +0800 Jason Wang jasow...@redhat.com wrote: Some deivces do not free the old tx skbs immediately after it has been sent (usually in tx interrupt). One such example is virtio-net which optimizes for virt and only free the possible old tx skbs during the next packet

Re: [net-next RFC] pktgen: don't wait for the device who doesn't free skb immediately after sent

On Tue, 27 Nov 2012 14:45:13 +0800 Jason Wang jasow...@redhat.com wrote: On 11/27/2012 01:37 AM, Stephen Hemminger wrote: On Mon, 26 Nov 2012 15:56:52 +0800 Jason Wang jasow...@redhat.com wrote: Some deivces do not free the old tx skbs immediately after it has been sent (usually in tx

Re: [net-next RFC] pktgen: don't wait for the device who doesn't free skb immediately after sent

On Wed, 28 Nov 2012 14:48:52 +0800 Jason Wang jasow...@redhat.com wrote: On 11/28/2012 12:49 AM, Stephen Hemminger wrote: On Tue, 27 Nov 2012 14:45:13 +0800 Jason Wang jasow...@redhat.com wrote: On 11/27/2012 01:37 AM, Stephen Hemminger wrote: On Mon, 26 Nov 2012 15:56:52 +0800 Jason

Re: [net-next RFC] pktgen: don't wait for the device who doesn't free skb immediately after sent

On Mon, 03 Dec 2012 14:45:46 +0800 Jason Wang jasow...@redhat.com wrote: On Tuesday, November 27, 2012 08:49:19 AM Stephen Hemminger wrote: On Tue, 27 Nov 2012 14:45:13 +0800 Jason Wang jasow...@redhat.com wrote: On 11/27/2012 01:37 AM, Stephen Hemminger wrote: On Mon, 26 Nov 2012

Re: [PATCH 1/3] virtio: change to_vp_device to an inlined definition

On Wed, 5 Dec 2012 15:03:27 +0800 Wanlong Gao gaowanl...@cn.fujitsu.com wrote: to_vp_device is worth changing to inlined definition. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- drivers/virtio/virtio_pci.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

Re: [PATCH net-next v3 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

Minor style issue reported by checkpatch which can be fixed after merge. Although sizeof is actually an operator in C, it is considered correct style to treat it as a function. WARNING: sizeof hdr-hdr should be sizeof(hdr-hdr) #293: FILE: drivers/net/virtio_net.c:395: + sg_set_buf(rq-sg,

Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net

, of the feedback given for this series has been addressed by Jason. Can I get some ACKs? Other than the minor style nit in the first patch, I see no issues. This is really needed by Virtual Routers. Acked-by: Stephen Hemminger shemmin...@vyatta.com

[PATCH] virtio: make config_ops const

It is just a table of function pointers, make it const for cleanliness and security reasons. Signed-off-by: Stephen Hemminger step...@networkplumber.org --- a/drivers/lguest/lguest_device.c2013-02-02 20:03:23.285506053 +1100 +++ b/drivers/lguest/lguest_device.c2013-02-02 20:06

Re: [PATCH 3/3] x86: Support compiling out userspace I/O (iopl and ioperm)

I/O from userspace is used to implement usermode virtio driver(s). This has been done independently by Intel, Brocade/Vyatta, and 6Wind. Sorry, it has to stay. On Mon, Oct 21, 2013 at 7:35 PM, Josh Triplett j...@joshtriplett.org wrote: On the vast majority of modern systems, no processes will

[PATCH net-next 3/3] virtio_net: spelling fixes

Signed-off-by: Stephen Hemminger step...@networkplumber.org --- a/drivers/net/virtio_net.c 2013-12-09 16:12:41.409051865 -0800 +++ b/drivers/net/virtio_net.c 2013-12-09 16:12:43.872996856 -0800 @@ -873,7 +873,7 @@ static netdev_tx_t start_xmit(struct sk_ /* * Send command via the control

[PATCH net-next 1/3] virtio_net: set multicast filter list to host

: Alex Williamson alex.william...@hp.com Date: Wed Feb 4 09:02:45 2009 + virtio_net: Add a MAC filter table Signed-off-by: Stephen Hemminger step...@networkplumber.org --- a/drivers/net/virtio_net.c 2013-12-09 16:12:03.897891975 -0800 +++ b/drivers/net/virtio_net.c 2013-12-09 16:12

[PATCH net-next 2/3] virtio_net: remove unused parameter to send_command

All the code passes NULL for the last sg list (in). Simplify by just removing it. Signed-off-by: Stephen Hemminger step...@networkplumber.org --- a/drivers/net/virtio_net.c 2013-12-09 16:12:36.353164803 -0800 +++ b/drivers/net/virtio_net.c 2013-12-09 16:12:41.409051865 -0800 @@ -876,13

[PATCH net-next] virtio: change comment in transmit

The original comment was not really informative or funny as well as sexist. Replace it with a better explanation of why the driver does stop and what the impacts are. Signed-off-by: Stephen Hemminger step...@networkplumber.org --- a/drivers/net/virtio_net.c 2015-03-24 15:20:25.174671000 -0700

Re: [RFC V7 PATCH 7/7] vhost_net: add interrupt coalescing support

On Mon, 25 May 2015 01:24:04 -0400 Jason Wang jasow...@redhat.com wrote: Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/vhost/net.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 7d137a4..5ee28b7 100644 ---

Re: [PATCH net-next] virtio_net: add ethtool support for set and get of settings

On Tue, 2 Feb 2016 13:51:20 +0100 Nikolay Aleksandrov wrote: > +static bool virtnet_validate_speed(u32 speed) > +{ > + switch (speed) { > + case SPEED_10: > + case SPEED_100: > + case SPEED_1000: > + case SPEED_2500: > + case SPEED_5000: > + case

Re: [RFC v2 -next 1/2] virtio: Start feature MTU support

On Tue, 15 Mar 2016 17:04:12 -0400 Aaron Conole wrote: > --- a/include/uapi/linux/virtio_net.h > +++ b/include/uapi/linux/virtio_net.h > @@ -55,6 +55,7 @@ > #define VIRTIO_NET_F_MQ 22 /* Device supports Receive Flow >*

Re: [RFC v2 -next 1/2] virtio: Start feature MTU support

On Thu, 17 Mar 2016 17:10:55 -0400 Aaron Conole <acon...@redhat.com> wrote: > Stephen Hemminger <step...@networkplumber.org> writes: > > > On Tue, 15 Mar 2016 17:04:12 -0400 > > Aaron Conole <acon...@redhat.com> wrote: > > > >> --- a/include/ua

[PATCH 08/14] vmbus: put related per-cpu variable together

The hv_context structure had several arrays which were per-cpu and was allocating small structures (tasklet_struct). Instead use a single per-cpu array. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/hv/channel_mgmt.c | 35 - drivers/hv/connection.c

[PATCH 07/14] vmbus: callback is in softirq not workqueue

The callback is done via tasklet not workqueue. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- include/linux/hyperv.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 39d493ce550d..b30808f740f9

[PATCH 09/14] vmbus: change to per channel tasklet

Make the event handling tasklet per channel rather than per-cpu. This allows for better fairness when getting lots of data on the same cpu. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/hv/channel.c | 2 +- drivers/hv/channel_mgmt.c | 16 +- driv

[PATCH 13/14] vmbus: constify parameters where possible

Functions that just query state of ring buffer can have parameters marked const. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/hv/hyperv_vmbus.h | 6 +++--- drivers/hv/ring_buffer.c | 22 ++ include/linux/hyperv.h| 12 ++-- 3

[PATCH 14/14] vmbus: replace modulus operation with subtraction

Takes less clock cycles to check for ring wrap and subtract than to do a modulus instruction. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/hv/ring_buffer.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/hv/ring_buffer.c b/driv

[PATCH 12/14] vmbus: expose hv_begin/end_read

In order to implement NAPI in netvsc, the driver needs access to control host interrupt mask. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/hv/hyperv_vmbus.h | 4 drivers/hv/ring_buffer.c | 20 include/linux/hyperv.h

[PATCH 11/14] vmbus: remove conditional locking of vmbus_write

All current usage of vmbus write uses the acquire_lock flag, therefore having it be optional is unnecessary. This also fixes a sparse warning since sparse doesn't like when a function has conditional locking. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/hv/cha

[PATCH 10/14] vmbus: add direct isr callback mode

), and the tasklet is rescheduled if more data is detected. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/hv/channel_mgmt.c| 7 --- drivers/hv/connection.c | 27 --- drivers/hv/hv_util.c | 3 +-- drivers/hv/vmbus_drv.c

[PATCH 03/14] vmbus: remove no longer used signal_policy

The explicit signal policy is no longer used. A different mechanism will be added later when xmit_more is supported. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- include/linux/hyperv.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/include/linux/hy

[PATCH 01/14] vmbus: use kernel bitops for traversing interrupt mask

Use standard kernel operations for find first set bit to traverse the channel bit array. This has added benefit of speeding up lookup on 64 bit and because it uses find first set instruction. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/hv/channel.c

[PATCH 05/14] netvsc: remove no longer needed receive staging buffers

Since commit aed8c164ca5199 ("Drivers: hv: ring_buffer: count on wrap around mappings") it is no longer necessary to handle ring wrapping by having a special receive buffer. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv_net.h | 5

[PATCH 00/14] hyperv: vmbus related patches

support. Stephen Hemminger (14): vmbus: use kernel bitops for traversing interrupt mask vmbus: drop no longer used kick_q argument vmbus: remove no longer used signal_policy vmbus: remove unused kickq argument to sendpacket netvsc: remove no longer needed receive staging buffers vmbus

[PATCH 02/14] vmbus: drop no longer used kick_q argument

The flag to cause notification of host is unused after commit a01a291a282f7c2e ("Drivers: hv: vmbus: Base host signaling strictly on the ring state"). Therefore remove it from the ring buffer internal API. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- driv

[PATCH 06/14] vmbus: remove per channel state

The netvsc no longer needs per channel state hook to track receive buffer. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- include/linux/hyperv.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 8c6a15

Re: [PATCH 1/2] hyperv: implement hv_get_tsc_page()

On Thu, 9 Feb 2017 21:14:25 +0100 (CET) Thomas Gleixner <t...@linutronix.de> wrote: > On Thu, 9 Feb 2017, Stephen Hemminger wrote: > > > The actual code looks fine, but the style police will not like you. > > { should be at start of line on functions. > > And #e

Re: [PATCH 2/2] x86/vdso: Add VCLOCK_HVCLOCK vDSO clock read method

e] > >> Sent: Thursday, February 9, 2017 9:08 AM > >> To: Vitaly Kuznetsov <vkuzn...@redhat.com> > >> Cc: x...@kernel.org; Andy Lutomirski <l...@amacapital.net>; Ingo Molnar > >> <mi...@redhat.com>; H. Peter Anvin <h...@zytor.com>; KY Sr

[PATCH net-next] net: make ndo_get_stats64 a void function

to have a void function. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/bonding/bond_main.c | 10 -- drivers/net/dummy.c | 5 ++--- drivers/net/ethernet/alacritech/slicoss.c| 6 ++ drive

Re: [PATCH net-next V3 3/3] tun: rx batching

On Fri, 30 Dec 2016 13:20:51 +0800 Jason Wang wrote: > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index cd8e02c..a268ed9 100644 > --- a/drivers/net/tun.c > +++ b/drivers/net/tun.c > @@ -75,6 +75,10 @@ > > #include > > +static int rx_batched; >

Re: [PATCH v3 2/3] x86/hyperv: move TSC reading method to asm/mshyperv.h

Minor coding comments > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h > index d324dce..4ff25436 100644 > --- a/arch/x86/include/asm/mshyperv.h > +++ b/arch/x86/include/asm/mshyperv.h > @@ -178,6 +178,56 @@ void hyperv_cleanup(void); > #endif > #ifdef

[PATCH net-next 4/4] mlx4: sizeof style usage

The kernel coding style is to treat sizeof as a function (ie. with parenthesis) not as an operator. Also use kcalloc and kmalloc_array Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- drivers/net/ethernet/mellanox/mlx4/alloc.c | 2 +- drivers/net/ethernet/mellano

[PATCH net-next 3/4] skge: add paren around sizeof arg

Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- drivers/net/ethernet/marvell/skge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 5d7d94de4e00..8a835e82256a

[PATCH net-next 1/4] tun/tap: use paren's with sizeof

Although sizeof is an operator in C. The kernel coding style convention is to always use it like a function and add parenthesis. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- drivers/net/tap.c | 2 +- drivers/net/tun.c | 2 +- 2 files changed, 2 insertions(+), 2 del

[PATCH] uapi: add SPDX identifier to vm_sockets_diag.h

New file seems to have missed the SPDX license scan and update. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- include/uapi/linux/vm_sockets_diag.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/vm_sockets_diag.h b/include/uapi/linux/vm_sockets_

Re: [RFC] virtio-net: help live migrate SR-IOV devices

gt; > > - virtio-net acts as the interface to the VM > > > - live migration initiates > > > - link goes down on SR-IOV, or SR-IOV device is removed > > > - failover to virtio-net as primary path > > > - migration continues to new host > > > - new host

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Tue, 19 Dec 2017 20:07:01 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Tue, Dec 19, 2017 at 09:55:48AM -0800, Stephen Hemminger wrote: > > On Tue, 19 Dec 2017 09:41:39 -0800 > > "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Tue, 19 Dec 2017 14:37:50 -0800 "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: > On 12/19/2017 11:46 AM, Stephen Hemminger wrote: > > On Tue, 19 Dec 2017 11:42:33 -0800 > > "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: >

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Tue, 19 Dec 2017 13:21:17 -0500 (EST) David Miller <da...@davemloft.net> wrote: > From: Stephen Hemminger <step...@networkplumber.org> > Date: Tue, 19 Dec 2017 09:55:48 -0800 > > > could be 10ms, just enough to let udev do its renaming > > Please, move to s

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Tue, 19 Dec 2017 11:42:33 -0800 "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: > On 12/19/2017 10:41 AM, Stephen Hemminger wrote: > > On Tue, 19 Dec 2017 13:21:17 -0500 (EST) > > David Miller <da...@davemloft.net> wrote: > > > >>

Re: [RFC] virtio-net: help live migrate SR-IOV devices

On Tue, 5 Dec 2017 14:29:28 -0800 Jakub Kicinski wrote: > On Tue, 5 Dec 2017 11:59:17 +0200, achiad shochat wrote: > > I second Jacob - having a netdev of one device driver enslave a netdev > > of another device driver is an awkward a-symmetric model. > >

Re: [RFC] virtio-net: help live migrate SR-IOV devices

On Sun, 3 Dec 2017 11:14:37 +0200 achiad shochat wrote: > On 3 December 2017 at 07:05, Michael S. Tsirkin wrote: > > On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: > >> On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: > >> > On

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: > +static struct net_device *net_failover_get_bymac(u8 *mac, > + struct net_failover_ops **ops) > +{ > + struct net_device *failover_dev; > + struct

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: > This provides a generic interface for paravirtual drivers to listen > for netdev register/unregister/link change events from pci ethernet > devices with the same MAC and takeover their datapath. The

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: > + if (netif_running(failover_dev)) { > + err = dev_open(slave_dev); > + if (err && (err != -EBUSY)) { > + netdev_err(failover_dev, "Opening slave %s failed

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On Thu, 24 May 2018 09:55:14 -0700 Sridhar Samudrala wrote: > --- a/drivers/net/hyperv/Kconfig > +++ b/drivers/net/hyperv/Kconfig > @@ -2,5 +2,6 @@ config HYPERV_NET > tristate "Microsoft Hyper-V virtual network driver" > depends on HYPERV > select

Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

On Thu, 24 May 2018 09:55:13 -0700 Sridhar Samudrala wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 03ed492c4e14..0f4ba52b641d 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1421,6 +1421,8 @@

Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

On Thu, 24 May 2018 09:55:13 -0700 Sridhar Samudrala wrote: > + spin_lock(_lock); Since register is not in fast path, this should be a mutex? > +int failover_slave_unregister(struct net_device *slave_dev) > +{ > + struct net_device *failover_dev; > +

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On Fri, 25 May 2018 16:11:47 -0700 "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: > On 5/25/2018 3:34 PM, Stephen Hemminger wrote: > > On Thu, 24 May 2018 09:55:14 -0700 > > Sridhar Samudrala <sridhar.samudr...@intel.com> wrote: > > >

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On Thu, 24 May 2018 09:55:14 -0700 Sridhar Samudrala wrote: > Use the registration/notification framework supported by the generic > failover infrastructure. > > Signed-off-by: Sridhar Samudrala Why was this merged? It was never signed off by any of the netvsc maintainers, and there were

Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

On Fri, 25 May 2018 16:06:58 -0700 "Samudrala, Sridhar" wrote: > On 5/25/2018 3:38 PM, Stephen Hemminger wrote: > > On Thu, 24 May 2018 09:55:13 -0700 > > Sridhar Samudrala wrote: > > > >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice

Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

On Fri, 25 May 2018 16:06:58 -0700 "Samudrala, Sridhar" wrote: > On 5/25/2018 3:38 PM, Stephen Hemminger wrote: > > On Thu, 24 May 2018 09:55:13 -0700 > > Sridhar Samudrala wrote: > > > >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On Wed, 30 May 2018 20:03:11 -0700 "Samudrala, Sridhar" wrote: > On 5/30/2018 7:06 PM, Stephen Hemminger wrote: > > On Thu, 24 May 2018 09:55:14 -0700 > > Sridhar Samudrala wrote: > > > >> Use the registration/notification framework supported by

Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Thu, 26 Apr 2018 05:30:05 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Wed, Apr 25, 2018 at 05:08:37PM -0700, Stephen Hemminger wrote: > > On Wed, 25 Apr 2018 16:59:28 -0700 > > Sridhar Samudrala <sridhar.samudr...@intel.com> wrote: > >

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, 26 Jan 2018 18:30:03 -0800 Jakub Kicinski wrote: > On Fri, 26 Jan 2018 15:30:35 -0800, Samudrala, Sridhar wrote: > > On 1/26/2018 2:47 PM, Jakub Kicinski wrote: > > > On Sat, 27 Jan 2018 00:14:20 +0200, Michael S. Tsirkin wrote: > > >> On Fri, Jan 26, 2018 at

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On Thu, 22 Feb 2018 13:30:12 -0800 Alexander Duyck wrote: > > Again, I undertand your motivation. Yet I don't like your solution. > > But if the decision is made to do this in-driver bonding. I would like > > to see it baing done some generic way: > > 1) share the same

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

(pruned to reduce thread) On Wed, 21 Feb 2018 16:17:19 -0800 Alexander Duyck wrote: > >>> FWIW two solutions that immediately come to mind is to export "backup" > >>> as phys_port_name of the backup virtio link and/or assign a name to the > >>> master like you are

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On Mon, 22 Jan 2018 15:27:40 -0800 "Samudrala, Sridhar" wrote: > On 1/22/2018 1:31 PM, Michael S. Tsirkin wrote: > > On Wed, Jan 17, 2018 at 01:49:58PM -0800, Alexander Duyck wrote: > >> On Wed, Jan 17, 2018 at 11:57 AM, Michael S. Tsirkin > >>

Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework

On Tue, 10 Apr 2018 11:59:50 -0700 Sridhar Samudrala wrote: > Use the registration/notification framework supported by the generic > bypass infrastructure. > > Signed-off-by: Sridhar Samudrala > --- Thanks for doing this. Your current

  1   2   >