Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

2021-03-23 Thread Arnd Bergmann
On Tue, Mar 23, 2021 at 9:33 AM Jie Deng wrote: > > On 2021/3/23 15:27, Viresh Kumar wrote: > > > On 23-03-21, 22:19, Jie Deng wrote: > >> +static int __maybe_unused virtio_i2c_freeze(struct virtio_device *vdev) > >> +{ > >> +virtio_i2c_del_vqs(vdev); > >> +return 0; > >> +} > >> + > >>

Re: [PATCH v8] i2c: virtio: add a virtio i2c frontend driver

2021-03-19 Thread Arnd Bergmann
On Fri, Mar 19, 2021 at 7:35 AM Viresh Kumar wrote: > > On 19-03-21, 14:29, Jie Deng wrote: > > I also see example drivers/i2c/busses/i2c-xiic.c. Some people might think > > this way is more clearer than > > > > updating each member in probe. Basically, I think it's just a matter of > > personal

Re: [PATCH v8] i2c: virtio: add a virtio i2c frontend driver

2021-03-18 Thread Arnd Bergmann
On Thu, Mar 18, 2021 at 3:42 PM Enrico Weigelt, metux IT consult wrote: > > On 16.03.21 08:44, Viresh Kumar wrote: > > > FWIW, this limits this driver to support a single device ever. We > > can't bind multiple devices to this driver now. Yeah, perhaps we will > > never be required to do so, but

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-15 Thread Arnd Bergmann
On Mon, Mar 15, 2021 at 6:54 AM Jie Deng wrote: > On 2021/3/15 11:13, Jason Wang wrote: > > On 2021/3/15 9:14 上午, Jie Deng wrote: > >> On 2021/3/12 16:58, Arnd Bergmann wrote: > > > Then do you think it is necessary to mark the virtio bufs with > cacheline_al

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-12 Thread Arnd Bergmann
On Fri, Mar 12, 2021 at 2:33 PM Jie Deng wrote: > + > +/** > + * struct virtio_i2c_req - the virtio I2C request structure > + * @out_hdr: the OUT header of the virtio I2C message > + * @buf: the buffer into which data is read, or from which it's written > + * @in_hdr: the IN header of the virtio

Re: [PATCH v6] i2c: virtio: add a virtio i2c frontend driver

2021-03-10 Thread Arnd Bergmann
On Wed, Mar 10, 2021 at 4:59 AM Jason Wang wrote: > On 2021/3/10 10:22 上午, Jie Deng wrote: > > On 2021/3/4 17:15, Jason Wang wrote: > >> > >> > >>> +} > >>> + > >>> +if (msgs[i].flags & I2C_M_RD) > >>> +memcpy(msgs[i].buf, req->buf, msgs[i].len); > >> > >> > >> Sorry

Re: [PATCH v5] i2c: virtio: add a virtio i2c frontend driver

2021-03-02 Thread Arnd Bergmann
On Tue, Mar 2, 2021 at 10:51 AM Stefan Hajnoczi wrote: > On Tue, Mar 02, 2021 at 10:42:06AM +0800, Jie Deng wrote: > > > > +/* > > > > + * Definitions for virtio I2C Adpter > > > > + * > > > > + * Copyright (c) 2021 Intel Corporation. All rights reserved. > > > > + */ > > > > + > > > > +#ifndef

Re: [PATCH v5] i2c: virtio: add a virtio i2c frontend driver

2021-03-01 Thread Arnd Bergmann
On Mon, Mar 1, 2021 at 1:10 PM Andy Shevchenko wrote: > On Mon, Mar 01, 2021 at 02:09:25PM +0200, Andy Shevchenko wrote: > > On Mon, Mar 01, 2021 at 05:24:41PM +0530, Viresh Kumar wrote: > > > On 01-03-21, 14:41, Jie Deng wrote: > > > > +/** > > > > + * struct virtio_i2c_req - the virtio I2C

Re: [PATCH v5] i2c: virtio: add a virtio i2c frontend driver

2021-03-01 Thread Arnd Bergmann
On Mon, Mar 1, 2021 at 7:41 AM Jie Deng wrote: > --- /dev/null > +++ b/include/uapi/linux/virtio_i2c.h > @@ -0,0 +1,56 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later WITH Linux-syscall-note */ > +/* > + * Definitions for virtio I2C Adpter > + * > + * Copyright (c) 2021 Intel Corporation. All

Re: [PATCH 04/18] alpha: Override READ_ONCE() with barriered implementation

2020-07-02 Thread Arnd Bergmann
On Thu, Jul 2, 2020 at 1:18 PM Will Deacon wrote: > On Thu, Jul 02, 2020 at 12:08:41PM +0200, Arnd Bergmann wrote: > > On Thu, Jul 2, 2020 at 11:48 AM Will Deacon wrote: > > > On Thu, Jul 02, 2020 at 10:32:39AM +0100, Mark Rutland wrote: > Not sure I follow you here, but I

Re: [PATCH 04/18] alpha: Override READ_ONCE() with barriered implementation

2020-07-02 Thread Arnd Bergmann
On Thu, Jul 2, 2020 at 11:48 AM Will Deacon wrote: > On Thu, Jul 02, 2020 at 10:32:39AM +0100, Mark Rutland wrote: > > On Tue, Jun 30, 2020 at 06:37:20PM +0100, Will Deacon wrote: > > > -#define read_barrier_depends() __asm__ __volatile__("mb": : :"memory") > > > +#define __smp_load_acquire(p)

Re: [PATCH 0/5] drivers/char: Constify static variables

2020-07-02 Thread Arnd Bergmann
o - Constify id_table[] > ipmi: watchdog: Constify ident > virtio_console: Constify some static variables I just realized it was a series rather than a single patch I received. They all look correct, so Acked-by: Arnd Bergmann but if you do more of those, I would suggest not including the

Re: [PATCH 02/18] compiler.h: Split {READ, WRITE}_ONCE definitions out into rwonce.h

2020-07-01 Thread Arnd Bergmann
On Wed, Jul 1, 2020 at 12:16 PM Will Deacon wrote: > On Tue, Jun 30, 2020 at 09:11:32PM +0200, Arnd Bergmann wrote: > > On Tue, Jun 30, 2020 at 7:37 PM Will Deacon wrote: > > > > > > In preparation for allowing architectures to define their own > > > implement

Re: [PATCH 18/18] arm64: lto: Strengthen READ_ONCE() to acquire when CLANG_LTO=y

2020-07-01 Thread Arnd Bergmann
On Wed, Jul 1, 2020 at 12:19 PM Will Deacon wrote: > On Tue, Jun 30, 2020 at 09:25:03PM +0200, Arnd Bergmann wrote: > > On Tue, Jun 30, 2020 at 7:39 PM Will Deacon wrote: > > Once we make gcc-4.9 the minimum version, > > this could be further improved to > > >

Re: [PATCH 18/18] arm64: lto: Strengthen READ_ONCE() to acquire when CLANG_LTO=y

2020-06-30 Thread Arnd Bergmann
On Tue, Jun 30, 2020 at 7:39 PM Will Deacon wrote: > +#define __READ_ONCE(x) \ > +({ \ > + int atomic = 1; \ > + union {

Re: [PATCH 02/18] compiler.h: Split {READ, WRITE}_ONCE definitions out into rwonce.h

2020-06-30 Thread Arnd Bergmann
On Tue, Jun 30, 2020 at 7:37 PM Will Deacon wrote: > > In preparation for allowing architectures to define their own > implementation of the READ_ONCE() macro, move the generic > {READ,WRITE}_ONCE() definitions out of the unwieldy 'linux/compiler.h' > file and into a new 'rwonce.h' header under

[PATCH] vhost: fix default for vhost_iotlb

2020-04-29 Thread Arnd Bergmann
this configuration. Fixes: e6faeaa12841 ("vhost: drop vring dependency on iotlb") Signed-off-by: Arnd Bergmann --- I fixed this a while ago locally but never got around to sending the fix. If the problem has been addressed differently in the meantime, please ignore this one. --- d

Re: [PATCH V9 9/9] virtio: Intel IFC VF driver for VDPA

2020-04-09 Thread Arnd Bergmann
On Thu, Mar 26, 2020 at 3:08 PM Jason Wang wrote: > > From: Zhu Lingshan > > This commit introduced two layers to drive IFC VF: > > (1) ifcvf_base layer, which handles IFC VF NIC hardware operations and > configurations. > > (2) ifcvf_main layer, which complies to VDPA bus framework, >

Re: [PATCH v2 2/2] vhost: disable for OABI

2020-04-06 Thread Arnd Bergmann
On Mon, Apr 6, 2020 at 3:02 PM Michael S. Tsirkin wrote: > > On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote: > > On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin wrote: > > > > > > > > +config VHOST_DPN > > > + bool "

Re: [PATCH v2 2/2] vhost: disable for OABI

2020-04-06 Thread Arnd Bergmann
On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin wrote: > > +config VHOST_DPN > + bool "VHOST dependencies" > + depends on !ARM || AEABI > + default y > + help > + Anything selecting VHOST or VHOST_RING must depend on VHOST_DPN. > + This excludes the

Re: [PATCH v3 13/22] compat_ioctl: scsi: move ioctl handling into drivers

2020-02-12 Thread Arnd Bergmann
On Wed, Feb 12, 2020 at 10:15 PM Johannes Hirte wrote: > > On 2020 Jan 02, Arnd Bergmann wrote: > > Error in getting drive hardware properties > Error in getting drive reading properties > Error in getting drive writing properties > __ &g

Re: [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-08 Thread Arnd Bergmann
y the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Suggested-by: Geert Uytterhoeven > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Geert Uytterhoeven Thanks for getting this done! R

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-08 Thread Arnd Bergmann
On Wed, Jan 8, 2020 at 10:15 AM Krzysztof Kozlowski wrote: > > The __force-cast that removes the __iomem here also means that > > the 'volatile' keyword could be dropped from the argument list, > > as it has no real effect any more, but then there are a few drivers > > that mark their iomem

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-08 Thread Arnd Bergmann
On Wed, Jan 8, 2020 at 9:36 AM Christophe Leroy wrote: > Le 08/01/2020 à 09:18, Krzysztof Kozlowski a écrit : > > On Wed, 8 Jan 2020 at 09:13, Geert Uytterhoeven > > wrote: > > I'll add to this one also changes to ioreadX_rep() and add another > > patch for volatile for reads and writes. I

Re: [RFT 06/13] arc: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-07 Thread Arnd Bergmann
On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the > address so they can be

Re: [RFT 03/13] sh: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-07 Thread Arnd Bergmann
On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be

[PATCH v3 13/22] compat_ioctl: scsi: move ioctl handling into drivers

2020-01-02 Thread Arnd Bergmann
mode, with the argument passed through compat_ptr(). With this, we can remove the entries from fs/compat_ioctl.c. The new code is larger, but should be easier to maintain and keep updated with newly added commands. Signed-off-by: Arnd Bergmann --- drivers/block/virtio_blk.c | 3 + drivers/scsi

Re: [PATCH 15/24] compat_ioctl: scsi: move ioctl handling into drivers

2019-12-12 Thread Arnd Bergmann
On Thu, Dec 12, 2019 at 1:28 AM Paolo Bonzini wrote: > On 12/12/19 00:05, Michael S. Tsirkin wrote: > >> @@ -405,6 +405,9 @@ static int virtblk_getgeo(struct block_device *bd, > >> struct hd_geometry *geo) > >> > >> static const struct block_device_operations virtblk_fops = { > >> .ioctl

[PATCH 15/24] compat_ioctl: scsi: move ioctl handling into drivers

2019-12-11 Thread Arnd Bergmann
mode, with the argument passed through compat_ptr(). With this, we can remove the entries from fs/compat_ioctl.c. The new code is larger, but should be easier to maintain and keep updated with newly added commands. Signed-off-by: Arnd Bergmann --- drivers/block/virtio_blk.c | 3 + drivers/scsi

[PATCH 00/24] block, scsi: final compat_ioctl cleanup

2019-12-11 Thread Arnd Bergmann
rg/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=compat-ioctl-endgame Arnd Bergmann (24): compat: ARM64: always include asm-generic/compat.h compat: scsi: sg: fix v3 compat read/write interface compat_ioctl: block: handle BLKREPORTZONE/BLKRESETZONE compat_ioctl: block: handle BL

Re: [PATCH 01/13] compiler.h: Split {READ, WRITE}_ONCE definitions out into rwonce.h

2019-11-11 Thread Arnd Bergmann
On Mon, Nov 11, 2019 at 9:10 AM Christian Borntraeger wrote: > On 08.11.19 20:57, Arnd Bergmann wrote: > > On Fri, Nov 8, 2019 at 6:01 PM Will Deacon wrote: > >> > >> In preparation for allowing architectures to define their own > >> implementation of the '

Re: [PATCH 01/13] compiler.h: Split {READ, WRITE}_ONCE definitions out into rwonce.h

2019-11-08 Thread Arnd Bergmann
On Fri, Nov 8, 2019 at 6:01 PM Will Deacon wrote: > > In preparation for allowing architectures to define their own > implementation of the 'READ_ONCE()' macro, move the generic > '{READ,WRITE}_ONCE()' definitions out of the unwieldy 'linux/compiler.h' > and into a new 'rwonce.h' header under

[PATCH v5 12/29] compat_ioctl: move drivers to compat_ptr_ioctl

2019-07-30 Thread Arnd Bergmann
-by: Jason Gunthorpe Reviewed-by: Jiri Kosina Reviewed-by: Stefan Hajnoczi Signed-off-by: Arnd Bergmann --- drivers/char/ppdev.c | 12 +- drivers/char/tpm/tpm_vtpm_proxy.c | 12 +- drivers/firewire/core-cdev.c | 12 +- drivers/hid/usbhid/hiddev.c

[PATCH v3 09/26] compat_ioctl: move drivers to compat_ptr_ioctl

2019-04-16 Thread Arnd Bergmann
-off-by: Arnd Bergmann --- drivers/char/ppdev.c | 12 +- drivers/char/tpm/tpm_vtpm_proxy.c | 12 +- drivers/firewire/core-cdev.c | 12 +- drivers/hid/usbhid/hiddev.c | 11 + drivers/hwtracing/stm/core.c | 12 +- drivers/misc/mei

[PATCH] vhost: silence an unused-variable warning

2019-03-06 Thread Arnd Bergmann
= vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX) ? 2 : 0; Mark the variable as __maybe_unused to shut up that warning. Signed-off-by: Arnd Bergmann --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index

Re: [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support

2018-09-24 Thread Arnd Bergmann
On Mon, Sep 17, 2018 at 3:00 PM Thomas Gleixner wrote: > > On Fri, 14 Sep 2018, Arnd Bergmann wrote: > > On Fri, Sep 14, 2018 at 2:52 PM Thomas Gleixner wrote: > > A couple of architectures (s390, ia64, riscv, powerpc, arm64) > > implement the vdso as assemble

Re: [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support

2018-09-14 Thread Arnd Bergmann
On Fri, Sep 14, 2018 at 2:52 PM Thomas Gleixner wrote: > > Matt attempted to add CLOCK_TAI support to the VDSO clock_gettime() > implementation, which extended the clockid switch case and added yet > another slightly different copy of the same code. > > Especially the extended switch case is

Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Arnd Bergmann
On Wed, Sep 12, 2018 at 5:33 PM Jason Gunthorpe wrote: > > On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote: > > Each of these drivers has a copy of the same trivial helper function to > > convert the pointer argument and then call the native ioctl handler. &

[PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Arnd Bergmann
Each of these drivers has a copy of the same trivial helper function to convert the pointer argument and then call the native ioctl handler. We now have a generic implementation of that, so use it. Signed-off-by: Arnd Bergmann --- drivers/char/ppdev.c | 12 +- drivers/char

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-08 Thread Arnd Bergmann
On Thu, Jun 7, 2018 at 10:49 PM, Nick Desaulniers wrote: > Functions marked extern inline do not emit an externally visible > function when the gnu89 C standard is used. Some KBUILD Makefiles > overwrite KBUILD_CFLAGS. This is an issue for GCC 5.1+ users as without > an explicit C standard

Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline

2018-06-05 Thread Arnd Bergmann
On Tue, Jun 5, 2018 at 11:28 PM, Arnd Bergmann wrote: > On Tue, Jun 5, 2018 at 7:05 PM, Nick Desaulniers > wrote: >> >> The semantics of extern inline has changed since gnu89. This means that >> folks using GCC versions >= 5.1 may see symbol redefinition errors

Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline

2018-06-05 Thread Arnd Bergmann
On Tue, Jun 5, 2018 at 7:05 PM, Nick Desaulniers wrote: > > The semantics of extern inline has changed since gnu89. This means that > folks using GCC versions >= 5.1 may see symbol redefinition errors at > link time for subdirs that override KBUILD_CFLAGS (making the C standard > used implicit)

[4.4-stable 12/22] virtio_balloon: prevent uninitialized variable use

2018-02-20 Thread Arnd Bergmann
tio: Add memory statistics reporting to the balloon driver (V4)") Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Ladi Prosek <lpro...@redhat.com> Signed-off-by: Michael S. Tsirkin <m...@redhat.com> [arnd: backported to 4.4] Signed-off-by: Arnd Bergmann <

[PATCH net-next] virtio-net: mark PM functions as __maybe_unused

2017-07-25 Thread Arnd Bergmann
just silently drop the unused code. Fixes: 4941d472bf95 ("virtio-net: do not reset during XDP set") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/virtio_net.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/

Re: [PATCH v3 2/3] virtio-balloon: use actual number of stats for stats queue buffers

2017-03-28 Thread Arnd Bergmann
atistics in all > buffers submitted to the statsq." > > Suggested-by: Arnd Bergmann <a...@arndb.de> > Signed-off-by: Ladi Prosek <lpro...@redhat.com> > Acked-by: Arnd Bergmann <a...@arndb.de> ___ Virtualization mailing list Vi

Re: [PATCH] virtio_balloon: prevent uninitialized variable use

2017-03-24 Thread Arnd Bergmann
On Fri, Mar 24, 2017 at 9:11 PM, Ladi Prosek <lpro...@redhat.com> wrote: > On Fri, Mar 24, 2017 at 7:38 PM, David Hildenbrand <da...@redhat.com> wrote: >> On 23.03.2017 16:17, Arnd Bergmann wrote: >>> The latest gcc-7.0.1 snapshot reports a new warning: >>> &

[PATCH] virtio_balloon: prevent uninitialized variable use

2017-03-23 Thread Arnd Bergmann
iver (V4)") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/virtio/virtio_balloon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 4e1191508228..cd5c54e2003d 100644 --- a/drivers/virtio/virtio_balloon.c +

Re: [PATCH] virtio_mmio: Set DMA masks appropriately

2017-01-10 Thread Arnd Bergmann
On Tuesday, January 10, 2017 1:44:37 PM CET Robin Murphy wrote: > On 10/01/17 13:15, Arnd Bergmann wrote: > > On Tuesday, January 10, 2017 12:26:01 PM CET Robin Murphy wrote: > >> @@ -548,6 +550,14 @@ static int virtio_mmio_probe(struct platform_device > >> *pdev) >

Re: [PATCH] virtio_mmio: Set DMA masks appropriately

2017-01-10 Thread Arnd Bergmann
On Tuesday, January 10, 2017 12:26:01 PM CET Robin Murphy wrote: > @@ -548,6 +550,14 @@ static int virtio_mmio_probe(struct platform_device > *pdev) > if (vm_dev->version == 1) > writel(PAGE_SIZE, vm_dev->base + VIRTIO_MMIO_GUEST_PAGE_SIZE); > > + rc =

Re: [PATCH] x86/paravirt: hide unused patch_default label

2016-12-16 Thread Arnd Bergmann
On Friday, December 16, 2016 10:51:50 AM CET Peter Zijlstra wrote: > -patch_default: > +patch_default: __maybe_unused > ret = paravirt_patch_default(type, clobbers, ibuf, addr, len); > break; > Ah, nice, I didn't know you could do that. Yes, please do this

[PATCH] x86/paravirt: hide unused patch_default label

2016-12-16 Thread Arnd Bergmann
t;x86/paravirt: Fix native_patch()") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- arch/x86/kernel/paravirt_patch_32.c | 2 ++ arch/x86/kernel/paravirt_patch_64.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/arch/x86/kernel/paravirt_patch_32.c b/arch/x86/kernel/paravirt_

Re: [PATCH] virtio: mark vring_dma_dev() static

2016-09-01 Thread Arnd Bergmann
e file in which it is > declared and don't need a declaration, but can be made static. > so this patch marks this function with 'static'. > > Signed-off-by: Baoyou Xie <baoyou....@linaro.org> > Acked-by: Arnd Bergmann <a...@arndb.de> _

[PATCH] drm/virtio: fix building without CONFIG_FBDEV

2016-08-02 Thread Arnd Bergmann
subsystems are configured as loadable modules. Signed-off-by: Arnd Bergmann <a...@arndb.de> Fixes: 0b6320dfdfea ("drm/virtio: make fbdev support really optional") --- drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: Build regressions/improvements in v4.7-rc6

2016-07-04 Thread Arnd Bergmann
On Monday, July 4, 2016 10:21:45 AM CEST Geert Uytterhoeven wrote: > On Mon, Jul 4, 2016 at 10:12 AM, Geert Uytterhoeven > wrote: > > JFYI, when comparing v4.7-rc6[1] to v4.7-rc5[3], the summaries are: > > - build errors: +3/-2 > > +

Re: [PATCH 00/34] arch: barrier cleanup + __smp_xxx barriers for virt

2015-12-30 Thread Arnd Bergmann
On Wednesday 30 December 2015 23:45:41 Michael S. Tsirkin wrote: > On Wed, Dec 30, 2015 at 02:49:53PM +0100, Arnd Bergmann wrote: > > On Wednesday 30 December 2015 15:24:12 Michael S. Tsirkin wrote: > > > This is really trying to cleanup some virt code, as suggested by Peter, &g

Re: [PATCH 08/34] asm-generic: smp_store_mb should use smp_mb

2015-12-30 Thread Arnd Bergmann
On Wednesday 30 December 2015 15:24:47 Michael S. Tsirkin wrote: > asm-generic variant of smp_store_mb() calls mb() which is stronger > than implied by both the name and the documentation. > > smp_store_mb is only used by core kernel code at the moment, so > we know no one mis-uses it for an MMIO

Re: [PATCH 00/34] arch: barrier cleanup + __smp_XXX barriers for virt

2015-12-30 Thread Arnd Bergmann
for using the asm-generic file, and for the virtualization users. Please add my "Acked-by: Arnd Bergmann <a...@arndb.de>" when merging the series through your tree. Arnd ___ Virtualization mailing list Virtualization@lists.linux-fo

[PATCH] vhost: vsock: select CONFIG_VHOST

2015-12-08 Thread Arnd Bergmann
When building the new vsock code without vhost, we get a build error: drivers/built-in.o: In function `vhost_vsock_flush': :(.text+0x24d29c): undefined reference to `vhost_poll_flush' This adds an explicit 'select' like we have for the other vhost drivers. Signed-off-by: Arnd Bergmann

Re: [PATCH] drm/virtio: use %llu format string form atomic64_t

2015-10-19 Thread Arnd Bergmann
On Monday 19 October 2015 11:37:00 Ralf Baechle wrote: > On Wed, Oct 07, 2015 at 01:23:07PM +0200, Arnd Bergmann wrote: > > > > I haven't checked all architectures, but I assume what happens is that > > > 64-bit ones just #define atomic64_t atomic_long_t, so they don't hav

Re: [PATCH] drm/virtio: use %llu format string form atomic64_t

2015-10-19 Thread Arnd Bergmann
On Monday 19 October 2015 09:34:15 Geert Uytterhoeven wrote: > On Wed, Oct 7, 2015 at 1:23 PM, Arnd Bergmann <a...@arndb.de> wrote: > > static __inline__ int atomic64_add_unless(atomic64_t *v, long a, long u) > > > > which truncates the result to 32 bit. > > W

[PATCH] drm/virtio: use %llu format string form atomic64_t

2015-10-07 Thread Arnd Bergmann
t strings to %llu and adds a cast to u64, which makes it work the same way everywhere. Signed-off-by: Arnd Bergmann <a...@arndb.de> diff --git a/drivers/gpu/drm/virtio/virtgpu_debugfs.c b/drivers/gpu/drm/virtio/virtgpu_debugfs.c index db8b49101a8b..512263919282 100644 --- a/drivers/gpu/drm/virtio

Re: [PATCH] drm/virtio: use %llu format string form atomic64_t

2015-10-07 Thread Arnd Bergmann
On Wednesday 07 October 2015 11:45:02 Russell King - ARM Linux wrote: > On Wed, Oct 07, 2015 at 12:41:21PM +0200, Arnd Bergmann wrote: > > The virtgpu driver prints the last_seq variable using the %ld or > > %lu format string, which does not work correctly on all architectures

Re: [PATCH] drm/virtio: use %llu format string form atomic64_t

2015-10-07 Thread Arnd Bergmann
On Wednesday 07 October 2015 13:04:06 Arnd Bergmann wrote: > On Wednesday 07 October 2015 11:45:02 Russell King - ARM Linux wrote: > > On Wed, Oct 07, 2015 at 12:41:21PM +0200, Arnd Bergmann wrote: > > > The virtgpu driver prints the last_seq variable using the %ld or >

Re: [PULL] uaccess: fix sparse warning on get/put_user for bitwise types

2015-01-14 Thread Arnd Bergmann
On Wednesday 14 January 2015 19:36:18 Michael S. Tsirkin wrote: As you asked, here's a pull request. This has been in linux-next apparently with no ill effects. The following changes since commit 99975cc6ada0d5f2675e83abecae05aba5f437d2: vhost/net: length miscalculation (2015-01-07

Re: [PATCH RFC 3/5] pci: add pci_iomap_range

2014-12-11 Thread Arnd Bergmann
On Thursday 11 December 2014 21:37:34 Michael S. Tsirkin wrote: if (flags IORESOURCE_MEM) { - if (flags IORESOURCE_CACHEABLE) + if (!force_nocache (flags IORESOURCE_CACHEABLE)) return ioremap(start, len); return

Re: [RFC PATCH 00/11] Refactor MSI to support Non-PCI device

2014-08-04 Thread Arnd Bergmann
On Monday 04 August 2014, Yijing Wang wrote: I have another question is some drivers will request more than one MSI/MSI-X IRQ, and the driver will use them to process different things. Eg. network driver generally uses one of them to process trivial network thins, and others to

Re: [RFC PATCH 00/11] Refactor MSI to support Non-PCI device

2014-08-04 Thread Arnd Bergmann
On Monday 04 August 2014, Yijing Wang wrote: On 2014/8/1 21:52, Arnd Bergmann wrote: On Wednesday 30 July 2014, Yijing Wang wrote: On 2014/7/29 22:08, Arnd Bergmann wrote: The other part I'm not completely sure about is how you want to have MSIs map into normal IRQ descriptors

Re: [RFC PATCH 00/11] Refactor MSI to support Non-PCI device

2014-08-01 Thread Arnd Bergmann
On Wednesday 30 July 2014, Yijing Wang wrote: The other part I'm not completely sure about is how you want to have MSIs map into normal IRQ descriptors. At the moment, all MSI users are based on IRQ numbers, but this has known scalability problems. Hmmm, I still use the IRQ number

Re: [RFC PATCH 00/11] Refactor MSI to support Non-PCI device

2014-08-01 Thread Arnd Bergmann
On Wednesday 30 July 2014, Yijing Wang wrote: On 2014/7/29 22:08, Arnd Bergmann wrote: On Saturday 26 July 2014 11:08:37 Yijing Wang wrote: The new data struct for generic MSI driver. struct msi_irqs { u8 msi_enabled:1; /* Enable flag */ u8 msix_enabled:1

Re: [RFC PATCH 00/11] Refactor MSI to support Non-PCI device

2014-07-29 Thread Arnd Bergmann
On Saturday 26 July 2014 11:08:37 Yijing Wang wrote: The series is a draft of generic MSI driver that supports PCI and Non-PCI device which have MSI capability. If you're not interested it, sorry for the noise. I've finally managed to take some time to look at the series. Overall, the

Re: [patch] virtio: console: fix error handling for debugfs_create_dir()

2013-08-01 Thread Arnd Bergmann
On Friday 19 July 2013, Dan Carpenter wrote: debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. Also my static checker doesn't like it when we print the error code, but it's always just NULL. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com This looks wrong.

Re: [patch] virtio: console: fix error handling for debugfs_create_dir()

2013-08-01 Thread Arnd Bergmann
On Saturday 20 July 2013, Dan Carpenter wrote: On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote: On Friday 19 July 2013, Dan Carpenter wrote: debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. Also my static checker doesn't like it when we print the error

Re: [PATCH] virtio_console: correct error message on failure of debugfs_create_dir

2013-01-03 Thread Arnd Bergmann
On Friday 21 December 2012, Amit Shah wrote: On (Thu) 20 Dec 2012 [14:11:21], Sasha Levin wrote: debugfs_create_dir() returns NULL if it fails, there's little point in calling PTR_ERR on it. debugfs_create_dir() does return an error value if debugfs is not enabled. This check for

Re: [Android-virt] [Embeddedxen-devel] [Xen-devel] [ANNOUNCE] Xen port to Cortex-A15 / ARMv7 with virt extensions

2011-12-01 Thread Arnd Bergmann
On Thursday 01 December 2011, Catalin Marinas wrote: Given the way register banking is done on AArch64, issuing an HVC on a 32-bit guest OS doesn't require translation on a 64-bit hypervisor. We have a similar implementation at the SVC level (for 32-bit user apps on a 64-bit kernel), the only

Re: [Android-virt] [Embeddedxen-devel] [Xen-devel] [ANNOUNCE] Xen port to Cortex-A15 / ARMv7 with virt extensions

2011-12-01 Thread Arnd Bergmann
On Thursday 01 December 2011, Catalin Marinas wrote: On Thu, Dec 01, 2011 at 03:42:19PM +, Arnd Bergmann wrote: On Thursday 01 December 2011, Catalin Marinas wrote: How do you deal with signed integer arguments passed into SVC or HVC from a caller? If I understand the architecture

Re: [ANNOUNCE] Xen port to Cortex-A15 / ARMv7 with virt extensions

2011-11-30 Thread Arnd Bergmann
On Wednesday 30 November 2011, Stefano Stabellini wrote: On Tue, 29 Nov 2011, Arnd Bergmann wrote: On Tuesday 29 November 2011, Stefano Stabellini wrote: Do you have a pointer to the kernel sources for the Linux guest? We have very few changes to the Linux kernel at the moment (only 3

Re: [Xen-devel] [ANNOUNCE] Xen port to Cortex-A15 / ARMv7 with virt extensions

2011-11-30 Thread Arnd Bergmann
On Wednesday 30 November 2011, Ian Campbell wrote: On Wed, 2011-11-30 at 13:03 +, Arnd Bergmann wrote: On Wednesday 30 November 2011, Stefano Stabellini wrote: This is the same choice people have made for KVM, but it's not necessarily the best option in the long run. In particular

Re: [Xen-devel] [ANNOUNCE] Xen port to Cortex-A15 / ARMv7 with virt extensions

2011-11-30 Thread Arnd Bergmann
On Wednesday 30 November 2011, Ian Campbell wrote: On Wed, 2011-11-30 at 14:32 +, Arnd Bergmann wrote: On Wednesday 30 November 2011, Ian Campbell wrote: What I suggested to the KVM developers is to start out with the vexpress platform, but then generalize it to the point where it fits

Re: [ANNOUNCE] Xen port to Cortex-A15 / ARMv7 with virt extensions

2011-11-29 Thread Arnd Bergmann
On Tuesday 29 November 2011, Stefano Stabellini wrote: Hi all, a few weeks ago I (and a few others) started hacking on a proof-of-concept hypervisor port to Cortex-A15 which uses and requires ARMv7 virtualization extensions. The intention of this work was to find out how to best support ARM

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-10 Thread Arnd Bergmann
On Friday 10 June 2011, Chris Metcalf wrote: This still leaves open the question of what really should go in this new directory. Is it just for drivers that manage/control the hypervisor? Or is it also for drivers that just use the hypervisor to do I/O of some kind, but aren't related to any

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Arnd Bergmann
On Thursday 09 June 2011 01:10:09 Randy Dunlap wrote: On Wed, 8 Jun 2011 17:45:54 -0500 Timur Tabi wrote: Add the drivers/virt directory, which houses drivers that support virtualization environments, and add the Freescale hypervisor management driver. It can't go in linux/virt or

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Arnd Bergmann
Hi Timur, thanks for addressing the issues I pointed out. Unfortunately, I have found a few more now: On Thursday 09 June 2011 21:13:14 Timur Tabi wrote: + /* Make sure the application is called the right driver. */ + if (_IOC_TYPE(cmd) != 0) { + pr_debug(fsl-hv:

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Arnd Bergmann
On Thursday 09 June 2011 21:48:58 Randy Dunlap wrote: So is it okay to stick with 0, or do I need to pick a new number? I wasn't suggesting that you change the 0, just note that it has conflicts, like other ioctls do. We normally don't try to maintain binary compatibility with out of tree

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Arnd Bergmann
On Thursday 09 June 2011 22:18:28 Timur Tabi wrote: More importantly, the code you have chose (0) conflicts with existing drivers (frame buffer, scsi and wavefront among others). Please chose a free one and add it to Documentation/ioctl/ioctl-number.txt in the same patch. Ok, I was

Re: [PATCH 7/7] [v6] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Arnd Bergmann
interface for receiving callbacks when a managed partition shuts down. Signed-off-by: Timur Tabi ti...@freescale.com Acked-by: Arnd Bergmann a...@arndb.de ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux

Re: [PATCH v2] arch/tile: more /proc and /sys file support

2011-05-27 Thread Arnd Bergmann
to me now, except Finally, after some feedback from Arnd Berghamm for the previous typo Reviewed-by: Arnd Bergmann a...@arndb.de ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-25 Thread Arnd Bergmann
On Wednesday 25 May 2011 21:18:05 Chris Metcalf wrote: (Resending with no HTML for LKML.) On 5/20/2011 3:59 PM, Arnd Bergmann wrote: Any chance you can still restructure the information? I would recommend making it a first-class procfs member, since the data is really per-task. You can

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-25 Thread Arnd Bergmann
On Wednesday 25 May 2011 22:31:37 Chris Metcalf wrote: On 5/25/2011 4:20 PM, Arnd Bergmann wrote: On Wednesday 25 May 2011 21:18:05 Chris Metcalf wrote: The contents of the hardwall ID file are then just a cpulist of the cpus covered by the hardwall, rather than introducing a new convention

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-24 Thread Arnd Bergmann
On Thursday 19 May 2011, Arnd Bergmann wrote: # cat /proc/tile/board board_part: 402-2-05 board_serial: NBS-5002-00012 chip_serial: P62338.01.110 chip_revision: A0 board_revision: 2.2 board_description: Tilera TILExpressPro-64, TILEPro64 processor (866 MHz-capable), 1 10GbE

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-20 Thread Arnd Bergmann
On Friday 20 May 2011 16:26:57 Chris Metcalf wrote: /proc/tile/hardwall Information on the set of currently active hardwalls (note that the implementation is already present in arch/tile/kernel/hardwall.c; this change just enables it) This one is not a hypervisor-related file. It

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-20 Thread Arnd Bergmann
On Friday 20 May 2011 17:00:47 Chris Metcalf wrote: Any chance you can still restructure the information? I would recommend making it a first-class procfs member, since the data is really per-task. You can add a conditional entry to tgid_base_stuff[] in fs/proc/base.c to make it show up

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-20 Thread Arnd Bergmann
On Friday 20 May 2011 17:13:25 Arnd Bergmann wrote: On Friday 20 May 2011 17:00:47 Chris Metcalf wrote: Any chance you can still restructure the information? I would recommend making it a first-class procfs member, since the data is really per-task. You can add a conditional entry

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-19 Thread Arnd Bergmann
(adding virtualization mailing list) On Thursday 19 May 2011, Chris Metcalf wrote: On 5/19/2011 9:41 AM, Arnd Bergmann wrote: /proc/tile/hvconfig Detailed configuration description of the hypervisor config I'm concerned about moving this one out of /proc, since it's just (copious) free

Re: [PATCH] virtio: console: Move file back to drivers/char/

2011-02-01 Thread Arnd Bergmann
/char/. In the future, the hvc part from this file can be split off and moved under drivers/tty/hvc/. CC: Rusty Russell ru...@rustcorp.com.au CC: Greg KH g...@kroah.com CC: Arnd Bergmann a...@arndb.de Signed-off-by: Amit Shah amit.s...@redhat.com Acked-by: Arnd Bergmann a...@arndb.de

hv block drivers

2010-08-30 Thread Arnd Bergmann
Hi Hank, I wanted to follow up on the block device driver discussion we had at LinuxCon, based on some other input I got. What most people recommended was to make both the hv scsi and the hv ata code scsi device drivers, *not* make them standalone block drivers as I originally recommended. The

Re: hv block drivers

2010-08-30 Thread Arnd Bergmann
On Monday 30 August 2010, Jeremy Fitzhardinge wrote: Have you investigated making virtio a scsi device? I doubt that there is much value in changing it now, and it's not something I'd be interested in working on. For the HyperV drivers, it probably makes sense because half of it is trying to

Re: hv block drivers

2010-08-30 Thread Arnd Bergmann
On Monday 30 August 2010 19:35:35 Jeremy Fitzhardinge wrote: On 08/30/2010 10:31 AM, Hank Janssen wrote: For a more general question, When/if we make it out of staging, where should these drivers live? drivers/hyper-v or drivers/scsi and drivers/ide. Is there a standard that

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Arnd Bergmann
On Wednesday 05 May 2010 19:47:10 Pankaj Thakkar wrote: Forget about the licensing. Loading binary blobs written to a shim layer is a complete pain in the ass and totally unsupportable, and also uninteresting because of the overhead. [PT] Why do you think it is unsupportable? How

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Arnd Bergmann
On Wednesday 05 May 2010 22:36:31 Dmitry Torokhov wrote: On Wednesday 05 May 2010 01:09:48 pm Arnd Bergmann wrote: If you have any interesting in developing this further, do: (1) move the limited VF drivers directly into the kernel tree, talk to them through a normal ops

Re: virtio over PCI

2010-03-03 Thread Arnd Bergmann
On Thursday 04 March 2010, Ira W. Snyder wrote: I'm happy to provide any help I can, including testing on MPC8349EA-based system. I would suggest talking to the virtualization mailing list before you get too deep in the project. They sometimes have good advice. I've added them to the CC list,

  1   2   3   >