Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-06 Thread Laszlo Ersek
b frame buffer device >> >> There is no virgl support because it's a virtio-gpu-device and not >> virtio-gpu-device-gl that is PCI-only in Qemu. Hence everything seems good. >> >> I'd appreciate if you could give s390x a test.. I never touched s390x >> and it wil

Re: [PATCH v7 71/72] x86/efi: Add GHCB mappings when SEV-ES is active

2020-09-09 Thread Laszlo Ersek
On 09/09/20 14:44, Laszlo Ersek wrote: > To summarize: for QemuFlashFvbServicesRuntimeDxe to allocate UEFI > Runtime Services Data type memory, for its own runtime GHCB, two > permissions are necessary (together), at OS runtime: > > - QemuFlashFvbServicesRuntimeDxe must be

Re: [PATCH v7 71/72] x86/efi: Add GHCB mappings when SEV-ES is active

2020-09-09 Thread Laszlo Ersek
On 09/09/20 10:27, Ard Biesheuvel wrote: > (adding Laszlo and Brijesh) > > On Tue, 8 Sep 2020 at 20:46, Borislav Petkov wrote: >> >> + Ard so that he can ack the efi bits. >> >> On Mon, Sep 07, 2020 at 03:16:12PM +0200, Joerg Roedel wrote: >>> From: Tom Lendacky >>> >>> Calling down to EFI

Re: [PATCH v5] drm/virtio: use virtio_max_dma_size

2019-08-22 Thread Laszlo Ersek
On 08/21/19 13:12, Gerd Hoffmann wrote: > We must make sure our scatterlist segments are not too big, otherwise > we might see swiotlb failures (happens with sev, also reproducable with > swiotlb=force). > > Suggested-by: Laszlo Ersek > Signed-off-by: Gerd Hoffmann > -

QueuePFN peculiarity in virtio-mmio

2013-10-22 Thread Laszlo Ersek
Hi, Appendix X: virtio-mmio in the virtio spec says • 0x040 | RW | QueuePFN [...] When the Guest stops using the queue it must write zero (0x0) to this register. [...] and Virtqueue Configuration [...] 2. Check if the queue is not already in use: read

Re: QueuePFN peculiarity in virtio-mmio

2013-10-22 Thread Laszlo Ersek
My apologies, I used Anthony's previous (now obsolete) email. Updated it now keeping full context below. Sorry. On 10/22/13 19:49, Laszlo Ersek wrote: Hi, Appendix X: virtio-mmio in the virtio spec says • 0x040 | RW | QueuePFN [...] When the Guest stops using the queue it must

Re: [edk2] QueuePFN peculiarity in virtio-mmio

2013-10-22 Thread Laszlo Ersek
On 10/22/13 19:55, Laszlo Ersek wrote: The question arises because Olivier has posted a series to edk2-devel that adds virtio-mmio support to TianoCore, and Mark tested it (using OVMF) with a Linux guest and found problems. Namely, OVMF itself can drive the virtio devices via virtio-mmio

Re: [virtio-spec PATCH 0/5] Receiving Used Buffers example code: cleanups and an extra mb()

2013-06-17 Thread Laszlo Ersek
On 06/17/13 04:17, Rusty Russell wrote: Stefan Hajnoczi stefa...@gmail.com writes: On Sat, Jun 8, 2013 at 7:39 PM, Laszlo Ersek ler...@redhat.com wrote: Patches before the last are small cleanups. In the last patch I'm trying to extract / generalize an idea from Stefan Hajnoczi's review

Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR

2013-05-29 Thread Laszlo Ersek
On 05/29/13 09:27, Paolo Bonzini wrote: Il 29/05/2013 06:33, Rusty Russell ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Il 28/05/2013 19:32, Michael S. Tsirkin ha scritto: + +switch (addr) { +case offsetof(struct virtio_pci_common_cfg, device_feature_select): +

anyone willing to review a virtio-net guest driver for OVMF?

2013-05-29 Thread Laszlo Ersek
(Resending to the virt list after the original qemu-devel posting, following MST's advice; plus adding ipxe-devel too -- apologies for spamming!) Hi, the driver in question is intended as a fallback driver when the iPXE EFI driver for virtio-net is not present as an oprom. The series starts with

Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR

2013-05-28 Thread Laszlo Ersek
On 05/28/13 19:43, Paolo Bonzini wrote: Il 28/05/2013 19:32, Michael S. Tsirkin ha scritto: + +switch (addr) { +case offsetof(struct virtio_pci_common_cfg, device_feature_select): +return proxy-device_feature_select; Oh dear no... Please use defines like the rest of QEMU.

Re: suggesting wording fixes for virtio-spec 0.9.5

2013-04-23 Thread Laszlo Ersek
On 04/23/13 06:05, Rusty Russell wrote: Laszlo Ersek ler...@redhat.com writes: Hi, (I'm not subscribed to either list,) using the word descriptor is misleading in the following sections: Yes, I like the use of 'descriptor chains'. This is a definite improvement. Here's the diff I

suggesting wording fixes for virtio-spec 0.9.5

2013-04-22 Thread Laszlo Ersek
Hi, (I'm not subscribed to either list,) using the word descriptor is misleading in the following sections: 2.4.1.2 Updating The Available Ring [...] However, in general we can add many descriptors before we update the idx field (at which point they become visible to the device), so

miscalculated vring size in virtio-0.9.5.pdf?

2012-09-18 Thread Laszlo Ersek
Hi, the vring_size() formula in section 2.3 seems to miss (a) vring_avail.used_event in the first ALIGN(), and (b) vring_used.flags, vring_used.idx, vring_used.avail_event in the second ALIGN(). vring_size() in Appendix A fixes (b) (no rounding up to page size though), but (a) is wrong there

[PATCH net-next v4] xen-netfront: delay gARP until backend switches to Connected

2011-12-11 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Ian Campbell ian.campb...@citrix.com --- drivers/net/xen-netfront.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index d29365a..f033656 100644

[PATCH v3 REPOST] xen-netfront: delay gARP until backend switches to Connected

2011-12-09 Thread Laszlo Ersek
comes from [2]. [1] http://old-list-archives.xen.org/xen-devel/2011-06/msg01969.html [2] http://old-list-archives.xen.org/xen-devel/2011-07/msg00484.html Signed-off-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Ian Campbell ian.campb...@citrix.com --- drivers/net/xen-netfront.c |4 +++- 1