Re: [PATCH] virtio_mmio: Set DMA masks appropriately

2017-01-10 Thread Russell King - ARM Linux
On Tue, Jan 10, 2017 at 02:15:57PM +0100, Arnd Bergmann wrote: > On Tuesday, January 10, 2017 12:26:01 PM CET Robin Murphy wrote: > > @@ -548,6 +550,14 @@ static int virtio_mmio_probe(struct platform_device > > *pdev) > > if (vm_dev->version == 1) > > writel(PAGE_SIZE,

Re: [PATCH 1/1] sched: provide common cpu_relax_yield definition

2016-11-21 Thread Russell King - ARM Linux
On Wed, Nov 16, 2016 at 01:23:05PM +0100, Christian Borntraeger wrote: > No need to duplicate the same define everywhere. Since > the only user is stop-machine and the only provider is > s390, we can use a default implementation of cpu_relax_yield > in sched.h. > > Suggested-by: Russell King

Re: [GIT PULL v2 1/5] processor.h: introduce cpu_relax_yield

2016-11-21 Thread Russell King - ARM Linux
On Tue, Nov 15, 2016 at 02:19:53PM +0100, Christian Borntraeger wrote: > On 11/15/2016 01:30 PM, Russell King - ARM Linux wrote: > > On Tue, Oct 25, 2016 at 11:03:11AM +0200, Christian Borntraeger wrote: > >> For spinning loops people do often use barrier() or cpu_rela

Re: [GIT PULL v2 1/5] processor.h: introduce cpu_relax_yield

2016-11-21 Thread Russell King - ARM Linux
On Tue, Oct 25, 2016 at 11:03:11AM +0200, Christian Borntraeger wrote: > For spinning loops people do often use barrier() or cpu_relax(). > For most architectures cpu_relax and barrier are the same, but on > some architectures cpu_relax can add some latency. > For example on power,sparc64 and arc,

Re: [PATCH v2 17/32] arm: define __smp_xxx

2016-01-04 Thread Russell King - ARM Linux
On Mon, Jan 04, 2016 at 02:54:20PM +0100, Peter Zijlstra wrote: > On Mon, Jan 04, 2016 at 02:36:58PM +0100, Peter Zijlstra wrote: > > On Sun, Jan 03, 2016 at 11:12:44AM +0200, Michael S. Tsirkin wrote: > > > On Sat, Jan 02, 2016 at 11:24:38AM +0000, Russell King - ARM Linux wrot

Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers

2016-01-04 Thread Russell King - ARM Linux
On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote: > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote: > > + my $all_barriers = join('|', (@barriers, @smp_barriers)); > > + > > + if ($line =~ /\b($all_barriers)\(/) { > > It would be better to use

Re: [PATCH v2 08/32] arm: reuse asm-generic/barrier.h

2016-01-02 Thread Russell King - ARM Linux
On Thu, Dec 31, 2015 at 09:06:46PM +0200, Michael S. Tsirkin wrote: > On arm smp_store_mb, read_barrier_depends, smp_read_barrier_depends, > smp_store_release, smp_load_acquire, smp_mb__before_atomic and > smp_mb__after_atomic match the asm-generic variants exactly. Drop the > local definitions

Re: [PATCH v2 17/32] arm: define __smp_xxx

2016-01-02 Thread Russell King - ARM Linux
On Thu, Dec 31, 2015 at 09:07:59PM +0200, Michael S. Tsirkin wrote: > This defines __smp_xxx barriers for arm, > for use by virtualization. > > smp_xxx barriers are removed as they are > defined correctly by asm-generic/barriers.h > > This reduces the amount of arch-specific boiler-plate code. >

Re: [PATCH] drm/virtio: use %llu format string form atomic64_t

2015-10-07 Thread Russell King - ARM Linux
On Wed, Oct 07, 2015 at 12:41:21PM +0200, Arnd Bergmann wrote: > The virtgpu driver prints the last_seq variable using the %ld or > %lu format string, which does not work correctly on all architectures > and causes this compiler warning on ARM: > > drivers/gpu/drm/virtio/virtgpu_fence.c: In

Re: [RFC PATCH v1 01/33] mm: introduce common help functions to deal with reserved/managed pages

2013-03-06 Thread Russell King - ARM Linux
On Tue, Mar 05, 2013 at 08:47:22PM +0100, Sam Ravnborg wrote: On Tue, Mar 05, 2013 at 10:54:44PM +0800, Jiang Liu wrote: +static inline void free_initmem_default(int poison) +{ Why request user to supply the poison argumet. If this is the default implmentation then use the default poison

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Russell King - ARM Linux
On Mon, Jan 17, 2011 at 12:07:13PM +0100, Peter Zijlstra wrote: diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c index 42aa078..c4a570b 100644 --- a/arch/alpha/kernel/smp.c +++ b/arch/alpha/kernel/smp.c @@ -587,6 +587,7 @@ handle_ipi(struct pt_regs *regs) case

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Russell King - ARM Linux
On Mon, Jan 17, 2011 at 12:41:49PM +0100, Peter Zijlstra wrote: === --- linux-2.6.orig/arch/arm/kernel/smp.c +++ linux-2.6/arch/arm/kernel/smp.c @@ -575,10 +575,7 @@ asmlinkage void __exception do_IPI(struc