RE: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-11 Thread Sjur BRENDELAND
Hi Rusty, From: Rusty Russell [mailto:ru...@rustcorp.com.au] sjur.brandel...@stericsson.com writes: From: Vikram ARV vikram@stericsson.com Add the the Virtio shared memory driver for STE Modems. caif_virtio is implemented utilizing the virtio framework for data transport and is

RE: [PATCH] virtio_console: Let unconnected rproc device receive data.

2013-01-25 Thread Sjur BRENDELAND
Hi Amit, @@ -1763,8 +1763,11 @@ static void in_intr(struct virtqueue *vq) * tty is spawned) and the host sends out data to console * ports. For generic serial ports, the host won't * (shouldn't) send data till the guest is connected. +* However a remote device might

RE: [[PATCH v9 3/3] 1/1] virtio_console: Remove buffers from out_vq at port removal

2012-12-12 Thread Sjur BRENDELAND
Amit Shah [mailto:amit.s...@redhat.com] writes: On (Wed) 12 Dec 2012 [10:31:04], Rusty Russell wrote: Amit Shah amit.s...@redhat.com writes: On (Tue) 11 Dec 2012 [09:39:41], Rusty Russell wrote: Amit Shah amit.s...@redhat.com writes: On (Fri) 16 Nov 2012 [11:22:09], Rusty Russell

RE: [RFCv2 04/12] virtio-ring: Refactor out the functions accessing user memory

2012-12-07 Thread Sjur BRENDELAND
Hi Michael, From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Thursday, December 06, 2012 12:16 PM On Thu, Dec 06, 2012 at 12:03:43PM +0100, Sjur BRENDELAND wrote: Hi Michael, -struct vring_used_elem *vring_add_used_user(struct vring_host *vh

RE: [RFCv2 04/12] virtio-ring: Refactor out the functions accessing user memory

2012-12-07 Thread Sjur BRENDELAND
From: Michael S. Tsirkin [mailto:m...@redhat.com] On Fri, Dec 07, 2012 at 12:05:11PM +0100, Sjur BRENDELAND wrote: Hi Michael, From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Thursday, December 06, 2012 12:16 PM On Thu, Dec 06, 2012 at 12:03:43PM +0100, Sjur BRENDELAND wrote

RE: [RFCv2 04/12] virtio-ring: Refactor out the functions accessing user memory

2012-12-06 Thread Sjur BRENDELAND
Hi Michael, -struct vring_used_elem *vring_add_used_user(struct vring_host *vh, -unsigned int head, int len) + +static inline struct vring_used_elem *_vring_add_used(struct vring_host *vh, + u32 head, u32

RE: [PATCHv7 4/4] virtio_console: Add support for remoteproc serial

2012-11-02 Thread Sjur BRENDELAND
On (Fri) 02 Nov 2012 [09:52:08], Rusty Russell wrote: Amit Shah amit.s...@redhat.com writes: On (Tue) 23 Oct 2012 [12:17:49], Rusty Russell wrote: sjur.brandel...@stericsson.com writes: From: Sjur Brændeland sjur.brandel...@stericsson.com @@ -1415,7 +1524,16 @@ static void

RE: [PATCH 1/3] virtio_console:Merge struct buffer_token into struct port_buffer

2012-09-26 Thread Sjur BRENDELAND
This merge reduces code size by unifying the approach for sending scatter-lists and regular buffers. Any type of write operation (splice, write, put_chars) will now allocate a port_buffer and send_buf() and free_buf() can always be used. Thanks! This looks much nicer and simpler. I

RE: [PATCHv4] virtio_console: Add support for remoteproc serial

2012-09-24 Thread Sjur BRENDELAND
Hi Amit, I'm sorry for not being able to look at this earlier. No worries. I'll try to respin and retest this patch by tomorrow. If you by any chance could find time to review so could make it in time for 3.7 it would be great :-) A general comment is to base this patchset on linux-next;

RE: [PATCHv2] virtio_console: Add support for remoteproc serial

2012-09-20 Thread Sjur BRENDELAND
From: Michael S. Tsirkin [mailto:m...@redhat.com] sjur.brandel...@stericsson.com wrote: From: Sjur Brændeland sjur.brandel...@stericsson.com Add a simple serial connection driver called VIRTIO_ID_RPROC_SERIAL (0xB) for communicating with a remote processor in an asymmetric

RE: [PATCHv2] virtio_console: Add support for remoteproc serial

2012-09-20 Thread Sjur BRENDELAND
Hi Rusty, +#if IS_ENABLED(CONFIG_REMOTEPROC) +static inline bool is_rproc_serial(struct virtio_device *vdev) +{ + return vdev-id.device == VIRTIO_ID_RPROC_SERIAL; +} +#else +static inline bool is_rproc_serial(struct virtio_device *vdev) +{ + return false; +} +#endif I

Question regarding Virtio Console and Remoteproc

2012-06-01 Thread Sjur BRENDELAND
Hi Amit and Rusty, I've been looking into the possibility of using the Virtio Console Driver together with the remoteproc framework to communicate with ST-Ericsson modem over shared memory. It seems like Virtio Console would be a good fit, except for a issue with buffer allocation. Due to HW