Re: [PATCH v3] virtio_console: Introduce an ID allocator for virtual console numbers

7 @@ static void unplug_port(struct port *port) list_del(>cons.list); spin_unlock_irq(_lock); hvc_remove(port->cons.hvc); + ida_free(_ida, port->cons.vtermno); } remove_port_data(port); Reviewed-by: Thomas Huth ___

Re: [PATCH v2] virtio_console: Introduce an ID allocator for virtual console numbers

On 14/11/2022 18.38, Cédric Le Goater wrote: When a virtio console port is initialized, it is registered as an hvc console using a virtual console number. If a KVM guest is started with multiple virtio console devices, the same vtermno (or virtual console number) can be used to allocate

Re: [PATCH 03/10] virtio/s390: enable packed ring

On 03/05/2019 11.44, Cornelia Huck wrote: > On Fri, 26 Apr 2019 20:32:38 +0200 > Halil Pasic wrote: > >> Nothing precludes to accepting VIRTIO_F_RING_PACKED any more. > > "precludes us from accepting" > >> >> Signed-off-by: Halil Pasic >> --- >> drivers/s390/virtio/virtio_ccw.c | 4 +--- >>

Re: [PATCH] virtio/s390: fixup for implement PM operations for virtio_ccw

On 18.12.2017 09:37, Christian Borntraeger wrote: > We need to disable the pm callbacks if CONFIG_PM is not set. > > Signed-off-by: Christian Borntraeger > --- > Cornelia, you might want to squash this into the original commit. > > drivers/s390/virtio/virtio_ccw.c | 4

[PATCH] drivers/s390/virtio: Remove the old KVM virtio transport

l required. So let's simply remove it. Signed-off-by: Thomas Huth <th...@redhat.com> --- arch/s390/Kconfig| 13 - drivers/s390/virtio/Makefile | 3 - drivers/s390/virtio/kvm_virtio.c | 515 --- 3 files changed, 531 deletions(-) de

Re: [PATCH] drivers/s390/virtio: Remove the old KVM virtio transport

On 27.09.2017 14:55, Heiko Carstens wrote: > On Wed, Sep 27, 2017 at 01:42:01PM +0200, Thomas Huth wrote: >> diff --git a/drivers/s390/virtio/Makefile b/drivers/s390/virtio/Makefile >> index df40692..d9942e0 100644 >> --- a/drivers/s390/virtio/Makefile >> +++ b/d

Re: [PATCH] KVM: s390: Disable CONFIG_S390_GUEST_OLD_TRANSPORT by default

>>> On 09/25/2017 07:54 PM, Halil Pasic wrote: >>>>> >>>>> >>>>> On 09/25/2017 04:45 PM, Thomas Huth wrote: >>>>>> There is no recent user space application available anymore which still >>>>>> supports this

[PATCH] KVM: s390: Disable CONFIG_S390_GUEST_OLD_TRANSPORT by default

There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default. Signed-off-by: Thomas Huth <th...@redhat.com> --- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/K

Re: [PATCH] KVM: s390: Disable CONFIG_S390_GUEST_OLD_TRANSPORT by default

On 25.09.2017 20:37, Christian Borntraeger wrote: > > On 09/25/2017 07:54 PM, Halil Pasic wrote: >> >> >> On 09/25/2017 04:45 PM, Thomas Huth wrote: >>> There is no recent user space application available anymore which still >>> supports this old virtio t

Re: [PATCH 1/1] Update my email address

include/uapi/linux/virtio_*.h > F: drivers/crypto/virtio/ > > VIRTIO DRIVERS FOR S390 > -M: Cornelia Huck <cornelia.h...@de.ibm.com> > +M: Cornelia Huck <coh...@redhat.com> > M: Halil Pasic <pa...@linux.vnet.ibm.com> > L: linux-s...@vger.

Re: [PATCH 2/2] virtio_ring: fix complaint by sparse

On 22.11.2016 16:04, Michael S. Tsirkin wrote: > On Tue, Nov 22, 2016 at 01:51:50PM +0800, Gonglei wrote: >> # make C=2 CF="-D__CHECK_ENDIAN__" ./drivers/virtio/ >> >> drivers/virtio/virtio_ring.c:423:19: warning: incorrect type in assignment >> (different base types) >>

Re: [PATCH] KVM: Add Kconfig option to signal cross-endian guests

On Thu, 9 Jul 2015 16:07:47 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jul 09, 2015 at 02:57:33PM +0200, Paolo Bonzini wrote: On 09/07/2015 11:48, Laurent Vivier wrote: On 09/07/2015 09:49, Thomas Huth wrote: The option for supporting cross-endianness legacy

Re: [PULL] virtio/vhost: cross endian support

On Thu, 2 Jul 2015 11:32:52 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jul 02, 2015 at 11:12:56AM +0200, Greg Kurz wrote: On Thu, 2 Jul 2015 08:01:28 +0200 Michael S. Tsirkin m...@redhat.com wrote: ... Yea, well - support for legacy BE guests on the new LE hosts is exactly

Re: I can read/write in virtio BLK Device, but I can't run a hello world program in it

On Tue, 7 Jul 2015 10:52:01 +0900 Ganis Zulfa Santoso ganis.zu...@gmail.com wrote: Hi Linux Virtualization Mailing List Members, I am trying to develop a driver for virtio blk device in guest. Why don't you simply use the driver that is already available in the kernel? I can safely mount

Re: [PATCH RESEND] virtio: Fix typecast of pointer in vring_init()

On Sun, 5 Jul 2015 14:59:54 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 05, 2015 at 12:58:53PM +0200, Michael S. Tsirkin wrote: On Thu, Jul 02, 2015 at 09:21:22AM +0200, Thomas Huth wrote: The virtio_ring.h header is used in userspace programs (ie. QEMU), too. Here we can

Re: [PATCH RESEND] virtio: Fix typecast of pointer in vring_init()

On Mon, 6 Jul 2015 12:50:22 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jul 06, 2015 at 11:24:42AM +0200, Thomas Huth wrote: On Sun, 5 Jul 2015 14:59:54 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 05, 2015 at 12:58:53PM +0200, Michael S. Tsirkin wrote

[PATCH RESEND] virtio: Fix typecast of pointer in vring_init()

The virtio_ring.h header is used in userspace programs (ie. QEMU), too. Here we can not assume that sizeof(pointer) is the same as sizeof(long), e.g. when compiling for Windows, so the typecast in vring_init() should be done with (uintptr_t) instead of (unsigned long). Signed-off-by: Thomas Huth

[PATCH] virtio: Fix typecast of pointer in vring_init()

warning when compiling QEMU with the mingw32 cross-compiler. Signed-off-by: Thomas Huth th...@redhat.com --- include/uapi/linux/virtio_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h index 915980a..8682551

Re: [PATCH v5 1/8] virtio: introduce virtio_is_little_endian() helper

Am Thu, 23 Apr 2015 17:26:20 +0200 schrieb Greg Kurz gk...@linux.vnet.ibm.com: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- include/linux/virtio_config.h | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/include/linux/virtio_config.h

Re: [PATCH v5 4/8] vringh: introduce vringh_is_little_endian() helper

__cpu_to_virtio64(vrh-little_endian, val); + return __cpu_to_virtio64(vringh_is_little_endian(vrh), val); } #endif /* _LINUX_VRINGH_H */ Reviewed-by: Thomas Huth th...@redhat.com ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https

Re: [PATCH v5 5/8] vhost: introduce vhost_is_little_endian() helper

(vhost_is_little_endian(vq), val); } #endif Reviewed-by: Thomas Huth th...@redhat.com ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v5 6/8] virtio: add explicit big-endian support to memory accessors

On Thu, 23 Apr 2015 17:29:06 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: The current memory accessors logic is: - little endian if little_endian - native endian (i.e. no byteswap) if !little_endian If we want to fully support cross-endian vhost, we also need to be able to convert to

Re: [PATCH v5 1/8] virtio: introduce virtio_is_little_endian() helper

Am Thu, 23 Apr 2015 19:22:15 +0200 schrieb Thomas Huth th...@redhat.com: Am Thu, 23 Apr 2015 17:26:20 +0200 schrieb Greg Kurz gk...@linux.vnet.ibm.com: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- include/linux/virtio_config.h | 17 +++-- 1 file changed, 11

Re: [PATCH v5 1/8] virtio: introduce virtio_is_little_endian() helper

); + return __cpu_to_virtio64(virtio_is_little_endian(vdev), val); } Reviewed-by: Thomas Huth th...@redhat.com ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo

Re: [PATCH v5 2/8] tun: add tun_is_little_endian() helper

); + return __cpu_to_virtio16(tun_is_little_endian(tun), val); } Reviewed-by: Thomas Huth th...@redhat.com ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v5 3/8] macvtap: introduce macvtap_is_little_endian() helper

) { - return __cpu_to_virtio16(q-flags MACVTAP_VNET_LE, val); + return __cpu_to_virtio16(macvtap_is_little_endian(q), val); } Reviewed-by: Thomas Huth th...@redhat.com ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https

Re: [PATCH v2] virtio-balloon: do not call blocking ops when !TASK_RUNNING

, rewrite using wait_woken. Cc: sta...@vger.kernel.org Reported-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- changes from v1: remove wait_event_interruptible noticed by Cornelia Huck cornelia.h...@de.ibm.com drivers

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

On Thu, 26 Feb 2015 11:50:42 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Thomas Huth th...@linux.vnet.ibm.com writes: Hi all, with the recent kernel 3.19, I get a kernel warning when I start my KVM guest on s390 with virtio balloon enabled: The deeper problem

virtio balloon: do not call blocking ops when !TASK_RUNNING

Hi all, with the recent kernel 3.19, I get a kernel warning when I start my KVM guest on s390 with virtio balloon enabled: [0.839687] do not call blocking ops when !TASK_RUNNING; state=1 set at [00174a1e] prepare_to_wait_event+0x7e/0x108 [0.839694] [

Re: [Qemu-devel] [PATCH RFC v6 05/20] virtio: support more feature bits

Hi, On Thu, 29 Jan 2015 11:11:32 +1100 David Gibson da...@gibson.dropbear.id.au wrote: On Wed, Jan 28, 2015 at 04:59:45PM +0100, Cornelia Huck wrote: On Thu, 22 Jan 2015 12:43:43 +1100 David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Dec 11, 2014 at 02:25:07PM +0100, Cornelia

Re: [Qemu-devel] [PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call

On Wed, 21 Jan 2015 12:23:18 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Tue, 20 Jan 2015 11:08:24 + Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Dec 11, 2014 at 02:25:12PM +0100, Cornelia Huck wrote: @@ -608,6 +631,25 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1

Re: [PATCH RFC v6 05/20] virtio: support more feature bits

On Thu, 11 Dec 2014 14:25:07 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: With virtio-1, we support more than 32 feature bits. Let's extend both host and guest features to 64, which should suffice for a while. vhost and migration have been ignored for now. Signed-off-by: Cornelia

Re: [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

On Thu, 11 Dec 2014 14:25:14 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: For virtio-1 devices, the driver must not attempt to set feature bits after it set FEATURES_OK in the device status. Simply reject it in that case. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com ---

Re: [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

On Fri, 12 Dec 2014 12:18:25 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Fri, 12 Dec 2014 11:55:38 +0100 Thomas Huth th...@linux.vnet.ibm.com wrote: On Thu, 11 Dec 2014 14:25:14 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: For virtio-1 devices, the driver must

Re: [PATCH RFC v6 04/20] virtio: add feature checking helpers

On Thu, 11 Dec 2014 14:25:06 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: Add a helper function for checking whether a bit is set in the guest features for a vdev as well as one that works on a feature bit set. Convert code that open-coded this: It cleans up the code and makes it

Re: [PATCH RFC v6 03/20] virtio: feature bit manipulation helpers

files changed, 44 insertions(+), 32 deletions(-) Patch looks fine to me. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo

[PATCH] virtio_net: Fixed a trivial typo (fitler -- filter)

MAC filter sounds more reasonable than MAC fitler. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com --- drivers/net/virtio_net.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 01f4eb5..fd96f09 100644

[PATCH] virtio-net: Set RXCSUM feature if GUEST_CSUM is available

flag. When the user now runs ethtool -k, he or she can see whether the virtio-net interface has to calculate RX checksums or not. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com --- drivers/net/virtio_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers

Virtio-net, ethtool and rx-checksumming

be good if at least the reporting was available. Regards, Thomas Huth ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization