Re: [bug report] vDPA/ifcvf: implement shared IRQ feature

2022-03-15 Thread Dan Carpenter
What I really want is to re-enable GCC's uninitialized variable warning. $ rm drivers/vdpa/ifcvf/ifcvf_main.o $ make W=2 drivers/vdpa/ifcvf/ifcvf_main.o It prints a ton of output but this is the relevant bit. drivers/vdpa/ifcvf/ifcvf_main.c: In function ‘ifcvf_vdpa_set_status’:

Re: [bug report] vDPA/ifcvf: implement shared IRQ feature

2022-03-15 Thread Dan Carpenter
On Tue, Mar 15, 2022 at 10:27:35AM +0800, Zhu, Lingshan wrote: > > > On 3/14/2022 6:37 PM, Dan Carpenter wrote: > > On Mon, Mar 14, 2022 at 10:22:03AM +0800, Zhu, Lingshan wrote: > > > Hello Dan, > > > > > > Thanks for your suggestions and this auto-testing efforts! > > > On handling the vector

Re: [bug report] vDPA/ifcvf: implement shared IRQ feature

2022-03-14 Thread Dan Carpenter
On Mon, Mar 14, 2022 at 10:22:03AM +0800, Zhu, Lingshan wrote: > Hello Dan, > > Thanks for your suggestions and this auto-testing efforts! > On handling the vector for device config interrupt, there are three > possibilities: > (1)it has a dedicated vector(2)it shares a vector with datapath(3)no

[bug report] vDPA/ifcvf: implement shared IRQ feature

2022-03-11 Thread Dan Carpenter
Hello Zhu Lingshan, The patch 79333575b8bd: "vDPA/ifcvf: implement shared IRQ feature" from Feb 22, 2022, leads to the following Smatch static checker warning: drivers/vdpa/ifcvf/ifcvf_main.c:306 ifcvf_request_config_irq() error: uninitialized symbol 'config_vector'.