Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-14 Thread Dor Laor
On 11/11/2010 10:03 PM, Ky Srinivasan wrote: + * An implementation of key value pair (KVP) functionality for Linux. + * + * + * Copyright (C) 2010, Novell, Inc. + * Author : K. Y. Srinivasanksriniva...@novell.com + * + * This program is free software; you can redistribute it and/or modify

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-12 Thread Ky Srinivasan
On 11/11/2010 at 3:49 PM, in message 2010124904.24010...@nehalam, Stephen Hemminger shemmin...@vyatta.com wrote: On Thu, 11 Nov 2010 13:03:10 -0700 Ky Srinivasan ksriniva...@novell.com wrote: +static char *kvp_keys[KVP_MAX_KEY] = {FullyQualifiedDomainName, +

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-12 Thread Ky Srinivasan
On 11/11/2010 at 3:49 PM, in message 2010124904.24010...@nehalam, Stephen Hemminger shemmin...@vyatta.com wrote: On Thu, 11 Nov 2010 13:03:10 -0700 Ky Srinivasan ksriniva...@novell.com wrote: +static char *kvp_keys[KVP_MAX_KEY] = {FullyQualifiedDomainName, +

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-12 Thread Ky Srinivasan
On 11/11/2010 at 3:49 PM, in message 2010124904.24010...@nehalam, Stephen Hemminger shemmin...@vyatta.com wrote: On Thu, 11 Nov 2010 13:03:10 -0700 Ky Srinivasan ksriniva...@novell.com wrote: +static char *kvp_keys[KVP_MAX_KEY] = {FullyQualifiedDomainName, +

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-12 Thread Ky Srinivasan
On 11/11/2010 at 4:15 PM, in message 2010211548.ga31...@kroah.com, Greg KH g...@kroah.com wrote: On Thu, Nov 11, 2010 at 01:03:10PM -0700, Ky Srinivasan wrote: +/* + * An implementation of key value pair (KVP) functionality for Linux. + * + * + * Copyright (C) 2010, Novell, Inc.

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-12 Thread Ky Srinivasan
On 11/11/2010 at 4:19 PM, in message 2010211904.gb31...@kroah.com, Greg KH g...@kroah.com wrote: On Thu, Nov 11, 2010 at 01:03:10PM -0700, Ky Srinivasan wrote: +/* + * Array of keys we support in Linux. Not really, you can support any number of keys as the kernel shouldn't care,

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-12 Thread Greg KH
On Fri, Nov 12, 2010 at 11:06:18AM -0700, Ky Srinivasan wrote: +typedef struct kvp_msg { + __u32 kvp_key; /* Key */ + __u8 kvp_value[0]; /* Corresponding value */ +} kvp_msg_t; I thought that kvp_value was really KVP_VALUE_SIZE? kvp_value is typed information and KVP_VALUE_SIZE

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-12 Thread Greg KH
On Fri, Nov 12, 2010 at 11:29:58AM -0700, Ky Srinivasan wrote: On 11/11/2010 at 4:19 PM, in message 2010211904.gb31...@kroah.com, Greg KH g...@kroah.com wrote: On Thu, Nov 11, 2010 at 01:03:10PM -0700, Ky Srinivasan wrote: +/* + * Array of keys we support in Linux. Not

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-12 Thread Ky Srinivasan
On 11/12/2010 at 1:47 PM, in message 20101112184753.ga20...@kroah.com, Greg KH g...@kroah.com wrote: On Fri, Nov 12, 2010 at 11:06:18AM -0700, Ky Srinivasan wrote: +typedef struct kvp_msg { + __u32 kvp_key; /* Key */ + __u8 kvp_value[0]; /* Corresponding value */ +} kvp_msg_t;

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-12 Thread Greg KH
On Fri, Nov 12, 2010 at 01:59:42PM -0700, Ky Srinivasan wrote: On 11/12/2010 at 1:47 PM, in message 20101112184753.ga20...@kroah.com, Greg KH g...@kroah.com wrote: On Fri, Nov 12, 2010 at 11:06:18AM -0700, Ky Srinivasan wrote: +typedef struct kvp_msg { + __u32 kvp_key; /*

[PATCH]: An implementation of HyperV KVP functionality

2010-11-11 Thread Ky Srinivasan
I am enclosing a patch that implements the KVP (Key Value Pair) functionality for Linux guests on HyperV. This functionality allows Microsoft Management stack to query information from the guest. This functionality is implemented in two parts: (a) A kernel component that communicates with the

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-11 Thread Stephen Hemminger
On Thu, 11 Nov 2010 13:03:10 -0700 Ky Srinivasan ksriniva...@novell.com wrote: +static char *kvp_keys[KVP_MAX_KEY] = {FullyQualifiedDomainName, + IntegrationServicesVersion, + NetworkAddressIPv4, +

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-11 Thread Greg KH
On Thu, Nov 11, 2010 at 01:03:10PM -0700, Ky Srinivasan wrote: +/* + * Array of keys we support in Linux. Not really, you can support any number of keys as the kernel shouldn't care, or did I get it wrong? + * + */ +#define KVP_MAX_KEY 10 +#define KVP_LIC_VERSION 1 Um, this is a nice

Re: [PATCH]: An implementation of HyperV KVP functionality

2010-11-11 Thread Greg KH
On Thu, Nov 11, 2010 at 01:03:10PM -0700, Ky Srinivasan wrote: +/* + * An implementation of key value pair (KVP) functionality for Linux. + * + * + * Copyright (C) 2010, Novell, Inc. + * Author : K. Y. Srinivasan ksriniva...@novell.com + * + * This program is free software; you can