Re: [PATCH] tools/virtio: fix build caused by virtio_ring changes

2023-04-10 Thread Shunsuke Mie
On 2023/04/10 19:58, Michael S. Tsirkin wrote: On Mon, Apr 10, 2023 at 07:56:13PM +0900, Shunsuke Mie wrote: On 2023/04/10 19:00, Shunsuke Mie wrote: On 2023/04/10 18:46, Michael S. Tsirkin wrote: On Mon, Apr 10, 2023 at 06:24:19PM +0900, Shunsuke Mie wrote: Fix the build dependency for virt

Re: [PATCH] tools/virtio: fix build caused by virtio_ring changes

2023-04-10 Thread Michael S. Tsirkin
On Mon, Apr 10, 2023 at 07:56:13PM +0900, Shunsuke Mie wrote: > > On 2023/04/10 19:00, Shunsuke Mie wrote: > > > > On 2023/04/10 18:46, Michael S. Tsirkin wrote: > > > On Mon, Apr 10, 2023 at 06:24:19PM +0900, Shunsuke Mie wrote: > > > > Fix the build dependency for virtio_test. virtio_ring requi

Re: [PATCH] tools/virtio: fix build caused by virtio_ring changes

2023-04-10 Thread Shunsuke Mie
On 2023/04/10 19:00, Shunsuke Mie wrote: On 2023/04/10 18:46, Michael S. Tsirkin wrote: On Mon, Apr 10, 2023 at 06:24:19PM +0900, Shunsuke Mie wrote: Fix the build dependency for virtio_test. virtio_ring requires container_of_const() and struce device. Signed-off-by: Shunsuke Mie ---   tool

Re: [PATCH] tools/virtio: fix build caused by virtio_ring changes

2023-04-10 Thread Shunsuke Mie
On 2023/04/10 18:46, Michael S. Tsirkin wrote: On Mon, Apr 10, 2023 at 06:24:19PM +0900, Shunsuke Mie wrote: Fix the build dependency for virtio_test. virtio_ring requires container_of_const() and struce device. Signed-off-by: Shunsuke Mie --- tools/include/linux/container_of.h | 36 ++

Re: [PATCH] tools/virtio: fix build caused by virtio_ring changes

2023-04-10 Thread Michael S. Tsirkin
On Mon, Apr 10, 2023 at 06:24:19PM +0900, Shunsuke Mie wrote: > Fix the build dependency for virtio_test. virtio_ring requires > container_of_const() and struce device. > > Signed-off-by: Shunsuke Mie > --- > tools/include/linux/container_of.h | 36 ++ > tools/virtio/

[PATCH] tools/virtio: fix build caused by virtio_ring changes

2023-04-10 Thread Shunsuke Mie
Fix the build dependency for virtio_test. virtio_ring requires container_of_const() and struce device. Signed-off-by: Shunsuke Mie --- tools/include/linux/container_of.h | 36 ++ tools/virtio/linux/compiler.h | 3 +++ tools/virtio/linux/kernel.h| 5 +---

Re: [PATCH] tools/virtio: fix build break for aarch64

2023-03-22 Thread Michael S. Tsirkin
On Wed, Mar 22, 2023 at 03:59:45PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > "-mfunction-return=thunk -mindirect-branch-register" are only valid > for x86. So introduce compiler operation check to avoid such issues > > Fixes: 0d0ed4006127 ("tools/virtio: enable to build with retpoline")

[PATCH] tools/virtio: fix build

2022-07-05 Thread Stefano Garzarella
Fix the build caused by the following changes: - phys_addr_t is now defined in tools/include/linux/types.h - dev_warn_once() is used in drivers/virtio/virtio_ring.c - linux/uio.h included by vringh.h use INT_MAX defined in limits.h Signed-off-by: Stefano Garzarella --- tools/virtio/linux/kernel.

Re: [PATCH] tools/virtio: Fix build

2019-10-13 Thread Michael S. Tsirkin
On Sun, Oct 13, 2019 at 03:29:34PM +0200, Jan Kiszka wrote: > On 13.10.19 14:20, Michael S. Tsirkin wrote: > > On Sun, Oct 13, 2019 at 02:01:03PM +0200, Jan Kiszka wrote: > >> On 13.10.19 13:52, Michael S. Tsirkin wrote: > >>> On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote: > From:

Re: [PATCH] tools/virtio: Fix build

2019-10-13 Thread Jan Kiszka
On 13.10.19 14:20, Michael S. Tsirkin wrote: > On Sun, Oct 13, 2019 at 02:01:03PM +0200, Jan Kiszka wrote: >> On 13.10.19 13:52, Michael S. Tsirkin wrote: >>> On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote: From: Jan Kiszka Various changes in the recent kernel versions b

Re: [PATCH] tools/virtio: Fix build

2019-10-13 Thread Michael S. Tsirkin
On Sun, Oct 13, 2019 at 02:01:03PM +0200, Jan Kiszka wrote: > On 13.10.19 13:52, Michael S. Tsirkin wrote: > > On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> Various changes in the recent kernel versions broke the build due to > >> missing function and

Re: [PATCH] tools/virtio: Fix build

2019-10-13 Thread Jan Kiszka
On 13.10.19 13:52, Michael S. Tsirkin wrote: > On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Various changes in the recent kernel versions broke the build due to >> missing function and header stubs. >> >> Signed-off-by: Jan Kiszka > > Thanks! > I think it'

Re: [PATCH] tools/virtio: Fix build

2019-10-13 Thread Michael S. Tsirkin
On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Various changes in the recent kernel versions broke the build due to > missing function and header stubs. > > Signed-off-by: Jan Kiszka Thanks! I think it's already fixes in the vhost tree. That tree also includ

[PATCH] tools/virtio: Fix build

2019-10-13 Thread Jan Kiszka
From: Jan Kiszka Various changes in the recent kernel versions broke the build due to missing function and header stubs. Signed-off-by: Jan Kiszka --- tools/virtio/crypto/hash.h | 0 tools/virtio/linux/dma-mapping.h | 2 ++ tools/virtio/linux/kernel.h | 2 ++ 3 files changed, 4 inse

[PATCH] tools/virtio: fix build breakage

2017-04-24 Thread Sekhar Nori
Commit db932ced55cf ("virtio: add context flag to find vqs") added a new 'context' flag to vring_new_virtqueue(), but the corresponding API in tools/virtio/ is not updated causing build errors due to conflicting declarations. Bring code in tools/virtio in sync with that in kernel. I have used 'fa