Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-03 Thread Jason Wang
On 2020/12/3 下午8:24, Eli Cohen wrote: It is mentioned in Parav's patchset that this will be coming in a subsequent patch to his vdpa tool. So I think kernel has two options: - require a mac when device is created, we supply it to guest Yes, the driver should always set VIRTIO_NET_F_MAC and

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-03 Thread Michael S. Tsirkin
On Thu, Dec 03, 2020 at 02:09:29PM +0200, Eli Cohen wrote: > On Thu, Dec 03, 2020 at 05:44:17AM -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 03, 2020 at 08:49:28AM +0200, Eli Cohen wrote: > > > On Wed, Dec 02, 2020 at 05:00:22PM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Dec 02, 2020 at

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-03 Thread Michael S. Tsirkin
On Thu, Dec 03, 2020 at 08:49:28AM +0200, Eli Cohen wrote: > On Wed, Dec 02, 2020 at 05:00:22PM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 09:48:25PM +0800, Jason Wang wrote: > > > > > > On 2020/12/2 下午5:23, Michael S. Tsirkin wrote: > > > > On Wed, Dec 02, 2020 at 07:57:14AM

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 09:48:25PM +0800, Jason Wang wrote: > > On 2020/12/2 下午5:23, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 07:57:14AM +0200, Eli Cohen wrote: > > > On Wed, Dec 02, 2020 at 12:18:36PM +0800, Jason Wang wrote: > > > > On 2020/12/1 下午5:23, Cindy Lu wrote: > > > > > On

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-02 Thread Jason Wang
On 2020/12/2 下午5:23, Michael S. Tsirkin wrote: On Wed, Dec 02, 2020 at 07:57:14AM +0200, Eli Cohen wrote: On Wed, Dec 02, 2020 at 12:18:36PM +0800, Jason Wang wrote: On 2020/12/1 下午5:23, Cindy Lu wrote: On Mon, Nov 30, 2020 at 11:33 PM Michael S. Tsirkin wrote: On Mon, Nov 30, 2020 at

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-02 Thread Jason Wang
On 2020/12/2 下午9:04, Michael S. Tsirkin wrote: On Wed, Dec 02, 2020 at 08:56:37PM +0800, Jason Wang wrote: On 2020/12/2 下午5:30, Michael S. Tsirkin wrote: On Wed, Dec 02, 2020 at 12:18:36PM +0800, Jason Wang wrote: On 2020/12/1 下午5:23, Cindy Lu wrote: On Mon, Nov 30, 2020 at 11:33 PM Michael

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-02 Thread Jason Wang
On 2020/12/2 下午9:07, Michael S. Tsirkin wrote: Two questions here: 1. Now we don't have support for control virtqueue. Yet, we must filter packets based on MAC, what do you suggest to do here? How about an ioctl to pass the mac to the device? Maybe mirroring the control vq struct format ... I

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 09:00:07PM +0800, Jason Wang wrote: > > On 2020/12/2 下午8:17, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 02:12:41PM +0200, Eli Cohen wrote: > > > On Wed, Dec 02, 2020 at 04:23:11AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Dec 02, 2020 at 07:57:14AM +0200,

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 08:56:37PM +0800, Jason Wang wrote: > > On 2020/12/2 下午5:30, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 12:18:36PM +0800, Jason Wang wrote: > > > On 2020/12/1 下午5:23, Cindy Lu wrote: > > > > On Mon, Nov 30, 2020 at 11:33 PM Michael S. Tsirkin > > > > wrote: >

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-02 Thread Jason Wang
On 2020/12/2 下午8:17, Michael S. Tsirkin wrote: On Wed, Dec 02, 2020 at 02:12:41PM +0200, Eli Cohen wrote: On Wed, Dec 02, 2020 at 04:23:11AM -0500, Michael S. Tsirkin wrote: On Wed, Dec 02, 2020 at 07:57:14AM +0200, Eli Cohen wrote: On Wed, Dec 02, 2020 at 12:18:36PM +0800, Jason Wang wrote:

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-02 Thread Jason Wang
On 2020/12/2 下午5:30, Michael S. Tsirkin wrote: On Wed, Dec 02, 2020 at 12:18:36PM +0800, Jason Wang wrote: On 2020/12/1 下午5:23, Cindy Lu wrote: On Mon, Nov 30, 2020 at 11:33 PM Michael S. Tsirkin wrote: On Mon, Nov 30, 2020 at 06:41:45PM +0800, Cindy Lu wrote: On Mon, Nov 30, 2020 at 5:33

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 02:12:41PM +0200, Eli Cohen wrote: > On Wed, Dec 02, 2020 at 04:23:11AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 07:57:14AM +0200, Eli Cohen wrote: > > > On Wed, Dec 02, 2020 at 12:18:36PM +0800, Jason Wang wrote: > > > > > > > > On 2020/12/1 下午5:23,

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 12:18:36PM +0800, Jason Wang wrote: > > On 2020/12/1 下午5:23, Cindy Lu wrote: > > On Mon, Nov 30, 2020 at 11:33 PM Michael S. Tsirkin wrote: > > > On Mon, Nov 30, 2020 at 06:41:45PM +0800, Cindy Lu wrote: > > > > On Mon, Nov 30, 2020 at 5:33 PM Michael S. Tsirkin > > > >

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 07:57:14AM +0200, Eli Cohen wrote: > On Wed, Dec 02, 2020 at 12:18:36PM +0800, Jason Wang wrote: > > > > On 2020/12/1 下午5:23, Cindy Lu wrote: > > > On Mon, Nov 30, 2020 at 11:33 PM Michael S. Tsirkin > > > wrote: > > > > On Mon, Nov 30, 2020 at 06:41:45PM +0800, Cindy Lu

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-01 Thread Jason Wang
On 2020/12/1 下午5:23, Cindy Lu wrote: On Mon, Nov 30, 2020 at 11:33 PM Michael S. Tsirkin wrote: On Mon, Nov 30, 2020 at 06:41:45PM +0800, Cindy Lu wrote: On Mon, Nov 30, 2020 at 5:33 PM Michael S. Tsirkin wrote: On Mon, Nov 30, 2020 at 11:27:59AM +0200, Eli Cohen wrote: On Mon, Nov 30,

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-01 Thread Michael S. Tsirkin
On Tue, Dec 01, 2020 at 05:23:18PM +0800, Cindy Lu wrote: > On Mon, Nov 30, 2020 at 11:33 PM Michael S. Tsirkin wrote: > > > > On Mon, Nov 30, 2020 at 06:41:45PM +0800, Cindy Lu wrote: > > > On Mon, Nov 30, 2020 at 5:33 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Nov 30, 2020 at

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-11-30 Thread Michael S. Tsirkin
On Mon, Nov 30, 2020 at 06:41:45PM +0800, Cindy Lu wrote: > On Mon, Nov 30, 2020 at 5:33 PM Michael S. Tsirkin wrote: > > > > On Mon, Nov 30, 2020 at 11:27:59AM +0200, Eli Cohen wrote: > > > On Mon, Nov 30, 2020 at 04:00:51AM -0500, Michael S. Tsirkin wrote: > > > > On Mon, Nov 30, 2020 at

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-11-30 Thread Michael S. Tsirkin
On Mon, Nov 30, 2020 at 01:51:06PM +0200, Eli Cohen wrote: > On Mon, Nov 30, 2020 at 04:33:09AM -0500, Michael S. Tsirkin wrote: > > On Mon, Nov 30, 2020 at 11:27:59AM +0200, Eli Cohen wrote: > > > On Mon, Nov 30, 2020 at 04:00:51AM -0500, Michael S. Tsirkin wrote: > > > > On Mon, Nov 30, 2020 at

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-11-30 Thread Michael S. Tsirkin
On Mon, Nov 30, 2020 at 11:27:59AM +0200, Eli Cohen wrote: > On Mon, Nov 30, 2020 at 04:00:51AM -0500, Michael S. Tsirkin wrote: > > On Mon, Nov 30, 2020 at 08:27:46AM +0200, Eli Cohen wrote: > > > On Sun, Nov 29, 2020 at 03:08:22PM -0500, Michael S. Tsirkin wrote: > > > > On Sun, Nov 29, 2020 at

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-11-30 Thread Michael S. Tsirkin
On Mon, Nov 30, 2020 at 08:27:46AM +0200, Eli Cohen wrote: > On Sun, Nov 29, 2020 at 03:08:22PM -0500, Michael S. Tsirkin wrote: > > On Sun, Nov 29, 2020 at 08:43:51AM +0200, Eli Cohen wrote: > > > We should not try to use the VF MAC address as that is used by the > > > regular (e.g. mlx5_core)

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-11-29 Thread Michael S. Tsirkin
On Sun, Nov 29, 2020 at 08:43:51AM +0200, Eli Cohen wrote: > We should not try to use the VF MAC address as that is used by the > regular (e.g. mlx5_core) NIC implementation. Instead, use a random > generated MAC address. > > Suggested by: Cindy Lu > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA