Re: [PATCH] virtio: Remove virtio device during shutdown

2015-03-13 Thread Michael S. Tsirkin
On Fri, Mar 13, 2015 at 07:35:52AM +0800, Fam Zheng wrote: On Thu, 03/12 17:22, Michael S. Tsirkin wrote: On Wed, Mar 11, 2015 at 06:11:35PM +0800, Fam Zheng wrote: On Wed, 03/11 10:06, Michael S. Tsirkin wrote: On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: Currently

Re: [PATCH] virtio: Remove virtio device during shutdown

2015-03-12 Thread Paolo Bonzini
On 12/03/2015 17:22, Michael S. Tsirkin wrote: On Wed, Mar 11, 2015 at 06:11:35PM +0800, Fam Zheng wrote: On Wed, 03/11 10:06, Michael S. Tsirkin wrote: On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: Currently shutdown is nop for virtio devices, but the core code could remove

Re: [PATCH] virtio: Remove virtio device during shutdown

2015-03-12 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 06:11:35PM +0800, Fam Zheng wrote: On Wed, 03/11 10:06, Michael S. Tsirkin wrote: On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: Currently shutdown is nop for virtio devices, but the core code could remove things behind us such as MSI-X handler etc. For

Re: [PATCH] virtio: Remove virtio device during shutdown

2015-03-12 Thread Fam Zheng
On Thu, 03/12 17:22, Michael S. Tsirkin wrote: On Wed, Mar 11, 2015 at 06:11:35PM +0800, Fam Zheng wrote: On Wed, 03/11 10:06, Michael S. Tsirkin wrote: On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: Currently shutdown is nop for virtio devices, but the core code could

Re: [PATCH] virtio: Remove virtio device during shutdown

2015-03-11 Thread Fam Zheng
On Wed, 03/11 10:06, Michael S. Tsirkin wrote: On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: Currently shutdown is nop for virtio devices, but the core code could remove things behind us such as MSI-X handler etc. For example in the case of virtio-scsi-pci, the device may still

Re: [PATCH] virtio: Remove virtio device during shutdown

2015-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: Currently shutdown is nop for virtio devices, but the core code could remove things behind us such as MSI-X handler etc. For example in the case of virtio-scsi-pci, the device may still try to send interupts, which will be on IRQ lines

[PATCH] virtio: Remove virtio device during shutdown

2015-03-11 Thread Fam Zheng
Currently shutdown is nop for virtio devices, but the core code could remove things behind us such as MSI-X handler etc. For example in the case of virtio-scsi-pci, the device may still try to send interupts, which will be on IRQ lines seeing MSI-X disabled. Those interrupts will be unhandled, and