Re: [PATCH] virtio_bt: Fix alignment in configuration struct

2022-10-11 Thread Igor Skalkin
Hi Luiz, Current version of this patch is wrong [q]changing uapi like this can't be done, will break userspace[/q], next version is in process, will be sent in few days. Best regards, Igor On 10/7/22 21:33, Luiz Augusto von Dentz wrote: Hi Michael, On Fri, Oct 7, 2022 at 6:03 AM Michael S.

Re: [PATCH] virtio_bt: Fix alignment in configuration struct

2022-10-07 Thread Michael S. Tsirkin
On Mon, Aug 08, 2022 at 02:04:43PM +0200, Igor Skalkin wrote: > On 8/8/22 01:00, Michael S. Tsirkin wrote: > > On Mon, Aug 08, 2022 at 12:11:52AM +0200, Igor Skalkin wrote: > > According to specification [1], "For the device-specific configuration > space, the driver MUST use

Re: [PATCH] virtio_bt: Fix alignment in configuration struct

2022-09-08 Thread Michael S. Tsirkin
On Tue, Aug 30, 2022 at 09:45:02AM -0400, Michael S. Tsirkin wrote: > On Thu, Aug 11, 2022 at 10:02:31AM -0700, Luiz Augusto von Dentz wrote: > > Hi Michael, > > > > On Thu, Aug 11, 2022 at 1:00 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Aug 08, 2022 at 08:16:11AM -0400, Michael S. Tsirkin

Re: [PATCH] virtio_bt: Fix alignment in configuration struct

2022-08-30 Thread Michael S. Tsirkin
On Thu, Aug 11, 2022 at 10:02:31AM -0700, Luiz Augusto von Dentz wrote: > Hi Michael, > > On Thu, Aug 11, 2022 at 1:00 AM Michael S. Tsirkin wrote: > > > > On Mon, Aug 08, 2022 at 08:16:11AM -0400, Michael S. Tsirkin wrote: > > > On Mon, Aug 08, 2022 at 02:04:43PM +0200, Igor Skalkin wrote: > >

Re: [PATCH] virtio_bt: Fix alignment in configuration struct

2022-08-11 Thread Michael S. Tsirkin
On Mon, Aug 08, 2022 at 08:16:11AM -0400, Michael S. Tsirkin wrote: > On Mon, Aug 08, 2022 at 02:04:43PM +0200, Igor Skalkin wrote: > > On 8/8/22 01:00, Michael S. Tsirkin wrote: > > > > On Mon, Aug 08, 2022 at 12:11:52AM +0200, Igor Skalkin wrote: > > > > According to specification

Re: [PATCH] virtio_bt: Fix alignment in configuration struct

2022-08-08 Thread Michael S. Tsirkin
On Mon, Aug 08, 2022 at 02:04:43PM +0200, Igor Skalkin wrote: > On 8/8/22 01:00, Michael S. Tsirkin wrote: > > On Mon, Aug 08, 2022 at 12:11:52AM +0200, Igor Skalkin wrote: > > According to specification [1], "For the device-specific configuration > space, the driver MUST use

Re: [PATCH] virtio_bt: Fix alignment in configuration struct

2022-08-08 Thread Igor Skalkin
On 8/8/22 01:00, Michael S. Tsirkin wrote: On Mon, Aug 08, 2022 at 12:11:52AM +0200, Igor Skalkin wrote: According to specification [1], "For the device-specific configuration space, the driver MUST use 8 bit wide accesses for 8 bit wide fields, 16 bit wide and aligned accesses for 16 bit wide

Re: [PATCH] virtio_bt: Fix alignment in configuration struct

2022-08-07 Thread Michael S. Tsirkin
On Mon, Aug 08, 2022 at 12:11:52AM +0200, Igor Skalkin wrote: > According to specification [1], "For the device-specific configuration > space, the driver MUST use 8 bit wide accesses for 8 bit wide fields, > 16 bit wide and aligned accesses for 16 bit wide fields and 32 bit wide > and aligned