Re: [PATCH 06/16] virtio_blk: drop config_enable

2014-10-06 Thread Cornelia Huck
On Mon, 6 Oct 2014 15:31:10 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 06, 2014 at 02:20:38PM +0200, Cornelia Huck wrote: > > On Mon, 6 Oct 2014 15:09:53 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Oct 06, 2014 at 01:42:29PM +0200, Cornelia Huck wrote: > > > > On Sun, 5 Oct 201

Re: [PATCH 06/16] virtio_blk: drop config_enable

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 02:20:38PM +0200, Cornelia Huck wrote: > On Mon, 6 Oct 2014 15:09:53 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Oct 06, 2014 at 01:42:29PM +0200, Cornelia Huck wrote: > > > On Sun, 5 Oct 2014 19:07:07 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > Now that

Re: [PATCH 06/16] virtio_blk: drop config_enable

2014-10-06 Thread Cornelia Huck
On Mon, 6 Oct 2014 15:09:53 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 06, 2014 at 01:42:29PM +0200, Cornelia Huck wrote: > > On Sun, 5 Oct 2014 19:07:07 +0300 > > "Michael S. Tsirkin" wrote: > > > > > Now that virtio core ensures config changes don't > > > arrive during probing, drop conf

Re: [PATCH 06/16] virtio_blk: drop config_enable

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 01:42:29PM +0200, Cornelia Huck wrote: > On Sun, 5 Oct 2014 19:07:07 +0300 > "Michael S. Tsirkin" wrote: > > > Now that virtio core ensures config changes don't > > arrive during probing, drop config_enable flag > > in virtio blk. > > On removal, flush is now sufficient to

Re: [PATCH 06/16] virtio_blk: drop config_enable

2014-10-06 Thread Cornelia Huck
On Sun, 5 Oct 2014 19:07:07 +0300 "Michael S. Tsirkin" wrote: > Now that virtio core ensures config changes don't > arrive during probing, drop config_enable flag > in virtio blk. > On removal, flush is now sufficient to guarantee that > no change work is queued. > > This help simplify the drive

[PATCH 06/16] virtio_blk: drop config_enable

2014-10-05 Thread Michael S. Tsirkin
Now that virtio core ensures config changes don't arrive during probing, drop config_enable flag in virtio blk. On removal, flush is now sufficient to guarantee that no change work is queued. This help simplify the driver, and will allow setting DRIVER_OK earlier without losing config change notif