Re: [PATCH 1/2] virtio: block: set max_segment_size and max_sectors to infinite.

2008-11-27 Thread Rusty Russell
On Thursday 27 November 2008 04:12:25 Chris Wright wrote: * Rusty Russell ([EMAIL PROTECTED]) wrote: + /* No real sector limit. */ + blk_queue_max_sectors(vblk-disk-queue, -1U); + Is that actually legitimate? I think it'd still work out, but seems odd, e.g. all the spots that do:

Re: [PATCH 1/2] virtio: block: set max_segment_size and max_sectors to infinite.

2008-11-27 Thread Jens Axboe
On Thu, Nov 27 2008, Rusty Russell wrote: On Thursday 27 November 2008 04:12:25 Chris Wright wrote: * Rusty Russell ([EMAIL PROTECTED]) wrote: + /* No real sector limit. */ + blk_queue_max_sectors(vblk-disk-queue, -1U); + Is that actually legitimate? I think it'd still work out,

Re: [PATCH 1/2] virtio: block: set max_segment_size and max_sectors to infinite.

2008-11-26 Thread Chris Wright
* Rusty Russell ([EMAIL PROTECTED]) wrote: + /* No real sector limit. */ + blk_queue_max_sectors(vblk-disk-queue, -1U); + Is that actually legitimate? I think it'd still work out, but seems odd, e.g. all the spots that do: q-max_hw_sectors 9 will just toss the upper bits...

[PATCH 1/2] virtio: block: set max_segment_size and max_sectors to infinite.

2008-11-16 Thread Rusty Russell
Setting max_segment_size allows more than 64k per sg element, unless the host specified a limit. Setting max_sectors indicates that our max_hw_segments is the only limit. Signed-off-by: Rusty Russell [EMAIL PROTECTED] diff -r 446171198334 drivers/block/virtio_blk.c ---