[PATCH 12/12] VMCI: Some header and config files.

2013-01-08 Thread George Zhang
VMCI head config patch Adds all the necessary files to enable building of the VMCI module with the Linux Makefiles and Kconfig systems. Also adds the header files used for building modules against the driver. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king

Re: [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Andy King
I didn't get the resend either, so it seems our corporate mail really is eating messages. Lovely. +#define IOCTLCMD(_cmd) IOCTL_VMCI_ ## _cmd I don't recall ever getting a valid answer for this (if you did, my appologies, can you repeat it). What in the world are you talking about

Re: [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Greg KH
On Fri, Nov 30, 2012 at 08:47:46AM -0800, Andy King wrote: I didn't get the resend either, so it seems our corporate mail really is eating messages. Lovely. +#define IOCTLCMD(_cmd) IOCTL_VMCI_ ## _cmd I don't recall ever getting a valid answer for this (if you did, my

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Dmitry Torokhov
On Friday, November 30, 2012 09:09:21 AM Greg KH wrote: On Fri, Nov 30, 2012 at 08:47:46AM -0800, Andy King wrote: I didn't get the resend either, so it seems our corporate mail really is eating messages. Lovely. +#define IOCTLCMD(_cmd) IOCTL_VMCI_ ## _cmd I don't recall

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Greg KH
On Fri, Nov 30, 2012 at 09:20:41AM -0800, Dmitry Torokhov wrote: On Friday, November 30, 2012 09:09:21 AM Greg KH wrote: On Fri, Nov 30, 2012 at 08:47:46AM -0800, Andy King wrote: I didn't get the resend either, so it seems our corporate mail really is eating messages. Lovely.

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Dmitry Torokhov
On Friday, November 30, 2012 10:39:18 AM Greg KH wrote: On Fri, Nov 30, 2012 at 09:20:41AM -0800, Dmitry Torokhov wrote: On Friday, November 30, 2012 09:09:21 AM Greg KH wrote: On Fri, Nov 30, 2012 at 08:47:46AM -0800, Andy King wrote: I didn't get the resend either, so it seems our

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Greg KH
On Fri, Nov 30, 2012 at 10:45:44AM -0800, Dmitry Torokhov wrote: However you snipped the rest of my reply: do we really need to renumber ioctls? There is no benefit for the driver as its ioctl handler does not parse the numbers into components. I don't know if you need to renumber, I really

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Dmitry Torokhov
On Friday, November 30, 2012 10:57:55 AM Greg KH wrote: On Fri, Nov 30, 2012 at 10:45:44AM -0800, Dmitry Torokhov wrote: However you snipped the rest of my reply: do we really need to renumber ioctls? There is no benefit for the driver as its ioctl handler does not parse the numbers into

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Greg KH
On Fri, Nov 30, 2012 at 12:09:40PM -0800, Dmitry Torokhov wrote: On Friday, November 30, 2012 10:57:55 AM Greg KH wrote: On Fri, Nov 30, 2012 at 10:45:44AM -0800, Dmitry Torokhov wrote: However you snipped the rest of my reply: do we really need to renumber ioctls? There is no benefit for

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Dmitry Torokhov
On Friday, November 30, 2012 12:44:06 PM Greg KH wrote: On Fri, Nov 30, 2012 at 12:09:40PM -0800, Dmitry Torokhov wrote: On Friday, November 30, 2012 10:57:55 AM Greg KH wrote: On Fri, Nov 30, 2012 at 10:45:44AM -0800, Dmitry Torokhov wrote: However you snipped the rest of my reply: do

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Greg KH
On Fri, Nov 30, 2012 at 12:58:25PM -0800, Dmitry Torokhov wrote: On Friday, November 30, 2012 12:44:06 PM Greg KH wrote: On Fri, Nov 30, 2012 at 12:09:40PM -0800, Dmitry Torokhov wrote: On Friday, November 30, 2012 10:57:55 AM Greg KH wrote: On Fri, Nov 30, 2012 at 10:45:44AM -0800,

Re: [PATCH 12/12] VMCI: Some header and config files.

2012-11-26 Thread Greg KH
On Wed, Nov 07, 2012 at 10:43:03AM -0800, George Zhang wrote: +#ifndef _VMCI_COMMONINT_H_ +#define _VMCI_COMMONINT_H_ + +#include linux/printk.h Why printk from a .h file? + +#define ASSERT(cond) BUG_ON(!(cond)) No, please no. + +#define PCI_VENDOR_ID_VMWARE 0x15AD +#define

Re: [PATCH 12/12] VMCI: Some header and config files.

2012-11-26 Thread Dmitry Torokhov
Hi Greg, For some reason it still didn't go through to our corporate mail server but I see it on LKML. On Mon, Nov 26, 2012 at 04:03:04PM -0800, Greg KH wrote: On Wed, Nov 07, 2012 at 10:43:03AM -0800, George Zhang wrote: +static inline struct vmci_handle VMCI_MAKE_HANDLE(vmci_id cid,

Re: [PATCH 12/12] VMCI: Some header and config files.

2012-11-26 Thread Greg KH
On Mon, Nov 26, 2012 at 04:23:57PM -0800, Dmitry Torokhov wrote: Hi Greg, For some reason it still didn't go through to our corporate mail server but I see it on LKML. Good. On Mon, Nov 26, 2012 at 04:03:04PM -0800, Greg KH wrote: On Wed, Nov 07, 2012 at 10:43:03AM -0800, George Zhang

[PATCH 12/12] VMCI: Some header and config files.

2012-11-21 Thread George Zhang
VMCI head config patch Adds all the necessary files to enable building of the VMCI module with the Linux Makefiles and Kconfig systems. Also adds the header files used for building modules against the driver. Signed-off-by: George Zhang georgezh...@vmware.com Signed-off-by: Dmitry Torokhov

Re: [PATCH 12/12] VMCI: Some header and config files.

2012-11-15 Thread Greg KH
On Wed, Nov 07, 2012 at 10:43:03AM -0800, George Zhang wrote: +#ifndef _VMCI_COMMONINT_H_ +#define _VMCI_COMMONINT_H_ + +#include linux/printk.h Why printk from a .h file? + +#define ASSERT(cond) BUG_ON(!(cond)) No, please no. + +#define PCI_VENDOR_ID_VMWARE 0x15AD +#define

[PATCH 12/12] VMCI: Some header and config files.

2012-11-07 Thread George Zhang
VMCI head config patch Adds all the necessary files to enable building of the VMCI module with the Linux Makefiles and Kconfig systems. Also adds the header files used for building modules against the driver. Signed-off-by: George Zhang georgezh...@vmware.com --- drivers/misc/Kconfig

[PATCH 12/12] VMCI: Some header and config files.

2012-11-01 Thread George Zhang
VMCI head config patch Adds all the necessary files to enable building of the VMCI module with the Linux Makefiles and Kconfig systems. Also adds the header files used for building modules against the driver. Signed-off-by: George Zhang georgezh...@vmware.com --- drivers/misc/Kconfig

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-10-29 Thread Dmitry Torokhov
On Mon, Oct 29, 2012 at 07:32:55PM -0700, Greg KH wrote: On Mon, Oct 29, 2012 at 06:05:38PM -0700, George Zhang wrote: --- /dev/null +++ b/drivers/misc/vmw_vmci/Makefile @@ -0,0 +1,43 @@ + +# +# Linux