[MailServer Resend] Quarantined email -- use caution when opening.Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-25 Thread Helpdesk
- Original Message Header - Subject: Re: [PATCH 5/5] tun: vringfd xmit support. From: [EMAIL PROTECTED]; To: [EMAIL PROTECTED]; Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; virtualization@lists.linux-foundation.org; [EMAIL PROTECTED]; --- Warning

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-19 Thread Andrew Morton
> On Sun, 20 Apr 2008 00:41:43 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > On Saturday 19 April 2008 05:06:34 Andrew Morton wrote: > > On Sat, 19 Apr 2008 01:15:15 +1000 Rusty Russell <[EMAIL PROTECTED]> > wrote: > > > > What is the maximum numbet of pages which an unpriviliged user can > > >

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-19 Thread Rusty Russell
On Saturday 19 April 2008 05:06:34 Andrew Morton wrote: > On Sat, 19 Apr 2008 01:15:15 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > > What is the maximum numbet of pages which an unpriviliged user can > > > concurrently pin with this code? > > > > Since only root can open the tun device, it'

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
On Sat, 19 Apr 2008 01:15:15 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > It's not clear to me why this is in swap.c, but it exists > even without CONFIG_SWAP, so that's OK. We should have done mv mm/swap.c mm/mmlib.c years ago. ___ Virtualization m

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
On Sat, 19 Apr 2008 01:15:15 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > > > What is the maximum numbet of pages which an unpriviliged user can > > concurrently pin with this code? > > Since only root can open the tun device, it's currently OK. The old code > kmalloced and copied: is ther

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread pradeep singh rautela
On Fri, Apr 18, 2008 at 7:55 PM, Ray Lee <[EMAIL PROTECTED]> wrote: > On Fri, Apr 18, 2008 at 4:46 AM, pradeep singh rautela > <[EMAIL PROTECTED]> wrote: > > > > On Fri, Apr 18, 2008 at 10:13 AM, Rusty Russell <[EMAIL PROTECTED]> wrote: > > > > + /* How many pages will this take?

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Ray Lee
On Fri, Apr 18, 2008 at 8:15 AM, Rusty Russell <[EMAIL PROTECTED]> wrote: > On Friday 18 April 2008 21:31:20 Andrew Morton wrote: > > On Fri, 18 Apr 2008 14:43:24 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > > > + /* How many pages will this take? */ > > > + npages = 1 +

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Rusty Russell
On Friday 18 April 2008 21:31:20 Andrew Morton wrote: > On Fri, 18 Apr 2008 14:43:24 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > + /* How many pages will this take? */ > > + npages = 1 + (base + len - 1)/PAGE_SIZE - base/PAGE_SIZE; > > Brain hurts. I hope you got that ri

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Ray Lee
On Fri, Apr 18, 2008 at 4:46 AM, pradeep singh rautela <[EMAIL PROTECTED]> wrote: > > On Fri, Apr 18, 2008 at 10:13 AM, Rusty Russell <[EMAIL PROTECTED]> wrote: > > + /* How many pages will this take? */ > > + npages = 1 + (base + len - 1)/PAGE_SIZE - base/PAGE_SIZE;

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread pradeep singh rautela
On Fri, Apr 18, 2008 at 10:13 AM, Rusty Russell <[EMAIL PROTECTED]> wrote: > This patch modifies tun to allow a vringfd to specify the send > buffer. The user does a write to push out packets from the buffer. > > Again we use the 'struct virtio_net_hdr' to allow userspace to send > GSO packets.

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
On Fri, 18 Apr 2008 14:43:24 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > This patch modifies tun to allow a vringfd to specify the send > buffer. The user does a write to push out packets from the buffer. > > Again we use the 'struct virtio_net_hdr' to allow userspace to send > GSO packets.

[PATCH 5/5] tun: vringfd xmit support.

2008-04-17 Thread Rusty Russell
This patch modifies tun to allow a vringfd to specify the send buffer. The user does a write to push out packets from the buffer. Again we use the 'struct virtio_net_hdr' to allow userspace to send GSO packets. In this case, it can hint how much to copy, and the other pages will be made into skb