Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()

2019-02-18 Thread Jason Wang
On 2019/2/16 上午12:45, Stephen Hemminger wrote: On Fri, 15 Feb 2019 15:53:24 +0800 Jason Wang wrote: When fail, translate_desc() returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero. Reported-by:

Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()

2019-02-18 Thread Jason Wang
On 2019/2/16 上午2:03, David Miller wrote: From: Jason Wang Date: Fri, 15 Feb 2019 15:53:24 +0800 When fail, translate_desc() returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero. Reported-by: Stephen

Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()

2019-02-15 Thread Michael S. Tsirkin
On Fri, Feb 15, 2019 at 03:53:24PM +0800, Jason Wang wrote: > When fail, translate_desc() returns negative value, otherwise the > number of iovs. So we should fail when the return value is negative > instead of a blindly check against zero. > > Reported-by: Stephen Hemminger > Fixes:

Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()

2019-02-15 Thread David Miller
From: Jason Wang Date: Fri, 15 Feb 2019 15:53:24 +0800 > When fail, translate_desc() returns negative value, otherwise the > number of iovs. So we should fail when the return value is negative > instead of a blindly check against zero. > > Reported-by: Stephen Hemminger > Fixes: cc5e71075947

Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()

2019-02-15 Thread Stephen Hemminger
On Fri, 15 Feb 2019 15:53:24 +0800 Jason Wang wrote: > When fail, translate_desc() returns negative value, otherwise the > number of iovs. So we should fail when the return value is negative > instead of a blindly check against zero. > > Reported-by: Stephen Hemminger > Fixes: cc5e71075947

[PATCH net] vhost: correctly check the return value of translate_desc() in log_used()

2019-02-14 Thread Jason Wang
When fail, translate_desc() returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero. Reported-by: Stephen Hemminger Fixes: cc5e71075947 ("vhost: log dirty page correctly") Signed-off-by: Jason Wang ---