Re: [PATCH net-next 06/11] tuntap: split out XDP logic

2018-09-09 Thread Jason Wang
On 2018年09月07日 22:16, Michael S. Tsirkin wrote: On Fri, Sep 07, 2018 at 11:29:34AM +0800, Jason Wang wrote: + if (act != XDP_PASS) + goto out; likely? It depends on the XDP program, so I tend not to use it. Point is XDP_PASS is already slow. Ok.

Re: [PATCH net-next 06/11] tuntap: split out XDP logic

2018-09-07 Thread Michael S. Tsirkin
On Fri, Sep 07, 2018 at 11:29:34AM +0800, Jason Wang wrote: > > > + if (act != XDP_PASS) > > > + goto out; > > likely? > > It depends on the XDP program, so I tend not to use it. Point is XDP_PASS is already slow. -- MST ___

Re: [PATCH net-next 06/11] tuntap: split out XDP logic

2018-09-06 Thread Jason Wang
On 2018年09月07日 01:21, Michael S. Tsirkin wrote: On Thu, Sep 06, 2018 at 12:05:21PM +0800, Jason Wang wrote: This patch split out XDP logic into a single function. This make it to be reused by XDP batching path in the following patch. Signed-off-by: Jason Wang --- drivers/net/tun.c | 84

Re: [PATCH net-next 06/11] tuntap: split out XDP logic

2018-09-06 Thread Michael S. Tsirkin
On Thu, Sep 06, 2018 at 12:05:21PM +0800, Jason Wang wrote: > This patch split out XDP logic into a single function. This make it to > be reused by XDP batching path in the following patch. > > Signed-off-by: Jason Wang > --- > drivers/net/tun.c | 84

[PATCH net-next 06/11] tuntap: split out XDP logic

2018-09-05 Thread Jason Wang
This patch split out XDP logic into a single function. This make it to be reused by XDP batching path in the following patch. Signed-off-by: Jason Wang --- drivers/net/tun.c | 84 --- 1 file changed, 51 insertions(+), 33 deletions(-) diff --git