Re: [PATCH net V2 0/4] Fix various issue of vhost
On 2018/12/13 上午7:31, David Miller wrote: From: Jason Wang Date: Wed, 12 Dec 2018 18:08:15 +0800 This series tries to fix various issues of vhost: - Patch 1 adds a missing write barrier between used idx updating and logging. - Patch 2-3 brings back the protection of device IOTLB through vq mutex, this fixes possible use after free in device IOTLB entries. - Patch 4-7 fixes the diry page logging when device IOTLB is enabled. We should done through GPA instead of GIOVA, this was done through intorudce HVA->GPA reverse mapping and convert HVA to GPA during logging dirty pages. Please consider them for -stable. Thanks Changes from V1: - silent compiler warning for 32bit. - use mutex_trylock() on slowpath instead of mutex_lock() even on fast path. Hello Jason. Look like Michael wants you to split out patch #4 and target net-next with it. So please do that and respin the first 3 patches here with Michael's ACKs. Thanks. Yes, will send V3. Thanks ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH net V2 0/4] Fix various issue of vhost
From: Jason Wang Date: Wed, 12 Dec 2018 18:08:15 +0800 > This series tries to fix various issues of vhost: > > - Patch 1 adds a missing write barrier between used idx updating and > logging. > - Patch 2-3 brings back the protection of device IOTLB through vq > mutex, this fixes possible use after free in device IOTLB entries. > - Patch 4-7 fixes the diry page logging when device IOTLB is > enabled. We should done through GPA instead of GIOVA, this was done > through intorudce HVA->GPA reverse mapping and convert HVA to GPA > during logging dirty pages. > > Please consider them for -stable. > > Thanks > > Changes from V1: > - silent compiler warning for 32bit. > - use mutex_trylock() on slowpath instead of mutex_lock() even on fast > path. Hello Jason. Look like Michael wants you to split out patch #4 and target net-next with it. So please do that and respin the first 3 patches here with Michael's ACKs. Thanks. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[PATCH net V2 0/4] Fix various issue of vhost
Hi: This series tries to fix various issues of vhost: - Patch 1 adds a missing write barrier between used idx updating and logging. - Patch 2-3 brings back the protection of device IOTLB through vq mutex, this fixes possible use after free in device IOTLB entries. - Patch 4-7 fixes the diry page logging when device IOTLB is enabled. We should done through GPA instead of GIOVA, this was done through intorudce HVA->GPA reverse mapping and convert HVA to GPA during logging dirty pages. Please consider them for -stable. Thanks Changes from V1: - silent compiler warning for 32bit. - use mutex_trylock() on slowpath instead of mutex_lock() even on fast path. Jason Wang (4): vhost: make sure used idx is seen before log in vhost_add_used_n() vhost_net: switch to use mutex_trylock() in vhost_net_busy_poll() Revert "net: vhost: lock the vqs one by one" vhost: log dirty page correctly drivers/vhost/net.c | 11 - drivers/vhost/vhost.c | 102 ++ drivers/vhost/vhost.h | 3 +- 3 files changed, 95 insertions(+), 21 deletions(-) -- 2.17.1 ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
