Re: [PATCH v2] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2020-01-09 Thread Michael S. Tsirkin
On Thu, Jan 09, 2020 at 06:33:39PM -0800, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Sun, 5 Jan 2020 08:22:07 -0500 > > > The only way for guest to control offloads (as enabled by > > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands > > through CTRL_VQ. So it does not make

Re: [PATCH v2] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2020-01-09 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 5 Jan 2020 08:22:07 -0500 > The only way for guest to control offloads (as enabled by > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands > through CTRL_VQ. So it does not make sense to > acknowledge VIRTIO_NET_F_CTRL_GUEST_OFFLOADS without >

Re: [PATCH v2] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2020-01-07 Thread Jason Wang
On 2020/1/7 下午3:06, Michael S. Tsirkin wrote: On Tue, Jan 07, 2020 at 10:29:08AM +0800, Jason Wang wrote: On 2020/1/6 下午8:54, Michael S. Tsirkin wrote: On Mon, Jan 06, 2020 at 10:47:35AM +0800, Jason Wang wrote: On 2020/1/5 下午9:22, Michael S. Tsirkin wrote: The only way for guest to control

Re: [PATCH v2] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2020-01-06 Thread Michael S. Tsirkin
On Tue, Jan 07, 2020 at 10:29:08AM +0800, Jason Wang wrote: > > On 2020/1/6 下午8:54, Michael S. Tsirkin wrote: > > On Mon, Jan 06, 2020 at 10:47:35AM +0800, Jason Wang wrote: > > > On 2020/1/5 下午9:22, Michael S. Tsirkin wrote: > > > > The only way for guest to control offloads (as enabled by > > >

Re: [PATCH v2] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2020-01-06 Thread Jason Wang
On 2020/1/6 下午8:54, Michael S. Tsirkin wrote: On Mon, Jan 06, 2020 at 10:47:35AM +0800, Jason Wang wrote: On 2020/1/5 下午9:22, Michael S. Tsirkin wrote: The only way for guest to control offloads (as enabled by VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands through CTRL_VQ. So it

Re: [PATCH v2] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2020-01-06 Thread Michael S. Tsirkin
On Mon, Jan 06, 2020 at 10:47:35AM +0800, Jason Wang wrote: > > On 2020/1/5 下午9:22, Michael S. Tsirkin wrote: > > The only way for guest to control offloads (as enabled by > > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands > > through CTRL_VQ. So it does not make sense to > >

Re: [PATCH v2] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2020-01-05 Thread Jason Wang
On 2020/1/5 下午9:22, Michael S. Tsirkin wrote: The only way for guest to control offloads (as enabled by VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands through CTRL_VQ. So it does not make sense to acknowledge VIRTIO_NET_F_CTRL_GUEST_OFFLOADS without VIRTIO_NET_F_CTRL_VQ. The spec

[PATCH v2] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2020-01-05 Thread Michael S. Tsirkin
The only way for guest to control offloads (as enabled by VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands through CTRL_VQ. So it does not make sense to acknowledge VIRTIO_NET_F_CTRL_GUEST_OFFLOADS without VIRTIO_NET_F_CTRL_VQ. The spec does not outlaw devices with such a configuration,