Re: [PATCH v2 5/6] virtio-gpu: add basic prime support

2015-09-22 Thread Daniel Vetter
On Tue, Sep 22, 2015 at 05:24:29PM +0200, Gerd Hoffmann wrote: > > > +int virtgpu_gem_prime_mmap(struct drm_gem_object *obj, > > > +struct vm_area_struct *area) > > > +{ > > > + WARN_ONCE(1, "not implemented"); > > > + return ENOSYS; > > > > This can get called by userspace, so

Re: [PATCH v2 5/6] virtio-gpu: add basic prime support

2015-09-22 Thread Daniel Vetter
On Mon, Sep 21, 2015 at 11:40:16AM +0200, Gerd Hoffmann wrote: > From: Dave Airlie > > This is enough to enable DRI3. > > Signed-off-by: Dave Airlie > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/Makefile| 2

Re: [PATCH v2 5/6] virtio-gpu: add basic prime support

2015-09-22 Thread Gerd Hoffmann
> > +int virtgpu_gem_prime_mmap(struct drm_gem_object *obj, > > + struct vm_area_struct *area) > > +{ > > + WARN_ONCE(1, "not implemented"); > > + return ENOSYS; > > This can get called by userspace, so please don't WARN here. Also missing > negate sign: > > return

[PATCH v2 5/6] virtio-gpu: add basic prime support

2015-09-21 Thread Gerd Hoffmann
From: Dave Airlie This is enough to enable DRI3. Signed-off-by: Dave Airlie Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/Makefile| 2 +- drivers/gpu/drm/virtio/virtgpu_drv.c | 13 +-